All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: Zhang Yanfei <zhangyanfei.yes@gmail.com>,
	Tang Chen <tangchen@cn.fujitsu.com>,
	konrad.wilk@oracle.com, robert.moore@intel.com,
	lv.zheng@intel.com, rjw@sisk.pl, lenb@kernel.org,
	tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com,
	akpm@linux-foundation.org, trenn@suse.de, yinghai@kernel.org,
	jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
	isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com,
	mgorman@suse.de, minchan@kernel.org, mina86@mina86.com,
	gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com,
	lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com,
	prarit@redhat.com, zhangyanfei@cn.fujitsu.com,
	yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH 0/8] x86, acpi: Move acpi_initrd_override() earlier.
Date: Thu, 22 Aug 2013 16:35:29 -0400	[thread overview]
Message-ID: <20130822203529.GE3490@mtj.dyndns.org> (raw)
In-Reply-To: <20130822202158.GD3490@mtj.dyndns.org>

A bit of addition.

On Thu, Aug 22, 2013 at 04:21:58PM -0400, Tejun Heo wrote:
> That works if such half solution eventually leads to the full
> solution.  This is just a distraction.  You are already too late in
> the boot sequence.  It doesn't even qualify as a half solution.  It's
> like obsessing about a speck on your shirt without your trousers on.
> If you want to solve this, do that from a place where it actually is
> solvable.

Seriously, what's the end game here?  How do you guys see this
eventually reaching full solution?  If you don't see that and this
kinda-sorta-working solution is fine, then that's fine too but we
aren't gonna make a lot of invasive changes for that.  If you can at
least envision the full solution, please try to fit this effort into
the bigger picture.

In all possible solutions that I can think of, there needs to be
earlier handling of SRAT informtaion before the kernel proper starts
executing be that either the actual bootloader or earlier kernel
serving as kexec host.  If a proper solution needs such processing
earlier anyway, it can set up things so that either the default
booting behavior doesn't harm hotpluggability or feed the necessary
information to the kernel.  In both cases, doing ACPI super early in
the booting kernel doesn't buy us anything.

So, then, what the hell are we doing here with all these relocations,
careful double execution of the same code from different execution
contexts, worrying about initrd firmware override even before the
kernel page table is set up?  If we're doing all those to just make
the temporary half-assed-anyway solution minutely better, that's just
plain stupid.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: Zhang Yanfei <zhangyanfei.yes@gmail.com>,
	Tang Chen <tangchen@cn.fujitsu.com>,
	konrad.wilk@oracle.com, robert.moore@intel.com,
	lv.zheng@intel.com, rjw@sisk.pl, lenb@kernel.org,
	tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com,
	akpm@linux-foundation.org, trenn@suse.de, yinghai@kernel.org,
	jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
	isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com,
	mgorman@suse.de, minchan@kernel.org, mina86@mina86.com,
	gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com,
	lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com,
	prarit@redhat.com, zhangyanfei@cn.fujitsu.com,
	yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH 0/8] x86, acpi: Move acpi_initrd_override() earlier.
Date: Thu, 22 Aug 2013 16:35:29 -0400	[thread overview]
Message-ID: <20130822203529.GE3490@mtj.dyndns.org> (raw)
In-Reply-To: <20130822202158.GD3490@mtj.dyndns.org>

A bit of addition.

On Thu, Aug 22, 2013 at 04:21:58PM -0400, Tejun Heo wrote:
> That works if such half solution eventually leads to the full
> solution.  This is just a distraction.  You are already too late in
> the boot sequence.  It doesn't even qualify as a half solution.  It's
> like obsessing about a speck on your shirt without your trousers on.
> If you want to solve this, do that from a place where it actually is
> solvable.

Seriously, what's the end game here?  How do you guys see this
eventually reaching full solution?  If you don't see that and this
kinda-sorta-working solution is fine, then that's fine too but we
aren't gonna make a lot of invasive changes for that.  If you can at
least envision the full solution, please try to fit this effort into
the bigger picture.

In all possible solutions that I can think of, there needs to be
earlier handling of SRAT informtaion before the kernel proper starts
executing be that either the actual bootloader or earlier kernel
serving as kexec host.  If a proper solution needs such processing
earlier anyway, it can set up things so that either the default
booting behavior doesn't harm hotpluggability or feed the necessary
information to the kernel.  In both cases, doing ACPI super early in
the booting kernel doesn't buy us anything.

So, then, what the hell are we doing here with all these relocations,
careful double execution of the same code from different execution
contexts, worrying about initrd firmware override even before the
kernel page table is set up?  If we're doing all those to just make
the temporary half-assed-anyway solution minutely better, that's just
plain stupid.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-08-22 20:35 UTC|newest]

Thread overview: 116+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 10:15 [PATCH 0/8] x86, acpi: Move acpi_initrd_override() earlier Tang Chen
2013-08-21 10:15 ` Tang Chen
2013-08-21 10:15 ` [PATCH 1/8] x86: Make get_ramdisk_{image|size}() global Tang Chen
2013-08-21 10:15   ` Tang Chen
2013-08-21 10:15 ` [PATCH 2/8] x86, microcode: Use get_ramdisk_{image|size}() in microcode handling Tang Chen
2013-08-21 10:15   ` Tang Chen
2013-08-21 10:15 ` [PATCH 3/8] x86, acpi: Move table_sigs[] to stack Tang Chen
2013-08-21 10:15   ` Tang Chen
2013-08-21 10:15 ` [PATCH 4/8] x86, acpi, brk: Extend BRK 256KB to store acpi override tables Tang Chen
2013-08-21 10:15   ` Tang Chen
2013-08-21 10:15 ` [PATCH 5/8] x86, brk: Make extend_brk() available with va/pa Tang Chen
2013-08-21 10:15   ` Tang Chen
2013-08-21 12:26   ` Konrad Rzeszutek Wilk
2013-08-21 12:26     ` Konrad Rzeszutek Wilk
2013-08-21 12:35     ` H. Peter Anvin
2013-08-21 12:35       ` H. Peter Anvin
2013-08-21 14:42       ` Konrad Rzeszutek Wilk
2013-08-21 14:42         ` Konrad Rzeszutek Wilk
2013-08-21 15:04         ` H. Peter Anvin
2013-08-21 15:04           ` H. Peter Anvin
2013-08-21 10:15 ` [PATCH 6/8] x86, acpi: Make acpi_initrd_override() available with va or pa Tang Chen
2013-08-21 10:15   ` Tang Chen
2013-08-21 10:15 ` [PATCH 7/8] x86, acpi, brk: Make early_alloc_acpi_override_tables_buf() available with va/pa Tang Chen
2013-08-21 10:15   ` Tang Chen
2013-08-21 10:15 ` [PATCH 8/8] x86, acpi: Do acpi_initrd_override() earlier in head_32.S/head64.c Tang Chen
2013-08-21 10:15   ` Tang Chen
2013-08-21 10:42 ` [PATCH 0/8] x86, acpi: Move acpi_initrd_override() earlier Tang Chen
2013-08-21 10:42   ` Tang Chen
2013-08-21 13:06 ` Tejun Heo
2013-08-21 13:06   ` Tejun Heo
2013-08-21 15:00   ` Zhang Yanfei
2013-08-21 15:00     ` Zhang Yanfei
2013-08-21 15:36     ` Tejun Heo
2013-08-21 15:36       ` Tejun Heo
2013-08-21 19:31       ` Toshi Kani
2013-08-21 19:31         ` Toshi Kani
2013-08-21 19:54         ` Tejun Heo
2013-08-21 19:54           ` Tejun Heo
2013-08-21 20:29           ` Toshi Kani
2013-08-21 20:29             ` Toshi Kani
2013-08-21 20:40             ` Tejun Heo
2013-08-21 20:40               ` Tejun Heo
2013-08-21 22:36               ` Toshi Kani
2013-08-21 22:36                 ` Toshi Kani
2013-08-22  3:32                 ` Tejun Heo
2013-08-22  3:32                   ` Tejun Heo
2013-08-22 15:52                   ` Toshi Kani
2013-08-22 15:52                     ` Toshi Kani
2013-08-22 18:31                     ` Tejun Heo
2013-08-22 18:31                       ` Tejun Heo
2013-08-22 19:39                       ` Zhang Yanfei
2013-08-22 19:39                         ` Zhang Yanfei
2013-08-22 19:45                         ` Tejun Heo
2013-08-22 19:45                           ` Tejun Heo
2013-08-22 20:11                       ` Toshi Kani
2013-08-22 20:11                         ` Toshi Kani
2013-08-22 20:21                         ` Tejun Heo
2013-08-22 20:21                           ` Tejun Heo
2013-08-22 20:35                           ` Tejun Heo [this message]
2013-08-22 20:35                             ` Tejun Heo
2013-08-22 21:06                           ` Toshi Kani
2013-08-22 21:06                             ` Toshi Kani
2013-08-22 21:21                             ` Tejun Heo
2013-08-22 21:21                               ` Tejun Heo
2013-08-22 22:17                               ` Toshi Kani
2013-08-22 22:17                                 ` Toshi Kani
2013-08-23 13:04                                 ` Tejun Heo
2013-08-23 13:04                                   ` Tejun Heo
2013-08-23 13:08                                   ` H. Peter Anvin
2013-08-23 13:08                                     ` H. Peter Anvin
2013-08-23 14:19                                     ` Tejun Heo
2013-08-23 14:19                                       ` Tejun Heo
2013-08-23 14:24                                       ` H. Peter Anvin
2013-08-23 14:24                                         ` H. Peter Anvin
2013-08-23 14:24                                         ` H. Peter Anvin
2013-08-23 14:35                                         ` Tejun Heo
2013-08-23 14:35                                           ` Tejun Heo
2013-08-23 14:57                                           ` Tejun Heo
2013-08-23 14:57                                             ` Tejun Heo
2013-08-23 16:14                                   ` Toshi Kani
2013-08-23 16:14                                     ` Toshi Kani
2013-08-23 16:24                                     ` Tejun Heo
2013-08-23 16:24                                       ` Tejun Heo
2013-08-23 17:13                                       ` Toshi Kani
2013-08-23 17:13                                         ` Toshi Kani
2013-08-23 17:29                                         ` Zhang Yanfei
2013-08-23 17:29                                           ` Zhang Yanfei
2013-08-23 16:54                                     ` Zhang Yanfei
2013-08-23 16:54                                       ` Zhang Yanfei
2013-08-23 18:18                                       ` Yinghai Lu
2013-08-23 18:18                                         ` Yinghai Lu
2013-08-23 18:25                                         ` H. Peter Anvin
2013-08-23 20:08                                           ` Yinghai Lu
2013-08-23 20:30                                             ` Russ Anderson
2013-08-23 20:48                                               ` Yinghai Lu
2013-08-23 21:50                                                 ` chen tang
2013-08-23 21:52                                                   ` Moore, Robert
2013-08-23 22:05                                                     ` Yinghai Lu
2013-08-23 22:08                                                   ` Yinghai Lu
2013-08-23 22:40                                                     ` chen tang
2013-08-23 23:04                                                       ` Yinghai Lu
2013-08-24  2:41                                             ` Russ Anderson
2013-08-23 20:33                                         ` chen tang
2013-08-23 20:33                                           ` chen tang
2013-08-23 21:08                                           ` Yinghai Lu
2013-08-23 21:08                                             ` Yinghai Lu
2013-08-23 22:27                                             ` chen tang
2013-08-23 22:27                                               ` chen tang
2013-08-23 18:29                                       ` Toshi Kani
2013-08-23 18:29                                         ` Toshi Kani
2013-08-23 21:37                                         ` chen tang
2013-08-23 21:37                                           ` chen tang
2013-08-23 21:52                                           ` Tejun Heo
2013-08-23 21:52                                             ` Tejun Heo
2013-08-23 23:56                                             ` chen tang
2013-08-23 23:56                                               ` chen tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130822203529.GE3490@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=gong.chen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=jiang.liu@huawei.com \
    --cc=jweiner@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lv.zheng@intel.com \
    --cc=lwoodman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=mingo@elte.hu \
    --cc=prarit@redhat.com \
    --cc=riel@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=robert.moore@intel.com \
    --cc=tangchen@cn.fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=toshi.kani@hp.com \
    --cc=trenn@suse.de \
    --cc=vasilis.liaskovitis@profitbricks.com \
    --cc=wency@cn.fujitsu.com \
    --cc=x86@kernel.org \
    --cc=yanghy@cn.fujitsu.com \
    --cc=yinghai@kernel.org \
    --cc=zhangyanfei.yes@gmail.com \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.