From: Arnd Bergmann <arnd@arndb.de> To: Guenter Roeck <linux@roeck-us.net> Cc: Jonas Jensen <jonas.jensen@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree-discuss@lists.ozlabs.org" <devicetree-discuss@lists.ozlabs.org>, "arm@kernel.org" <arm@kernel.org>, "Russell King - ARM Linux" <linux@arm.linux.org.uk>, Olof Johansson <olof@lixom.net> Subject: Re: [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files Date: Sat, 14 Dec 2013 05:01:05 +0100 [thread overview] Message-ID: <201312140501.05749.arnd@arndb.de> (raw) In-Reply-To: <20131213190707.GA9713@roeck-us.net> On Friday 13 December 2013, Guenter Roeck wrote: > On Fri, Dec 13, 2013 at 06:23:44PM +0100, Jonas Jensen wrote: > > On 13 December 2013 17:17, Arnd Bergmann <arnd@arndb.de> wrote: > > > I've been out of the loop a bit here. I initially suggested having the restart > > > handler be part of the watchdog driver, and I thought you had done that in an > > > earlier version. What has changed your mind? > > > > I got the impression from Guenter Roeck's review, that it doesn't belong there, > > maybe I was too quick to remove it? > > > You'd have to answer the questions I raised in my review if you want it in > there. > Let me reply to your comment from that email: > > + > > + arm_pm_restart = moxart_wdt_restart; > > It is quite unusual that system restart code is implemented in a watchdog > driver (which may not even be compiled into an image, or not be loaded). I had asked Jonas to do it in the watchdog driver because that driver is the place that handles this particular register. We have moved a bunch of restart handlers into drivers/power for similar reasons, and those can also be compiled out. The restart handler isn't actually essential for most operations, and we have moved some far more important drivers from arch/arm into drivers/, such as clocks, interrupts, timers etc. The restart handler in this case is the only piece of code that remains in mach-moxart, and I would really like it to be completely empty. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files Date: Sat, 14 Dec 2013 05:01:05 +0100 [thread overview] Message-ID: <201312140501.05749.arnd@arndb.de> (raw) In-Reply-To: <20131213190707.GA9713@roeck-us.net> On Friday 13 December 2013, Guenter Roeck wrote: > On Fri, Dec 13, 2013 at 06:23:44PM +0100, Jonas Jensen wrote: > > On 13 December 2013 17:17, Arnd Bergmann <arnd@arndb.de> wrote: > > > I've been out of the loop a bit here. I initially suggested having the restart > > > handler be part of the watchdog driver, and I thought you had done that in an > > > earlier version. What has changed your mind? > > > > I got the impression from Guenter Roeck's review, that it doesn't belong there, > > maybe I was too quick to remove it? > > > You'd have to answer the questions I raised in my review if you want it in > there. > Let me reply to your comment from that email: > > + > > + arm_pm_restart = moxart_wdt_restart; > > It is quite unusual that system restart code is implemented in a watchdog > driver (which may not even be compiled into an image, or not be loaded). I had asked Jonas to do it in the watchdog driver because that driver is the place that handles this particular register. We have moved a bunch of restart handlers into drivers/power for similar reasons, and those can also be compiled out. The restart handler isn't actually essential for most operations, and we have moved some far more important drivers from arch/arm into drivers/, such as clocks, interrupts, timers etc. The restart handler in this case is the only piece of code that remains in mach-moxart, and I would really like it to be completely empty. Arnd
next prev parent reply other threads:[~2013-12-14 4:01 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-12-13 14:33 [PATCH v4 0/2] ARM: mach-moxart: add MOXA ART SoC support Jonas Jensen 2013-12-13 14:33 ` Jonas Jensen 2013-12-13 14:33 ` [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files Jonas Jensen 2013-12-13 14:33 ` Jonas Jensen [not found] ` <1386945188-8316-2-git-send-email-jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2013-12-13 14:38 ` Fwd: " Jonas Jensen 2013-12-13 16:17 ` Arnd Bergmann 2013-12-13 16:17 ` Arnd Bergmann 2013-12-13 17:23 ` Jonas Jensen 2013-12-13 17:23 ` Jonas Jensen 2013-12-13 19:07 ` Guenter Roeck 2013-12-13 19:07 ` Guenter Roeck 2013-12-14 4:01 ` Arnd Bergmann [this message] 2013-12-14 4:01 ` Arnd Bergmann 2013-12-14 8:32 ` Jonas Jensen 2013-12-14 8:32 ` Jonas Jensen 2013-12-14 15:50 ` Guenter Roeck 2013-12-14 15:50 ` Guenter Roeck 2013-12-14 16:26 ` Jonas Jensen 2013-12-14 16:26 ` Jonas Jensen 2013-12-14 18:50 ` Arnd Bergmann 2013-12-14 18:50 ` Arnd Bergmann 2013-12-14 20:14 ` Guenter Roeck 2013-12-14 20:14 ` Guenter Roeck 2013-12-15 0:21 ` Arnd Bergmann 2013-12-15 0:21 ` Arnd Bergmann 2013-12-22 19:48 ` Olof Johansson 2013-12-22 19:48 ` Olof Johansson 2013-12-13 14:33 ` [PATCH v4 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files Jonas Jensen 2013-12-13 14:33 ` Jonas Jensen [not found] ` <1386945188-8316-3-git-send-email-jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2013-12-13 14:39 ` Fwd: " Jonas Jensen 2013-12-13 16:17 ` Arnd Bergmann 2013-12-13 16:17 ` Arnd Bergmann 2013-12-15 4:27 ` Peter Crosthwaite 2013-12-15 4:27 ` Peter Crosthwaite 2013-12-16 20:05 ` Jonas Jensen 2013-12-16 20:05 ` Jonas Jensen 2013-12-16 23:53 ` Peter Crosthwaite 2013-12-16 23:53 ` Peter Crosthwaite 2013-12-16 23:53 ` Peter Crosthwaite 2013-12-17 0:09 ` Sören Brinkmann 2013-12-17 0:09 ` Sören Brinkmann 2013-12-17 0:09 ` Sören Brinkmann 2013-12-22 19:49 ` Olof Johansson 2013-12-22 19:49 ` Olof Johansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201312140501.05749.arnd@arndb.de \ --to=arnd@arndb.de \ --cc=arm@kernel.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=jonas.jensen@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=linux@roeck-us.net \ --cc=olof@lixom.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.