All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonas Jensen <jonas.jensen@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"arm@kernel.org" <arm@kernel.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files
Date: Sat, 14 Dec 2013 09:32:36 +0100	[thread overview]
Message-ID: <CACmBeS2_WZj6_HJo0N50TBwneNVmeB9TyXbHRLm9CJFGNN+HtQ@mail.gmail.com> (raw)
In-Reply-To: <20131213190707.GA9713@roeck-us.net>

On 13 December 2013 20:07, Guenter Roeck <linux@roeck-us.net> wrote:
>> I got the impression from Guenter Roeck's review, that it doesn't belong there,
>> maybe I was too quick to remove it?
>>
> You'd have to answer the questions I raised in my review if you want it in
> there.

I didn't see a solution at the time. Now I'm thinking arm_pm_restart
can be set later in probe, preventing a crash on load failure, and
maybe it can be unset on unload.

Would you accept a patch for this?

Best regards,
Jonas

WARNING: multiple messages have this Message-ID (diff)
From: jonas.jensen@gmail.com (Jonas Jensen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files
Date: Sat, 14 Dec 2013 09:32:36 +0100	[thread overview]
Message-ID: <CACmBeS2_WZj6_HJo0N50TBwneNVmeB9TyXbHRLm9CJFGNN+HtQ@mail.gmail.com> (raw)
In-Reply-To: <20131213190707.GA9713@roeck-us.net>

On 13 December 2013 20:07, Guenter Roeck <linux@roeck-us.net> wrote:
>> I got the impression from Guenter Roeck's review, that it doesn't belong there,
>> maybe I was too quick to remove it?
>>
> You'd have to answer the questions I raised in my review if you want it in
> there.

I didn't see a solution at the time. Now I'm thinking arm_pm_restart
can be set later in probe, preventing a crash on load failure, and
maybe it can be unset on unload.

Would you accept a patch for this?

Best regards,
Jonas

  parent reply	other threads:[~2013-12-14  8:32 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 14:33 [PATCH v4 0/2] ARM: mach-moxart: add MOXA ART SoC support Jonas Jensen
2013-12-13 14:33 ` Jonas Jensen
2013-12-13 14:33 ` [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files Jonas Jensen
2013-12-13 14:33   ` Jonas Jensen
     [not found]   ` <1386945188-8316-2-git-send-email-jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-12-13 14:38     ` Fwd: " Jonas Jensen
2013-12-13 16:17   ` Arnd Bergmann
2013-12-13 16:17     ` Arnd Bergmann
2013-12-13 17:23     ` Jonas Jensen
2013-12-13 17:23       ` Jonas Jensen
2013-12-13 19:07       ` Guenter Roeck
2013-12-13 19:07         ` Guenter Roeck
2013-12-14  4:01         ` Arnd Bergmann
2013-12-14  4:01           ` Arnd Bergmann
2013-12-14  8:32         ` Jonas Jensen [this message]
2013-12-14  8:32           ` Jonas Jensen
2013-12-14 15:50           ` Guenter Roeck
2013-12-14 15:50             ` Guenter Roeck
2013-12-14 16:26             ` Jonas Jensen
2013-12-14 16:26               ` Jonas Jensen
2013-12-14 18:50               ` Arnd Bergmann
2013-12-14 18:50                 ` Arnd Bergmann
2013-12-14 20:14                 ` Guenter Roeck
2013-12-14 20:14                   ` Guenter Roeck
2013-12-15  0:21                   ` Arnd Bergmann
2013-12-15  0:21                     ` Arnd Bergmann
2013-12-22 19:48   ` Olof Johansson
2013-12-22 19:48     ` Olof Johansson
2013-12-13 14:33 ` [PATCH v4 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files Jonas Jensen
2013-12-13 14:33   ` Jonas Jensen
     [not found]   ` <1386945188-8316-3-git-send-email-jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-12-13 14:39     ` Fwd: " Jonas Jensen
2013-12-13 16:17   ` Arnd Bergmann
2013-12-13 16:17     ` Arnd Bergmann
2013-12-15  4:27   ` Peter Crosthwaite
2013-12-15  4:27     ` Peter Crosthwaite
2013-12-16 20:05     ` Jonas Jensen
2013-12-16 20:05       ` Jonas Jensen
2013-12-16 23:53       ` Peter Crosthwaite
2013-12-16 23:53         ` Peter Crosthwaite
2013-12-16 23:53         ` Peter Crosthwaite
2013-12-17  0:09         ` Sören Brinkmann
2013-12-17  0:09           ` Sören Brinkmann
2013-12-17  0:09           ` Sören Brinkmann
2013-12-22 19:49   ` Olof Johansson
2013-12-22 19:49     ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACmBeS2_WZj6_HJo0N50TBwneNVmeB9TyXbHRLm9CJFGNN+HtQ@mail.gmail.com \
    --to=jonas.jensen@gmail.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linux@roeck-us.net \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.