From: Arnd Bergmann <arnd@arndb.de>
To: Jonas Jensen <jonas.jensen@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arm@kernel.org" <arm@kernel.org>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files
Date: Sat, 14 Dec 2013 19:50:09 +0100 [thread overview]
Message-ID: <201312141950.09447.arnd@arndb.de> (raw)
In-Reply-To: <CACmBeS3Xse5KkFqkM5Ye+qaaxpVCjyeGz7Oc9sr0PN+pZ9sztQ@mail.gmail.com>
On Saturday 14 December 2013, Jonas Jensen wrote:
> >
> > Conceptually it might be cleaner to write a separate driver, for example
> > in drivers/power/restart, than plugging the functionality into
> > the watchdog driver, at least if you don't want it in architecture
> > or platform code. The xgene restart driver is a good example.
> >
>
> Moving it to a new power/restart driver seems reasonable to me, I'm
> really just looking for a home for it, I would have preferred a
> hardware with reset in a separate register though.
>
> I now plan to remove it for v5 and submit a separate driver.
I still think it's better to leave it in the watchdog driver: This
driver attaches to the watchdog device, and adding a separate driver
for reset means we have to trick the core Linux code into attaching
two drivers to one device in some way, or the device tree has to fake
a second device that doesn't exist in hardware but is only needed
because of Linux implementation details.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files
Date: Sat, 14 Dec 2013 19:50:09 +0100 [thread overview]
Message-ID: <201312141950.09447.arnd@arndb.de> (raw)
In-Reply-To: <CACmBeS3Xse5KkFqkM5Ye+qaaxpVCjyeGz7Oc9sr0PN+pZ9sztQ@mail.gmail.com>
On Saturday 14 December 2013, Jonas Jensen wrote:
> >
> > Conceptually it might be cleaner to write a separate driver, for example
> > in drivers/power/restart, than plugging the functionality into
> > the watchdog driver, at least if you don't want it in architecture
> > or platform code. The xgene restart driver is a good example.
> >
>
> Moving it to a new power/restart driver seems reasonable to me, I'm
> really just looking for a home for it, I would have preferred a
> hardware with reset in a separate register though.
>
> I now plan to remove it for v5 and submit a separate driver.
I still think it's better to leave it in the watchdog driver: This
driver attaches to the watchdog device, and adding a separate driver
for reset means we have to trick the core Linux code into attaching
two drivers to one device in some way, or the device tree has to fake
a second device that doesn't exist in hardware but is only needed
because of Linux implementation details.
Arnd
next prev parent reply other threads:[~2013-12-14 18:50 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 14:33 [PATCH v4 0/2] ARM: mach-moxart: add MOXA ART SoC support Jonas Jensen
2013-12-13 14:33 ` Jonas Jensen
2013-12-13 14:33 ` [PATCH v4 1/2] ARM: mach-moxart: add MOXA ART SoC platform files Jonas Jensen
2013-12-13 14:33 ` Jonas Jensen
[not found] ` <1386945188-8316-2-git-send-email-jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-12-13 14:38 ` Fwd: " Jonas Jensen
2013-12-13 16:17 ` Arnd Bergmann
2013-12-13 16:17 ` Arnd Bergmann
2013-12-13 17:23 ` Jonas Jensen
2013-12-13 17:23 ` Jonas Jensen
2013-12-13 19:07 ` Guenter Roeck
2013-12-13 19:07 ` Guenter Roeck
2013-12-14 4:01 ` Arnd Bergmann
2013-12-14 4:01 ` Arnd Bergmann
2013-12-14 8:32 ` Jonas Jensen
2013-12-14 8:32 ` Jonas Jensen
2013-12-14 15:50 ` Guenter Roeck
2013-12-14 15:50 ` Guenter Roeck
2013-12-14 16:26 ` Jonas Jensen
2013-12-14 16:26 ` Jonas Jensen
2013-12-14 18:50 ` Arnd Bergmann [this message]
2013-12-14 18:50 ` Arnd Bergmann
2013-12-14 20:14 ` Guenter Roeck
2013-12-14 20:14 ` Guenter Roeck
2013-12-15 0:21 ` Arnd Bergmann
2013-12-15 0:21 ` Arnd Bergmann
2013-12-22 19:48 ` Olof Johansson
2013-12-22 19:48 ` Olof Johansson
2013-12-13 14:33 ` [PATCH v4 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files Jonas Jensen
2013-12-13 14:33 ` Jonas Jensen
[not found] ` <1386945188-8316-3-git-send-email-jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-12-13 14:39 ` Fwd: " Jonas Jensen
2013-12-13 16:17 ` Arnd Bergmann
2013-12-13 16:17 ` Arnd Bergmann
2013-12-15 4:27 ` Peter Crosthwaite
2013-12-15 4:27 ` Peter Crosthwaite
2013-12-16 20:05 ` Jonas Jensen
2013-12-16 20:05 ` Jonas Jensen
2013-12-16 23:53 ` Peter Crosthwaite
2013-12-16 23:53 ` Peter Crosthwaite
2013-12-16 23:53 ` Peter Crosthwaite
2013-12-17 0:09 ` Sören Brinkmann
2013-12-17 0:09 ` Sören Brinkmann
2013-12-17 0:09 ` Sören Brinkmann
2013-12-22 19:49 ` Olof Johansson
2013-12-22 19:49 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312141950.09447.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=jonas.jensen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.