All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: "sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>,
	"tj@kernel.org" <tj@kernel.org>,
	"alexandre.belloni@free-electrons.com"
	<alexandre.belloni@free-electrons.com>,
	Jimmy Xu <zmxu@marvell.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs
Date: Thu, 24 Apr 2014 12:26:39 +0200	[thread overview]
Message-ID: <20140424102639.GA31101@kwain> (raw)
In-Reply-To: <20140424175041.0bade2d6@xhacker>

Hi Jisheng,

On Thu, Apr 24, 2014 at 05:50:41PM +0800, Jisheng Zhang wrote:
> Hi Antoine,
> 
> On Tue, 22 Apr 2014 08:38:20 -0700
> Antoine Ténart <antoine.tenart@free-electrons.com> wrote:
> 
> > +		/* CT timing fix */
> > +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) |
> > BIT(1));
> > +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> > +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> > +				    BIT(10) | BIT(2) | BIT(1));
> 
> Could you please remove these code? They are not used for BG2Q, I'm sorry there's
> such mistake in the code I provided to you ;)

OK, thanks for the update!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: antoine.tenart@free-electrons.com (Antoine Ténart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs
Date: Thu, 24 Apr 2014 12:26:39 +0200	[thread overview]
Message-ID: <20140424102639.GA31101@kwain> (raw)
In-Reply-To: <20140424175041.0bade2d6@xhacker>

Hi Jisheng,

On Thu, Apr 24, 2014 at 05:50:41PM +0800, Jisheng Zhang wrote:
> Hi Antoine,
> 
> On Tue, 22 Apr 2014 08:38:20 -0700
> Antoine T?nart <antoine.tenart@free-electrons.com> wrote:
> 
> > +		/* CT timing fix */
> > +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) |
> > BIT(1));
> > +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> > +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> > +				    BIT(10) | BIT(2) | BIT(1));
> 
> Could you please remove these code? They are not used for BG2Q, I'm sorry there's
> such mistake in the code I provided to you ;)

OK, thanks for the update!

Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-04-24 10:26 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 15:38 [PATCH 0/6] ARM: berlin: add AHCI support Antoine Ténart
2014-04-22 15:38 ` Antoine Ténart
2014-04-22 15:38 ` Antoine Ténart
2014-04-22 15:38 ` [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs Antoine Ténart
2014-04-22 15:38   ` Antoine Ténart
2014-04-22 16:54   ` Bartlomiej Zolnierkiewicz
2014-04-22 16:54     ` Bartlomiej Zolnierkiewicz
2014-04-23  8:13     ` Antoine Ténart
2014-04-23  8:13       ` Antoine Ténart
2014-04-22 17:20   ` Sebastian Hesselbarth
2014-04-22 17:20     ` Sebastian Hesselbarth
2014-04-22 17:20     ` Sebastian Hesselbarth
2014-04-23  8:21     ` Antoine Ténart
2014-04-23  8:21       ` Antoine Ténart
2014-04-22 18:47   ` Rob Herring
2014-04-22 18:47     ` Rob Herring
2014-04-22 18:47     ` Rob Herring
2014-04-22 18:54     ` Rob Herring
2014-04-22 18:54       ` Rob Herring
2014-04-22 18:54       ` Rob Herring
2014-04-23  8:24       ` Antoine Ténart
2014-04-23  8:24         ` Antoine Ténart
2014-04-23  8:24         ` Antoine Ténart
2014-04-23  8:33     ` Antoine Ténart
2014-04-23  8:33       ` Antoine Ténart
2014-04-23  8:33       ` Antoine Ténart
2014-04-22 20:56   ` Andrew Lunn
2014-04-22 20:56     ` Andrew Lunn
2014-04-24  9:50   ` Jisheng Zhang
2014-04-24  9:50     ` Jisheng Zhang
2014-04-24  9:50     ` Jisheng Zhang
2014-04-24 10:26     ` Antoine Ténart [this message]
2014-04-24 10:26       ` Antoine Ténart
2014-04-24 10:26       ` Antoine Ténart
2014-04-22 15:38 ` [PATCH 2/6] Documentation: bindings: add the berlin-achi compatible to the ahci platform Antoine Ténart
2014-04-22 15:38   ` Antoine Ténart
2014-04-22 16:27   ` Thomas Petazzoni
2014-04-22 16:27     ` Thomas Petazzoni
2014-04-22 17:21   ` Sebastian Hesselbarth
2014-04-22 17:21     ` Sebastian Hesselbarth
2014-04-22 17:21     ` Sebastian Hesselbarth
2014-04-22 15:38 ` [PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q Antoine Ténart
2014-04-22 15:38   ` Antoine Ténart
2014-04-22 15:38   ` Antoine Ténart
2014-04-22 16:28   ` Thomas Petazzoni
2014-04-22 16:28     ` Thomas Petazzoni
2014-04-22 17:22     ` Sebastian Hesselbarth
2014-04-22 17:22       ` Sebastian Hesselbarth
2014-04-22 17:22       ` Sebastian Hesselbarth
2014-04-22 16:28   ` Thomas Petazzoni
2014-04-22 16:28     ` Thomas Petazzoni
2014-04-22 15:38 ` [PATCH 4/6] ARM: berlin: enable the eSATA interface on the BG2Q DMP Antoine Ténart
2014-04-22 15:38   ` Antoine Ténart
2014-04-22 15:38   ` Antoine Ténart
2014-04-22 15:38 ` [PATCH 5/6] ARM: berlin: add the AHCI node for the BG2 Antoine Ténart
2014-04-22 15:38   ` Antoine Ténart
2014-04-23  2:45   ` Jisheng Zhang
2014-04-23  2:45     ` Jisheng Zhang
2014-04-23  2:45     ` Jisheng Zhang
2014-04-23  8:58     ` Antoine Ténart
2014-04-23  8:58       ` Antoine Ténart
2014-04-23  8:58       ` Antoine Ténart
2014-04-22 15:38 ` [PATCH 6/6] ARM: berlin: add the AHCI node for the BG2CD Antoine Ténart
2014-04-22 15:38   ` Antoine Ténart
2014-04-22 15:38   ` Antoine Ténart
2014-04-23  2:43   ` Jisheng Zhang
2014-04-23  2:43     ` Jisheng Zhang
2014-04-23  2:43     ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140424102639.GA31101@kwain \
    --to=antoine.tenart@free-electrons.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tj@kernel.org \
    --cc=zmxu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.