From: Rob Herring <robherring2@gmail.com> To: "Antoine Ténart" <antoine.tenart@free-electrons.com> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Tejun Heo <tj@kernel.org>, zmxu@marvell.com, Jisheng Zhang <jszhang@marvell.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-ide@vger.kernel.org, Alexandre Belloni <alexandre.belloni@free-electrons.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs Date: Tue, 22 Apr 2014 13:54:33 -0500 [thread overview] Message-ID: <CAL_JsqJwC2xcZakXiJXJscK7tN7xt2OotBKyr9u+aK3bOP+7GQ@mail.gmail.com> (raw) In-Reply-To: <CAL_JsqKE_Z3kBhS1VaQADV5ob8x6AKHhbHaQEGoVSwkwdd50zA@mail.gmail.com> On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@gmail.com> wrote: > On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart > <antoine.tenart@free-electrons.com> wrote: >> Add support for the Berlin SoCs AHCI SATA controller allowing to >> interface with devices like external hard drives. One more thing. >> + nports = readl(hpriv->mmio + HOST_PORTS_IMPL); >> + >> + /* force_map is modified only if the property is found */ >> + of_property_read_u32(np, "marvell,force-port-map", &force_map); This property does not appear to be documented. >> + if (force_map) >> + nports = force_map; You don't need this as your comment says, you can just do: of_property_read_u32(np, "marvell,force-port-map", &nports); nports will only be changed if property is present. Rob
WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs Date: Tue, 22 Apr 2014 13:54:33 -0500 [thread overview] Message-ID: <CAL_JsqJwC2xcZakXiJXJscK7tN7xt2OotBKyr9u+aK3bOP+7GQ@mail.gmail.com> (raw) In-Reply-To: <CAL_JsqKE_Z3kBhS1VaQADV5ob8x6AKHhbHaQEGoVSwkwdd50zA@mail.gmail.com> On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@gmail.com> wrote: > On Tue, Apr 22, 2014 at 10:38 AM, Antoine T?nart > <antoine.tenart@free-electrons.com> wrote: >> Add support for the Berlin SoCs AHCI SATA controller allowing to >> interface with devices like external hard drives. One more thing. >> + nports = readl(hpriv->mmio + HOST_PORTS_IMPL); >> + >> + /* force_map is modified only if the property is found */ >> + of_property_read_u32(np, "marvell,force-port-map", &force_map); This property does not appear to be documented. >> + if (force_map) >> + nports = force_map; You don't need this as your comment says, you can just do: of_property_read_u32(np, "marvell,force-port-map", &nports); nports will only be changed if property is present. Rob
next prev parent reply other threads:[~2014-04-22 18:54 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-04-22 15:38 [PATCH 0/6] ARM: berlin: add AHCI support Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-22 15:38 ` [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-22 16:54 ` Bartlomiej Zolnierkiewicz 2014-04-22 16:54 ` Bartlomiej Zolnierkiewicz 2014-04-23 8:13 ` Antoine Ténart 2014-04-23 8:13 ` Antoine Ténart 2014-04-22 17:20 ` Sebastian Hesselbarth 2014-04-22 17:20 ` Sebastian Hesselbarth 2014-04-22 17:20 ` Sebastian Hesselbarth 2014-04-23 8:21 ` Antoine Ténart 2014-04-23 8:21 ` Antoine Ténart 2014-04-22 18:47 ` Rob Herring 2014-04-22 18:47 ` Rob Herring 2014-04-22 18:47 ` Rob Herring 2014-04-22 18:54 ` Rob Herring [this message] 2014-04-22 18:54 ` Rob Herring 2014-04-22 18:54 ` Rob Herring 2014-04-23 8:24 ` Antoine Ténart 2014-04-23 8:24 ` Antoine Ténart 2014-04-23 8:24 ` Antoine Ténart 2014-04-23 8:33 ` Antoine Ténart 2014-04-23 8:33 ` Antoine Ténart 2014-04-23 8:33 ` Antoine Ténart 2014-04-22 20:56 ` Andrew Lunn 2014-04-22 20:56 ` Andrew Lunn 2014-04-24 9:50 ` Jisheng Zhang 2014-04-24 9:50 ` Jisheng Zhang 2014-04-24 9:50 ` Jisheng Zhang 2014-04-24 10:26 ` Antoine Ténart 2014-04-24 10:26 ` Antoine Ténart 2014-04-24 10:26 ` Antoine Ténart 2014-04-22 15:38 ` [PATCH 2/6] Documentation: bindings: add the berlin-achi compatible to the ahci platform Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-22 16:27 ` Thomas Petazzoni 2014-04-22 16:27 ` Thomas Petazzoni 2014-04-22 17:21 ` Sebastian Hesselbarth 2014-04-22 17:21 ` Sebastian Hesselbarth 2014-04-22 17:21 ` Sebastian Hesselbarth 2014-04-22 15:38 ` [PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-22 16:28 ` Thomas Petazzoni 2014-04-22 16:28 ` Thomas Petazzoni 2014-04-22 17:22 ` Sebastian Hesselbarth 2014-04-22 17:22 ` Sebastian Hesselbarth 2014-04-22 17:22 ` Sebastian Hesselbarth 2014-04-22 16:28 ` Thomas Petazzoni 2014-04-22 16:28 ` Thomas Petazzoni 2014-04-22 15:38 ` [PATCH 4/6] ARM: berlin: enable the eSATA interface on the BG2Q DMP Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-22 15:38 ` [PATCH 5/6] ARM: berlin: add the AHCI node for the BG2 Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-23 2:45 ` Jisheng Zhang 2014-04-23 2:45 ` Jisheng Zhang 2014-04-23 2:45 ` Jisheng Zhang 2014-04-23 8:58 ` Antoine Ténart 2014-04-23 8:58 ` Antoine Ténart 2014-04-23 8:58 ` Antoine Ténart 2014-04-22 15:38 ` [PATCH 6/6] ARM: berlin: add the AHCI node for the BG2CD Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-22 15:38 ` Antoine Ténart 2014-04-23 2:43 ` Jisheng Zhang 2014-04-23 2:43 ` Jisheng Zhang 2014-04-23 2:43 ` Jisheng Zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAL_JsqJwC2xcZakXiJXJscK7tN7xt2OotBKyr9u+aK3bOP+7GQ@mail.gmail.com \ --to=robherring2@gmail.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=antoine.tenart@free-electrons.com \ --cc=jszhang@marvell.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=tj@kernel.org \ --cc=zmxu@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.