* [PATCH] net: xen-netback: include linux/vmalloc.h again
@ 2014-06-10 8:34 Arnd Bergmann
2014-06-10 8:44 ` Wei Liu
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Arnd Bergmann @ 2014-06-10 8:34 UTC (permalink / raw)
To: netdev; +Cc: David Miller, Wei Liu, Andrew J. Bennieston, xen-devel, Josh Boyer
commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
queue struct") added a use of vzalloc/vfree to interface.c, but
removed the #include <linux/vmalloc.h> statement at the same time,
which causes this build error:
drivers/net/xen-netback/interface.c: In function 'xenvif_free':
drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
vfree(vif->queues);
^
cc1: some warnings being treated as errors
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
---
I haven't found another report of this bug, but if someone else already
submitted a fix, please ignore this one.
Incidentally, it's the same bug that Josh fixed before in January,
but it has reappeared now, see https://lkml.org/lkml/2014/1/5/36
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 6929bcb..852da34 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -34,6 +34,7 @@
#include <linux/ethtool.h>
#include <linux/rtnetlink.h>
#include <linux/if_vlan.h>
+#include <linux/vmalloc.h>
#include <xen/events.h>
#include <asm/xen/hypercall.h>
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] net: xen-netback: include linux/vmalloc.h again
2014-06-10 8:34 [PATCH] net: xen-netback: include linux/vmalloc.h again Arnd Bergmann
@ 2014-06-10 8:44 ` Wei Liu
2014-06-10 8:52 ` [Xen-devel] " Ian Campbell
` (3 more replies)
2014-06-10 8:44 ` Wei Liu
` (2 subsequent siblings)
3 siblings, 4 replies; 12+ messages in thread
From: Wei Liu @ 2014-06-10 8:44 UTC (permalink / raw)
To: Arnd Bergmann
Cc: netdev, David Miller, Wei Liu, Andrew J. Bennieston, xen-devel,
Josh Boyer
On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> queue struct") added a use of vzalloc/vfree to interface.c, but
> removed the #include <linux/vmalloc.h> statement at the same time,
> which causes this build error:
>
> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(vif->queues);
> ^
> cc1: some warnings being treated as errors
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
This didn't happen to me when I built it on x86 though. Just curious,
did you build it on othet platform, say, ARM?
Wei.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Xen-devel] [PATCH] net: xen-netback: include linux/vmalloc.h again
2014-06-10 8:44 ` Wei Liu
@ 2014-06-10 8:52 ` Ian Campbell
2014-06-10 8:52 ` Ian Campbell
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: Ian Campbell @ 2014-06-10 8:52 UTC (permalink / raw)
To: Wei Liu
Cc: Arnd Bergmann, Josh Boyer, netdev, xen-devel,
Andrew J. Bennieston, David Miller
On Tue, 2014-06-10 at 09:44 +0100, Wei Liu wrote:
> On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> > commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> > queue struct") added a use of vzalloc/vfree to interface.c, but
> > removed the #include <linux/vmalloc.h> statement at the same time,
> > which causes this build error:
> >
> > drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> > drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> > vfree(vif->queues);
> > ^
> > cc1: some warnings being treated as errors
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> This didn't happen to me when I built it on x86 though. Just curious,
> did you build it on othet platform, say, ARM?
Arnd comaintains the arm-soc tree, so that's a pretty good bet ;-)
Ian.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] net: xen-netback: include linux/vmalloc.h again
2014-06-10 8:44 ` Wei Liu
2014-06-10 8:52 ` [Xen-devel] " Ian Campbell
@ 2014-06-10 8:52 ` Ian Campbell
2014-06-11 22:19 ` David Miller
2014-06-11 22:19 ` David Miller
3 siblings, 0 replies; 12+ messages in thread
From: Ian Campbell @ 2014-06-10 8:52 UTC (permalink / raw)
To: Wei Liu
Cc: Josh Boyer, Arnd Bergmann, netdev, xen-devel,
Andrew J. Bennieston, David Miller
On Tue, 2014-06-10 at 09:44 +0100, Wei Liu wrote:
> On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> > commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> > queue struct") added a use of vzalloc/vfree to interface.c, but
> > removed the #include <linux/vmalloc.h> statement at the same time,
> > which causes this build error:
> >
> > drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> > drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> > vfree(vif->queues);
> > ^
> > cc1: some warnings being treated as errors
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> This didn't happen to me when I built it on x86 though. Just curious,
> did you build it on othet platform, say, ARM?
Arnd comaintains the arm-soc tree, so that's a pretty good bet ;-)
Ian.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] net: xen-netback: include linux/vmalloc.h again
2014-06-10 8:44 ` Wei Liu
2014-06-10 8:52 ` [Xen-devel] " Ian Campbell
2014-06-10 8:52 ` Ian Campbell
@ 2014-06-11 22:19 ` David Miller
2014-06-12 9:07 ` Wei Liu
2014-06-12 9:07 ` Wei Liu
2014-06-11 22:19 ` David Miller
3 siblings, 2 replies; 12+ messages in thread
From: David Miller @ 2014-06-11 22:19 UTC (permalink / raw)
To: wei.liu2; +Cc: arnd, netdev, andrew.bennieston, xen-devel, jwboyer
From: Wei Liu <wei.liu2@citrix.com>
Date: Tue, 10 Jun 2014 09:44:54 +0100
> On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
>> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
>> queue struct") added a use of vzalloc/vfree to interface.c, but
>> removed the #include <linux/vmalloc.h> statement at the same time,
>> which causes this build error:
>>
>> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
>> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>> vfree(vif->queues);
>> ^
>> cc1: some warnings being treated as errors
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Wei Liu <wei.liu2@citrix.com>
>> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> This didn't happen to me when I built it on x86 though. Just curious,
> did you build it on othet platform, say, ARM?
ARM and PowerPC will both show this problem.
The issue is that x86 get's linux/vmalloc.h implicitly through one of
it's asm/ headers, thus you'll never hit the issue if you only build
test on that arch.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] net: xen-netback: include linux/vmalloc.h again
2014-06-11 22:19 ` David Miller
@ 2014-06-12 9:07 ` Wei Liu
2014-06-12 9:07 ` Wei Liu
1 sibling, 0 replies; 12+ messages in thread
From: Wei Liu @ 2014-06-12 9:07 UTC (permalink / raw)
To: David Miller
Cc: wei.liu2, arnd, netdev, andrew.bennieston, xen-devel, jwboyer
On Wed, Jun 11, 2014 at 03:19:01PM -0700, David Miller wrote:
> From: Wei Liu <wei.liu2@citrix.com>
> Date: Tue, 10 Jun 2014 09:44:54 +0100
>
> > On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> >> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> >> queue struct") added a use of vzalloc/vfree to interface.c, but
> >> removed the #include <linux/vmalloc.h> statement at the same time,
> >> which causes this build error:
> >>
> >> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> >> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> >> vfree(vif->queues);
> >> ^
> >> cc1: some warnings being treated as errors
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Cc: Wei Liu <wei.liu2@citrix.com>
> >> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
> >
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> >
> > This didn't happen to me when I built it on x86 though. Just curious,
> > did you build it on othet platform, say, ARM?
>
> ARM and PowerPC will both show this problem.
>
> The issue is that x86 get's linux/vmalloc.h implicitly through one of
> it's asm/ headers, thus you'll never hit the issue if you only build
> test on that arch.
Good to know. I shall keep an eye on this in the future.
Thanks
Wei.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] net: xen-netback: include linux/vmalloc.h again
2014-06-11 22:19 ` David Miller
2014-06-12 9:07 ` Wei Liu
@ 2014-06-12 9:07 ` Wei Liu
1 sibling, 0 replies; 12+ messages in thread
From: Wei Liu @ 2014-06-12 9:07 UTC (permalink / raw)
To: David Miller
Cc: jwboyer, wei.liu2, arnd, netdev, xen-devel, andrew.bennieston
On Wed, Jun 11, 2014 at 03:19:01PM -0700, David Miller wrote:
> From: Wei Liu <wei.liu2@citrix.com>
> Date: Tue, 10 Jun 2014 09:44:54 +0100
>
> > On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> >> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> >> queue struct") added a use of vzalloc/vfree to interface.c, but
> >> removed the #include <linux/vmalloc.h> statement at the same time,
> >> which causes this build error:
> >>
> >> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> >> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> >> vfree(vif->queues);
> >> ^
> >> cc1: some warnings being treated as errors
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Cc: Wei Liu <wei.liu2@citrix.com>
> >> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
> >
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> >
> > This didn't happen to me when I built it on x86 though. Just curious,
> > did you build it on othet platform, say, ARM?
>
> ARM and PowerPC will both show this problem.
>
> The issue is that x86 get's linux/vmalloc.h implicitly through one of
> it's asm/ headers, thus you'll never hit the issue if you only build
> test on that arch.
Good to know. I shall keep an eye on this in the future.
Thanks
Wei.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] net: xen-netback: include linux/vmalloc.h again
2014-06-10 8:44 ` Wei Liu
` (2 preceding siblings ...)
2014-06-11 22:19 ` David Miller
@ 2014-06-11 22:19 ` David Miller
3 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2014-06-11 22:19 UTC (permalink / raw)
To: wei.liu2; +Cc: netdev, jwboyer, andrew.bennieston, arnd, xen-devel
From: Wei Liu <wei.liu2@citrix.com>
Date: Tue, 10 Jun 2014 09:44:54 +0100
> On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
>> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
>> queue struct") added a use of vzalloc/vfree to interface.c, but
>> removed the #include <linux/vmalloc.h> statement at the same time,
>> which causes this build error:
>>
>> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
>> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>> vfree(vif->queues);
>> ^
>> cc1: some warnings being treated as errors
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Wei Liu <wei.liu2@citrix.com>
>> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> This didn't happen to me when I built it on x86 though. Just curious,
> did you build it on othet platform, say, ARM?
ARM and PowerPC will both show this problem.
The issue is that x86 get's linux/vmalloc.h implicitly through one of
it's asm/ headers, thus you'll never hit the issue if you only build
test on that arch.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] net: xen-netback: include linux/vmalloc.h again
2014-06-10 8:34 [PATCH] net: xen-netback: include linux/vmalloc.h again Arnd Bergmann
2014-06-10 8:44 ` Wei Liu
@ 2014-06-10 8:44 ` Wei Liu
2014-06-11 22:19 ` David Miller
2014-06-11 22:19 ` David Miller
3 siblings, 0 replies; 12+ messages in thread
From: Wei Liu @ 2014-06-10 8:44 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Josh Boyer, Wei Liu, netdev, xen-devel, Andrew J. Bennieston,
David Miller
On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> queue struct") added a use of vzalloc/vfree to interface.c, but
> removed the #include <linux/vmalloc.h> statement at the same time,
> which causes this build error:
>
> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(vif->queues);
> ^
> cc1: some warnings being treated as errors
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
This didn't happen to me when I built it on x86 though. Just curious,
did you build it on othet platform, say, ARM?
Wei.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] net: xen-netback: include linux/vmalloc.h again
2014-06-10 8:34 [PATCH] net: xen-netback: include linux/vmalloc.h again Arnd Bergmann
2014-06-10 8:44 ` Wei Liu
2014-06-10 8:44 ` Wei Liu
@ 2014-06-11 22:19 ` David Miller
2014-06-11 22:19 ` David Miller
3 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2014-06-11 22:19 UTC (permalink / raw)
To: arnd; +Cc: netdev, wei.liu2, andrew.bennieston, xen-devel, jwboyer
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 10 Jun 2014 10:34:36 +0200
> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> queue struct") added a use of vzalloc/vfree to interface.c, but
> removed the #include <linux/vmalloc.h> statement at the same time,
> which causes this build error:
>
> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(vif->queues);
> ^
> cc1: some warnings being treated as errors
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] net: xen-netback: include linux/vmalloc.h again
2014-06-10 8:34 [PATCH] net: xen-netback: include linux/vmalloc.h again Arnd Bergmann
` (2 preceding siblings ...)
2014-06-11 22:19 ` David Miller
@ 2014-06-11 22:19 ` David Miller
3 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2014-06-11 22:19 UTC (permalink / raw)
To: arnd; +Cc: andrew.bennieston, netdev, jwboyer, wei.liu2, xen-devel
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 10 Jun 2014 10:34:36 +0200
> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> queue struct") added a use of vzalloc/vfree to interface.c, but
> removed the #include <linux/vmalloc.h> statement at the same time,
> which causes this build error:
>
> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(vif->queues);
> ^
> cc1: some warnings being treated as errors
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] net: xen-netback: include linux/vmalloc.h again
@ 2014-06-10 8:34 Arnd Bergmann
0 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2014-06-10 8:34 UTC (permalink / raw)
To: netdev; +Cc: Andrew J. Bennieston, Josh Boyer, Wei Liu, David Miller, xen-devel
commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
queue struct") added a use of vzalloc/vfree to interface.c, but
removed the #include <linux/vmalloc.h> statement at the same time,
which causes this build error:
drivers/net/xen-netback/interface.c: In function 'xenvif_free':
drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
vfree(vif->queues);
^
cc1: some warnings being treated as errors
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
---
I haven't found another report of this bug, but if someone else already
submitted a fix, please ignore this one.
Incidentally, it's the same bug that Josh fixed before in January,
but it has reappeared now, see https://lkml.org/lkml/2014/1/5/36
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 6929bcb..852da34 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -34,6 +34,7 @@
#include <linux/ethtool.h>
#include <linux/rtnetlink.h>
#include <linux/if_vlan.h>
+#include <linux/vmalloc.h>
#include <xen/events.h>
#include <asm/xen/hypercall.h>
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-06-12 9:07 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-10 8:34 [PATCH] net: xen-netback: include linux/vmalloc.h again Arnd Bergmann
2014-06-10 8:44 ` Wei Liu
2014-06-10 8:52 ` [Xen-devel] " Ian Campbell
2014-06-10 8:52 ` Ian Campbell
2014-06-11 22:19 ` David Miller
2014-06-12 9:07 ` Wei Liu
2014-06-12 9:07 ` Wei Liu
2014-06-11 22:19 ` David Miller
2014-06-10 8:44 ` Wei Liu
2014-06-11 22:19 ` David Miller
2014-06-11 22:19 ` David Miller
2014-06-10 8:34 Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.