[PATCH] net: xen-netback: include linux/vmalloc.h again

[PATCH] net: xen-netback: include linux/vmalloc.h again

[Arnd Bergmann]

commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
queue struct") added a use of vzalloc/vfree to interface.c, but
removed the #include <linux/vmalloc.h> statement at the same time,
which causes this build error:

drivers/net/xen-netback/interface.c: In function 'xenvif_free':
drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
  vfree(vif->queues);
  ^
cc1: some warnings being treated as errors

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
---

I haven't found another report of this bug, but if someone else already
submitted a fix, please ignore this one.

Incidentally, it's the same bug that Josh fixed before in January,
but it has reappeared now, see https://lkml.org/lkml/2014/1/5/36

diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 6929bcb..852da34 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -34,6 +34,7 @@
 #include <linux/ethtool.h>
 #include <linux/rtnetlink.h>
 #include <linux/if_vlan.h>
+#include <linux/vmalloc.h>
 
 #include <xen/events.h>
 #include <asm/xen/hypercall.h>

Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

[Wei Liu]

On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> queue struct") added a use of vzalloc/vfree to interface.c, but
> removed the #include <linux/vmalloc.h> statement at the same time,
> which causes this build error:
> 
> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>   vfree(vif->queues);
>   ^
> cc1: some warnings being treated as errors
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

This didn't happen to me when I built it on x86 though. Just curious,
did you build it on othet platform, say, ARM?

Wei.

Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

[Wei Liu]

On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> queue struct") added a use of vzalloc/vfree to interface.c, but
> removed the #include <linux/vmalloc.h> statement at the same time,
> which causes this build error:
> 
> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>   vfree(vif->queues);
>   ^
> cc1: some warnings being treated as errors
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

This didn't happen to me when I built it on x86 though. Just curious,
did you build it on othet platform, say, ARM?

Wei.

Re: [Xen-devel] [PATCH] net: xen-netback: include linux/vmalloc.h again

[Ian Campbell]

On Tue, 2014-06-10 at 09:44 +0100, Wei Liu wrote:
> On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> > commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> > queue struct") added a use of vzalloc/vfree to interface.c, but
> > removed the #include <linux/vmalloc.h> statement at the same time,
> > which causes this build error:
> > 
> > drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> > drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> >   vfree(vif->queues);
> >   ^
> > cc1: some warnings being treated as errors
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> This didn't happen to me when I built it on x86 though. Just curious,
> did you build it on othet platform, say, ARM?

Arnd comaintains the arm-soc tree, so that's a pretty good bet ;-)

Ian.

Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

[Ian Campbell]

On Tue, 2014-06-10 at 09:44 +0100, Wei Liu wrote:
> On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> > commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> > queue struct") added a use of vzalloc/vfree to interface.c, but
> > removed the #include <linux/vmalloc.h> statement at the same time,
> > which causes this build error:
> > 
> > drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> > drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> >   vfree(vif->queues);
> >   ^
> > cc1: some warnings being treated as errors
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> This didn't happen to me when I built it on x86 though. Just curious,
> did you build it on othet platform, say, ARM?

Arnd comaintains the arm-soc tree, so that's a pretty good bet ;-)

Ian.

Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

[David Miller]

From: Wei Liu <wei.liu2@citrix.com>
Date: Tue, 10 Jun 2014 09:44:54 +0100

> On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
>> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
>> queue struct") added a use of vzalloc/vfree to interface.c, but
>> removed the #include <linux/vmalloc.h> statement at the same time,
>> which causes this build error:
>> 
>> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
>> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>>   vfree(vif->queues);
>>   ^
>> cc1: some warnings being treated as errors
>> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Wei Liu <wei.liu2@citrix.com>
>> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> This didn't happen to me when I built it on x86 though. Just curious,
> did you build it on othet platform, say, ARM?

ARM and PowerPC will both show this problem.

The issue is that x86 get's linux/vmalloc.h implicitly through one of
it's asm/ headers, thus you'll never hit the issue if you only build
test on that arch.

Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

[David Miller]

From: Wei Liu <wei.liu2@citrix.com>
Date: Tue, 10 Jun 2014 09:44:54 +0100

> On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
>> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
>> queue struct") added a use of vzalloc/vfree to interface.c, but
>> removed the #include <linux/vmalloc.h> statement at the same time,
>> which causes this build error:
>> 
>> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
>> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>>   vfree(vif->queues);
>>   ^
>> cc1: some warnings being treated as errors
>> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Wei Liu <wei.liu2@citrix.com>
>> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> This didn't happen to me when I built it on x86 though. Just curious,
> did you build it on othet platform, say, ARM?

ARM and PowerPC will both show this problem.

The issue is that x86 get's linux/vmalloc.h implicitly through one of
it's asm/ headers, thus you'll never hit the issue if you only build
test on that arch.

Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

[David Miller]

From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 10 Jun 2014 10:34:36 +0200

> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> queue struct") added a use of vzalloc/vfree to interface.c, but
> removed the #include <linux/vmalloc.h> statement at the same time,
> which causes this build error:
> 
> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>   vfree(vif->queues);
>   ^
> cc1: some warnings being treated as errors
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to net-next, thanks.

Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

[David Miller]

From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 10 Jun 2014 10:34:36 +0200

> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> queue struct") added a use of vzalloc/vfree to interface.c, but
> removed the #include <linux/vmalloc.h> statement at the same time,
> which causes this build error:
> 
> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>   vfree(vif->queues);
>   ^
> cc1: some warnings being treated as errors
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to net-next, thanks.

Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

[Wei Liu]

On Wed, Jun 11, 2014 at 03:19:01PM -0700, David Miller wrote:
> From: Wei Liu <wei.liu2@citrix.com>
> Date: Tue, 10 Jun 2014 09:44:54 +0100
> 
> > On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> >> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> >> queue struct") added a use of vzalloc/vfree to interface.c, but
> >> removed the #include <linux/vmalloc.h> statement at the same time,
> >> which causes this build error:
> >> 
> >> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> >> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> >>   vfree(vif->queues);
> >>   ^
> >> cc1: some warnings being treated as errors
> >> 
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Cc: Wei Liu <wei.liu2@citrix.com>
> >> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
> > 
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> > 
> > This didn't happen to me when I built it on x86 though. Just curious,
> > did you build it on othet platform, say, ARM?
> 
> ARM and PowerPC will both show this problem.
> 
> The issue is that x86 get's linux/vmalloc.h implicitly through one of
> it's asm/ headers, thus you'll never hit the issue if you only build
> test on that arch.

Good to know. I shall keep an eye on this in the future.

Thanks
Wei.

Re: [PATCH] net: xen-netback: include linux/vmalloc.h again

[Wei Liu]

On Wed, Jun 11, 2014 at 03:19:01PM -0700, David Miller wrote:
> From: Wei Liu <wei.liu2@citrix.com>
> Date: Tue, 10 Jun 2014 09:44:54 +0100
> 
> > On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> >> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> >> queue struct") added a use of vzalloc/vfree to interface.c, but
> >> removed the #include <linux/vmalloc.h> statement at the same time,
> >> which causes this build error:
> >> 
> >> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> >> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> >>   vfree(vif->queues);
> >>   ^
> >> cc1: some warnings being treated as errors
> >> 
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Cc: Wei Liu <wei.liu2@citrix.com>
> >> Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
> > 
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> > 
> > This didn't happen to me when I built it on x86 though. Just curious,
> > did you build it on othet platform, say, ARM?
> 
> ARM and PowerPC will both show this problem.
> 
> The issue is that x86 get's linux/vmalloc.h implicitly through one of
> it's asm/ headers, thus you'll never hit the issue if you only build
> test on that arch.

Good to know. I shall keep an eye on this in the future.

Thanks
Wei.

[PATCH] net: xen-netback: include linux/vmalloc.h again

[Arnd Bergmann]

commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
queue struct") added a use of vzalloc/vfree to interface.c, but
removed the #include <linux/vmalloc.h> statement at the same time,
which causes this build error:

drivers/net/xen-netback/interface.c: In function 'xenvif_free':
drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
  vfree(vif->queues);
  ^
cc1: some warnings being treated as errors

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
---

I haven't found another report of this bug, but if someone else already
submitted a fix, please ignore this one.

Incidentally, it's the same bug that Josh fixed before in January,
but it has reappeared now, see https://lkml.org/lkml/2014/1/5/36

diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 6929bcb..852da34 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -34,6 +34,7 @@
 #include <linux/ethtool.h>
 #include <linux/rtnetlink.h>
 #include <linux/if_vlan.h>
+#include <linux/vmalloc.h>
 
 #include <xen/events.h>
 #include <asm/xen/hypercall.h>