All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Laurentiu Palcu <laurentiu.palcu@intel.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>, Johan Havold <johan@kernel.org>,
	Octavian Purdila <octavian.purdila@intel.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] spi: add support for DLN-2 USB-SPI adapter
Date: Fri, 28 Nov 2014 18:35:07 +0000	[thread overview]
Message-ID: <20141128183507.GZ7712@sirena.org.uk> (raw)
In-Reply-To: <20141128181326.GA23784@lpalcu-laptop>

[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]

On Fri, Nov 28, 2014 at 08:13:26PM +0200, Laurentiu Palcu wrote:
> On Fri, Nov 28, 2014 at 04:01:56PM +0000, Mark Brown wrote:

> > No, please don't - you're missing the point.  The point is that now Lee
> > has applied the other patch you're not sending two patches any more,
> > you're sending a single patch.  This isn't patch 1/2, it's just a single
> > patch by itself now.

> All I did was send new revisions of the 1/2 patch using the
> --in-reply-to option of git-send-email, with the message-id of the
> original version. I used to do this for other projects I contributed to,
> so I didn't have to re-send the entire series for just one patch that

The whole point is that you're not sending a series, you're just sending
one patch.

> needs to be changed. Mail clients, at least the ones I use (mutt,
> evolution), order the mails nicely and you have all the history in one
> thread. So, one can see the cover letter of the series and the other
> original patches in the series, together with the new revisions of the
> changed patch. Of course, if more patches needed change, I would re-send a new
> series.

Definitely do *not* do this, it makes the thread very hard to follow if
there are multiple versions - you end up with multiple versions of
various patches scattered through the thread and it can be very unclear
which versions are current.  If there's a lot of traffic things get
hidden way back when the original submission happened.

Fortunately I've deleted old parts of the thread so I didn't notice you
were doing this.

> So, Mark, can you please instruct me (a link to a page explaining the
> workflow would be fine too) what is the exact workflow you are/were
> expecting?

The patch submission workflow is covered in SubmittingPatches.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Laurentiu Palcu
	<laurentiu.palcu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Johan Havold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Octavian Purdila
	<octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v7 1/2] spi: add support for DLN-2 USB-SPI adapter
Date: Fri, 28 Nov 2014 18:35:07 +0000	[thread overview]
Message-ID: <20141128183507.GZ7712@sirena.org.uk> (raw)
In-Reply-To: <20141128181326.GA23784@lpalcu-laptop>

[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]

On Fri, Nov 28, 2014 at 08:13:26PM +0200, Laurentiu Palcu wrote:
> On Fri, Nov 28, 2014 at 04:01:56PM +0000, Mark Brown wrote:

> > No, please don't - you're missing the point.  The point is that now Lee
> > has applied the other patch you're not sending two patches any more,
> > you're sending a single patch.  This isn't patch 1/2, it's just a single
> > patch by itself now.

> All I did was send new revisions of the 1/2 patch using the
> --in-reply-to option of git-send-email, with the message-id of the
> original version. I used to do this for other projects I contributed to,
> so I didn't have to re-send the entire series for just one patch that

The whole point is that you're not sending a series, you're just sending
one patch.

> needs to be changed. Mail clients, at least the ones I use (mutt,
> evolution), order the mails nicely and you have all the history in one
> thread. So, one can see the cover letter of the series and the other
> original patches in the series, together with the new revisions of the
> changed patch. Of course, if more patches needed change, I would re-send a new
> series.

Definitely do *not* do this, it makes the thread very hard to follow if
there are multiple versions - you end up with multiple versions of
various patches scattered through the thread and it can be very unclear
which versions are current.  If there's a lot of traffic things get
hidden way back when the original submission happened.

Fortunately I've deleted old parts of the thread so I didn't notice you
were doing this.

> So, Mark, can you please instruct me (a link to a page explaining the
> workflow would be fine too) what is the exact workflow you are/were
> expecting?

The patch submission workflow is covered in SubmittingPatches.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2014-11-28 18:35 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 12:09 [PATCH v3 0/2] Add SPI support for Diolan DLN2 Laurentiu Palcu
2014-11-18 12:09 ` Laurentiu Palcu
2014-11-18 12:09 ` [PATCH v3 1/2] spi: add support for DLN-2 USB-SPI adapter Laurentiu Palcu
2014-11-18 17:06   ` Johan Hovold
2014-11-18 17:06     ` Johan Hovold
2014-11-19  9:53     ` Laurentiu Palcu
2014-11-19 10:09       ` Johan Hovold
2014-11-19 10:09         ` Johan Hovold
2014-11-19 10:47   ` [PATCH v4 " Laurentiu Palcu
2014-11-19 10:47     ` Laurentiu Palcu
2014-11-19 12:21     ` Johan Hovold
2014-11-19 12:21       ` Johan Hovold
2014-11-19 13:07     ` [PATCH v5 " Laurentiu Palcu
2014-11-19 13:07       ` Laurentiu Palcu
2014-11-19 13:51       ` Johan Hovold
2014-11-19 13:51         ` Johan Hovold
2014-11-19 14:12         ` Laurentiu Palcu
2014-11-19 14:12           ` Laurentiu Palcu
2014-11-26 10:09   ` [PATCH v6 " Laurentiu Palcu
2014-11-26 18:25     ` Mark Brown
2014-11-26 18:25       ` Mark Brown
2014-11-27 10:30       ` Laurentiu Palcu
2014-11-27 10:30         ` Laurentiu Palcu
2014-11-28 13:09   ` [PATCH v7 " Laurentiu Palcu
2014-11-28 14:10     ` Mark Brown
2014-11-28 14:57       ` Laurentiu Palcu
2014-11-28 14:57         ` Laurentiu Palcu
2014-11-28 15:14         ` Mark Brown
2014-11-28 15:14           ` Mark Brown
2014-11-28 15:31           ` Laurentiu Palcu
2014-11-28 15:31             ` Laurentiu Palcu
2014-11-28 16:01             ` Mark Brown
2014-11-28 18:13               ` Laurentiu Palcu
2014-11-28 18:13                 ` Laurentiu Palcu
2014-11-28 18:35                 ` Mark Brown [this message]
2014-11-28 18:35                   ` Mark Brown
2014-11-28 19:27                   ` Laurentiu Palcu
2014-11-28 19:27                     ` Laurentiu Palcu
2014-11-28 19:46                     ` Mark Brown
2014-11-28 19:46                       ` Mark Brown
2014-11-28 19:21                 ` Octavian Purdila
2014-11-28 19:21                   ` Octavian Purdila
2014-12-05 18:34     ` Mark Brown
2014-12-05 18:34       ` Mark Brown
2014-11-18 12:09 ` [PATCH v3 2/2] mfd: dln2: add support for USB-SPI module Laurentiu Palcu
2014-11-18 12:09   ` Laurentiu Palcu
2014-11-19 16:29   ` Lee Jones
2014-11-19 16:29     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141128183507.GZ7712@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=johan@kernel.org \
    --cc=laurentiu.palcu@intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=octavian.purdila@intel.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.