From: Christoffer Dall <christoffer.dall@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com,
peter.maydell@linaro.org, agraf@suse.de, pbonzini@redhat.com,
zhichao.huang@linaro.org, jan.kiszka@siemens.com,
dahi@linux.vnet.ibm.com, r65777@freescale.com, bp@suse.de,
Gleb Natapov <gleb@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 09/10] KVM: arm64: trap nested debug register access
Date: Tue, 14 Apr 2015 12:27:03 +0200 [thread overview]
Message-ID: <20150414102703.GW6186@cbox> (raw)
In-Reply-To: <877ftglaqu.fsf@linaro.org>
On Mon, Apr 13, 2015 at 08:59:21AM +0100, Alex Bennée wrote:
[...]
> >> + /* MDSCR_EL1 */
> >> + if (r->reg == MDSCR_EL1) {
> >> + if (p->is_write)
> >> + vcpu_debug_saved_reg(vcpu, mdscr_el1) =
> >> + *vcpu_reg(vcpu, p->Rt);
> >> + else
> >> + *vcpu_reg(vcpu, p->Rt) =
> >> + vcpu_debug_saved_reg(vcpu, mdscr_el1);
> >
> > With this lines wrapping, {}'s might be nice.
>
> My natural inclination is to wrap in {}'s but I know the kernel is a fan
> of the single-statement if forms.
>
It's accepted to use braces for multi-line single statements - and I
prefer it too :)
-Christoffer
WARNING: multiple messages have this Message-ID (diff)
From: Christoffer Dall <christoffer.dall@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
kvm@vger.kernel.org, marc.zyngier@arm.com,
jan.kiszka@siemens.com, Will Deacon <will.deacon@arm.com>,
open list <linux-kernel@vger.kernel.org>,
dahi@linux.vnet.ibm.com, zhichao.huang@linaro.org,
r65777@freescale.com, pbonzini@redhat.com, bp@suse.de,
Gleb Natapov <gleb@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 09/10] KVM: arm64: trap nested debug register access
Date: Tue, 14 Apr 2015 12:27:03 +0200 [thread overview]
Message-ID: <20150414102703.GW6186@cbox> (raw)
In-Reply-To: <877ftglaqu.fsf@linaro.org>
On Mon, Apr 13, 2015 at 08:59:21AM +0100, Alex Bennée wrote:
[...]
> >> + /* MDSCR_EL1 */
> >> + if (r->reg == MDSCR_EL1) {
> >> + if (p->is_write)
> >> + vcpu_debug_saved_reg(vcpu, mdscr_el1) =
> >> + *vcpu_reg(vcpu, p->Rt);
> >> + else
> >> + *vcpu_reg(vcpu, p->Rt) =
> >> + vcpu_debug_saved_reg(vcpu, mdscr_el1);
> >
> > With this lines wrapping, {}'s might be nice.
>
> My natural inclination is to wrap in {}'s but I know the kernel is a fan
> of the single-statement if forms.
>
It's accepted to use braces for multi-line single statements - and I
prefer it too :)
-Christoffer
WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 09/10] KVM: arm64: trap nested debug register access
Date: Tue, 14 Apr 2015 12:27:03 +0200 [thread overview]
Message-ID: <20150414102703.GW6186@cbox> (raw)
In-Reply-To: <877ftglaqu.fsf@linaro.org>
On Mon, Apr 13, 2015 at 08:59:21AM +0100, Alex Benn?e wrote:
[...]
> >> + /* MDSCR_EL1 */
> >> + if (r->reg == MDSCR_EL1) {
> >> + if (p->is_write)
> >> + vcpu_debug_saved_reg(vcpu, mdscr_el1) =
> >> + *vcpu_reg(vcpu, p->Rt);
> >> + else
> >> + *vcpu_reg(vcpu, p->Rt) =
> >> + vcpu_debug_saved_reg(vcpu, mdscr_el1);
> >
> > With this lines wrapping, {}'s might be nice.
>
> My natural inclination is to wrap in {}'s but I know the kernel is a fan
> of the single-statement if forms.
>
It's accepted to use braces for multi-line single statements - and I
prefer it too :)
-Christoffer
next prev parent reply other threads:[~2015-04-14 10:27 UTC|newest]
Thread overview: 199+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 15:07 [PATCH v2 00/10] KVM Guest Debug support for arm64 Alex Bennée
2015-03-31 15:07 ` Alex Bennée
2015-03-31 15:07 ` [PATCH v2 01/10] KVM: add commentary for kvm_debug_exit_arch struct Alex Bennée
2015-03-31 15:07 ` Alex Bennée
2015-03-31 15:07 ` Alex Bennée
2015-04-01 15:38 ` David Hildenbrand
2015-04-01 15:38 ` David Hildenbrand
2015-04-01 15:38 ` David Hildenbrand
2015-04-01 15:38 ` David Hildenbrand
2015-04-10 12:58 ` Andrew Jones
2015-04-10 12:58 ` Andrew Jones
2015-04-13 10:57 ` Christoffer Dall
2015-04-13 10:57 ` Christoffer Dall
2015-04-13 10:57 ` Christoffer Dall
2015-03-31 15:08 ` [PATCH v2 02/10] KVM: define common __KVM_GUESTDBG_USE_SW/HW_BP values Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-04-10 12:59 ` Andrew Jones
2015-04-10 12:59 ` Andrew Jones
2015-04-10 12:59 ` Andrew Jones
2015-04-10 12:59 ` Andrew Jones
2015-04-13 11:55 ` Christoffer Dall
2015-04-13 11:55 ` Christoffer Dall
2015-04-13 11:55 ` Christoffer Dall
2015-04-13 11:55 ` Christoffer Dall
2015-04-13 14:51 ` Alex Bennée
2015-04-13 14:51 ` Alex Bennée
2015-04-13 14:51 ` Alex Bennée
2015-04-13 14:51 ` Alex Bennée
2015-04-13 15:07 ` Andrew Jones
2015-04-13 15:07 ` Andrew Jones
2015-04-13 15:07 ` Andrew Jones
2015-04-13 15:07 ` Andrew Jones
2015-04-14 8:24 ` Christoffer Dall
2015-04-14 8:24 ` Christoffer Dall
2015-04-14 8:24 ` Christoffer Dall
2015-04-14 8:24 ` Christoffer Dall
2015-04-14 8:24 ` Christoffer Dall
2015-03-31 15:08 ` [PATCH v2 03/10] KVM: arm: guest debug, define API headers Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-04-01 15:46 ` David Hildenbrand
2015-04-01 15:46 ` David Hildenbrand
2015-04-01 15:46 ` David Hildenbrand
2015-04-01 16:01 ` Alex Bennée
2015-04-01 16:01 ` Alex Bennée
2015-04-01 16:05 ` David Hildenbrand
2015-04-01 16:05 ` David Hildenbrand
2015-04-01 16:09 ` Peter Maydell
2015-04-01 16:09 ` Peter Maydell
2015-04-10 13:05 ` Andrew Jones
2015-04-10 13:05 ` Andrew Jones
2015-04-10 13:05 ` Andrew Jones
2015-04-13 12:08 ` Christoffer Dall
2015-04-13 12:08 ` Christoffer Dall
2015-04-23 9:54 ` Alex Bennée
2015-04-23 9:54 ` Alex Bennée
2015-04-23 9:54 ` Alex Bennée
2015-03-31 15:08 ` [PATCH v2 04/10] KVM: arm: guest debug, add stub KVM_SET_GUEST_DEBUG ioctl Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-04-01 15:55 ` David Hildenbrand
2015-04-01 15:55 ` David Hildenbrand
2015-04-01 15:55 ` David Hildenbrand
2015-04-09 12:28 ` Andrew Jones
2015-04-09 12:28 ` Andrew Jones
2015-04-09 12:28 ` Andrew Jones
2015-04-09 14:19 ` Alex Bennée
2015-04-09 14:19 ` Alex Bennée
2015-04-09 14:19 ` Alex Bennée
2015-04-13 12:12 ` Christoffer Dall
2015-04-13 12:12 ` Christoffer Dall
2015-04-13 12:12 ` Christoffer Dall
2015-04-14 6:31 ` David Hildenbrand
2015-04-14 6:31 ` David Hildenbrand
2015-04-14 6:31 ` David Hildenbrand
2015-04-14 8:03 ` Alex Bennée
2015-04-14 8:03 ` Alex Bennée
2015-04-14 8:03 ` Alex Bennée
2015-03-31 15:08 ` [PATCH v2 05/10] KVM: arm: introduce kvm_arch_setup/clear_debug() Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-04-01 16:28 ` David Hildenbrand
2015-04-01 16:28 ` David Hildenbrand
2015-04-01 16:28 ` David Hildenbrand
2015-04-09 12:56 ` Andrew Jones
2015-04-09 12:56 ` Andrew Jones
2015-04-09 12:56 ` Andrew Jones
2015-04-09 14:18 ` Alex Bennée
2015-04-09 14:18 ` Alex Bennée
2015-04-09 12:55 ` Andrew Jones
2015-04-09 12:55 ` Andrew Jones
2015-04-09 12:55 ` Andrew Jones
2015-04-13 14:36 ` Christoffer Dall
2015-04-13 14:36 ` Christoffer Dall
2015-04-13 14:48 ` Christoffer Dall
2015-04-13 14:48 ` Christoffer Dall
2015-04-13 14:48 ` Christoffer Dall
2015-04-13 15:29 ` Alex Bennée
2015-04-13 15:29 ` Alex Bennée
2015-04-13 15:29 ` Alex Bennée
2015-03-31 15:08 ` [PATCH v2 06/10] KVM: arm64: guest debug, add SW break point support Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-04-02 12:52 ` David Hildenbrand
2015-04-02 12:52 ` David Hildenbrand
2015-04-02 12:52 ` David Hildenbrand
2015-04-02 14:06 ` Alex Bennée
2015-04-02 14:06 ` Alex Bennée
2015-04-02 14:06 ` Alex Bennée
2015-04-10 13:09 ` Andrew Jones
2015-04-10 13:09 ` Andrew Jones
2015-04-10 13:09 ` Andrew Jones
2015-04-14 8:25 ` Christoffer Dall
2015-04-14 8:25 ` Christoffer Dall
2015-04-23 14:26 ` Alex Bennée
2015-04-23 14:26 ` Alex Bennée
2015-04-23 14:26 ` Alex Bennée
2015-04-27 20:04 ` Christoffer Dall
2015-04-27 20:04 ` Christoffer Dall
2015-04-27 21:57 ` Peter Maydell
2015-04-27 21:57 ` Peter Maydell
2015-04-28 8:42 ` Alex Bennée
2015-04-28 8:42 ` Alex Bennée
2015-04-28 8:42 ` Alex Bennée
2015-04-28 9:34 ` Peter Maydell
2015-04-28 9:34 ` Peter Maydell
2015-04-28 12:56 ` Christoffer Dall
2015-04-28 12:56 ` Christoffer Dall
2015-04-28 14:37 ` Alex Bennée
2015-04-28 14:37 ` Alex Bennée
2015-04-28 14:37 ` Alex Bennée
2015-04-29 8:10 ` Christoffer Dall
2015-04-29 8:10 ` Christoffer Dall
2015-04-29 9:18 ` Alex Bennée
2015-04-29 9:18 ` Alex Bennée
2015-04-29 9:18 ` Alex Bennée
2015-04-29 10:38 ` Christoffer Dall
2015-04-29 10:38 ` Christoffer Dall
2015-04-29 15:08 ` Alex Bennée
2015-04-29 15:08 ` Alex Bennée
2015-04-29 15:08 ` Alex Bennée
2015-04-29 19:20 ` Christoffer Dall
2015-04-29 19:20 ` Christoffer Dall
2015-04-21 14:42 ` Zhichao Huang
2015-04-22 9:46 ` Alex Bennée
2015-04-22 9:46 ` Alex Bennée
2015-04-22 9:46 ` Alex Bennée
2015-03-31 15:08 ` [PATCH v2 07/10] KVM: arm64: guest debug, add support for single-step Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-04-09 13:24 ` Andrew Jones
2015-04-09 13:24 ` Andrew Jones
2015-04-09 14:16 ` Alex Bennée
2015-04-09 14:16 ` Alex Bennée
2015-04-09 14:16 ` Alex Bennée
2015-04-14 8:27 ` Christoffer Dall
2015-04-14 8:27 ` Christoffer Dall
2015-04-14 8:27 ` Christoffer Dall
2015-03-31 15:08 ` [PATCH v2 08/10] KVM: arm64: guest debug, HW assisted debug support Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-04-10 12:25 ` Andrew Jones
2015-04-10 12:25 ` Andrew Jones
2015-04-10 12:25 ` Andrew Jones
2015-04-13 8:00 ` Alex Bennée
2015-04-13 8:00 ` Alex Bennée
2015-04-13 8:00 ` Alex Bennée
2015-04-14 10:23 ` Christoffer Dall
2015-04-14 10:23 ` Christoffer Dall
2015-04-14 10:17 ` Christoffer Dall
2015-04-14 10:17 ` Christoffer Dall
2015-04-14 10:17 ` Christoffer Dall
2015-03-31 15:08 ` [PATCH v2 09/10] KVM: arm64: trap nested debug register access Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-04-10 12:38 ` Andrew Jones
2015-04-10 12:38 ` Andrew Jones
2015-04-10 12:38 ` Andrew Jones
2015-04-13 7:59 ` Alex Bennée
2015-04-13 7:59 ` Alex Bennée
2015-04-13 7:59 ` Alex Bennée
2015-04-14 10:27 ` Christoffer Dall [this message]
2015-04-14 10:27 ` Christoffer Dall
2015-04-14 10:27 ` Christoffer Dall
2015-04-14 10:30 ` Christoffer Dall
2015-04-14 10:30 ` Christoffer Dall
2015-04-14 10:30 ` Christoffer Dall
2015-03-31 15:08 ` [PATCH v2 10/10] KVM: arm64: add trace points for guest_debug debug Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-03-31 15:08 ` Alex Bennée
2015-04-10 12:54 ` Andrew Jones
2015-04-10 12:54 ` Andrew Jones
2015-04-13 7:57 ` Alex Bennée
2015-04-13 7:57 ` Alex Bennée
2015-04-14 10:32 ` Christoffer Dall
2015-04-14 10:32 ` Christoffer Dall
2015-04-14 10:32 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414102703.GW6186@cbox \
--to=christoffer.dall@linaro.org \
--cc=agraf@suse.de \
--cc=alex.bennee@linaro.org \
--cc=bp@suse.de \
--cc=catalin.marinas@arm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=drjones@redhat.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=r65777@freescale.com \
--cc=will.deacon@arm.com \
--cc=zhichao.huang@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.