From: "Luis R. Rodriguez" <mcgrof@kernel.org> To: Linus Torvalds <torvalds@linux-foundation.org>, "Herbert, Marc" <marc.herbert@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Bjorn Andersson <bjorn.andersson@linaro.org> Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>, Rob Landley <rob@landley.net>, Mimi Zohar <zohar@linux.vnet.ibm.com>, Felix Fietkau <nbd@nbd.name>, David Woodhouse <dwmw2@infradead.org>, Roman Pen <r.peniaev@gmail.com>, Ming Lei <ming.lei@canonical.com>, Andrew Morton <akpm@linux-foundation.org>, Michal Marek <mmarek@suse.com>, Greg KH <gregkh@linuxfoundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Vikram Mulukutla <markivx@codeaurora.org>, Stephen Boyd <stephen.boyd@linaro.org>, Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>, Johannes Berg <johannes@sipsolutions.net>, Christian Lamparter <chunkeey@googlemail.com>, Hauke Mehrtens <hauke@hauke-m.de>, Josh Boyer <jwboyer@fedoraproject.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Jiri Slaby <jslaby@suse.com>, Andy Lutomirski <luto@amacapital.net>, Wu Fengguang <fengguang.wu@intel.com>, Richard Purdie <rpurdie@rpsys.net>, Jeff Mahoney <jeffm@suse.com>, Jacek Anaszewski <j.anaszewski@samsung.com>, Abhay_Salunke@dell.com, Julia Lawall <Julia.Lawall@lip6.fr>, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, Tom Gundersen <teg@jklm.no>, Kay Sievers <kay@vrfy.org>, David Howells <dhowells@redhat.com>, Alessandro Rubini <rubini@gnudd.com>, Kevin Cernekee <cernekee@gmail.com>, Kees Cook <keescook@chromium.org>, Jonathan Corbet <corbet@lwn.net>, Thierry Martinez <martinez@nsup.org>, linux-serial <linux-serial@vger.kernel.org>, "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, Josh Triplett <josh@joshtriplett.org> Subject: Re: [RFC] fs: add userspace critical mounts event support Date: Wed, 5 Oct 2016 21:46:33 +0200 [thread overview] Message-ID: <20161005194633.GE3296@wotan.suse.de> (raw) In-Reply-To: <CA+55aFzrRekSrEczdtGb3RuOeJttJ7i7dQJxiTOXz8V+kr=hdA@mail.gmail.com> On Wed, Oct 05, 2016 at 11:08:06AM -0700, Linus Torvalds wrote: > On Wed, Oct 5, 2016 at 11:00 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote: > > On Tue, Sep 13, 2016 at 09:38:17PM -0500, Rob Landley wrote: > > > >> I did some shuffling around of those code to make initmpfs work, does > >> anybody know why initramfs extraction _before_ we initialize drivers > >> would be a bad thing? > > > > No, but it seems sensible to me, if its done before do_initcalls() > > that should resolve the race for initramfs users > > initramfs should already be set up before drivers are. Actually you are right, the issue would only be for old initrd, for initramfs we populate that via rootfs_initcall(populate_rootfs), so as long as drivers in question use an init level beyond rootfs's we're good there. > Exactly what is it that has trouble right now? It would seem then that the only current stated race possible should then be non-initramfs users. One example if very large firmware for remote-proc, whereby an initramfs is just not practical or desirable. > The gating issue for initramfs is that technically the filesystem > setup needs to be done, which means that it currently ends up being > populated _fairly_ late in the initcall series, but certainly before > drivers. But since initramfs really only needs very limited filesystem > functionality, I assume Rob had few problems with just moving it > earlier. > > Still, what kind of ordering issues did people have? What is it that > needs to load files even before driver init? Some crazy subsystem? No, I think this is just about non-initramfs users now, if we disregard old initrd users. Bjorn, Marc, correct me if I'm wrong, as I think its so far you both who have seemed to run into race issues and have then ended up trying to look for hacks to address this race or considered using the usermode helper (which we're trying to minimize users for). Daniel seems to note a lot of video drivers use firmware on probe as well so there's a potential issue for those users if they don't use initramfs. Luis
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <mcgrof@kernel.org> To: Linus Torvalds <torvalds@linux-foundation.org>, "Herbert, Marc" <marc.herbert@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Bjorn Andersson <bjorn.andersson@linaro.org> Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>, Rob Landley <rob@landley.net>, Mimi Zohar <zohar@linux.vnet.ibm.com>, Felix Fietkau <nbd@nbd.name>, David Woodhouse <dwmw2@infradead.org>, Roman Pen <r.peniaev@gmail.com>, Ming Lei <ming.lei@canonical.com>, Andrew Morton <akpm@linux-foundation.org>, Michal Marek <mmarek@suse.com>, Greg KH <gregkh@linuxfoundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Vikram Mulukutla <markivx@codeaurora.org>, Stephen Boyd <stephen.boyd@linaro.org>, Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>, Johannes Berg <johannes@sipsolutions.net>, Christian Lamparter <chunkeey@googlemail.com>, Hauke Mehrtens <hauke@hauke-m.de>, Josh Boyer <jwboyer@fedoraproject.org>, Dmitry Torokhov <dmitr> Subject: Re: [RFC] fs: add userspace critical mounts event support Date: Wed, 5 Oct 2016 21:46:33 +0200 [thread overview] Message-ID: <20161005194633.GE3296@wotan.suse.de> (raw) In-Reply-To: <CA+55aFzrRekSrEczdtGb3RuOeJttJ7i7dQJxiTOXz8V+kr=hdA@mail.gmail.com> On Wed, Oct 05, 2016 at 11:08:06AM -0700, Linus Torvalds wrote: > On Wed, Oct 5, 2016 at 11:00 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote: > > On Tue, Sep 13, 2016 at 09:38:17PM -0500, Rob Landley wrote: > > > >> I did some shuffling around of those code to make initmpfs work, does > >> anybody know why initramfs extraction _before_ we initialize drivers > >> would be a bad thing? > > > > No, but it seems sensible to me, if its done before do_initcalls() > > that should resolve the race for initramfs users > > initramfs should already be set up before drivers are. Actually you are right, the issue would only be for old initrd, for initramfs we populate that via rootfs_initcall(populate_rootfs), so as long as drivers in question use an init level beyond rootfs's we're good there. > Exactly what is it that has trouble right now? It would seem then that the only current stated race possible should then be non-initramfs users. One example if very large firmware for remote-proc, whereby an initramfs is just not practical or desirable. > The gating issue for initramfs is that technically the filesystem > setup needs to be done, which means that it currently ends up being > populated _fairly_ late in the initcall series, but certainly before > drivers. But since initramfs really only needs very limited filesystem > functionality, I assume Rob had few problems with just moving it > earlier. > > Still, what kind of ordering issues did people have? What is it that > needs to load files even before driver init? Some crazy subsystem? No, I think this is just about non-initramfs users now, if we disregard old initrd users. Bjorn, Marc, correct me if I'm wrong, as I think its so far you both who have seemed to run into race issues and have then ended up trying to look for hacks to address this race or considered using the usermode helper (which we're trying to minimize users for). Daniel seems to note a lot of video drivers use firmware on probe as well so there's a potential issue for those users if they don't use initramfs. Luis
next prev parent reply other threads:[~2016-10-05 19:46 UTC|newest] Thread overview: 145+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-16 22:54 [PATCH v2 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez 2016-06-16 22:54 ` [PATCH v2 1/5] MAINTAINERS: extend firmware_class maintainer list Luis R. Rodriguez 2016-06-16 22:54 ` [PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe Luis R. Rodriguez 2016-06-16 22:54 ` [Cocci] " Luis R. Rodriguez 2016-06-16 22:54 ` Luis R. Rodriguez 2016-08-24 6:55 ` Daniel Vetter 2016-08-24 6:55 ` [Cocci] " Daniel Vetter 2016-08-24 6:55 ` Daniel Vetter 2016-08-24 20:39 ` Luis R. Rodriguez 2016-08-24 20:39 ` [Cocci] " Luis R. Rodriguez 2016-08-24 20:39 ` Luis R. Rodriguez 2016-08-25 11:05 ` Daniel Vetter 2016-08-25 11:05 ` [Cocci] " Daniel Vetter 2016-08-25 11:05 ` Daniel Vetter 2016-08-25 19:41 ` Luis R. Rodriguez 2016-08-25 19:41 ` [Cocci] " Luis R. Rodriguez 2016-08-25 19:41 ` Luis R. Rodriguez 2016-08-25 20:10 ` Daniel Vetter 2016-08-25 20:10 ` [Cocci] " Daniel Vetter 2016-08-25 20:10 ` Daniel Vetter 2016-08-25 20:25 ` Luis R. Rodriguez 2016-08-25 20:25 ` [Cocci] " Luis R. Rodriguez 2016-08-25 20:25 ` Luis R. Rodriguez 2016-08-25 20:30 ` Dmitry Torokhov 2016-08-25 20:30 ` [Cocci] " Dmitry Torokhov 2016-08-25 20:30 ` Dmitry Torokhov 2016-09-02 23:59 ` Luis R. Rodriguez 2016-09-02 23:59 ` Luis R. Rodriguez 2016-09-03 0:20 ` [RFC] fs: add userspace critical mounts event support Luis R. Rodriguez 2016-09-03 0:20 ` Luis R. Rodriguez 2016-09-03 4:11 ` Linus Torvalds 2016-09-03 4:11 ` Linus Torvalds 2016-09-03 4:20 ` Dmitry Torokhov 2016-09-03 4:20 ` Dmitry Torokhov 2016-09-03 4:41 ` Linus Torvalds 2016-09-03 4:41 ` Linus Torvalds 2016-09-03 17:49 ` Dmitry Torokhov 2016-09-03 17:49 ` Dmitry Torokhov 2016-09-03 18:01 ` Linus Torvalds 2016-09-03 18:01 ` Linus Torvalds 2016-09-03 18:10 ` Dmitry Torokhov 2016-09-03 18:10 ` Dmitry Torokhov 2016-09-06 21:52 ` Luis R. Rodriguez 2016-09-06 21:52 ` Luis R. Rodriguez 2016-09-06 22:28 ` Bjorn Andersson 2016-09-06 22:28 ` Bjorn Andersson 2016-09-06 23:14 ` Luis R. Rodriguez 2016-09-06 23:14 ` Luis R. Rodriguez 2016-09-24 1:37 ` Herbert, Marc 2016-09-24 1:37 ` Herbert, Marc 2016-09-24 1:37 ` Herbert, Marc 2016-09-24 1:37 ` Herbert, Marc 2016-09-24 17:41 ` Dmitry Torokhov 2016-09-24 17:41 ` Dmitry Torokhov 2016-10-05 0:00 ` Luis R. Rodriguez 2016-10-05 0:12 ` Linus Torvalds 2016-10-05 0:24 ` Luis R. Rodriguez 2016-10-05 0:32 ` Linus Torvalds 2016-10-05 17:38 ` Luis R. Rodriguez 2016-10-05 1:48 ` Josh Triplett 2016-10-05 1:58 ` Linus Torvalds 2016-09-06 17:46 ` Bjorn Andersson 2016-09-06 17:46 ` Bjorn Andersson 2016-09-06 18:32 ` Linus Torvalds 2016-09-06 18:32 ` Linus Torvalds 2016-09-06 21:11 ` Bjorn Andersson 2016-09-06 21:11 ` Bjorn Andersson 2016-09-06 21:50 ` Linus Torvalds 2016-09-06 21:50 ` Linus Torvalds 2016-09-06 23:04 ` Luis R. Rodriguez 2016-09-06 23:04 ` Luis R. Rodriguez 2016-09-24 2:51 ` Herbert, Marc 2016-10-04 23:28 ` Luis R. Rodriguez 2016-09-06 22:32 ` Luis R. Rodriguez 2016-09-06 22:32 ` Luis R. Rodriguez 2016-09-14 2:38 ` Rob Landley 2016-09-14 2:38 ` Rob Landley 2016-10-05 18:00 ` Luis R. Rodriguez 2016-10-05 18:00 ` Luis R. Rodriguez 2016-10-05 18:08 ` Linus Torvalds 2016-10-05 18:08 ` Linus Torvalds 2016-10-05 19:46 ` Luis R. Rodriguez [this message] 2016-10-05 19:46 ` Luis R. Rodriguez 2016-11-08 22:47 ` Luis R. Rodriguez 2016-11-08 22:47 ` Luis R. Rodriguez 2016-11-09 9:13 ` Daniel Wagner 2016-11-09 9:13 ` Daniel Wagner 2016-11-09 11:21 ` Andy Lutomirski 2016-11-09 11:21 ` Andy Lutomirski 2016-11-09 23:53 ` Luis R. Rodriguez 2016-11-09 23:53 ` Luis R. Rodriguez 2016-11-29 21:54 ` Luis R. Rodriguez 2016-11-29 21:54 ` Luis R. Rodriguez 2016-11-09 23:40 ` Luis R. Rodriguez 2016-11-09 23:40 ` Luis R. Rodriguez 2016-11-15 9:28 ` Johannes Berg 2016-11-15 9:28 ` Johannes Berg 2016-11-15 9:28 ` Johannes Berg 2016-11-29 21:10 ` Tom Gundersen 2016-11-29 21:10 ` Tom Gundersen 2016-11-29 21:37 ` Luis R. Rodriguez 2016-11-29 21:37 ` Luis R. Rodriguez 2016-11-30 8:18 ` Johannes Berg 2016-11-30 8:18 ` Johannes Berg 2016-06-16 22:54 ` [PATCH v2 3/5] firmware: update usermode helper docs and add SmPL report Luis R. Rodriguez 2016-06-16 22:54 ` [PATCH v2 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation Luis R. Rodriguez 2016-06-16 22:54 ` [PATCH v2 5/5] firmware: fix fw cache to avoid usermode helper on suspend Luis R. Rodriguez 2016-07-07 0:56 ` [PATCH v2 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez 2016-07-13 21:47 ` Luis R. Rodriguez 2016-07-28 0:41 ` Luis R. Rodriguez 2016-08-03 14:50 ` Luis R. Rodriguez 2016-08-03 15:04 ` Greg KH 2016-08-03 17:06 ` Luis R. Rodriguez 2016-08-03 19:32 ` Greg KH 2016-08-03 19:46 ` Luis R. Rodriguez 2016-07-13 23:52 ` Fengguang Wu 2016-07-14 2:15 ` Luis R. Rodriguez 2016-07-14 2:23 ` Fengguang Wu 2016-07-14 3:08 ` Luis R. Rodriguez 2016-07-14 3:35 ` Fengguang Wu 2016-08-24 0:45 ` [PATCH v3 " mcgrof 2016-08-24 0:45 ` [PATCH v3 1/5] MAINTAINERS: extend firmware_class maintainer list mcgrof 2016-08-24 0:45 ` [PATCH v3 2/5] firmware: annotate thou shalt not request fw on init or probe mcgrof 2016-08-24 0:45 ` [Cocci] " mcgrof at kernel.org 2016-08-24 0:45 ` mcgrof 2016-08-24 8:17 ` Gabriel Paubert 2016-08-24 8:17 ` [Cocci] " Gabriel Paubert 2016-08-24 8:17 ` Gabriel Paubert 2016-09-02 18:26 ` Luis R. Rodriguez 2016-09-02 18:26 ` Luis R. Rodriguez 2016-08-24 0:45 ` [PATCH v3 3/5] firmware: update usermode helper docs and add SmPL report mcgrof 2016-08-24 0:45 ` [PATCH v3 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation mcgrof 2016-08-24 0:45 ` [PATCH v3 5/5] firmware: fix fw cache to avoid usermode helper on suspend mcgrof 2016-08-31 7:03 ` Daniel Wagner 2016-09-02 18:13 ` Luis R. Rodriguez 2016-09-07 0:42 ` [PATCH v4 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez 2016-09-07 0:42 ` [PATCH v4 1/5] MAINTAINERS: extend firmware_class maintainer list Luis R. Rodriguez 2016-09-07 6:43 ` Greg KH 2016-09-08 14:58 ` Luis R. Rodriguez 2016-09-08 15:25 ` Ming Lei 2016-09-07 0:42 ` [PATCH v4 2/5] firmware: annotate thou shalt not request fw on init or probe Luis R. Rodriguez 2016-09-07 0:42 ` Luis R. Rodriguez 2016-09-07 0:42 ` [PATCH v4 3/5] firmware: update usermode helper docs and add SmPL report Luis R. Rodriguez 2016-09-07 0:42 ` [PATCH v4 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation Luis R. Rodriguez 2016-09-07 0:42 ` [PATCH v4 5/5] firmware: fix fw cache to avoid usermode helper on suspend Luis R. Rodriguez
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161005194633.GE3296@wotan.suse.de \ --to=mcgrof@kernel.org \ --cc=Abhay_Salunke@dell.com \ --cc=Gilles.Muller@lip6.fr \ --cc=Julia.Lawall@lip6.fr \ --cc=akpm@linux-foundation.org \ --cc=bjorn.andersson@linaro.org \ --cc=broonie@kernel.org \ --cc=cernekee@gmail.com \ --cc=chunkeey@googlemail.com \ --cc=corbet@lwn.net \ --cc=daniel.vetter@ffwll.ch \ --cc=dhowells@redhat.com \ --cc=dmitry.torokhov@gmail.com \ --cc=dwmw2@infradead.org \ --cc=fengguang.wu@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=hauke@hauke-m.de \ --cc=j.anaszewski@samsung.com \ --cc=jeffm@suse.com \ --cc=johannes@sipsolutions.net \ --cc=josh@joshtriplett.org \ --cc=jslaby@suse.com \ --cc=jwboyer@fedoraproject.org \ --cc=kay@vrfy.org \ --cc=keescook@chromium.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=luto@amacapital.net \ --cc=marc.herbert@intel.com \ --cc=markivx@codeaurora.org \ --cc=martinez@nsup.org \ --cc=ming.lei@canonical.com \ --cc=mmarek@suse.com \ --cc=nbd@nbd.name \ --cc=nicolas.palix@imag.fr \ --cc=r.peniaev@gmail.com \ --cc=rob@landley.net \ --cc=rpurdie@rpsys.net \ --cc=rubini@gnudd.com \ --cc=stephen.boyd@linaro.org \ --cc=teg@jklm.no \ --cc=tiwai@suse.de \ --cc=torvalds@linux-foundation.org \ --cc=zohar@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.