All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	cocci@systeme.lip6.fr,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Christian Lamparter <chunkeey@googlemail.com>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Richard Purdie <rpurdie@rpsys.net>,
	Wu Fengguang <fengguang.wu@intel.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>,
	Michal Marek <mmarek@suse.com>, Hauke Mehrtens <hauke@hauke-m.de>,
	Mark Brown <broonie@kernel.org>, Jiri Slaby <jslaby@suse.com>,
	Ming Lei <ming.lei@canonical.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Kevin Cernekee <cernekee@gmail.com>,
	Jeff Mahoney <jeffm@suse.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>, Felix Fietkau <nbd@nbd.name>,
	David Howells <dhowells@redhat.com>,
	Vikram Mulukutla <markivx@codeaurora.org>,
	Alessandro Rubini <rubini@gnudd.com>, Tom Gundersen <teg@jklm.no>,
	Kees Cook <keescook@chromium.org>, Takashi Iwai <tiwai@suse.de>,
	Gilles.Muller@lip6.fr,
	linux-serial <linux-serial@vger.kernel.org>,
	Roman Pen <r.peniaev@gmail.com>, Kay Sievers <kay@vrfy.org>,
	Stephen Boyd <stephen.boyd@linaro.org>,
	nicolas.palix@imag.fr,
	"Abhay_Salunke@dell.com" <Abhay_Salunke@dell.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thierry Martinez <martinez@nsup.org>,
	Josh Boyer <jwboyer@fedoraproject.org>
Subject: Re: [RFC] fs: add userspace critical mounts event support
Date: Sat, 3 Sep 2016 11:01:58 -0700	[thread overview]
Message-ID: <CA+55aFwLrXRUO9n75Sthu+g73BEjskAgUkguyLwU=JA_PNzdOQ@mail.gmail.com> (raw)
In-Reply-To: <20160903174939.GB32345@dtor-ws>

On Sat, Sep 3, 2016 at 10:49 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Unfortunately module loading and availability of firmware is very
> loosely coupled.

The whole "let's add a new magical proc entry to say that all
filesystems are mounted" is all about the user space coupling them.

I'm just saying that if user space must know about when firmware is
ready to be loaded anyway, just do it rigth. Not with some hacky "you
can now do random things" flag. But by having user space actually say
"put this module together with this firmware".

If you just put the two pieces together, then the module "will just work".

And quite frankly, that sounds like a much better maintenance practice
anyway. If some module doesn't work without the firmware, then dammit,
the two *should* go together. Putting them in two different places
would be *INSANE*.

                    Linus

WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Ming Lei <ming.lei@canonical.com>, Jeff Mahoney <jeffm@suse.com>,
	Kay Sievers <kay@vrfy.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	David Howells <dhowells@redhat.com>,
	Christian Lamparter <chunkeey@googlemail.com>,
	cocci@systeme.lip6.fr, Josh Boyer <jwboyer@fedoraproject.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Kevin Cernekee <cernekee@gmail.com>,
	Thierry Martinez <martinez@nsup.org>,
	linux-serial <linux-serial@vger.kernel.org>,
	Jiri Slaby <jslaby@suse.com>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Alessandro Rubini <rubini@gnudd.com>,
	Stephen Boyd <stephen.boyd@linaro.org>,
	Kees Cook <keescook@chromium.org>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	nicolas.palix@imag.fr,
	"Abhay_Salunke@dell.com" <Abhay_Salunke@dell.com>,
	Julia Lawall <Julia.Lawall>
Subject: Re: [RFC] fs: add userspace critical mounts event support
Date: Sat, 3 Sep 2016 11:01:58 -0700	[thread overview]
Message-ID: <CA+55aFwLrXRUO9n75Sthu+g73BEjskAgUkguyLwU=JA_PNzdOQ@mail.gmail.com> (raw)
In-Reply-To: <20160903174939.GB32345@dtor-ws>

On Sat, Sep 3, 2016 at 10:49 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Unfortunately module loading and availability of firmware is very
> loosely coupled.

The whole "let's add a new magical proc entry to say that all
filesystems are mounted" is all about the user space coupling them.

I'm just saying that if user space must know about when firmware is
ready to be loaded anyway, just do it rigth. Not with some hacky "you
can now do random things" flag. But by having user space actually say
"put this module together with this firmware".

If you just put the two pieces together, then the module "will just work".

And quite frankly, that sounds like a much better maintenance practice
anyway. If some module doesn't work without the firmware, then dammit,
the two *should* go together. Putting them in two different places
would be *INSANE*.

                    Linus

  reply	other threads:[~2016-09-03 18:20 UTC|newest]

Thread overview: 145+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 22:54 [PATCH v2 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 1/5] MAINTAINERS: extend firmware_class maintainer list Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe Luis R. Rodriguez
2016-06-16 22:54   ` [Cocci] " Luis R. Rodriguez
2016-06-16 22:54   ` Luis R. Rodriguez
2016-08-24  6:55   ` Daniel Vetter
2016-08-24  6:55     ` [Cocci] " Daniel Vetter
2016-08-24  6:55     ` Daniel Vetter
2016-08-24 20:39     ` Luis R. Rodriguez
2016-08-24 20:39       ` [Cocci] " Luis R. Rodriguez
2016-08-24 20:39       ` Luis R. Rodriguez
2016-08-25 11:05       ` Daniel Vetter
2016-08-25 11:05         ` [Cocci] " Daniel Vetter
2016-08-25 11:05         ` Daniel Vetter
2016-08-25 19:41         ` Luis R. Rodriguez
2016-08-25 19:41           ` [Cocci] " Luis R. Rodriguez
2016-08-25 19:41           ` Luis R. Rodriguez
2016-08-25 20:10           ` Daniel Vetter
2016-08-25 20:10             ` [Cocci] " Daniel Vetter
2016-08-25 20:10             ` Daniel Vetter
2016-08-25 20:25             ` Luis R. Rodriguez
2016-08-25 20:25               ` [Cocci] " Luis R. Rodriguez
2016-08-25 20:25               ` Luis R. Rodriguez
2016-08-25 20:30           ` Dmitry Torokhov
2016-08-25 20:30             ` [Cocci] " Dmitry Torokhov
2016-08-25 20:30             ` Dmitry Torokhov
2016-09-02 23:59           ` Luis R. Rodriguez
2016-09-02 23:59             ` Luis R. Rodriguez
2016-09-03  0:20             ` [RFC] fs: add userspace critical mounts event support Luis R. Rodriguez
2016-09-03  0:20               ` Luis R. Rodriguez
2016-09-03  4:11               ` Linus Torvalds
2016-09-03  4:11                 ` Linus Torvalds
2016-09-03  4:20                 ` Dmitry Torokhov
2016-09-03  4:20                   ` Dmitry Torokhov
2016-09-03  4:41                   ` Linus Torvalds
2016-09-03  4:41                     ` Linus Torvalds
2016-09-03 17:49                     ` Dmitry Torokhov
2016-09-03 17:49                       ` Dmitry Torokhov
2016-09-03 18:01                       ` Linus Torvalds [this message]
2016-09-03 18:01                         ` Linus Torvalds
2016-09-03 18:10                         ` Dmitry Torokhov
2016-09-03 18:10                           ` Dmitry Torokhov
2016-09-06 21:52                           ` Luis R. Rodriguez
2016-09-06 21:52                             ` Luis R. Rodriguez
2016-09-06 22:28                             ` Bjorn Andersson
2016-09-06 22:28                               ` Bjorn Andersson
2016-09-06 23:14                               ` Luis R. Rodriguez
2016-09-06 23:14                                 ` Luis R. Rodriguez
2016-09-24  1:37                           ` Herbert, Marc
2016-09-24  1:37                           ` Herbert, Marc
2016-09-24  1:37                           ` Herbert, Marc
2016-09-24  1:37                             ` Herbert, Marc
2016-09-24 17:41                             ` Dmitry Torokhov
2016-09-24 17:41                               ` Dmitry Torokhov
2016-10-05  0:00                               ` Luis R. Rodriguez
2016-10-05  0:12                                 ` Linus Torvalds
2016-10-05  0:24                                   ` Luis R. Rodriguez
2016-10-05  0:32                                     ` Linus Torvalds
2016-10-05 17:38                                       ` Luis R. Rodriguez
2016-10-05  1:48                                   ` Josh Triplett
2016-10-05  1:58                                     ` Linus Torvalds
2016-09-06 17:46                 ` Bjorn Andersson
2016-09-06 17:46                   ` Bjorn Andersson
2016-09-06 18:32                   ` Linus Torvalds
2016-09-06 18:32                     ` Linus Torvalds
2016-09-06 21:11                     ` Bjorn Andersson
2016-09-06 21:11                       ` Bjorn Andersson
2016-09-06 21:50                       ` Linus Torvalds
2016-09-06 21:50                         ` Linus Torvalds
2016-09-06 23:04                         ` Luis R. Rodriguez
2016-09-06 23:04                           ` Luis R. Rodriguez
2016-09-24  2:51                           ` Herbert, Marc
2016-10-04 23:28                             ` Luis R. Rodriguez
2016-09-06 22:32                     ` Luis R. Rodriguez
2016-09-06 22:32                       ` Luis R. Rodriguez
2016-09-14  2:38               ` Rob Landley
2016-09-14  2:38                 ` Rob Landley
2016-10-05 18:00                 ` Luis R. Rodriguez
2016-10-05 18:00                   ` Luis R. Rodriguez
2016-10-05 18:08                   ` Linus Torvalds
2016-10-05 18:08                     ` Linus Torvalds
2016-10-05 19:46                     ` Luis R. Rodriguez
2016-10-05 19:46                       ` Luis R. Rodriguez
2016-11-08 22:47                       ` Luis R. Rodriguez
2016-11-08 22:47                         ` Luis R. Rodriguez
2016-11-09  9:13                         ` Daniel Wagner
2016-11-09  9:13                           ` Daniel Wagner
2016-11-09 11:21                           ` Andy Lutomirski
2016-11-09 11:21                             ` Andy Lutomirski
2016-11-09 23:53                             ` Luis R. Rodriguez
2016-11-09 23:53                               ` Luis R. Rodriguez
2016-11-29 21:54                             ` Luis R. Rodriguez
2016-11-29 21:54                               ` Luis R. Rodriguez
2016-11-09 23:40                         ` Luis R. Rodriguez
2016-11-09 23:40                           ` Luis R. Rodriguez
2016-11-15  9:28                         ` Johannes Berg
2016-11-15  9:28                           ` Johannes Berg
2016-11-15  9:28                           ` Johannes Berg
2016-11-29 21:10                           ` Tom Gundersen
2016-11-29 21:10                             ` Tom Gundersen
2016-11-29 21:37                             ` Luis R. Rodriguez
2016-11-29 21:37                               ` Luis R. Rodriguez
2016-11-30  8:18                               ` Johannes Berg
2016-11-30  8:18                                 ` Johannes Berg
2016-06-16 22:54 ` [PATCH v2 3/5] firmware: update usermode helper docs and add SmPL report Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation Luis R. Rodriguez
2016-06-16 22:54 ` [PATCH v2 5/5] firmware: fix fw cache to avoid usermode helper on suspend Luis R. Rodriguez
2016-07-07  0:56 ` [PATCH v2 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez
2016-07-13 21:47   ` Luis R. Rodriguez
2016-07-28  0:41     ` Luis R. Rodriguez
2016-08-03 14:50       ` Luis R. Rodriguez
2016-08-03 15:04         ` Greg KH
2016-08-03 17:06           ` Luis R. Rodriguez
2016-08-03 19:32             ` Greg KH
2016-08-03 19:46               ` Luis R. Rodriguez
2016-07-13 23:52   ` Fengguang Wu
2016-07-14  2:15     ` Luis R. Rodriguez
2016-07-14  2:23       ` Fengguang Wu
2016-07-14  3:08         ` Luis R. Rodriguez
2016-07-14  3:35           ` Fengguang Wu
2016-08-24  0:45 ` [PATCH v3 " mcgrof
2016-08-24  0:45   ` [PATCH v3 1/5] MAINTAINERS: extend firmware_class maintainer list mcgrof
2016-08-24  0:45   ` [PATCH v3 2/5] firmware: annotate thou shalt not request fw on init or probe mcgrof
2016-08-24  0:45     ` [Cocci] " mcgrof at kernel.org
2016-08-24  0:45     ` mcgrof
2016-08-24  8:17     ` Gabriel Paubert
2016-08-24  8:17       ` [Cocci] " Gabriel Paubert
2016-08-24  8:17       ` Gabriel Paubert
2016-09-02 18:26       ` Luis R. Rodriguez
2016-09-02 18:26         ` Luis R. Rodriguez
2016-08-24  0:45   ` [PATCH v3 3/5] firmware: update usermode helper docs and add SmPL report mcgrof
2016-08-24  0:45   ` [PATCH v3 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation mcgrof
2016-08-24  0:45   ` [PATCH v3 5/5] firmware: fix fw cache to avoid usermode helper on suspend mcgrof
2016-08-31  7:03     ` Daniel Wagner
2016-09-02 18:13       ` Luis R. Rodriguez
2016-09-07  0:42   ` [PATCH v4 0/5] firmware: add SmPL grammar to avoid issues Luis R. Rodriguez
2016-09-07  0:42     ` [PATCH v4 1/5] MAINTAINERS: extend firmware_class maintainer list Luis R. Rodriguez
2016-09-07  6:43       ` Greg KH
2016-09-08 14:58         ` Luis R. Rodriguez
2016-09-08 15:25         ` Ming Lei
2016-09-07  0:42     ` [PATCH v4 2/5] firmware: annotate thou shalt not request fw on init or probe Luis R. Rodriguez
2016-09-07  0:42       ` Luis R. Rodriguez
2016-09-07  0:42     ` [PATCH v4 3/5] firmware: update usermode helper docs and add SmPL report Luis R. Rodriguez
2016-09-07  0:42     ` [PATCH v4 4/5] firmware: add usermode helper DECLARE_FW_LOADER_USER() annotation Luis R. Rodriguez
2016-09-07  0:42     ` [PATCH v4 5/5] firmware: fix fw cache to avoid usermode helper on suspend Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+55aFwLrXRUO9n75Sthu+g73BEjskAgUkguyLwU=JA_PNzdOQ@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=Abhay_Salunke@dell.com \
    --cc=Gilles.Muller@lip6.fr \
    --cc=Julia.Lawall@lip6.fr \
    --cc=akpm@linux-foundation.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=cernekee@gmail.com \
    --cc=chunkeey@googlemail.com \
    --cc=cocci@systeme.lip6.fr \
    --cc=corbet@lwn.net \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dhowells@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=fengguang.wu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hauke@hauke-m.de \
    --cc=j.anaszewski@samsung.com \
    --cc=jeffm@suse.com \
    --cc=johannes@sipsolutions.net \
    --cc=jslaby@suse.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=kay@vrfy.org \
    --cc=keescook@chromium.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=luto@amacapital.net \
    --cc=markivx@codeaurora.org \
    --cc=martinez@nsup.org \
    --cc=mcgrof@kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=mmarek@suse.com \
    --cc=nbd@nbd.name \
    --cc=nicolas.palix@imag.fr \
    --cc=r.peniaev@gmail.com \
    --cc=rpurdie@rpsys.net \
    --cc=rubini@gnudd.com \
    --cc=stephen.boyd@linaro.org \
    --cc=teg@jklm.no \
    --cc=tiwai@suse.de \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.