From: Mark Rutland <mark.rutland@arm.com> To: fu.wei@linaro.org Cc: rjw@rjwysocki.net, lenb@kernel.org, daniel.lezcano@linaro.org, tglx@linutronix.de, marc.zyngier@arm.com, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, hanjun.guo@linaro.org, linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rruigrok@codeaurora.org, harba@codeaurora.org, cov@codeaurora.org, timur@codeaurora.org, graeme.gregory@linaro.org, al.stone@linaro.org, jcm@redhat.com, wei@redhat.com, arnd@arndb.de, catalin.marinas@arm.com, will.deacon@arm.com, Suravee.Suthikulpanit@amd.com, leo.duran@amd.com, wim@iguana.be, linux@roeck-us.net, linux-watchdog@vger.kernel.org, tn@semihalf.com, christoffer.dall@linaro.org, julien.grall@arm.com Subject: Re: [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code Date: Thu, 20 Oct 2016 16:32:45 +0100 [thread overview] Message-ID: <20161020153244.GB27598@leverpostej> (raw) In-Reply-To: <1475086637-1914-4-git-send-email-fu.wei@linaro.org> On Thu, Sep 29, 2016 at 02:17:11AM +0800, fu.wei@linaro.org wrote: > static void arch_timer_banner(unsigned type) > { > - pr_info("Architected %s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n", > - type & ARCH_CP15_TIMER ? "cp15" : "", > - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "", > - type & ARCH_MEM_TIMER ? "mmio" : "", > - (unsigned long)arch_timer_rate / 1000000, > - (unsigned long)(arch_timer_rate / 10000) % 100, > - type & ARCH_CP15_TIMER ? > - (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" : > - "", > - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "", > - type & ARCH_MEM_TIMER ? > - arch_timer_mem_use_virtual ? "virt" : "phys" : > - ""); > + pr_info("%s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n", > + type & ARCH_CP15_TIMER ? "cp15" : "", > + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "", > + type & ARCH_MEM_TIMER ? "mmio" : "", > + (unsigned long)arch_timer_rate / 1000000, > + (unsigned long)(arch_timer_rate / 10000) % 100, > + type & ARCH_CP15_TIMER ? > + (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" : > + "", Please restore the additional indent on this line... > + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "", > + type & ARCH_MEM_TIMER ? > + arch_timer_mem_use_virtual ? "virt" : "phys" : > + ""); ... and these two. No matter what checkpatch says, I prefer the code that way so as to keep the ternary clear. [...] > @@ -768,7 +769,7 @@ static int __init arch_timer_init(void) > return ret; > > arch_timer_kvm_info.virtual_irq = arch_timer_ppi[VIRT_PPI]; > - > + Please mention the whitespace fixup in the commit message. It's surprising otherwise. With all that: Acked-by: Mark Rutland <mark.rutland@arm.com> Thanks, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code Date: Thu, 20 Oct 2016 16:32:45 +0100 [thread overview] Message-ID: <20161020153244.GB27598@leverpostej> (raw) In-Reply-To: <1475086637-1914-4-git-send-email-fu.wei@linaro.org> On Thu, Sep 29, 2016 at 02:17:11AM +0800, fu.wei at linaro.org wrote: > static void arch_timer_banner(unsigned type) > { > - pr_info("Architected %s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n", > - type & ARCH_CP15_TIMER ? "cp15" : "", > - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "", > - type & ARCH_MEM_TIMER ? "mmio" : "", > - (unsigned long)arch_timer_rate / 1000000, > - (unsigned long)(arch_timer_rate / 10000) % 100, > - type & ARCH_CP15_TIMER ? > - (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" : > - "", > - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "", > - type & ARCH_MEM_TIMER ? > - arch_timer_mem_use_virtual ? "virt" : "phys" : > - ""); > + pr_info("%s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n", > + type & ARCH_CP15_TIMER ? "cp15" : "", > + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "", > + type & ARCH_MEM_TIMER ? "mmio" : "", > + (unsigned long)arch_timer_rate / 1000000, > + (unsigned long)(arch_timer_rate / 10000) % 100, > + type & ARCH_CP15_TIMER ? > + (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" : > + "", Please restore the additional indent on this line... > + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "", > + type & ARCH_MEM_TIMER ? > + arch_timer_mem_use_virtual ? "virt" : "phys" : > + ""); ... and these two. No matter what checkpatch says, I prefer the code that way so as to keep the ternary clear. [...] > @@ -768,7 +769,7 @@ static int __init arch_timer_init(void) > return ret; > > arch_timer_kvm_info.virtual_irq = arch_timer_ppi[VIRT_PPI]; > - > + Please mention the whitespace fixup in the commit message. It's surprising otherwise. With all that: Acked-by: Mark Rutland <mark.rutland@arm.com> Thanks, Mark.
next prev parent reply other threads:[~2016-10-20 15:32 UTC|newest] Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-28 18:17 [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei [not found] ` <1475086637-1914-2-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-20 14:45 ` Mark Rutland 2016-10-20 14:45 ` Mark Rutland 2016-10-20 14:45 ` Mark Rutland 2016-10-26 8:31 ` Fu Wei 2016-10-26 8:31 ` Fu Wei 2016-10-26 8:31 ` Fu Wei 2016-10-26 10:51 ` Mark Rutland 2016-10-26 10:51 ` Mark Rutland 2016-10-26 10:51 ` Mark Rutland 2016-10-26 10:54 ` Fu Wei 2016-10-26 10:54 ` Fu Wei 2016-10-26 10:54 ` Fu Wei 2016-09-28 18:17 ` [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org 2016-10-20 15:32 ` Mark Rutland [this message] 2016-10-20 15:32 ` Mark Rutland 2016-10-26 8:28 ` Fu Wei 2016-10-26 8:28 ` Fu Wei 2016-10-26 8:28 ` Fu Wei [not found] ` <1475086637-1914-1-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-09-28 18:17 ` [PATCH v14 2/9] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei-QSEj5FYQhm4dnm+yROfE0A 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei [not found] ` <1475086637-1914-3-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-20 15:09 ` Mark Rutland 2016-10-20 15:09 ` Mark Rutland 2016-10-20 15:09 ` Mark Rutland 2016-10-26 8:26 ` Fu Wei 2016-10-26 8:26 ` Fu Wei 2016-10-26 8:26 ` Fu Wei 2016-09-28 18:17 ` [PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver fu.wei-QSEj5FYQhm4dnm+yROfE0A 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei [not found] ` <1475086637-1914-5-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-20 16:37 ` Mark Rutland 2016-10-20 16:37 ` Mark Rutland 2016-10-20 16:37 ` Mark Rutland 2016-10-26 11:10 ` Fu Wei 2016-10-26 11:10 ` Fu Wei 2016-10-26 11:10 ` Fu Wei 2016-10-26 12:11 ` Marc Zyngier 2016-10-26 12:11 ` Marc Zyngier 2016-10-26 12:11 ` Marc Zyngier 2016-10-26 13:41 ` Fu Wei 2016-10-26 13:41 ` Fu Wei 2016-10-26 13:41 ` Fu Wei 2016-11-11 13:43 ` Hanjun Guo 2016-11-11 13:43 ` Hanjun Guo 2016-11-11 13:43 ` Hanjun Guo 2016-11-11 13:46 ` Hanjun Guo 2016-11-11 13:46 ` Hanjun Guo 2016-11-11 13:58 ` Hanjun Guo 2016-11-11 13:58 ` Hanjun Guo 2016-11-11 15:32 ` Mark Rutland 2016-11-11 15:32 ` Mark Rutland 2016-09-28 18:17 ` [PATCH v14 6/9] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei-QSEj5FYQhm4dnm+yROfE0A 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei 2016-10-21 11:19 ` Mark Rutland 2016-10-21 11:19 ` Mark Rutland 2016-09-28 18:17 ` [PATCH v14 9/9] acpi/arm64: Add SBSA Generic Watchdog " fu.wei-QSEj5FYQhm4dnm+yROfE0A 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei 2016-10-20 14:31 ` [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Mark Rutland 2016-10-20 14:31 ` Mark Rutland 2016-10-20 14:31 ` Mark Rutland 2016-10-20 14:57 ` Lorenzo Pieralisi 2016-10-20 14:57 ` Lorenzo Pieralisi 2016-10-20 15:17 ` Mark Rutland 2016-10-20 15:17 ` Mark Rutland 2016-10-20 15:17 ` Mark Rutland 2016-10-26 8:24 ` Fu Wei 2016-10-26 8:24 ` Fu Wei 2016-10-26 8:24 ` Fu Wei 2016-09-28 18:17 ` [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org [not found] ` <1475086637-1914-6-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-20 16:58 ` Mark Rutland 2016-10-20 16:58 ` Mark Rutland 2016-10-20 16:58 ` Mark Rutland 2016-10-21 11:14 ` Mark Rutland 2016-10-21 11:14 ` Mark Rutland 2016-10-21 11:14 ` Mark Rutland 2016-10-21 11:21 ` Mark Rutland 2016-10-21 11:21 ` Mark Rutland 2016-10-26 8:54 ` Fu Wei 2016-10-26 8:54 ` Fu Wei 2016-10-26 8:54 ` Fu Wei 2016-11-11 13:55 ` Hanjun Guo 2016-11-11 13:55 ` Hanjun Guo 2016-11-11 13:55 ` Hanjun Guo 2016-09-28 18:17 ` [PATCH v14 7/9] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org [not found] ` <1475086637-1914-8-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-21 11:32 ` Mark Rutland 2016-10-21 11:32 ` Mark Rutland 2016-10-21 11:32 ` Mark Rutland 2016-10-26 15:24 ` Fu Wei 2016-10-26 15:24 ` Fu Wei 2016-10-26 15:24 ` Fu Wei 2016-10-26 15:46 ` Mark Rutland 2016-10-26 15:46 ` Mark Rutland 2016-10-26 15:46 ` Mark Rutland 2016-10-26 16:07 ` Fu Wei 2016-10-26 16:07 ` Fu Wei 2016-10-26 16:07 ` Fu Wei 2016-09-28 18:17 ` [PATCH v14 8/9] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei 2016-09-30 0:40 ` [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Xiongfeng Wang 2016-09-30 0:40 ` Xiongfeng Wang 2016-09-30 0:40 ` Xiongfeng Wang 2016-10-05 17:26 ` Fu Wei 2016-10-05 17:26 ` Fu Wei 2016-10-05 17:26 ` Fu Wei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161020153244.GB27598@leverpostej \ --to=mark.rutland@arm.com \ --cc=Suravee.Suthikulpanit@amd.com \ --cc=al.stone@linaro.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=christoffer.dall@linaro.org \ --cc=cov@codeaurora.org \ --cc=daniel.lezcano@linaro.org \ --cc=fu.wei@linaro.org \ --cc=graeme.gregory@linaro.org \ --cc=hanjun.guo@linaro.org \ --cc=harba@codeaurora.org \ --cc=jcm@redhat.com \ --cc=julien.grall@arm.com \ --cc=lenb@kernel.org \ --cc=leo.duran@amd.com \ --cc=linaro-acpi@lists.linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=lorenzo.pieralisi@arm.com \ --cc=marc.zyngier@arm.com \ --cc=rjw@rjwysocki.net \ --cc=rruigrok@codeaurora.org \ --cc=sudeep.holla@arm.com \ --cc=tglx@linutronix.de \ --cc=timur@codeaurora.org \ --cc=tn@semihalf.com \ --cc=wei@redhat.com \ --cc=will.deacon@arm.com \ --cc=wim@iguana.be \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.