From: Mark Rutland <mark.rutland@arm.com> To: fu.wei@linaro.org Cc: rjw@rjwysocki.net, lenb@kernel.org, daniel.lezcano@linaro.org, tglx@linutronix.de, marc.zyngier@arm.com, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, hanjun.guo@linaro.org, linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rruigrok@codeaurora.org, harba@codeaurora.org, cov@codeaurora.org, timur@codeaurora.org, graeme.gregory@linaro.org, al.stone@linaro.org, jcm@redhat.com, wei@redhat.com, arnd@arndb.de, catalin.marinas@arm.com, will.deacon@arm.com, Suravee.Suthikulpanit@amd.com, leo.duran@amd.com, wim@iguana.be, linux@roeck-us.net, linux-watchdog@vger.kernel.org, tn@semihalf.com, christoffer.dall@linaro.org, julien.grall@arm.com Subject: Re: [PATCH v14 6/9] acpi/arm64: Add memory-mapped timer support in GTDT driver Date: Fri, 21 Oct 2016 12:19:27 +0100 [thread overview] Message-ID: <20161021111927.GB16630@leverpostej> (raw) In-Reply-To: <1475086637-1914-7-git-send-email-fu.wei@linaro.org> On Thu, Sep 29, 2016 at 02:17:14AM +0800, fu.wei@linaro.org wrote: > From: Fu Wei <fu.wei@linaro.org> > > On platforms booting with ACPI, architected memory-mapped timers' > configuration data is provided by firmware through the ACPI GTDT > static table. > > The clocksource architected timer kernel driver requires a firmware > interface to collect timer configuration and configure its driver. > this infrastructure is present for device tree systems, but it is > missing on systems booting with ACPI. > > Implement the kernel infrastructure required to parse the static > ACPI GTDT table so that the architected timer clocksource driver can > make use of it on systems booting with ACPI, therefore enabling > the corresponding timers configuration. > > Signed-off-by: Fu Wei <fu.wei@linaro.org> > Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> > --- > drivers/acpi/arm64/gtdt.c | 70 ++++++++++++++++++++++++++++++++++++ > include/clocksource/arm_arch_timer.h | 15 ++++++++ > include/linux/acpi.h | 1 + > 3 files changed, 86 insertions(+) > > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c > index b24844d..b6021db 100644 > --- a/drivers/acpi/arm64/gtdt.c > +++ b/drivers/acpi/arm64/gtdt.c > @@ -150,3 +150,73 @@ int __init acpi_gtdt_init(struct acpi_table_header *table) > > return gtdt->platform_timer_count; > } > + > +static int __init gtdt_parse_gt_block(struct acpi_gtdt_timer_block *block, > + struct gt_block_data *data) > +{ > + struct acpi_gtdt_timer_entry *frame; > + int i; > + > + if (!block || !data) > + return -EINVAL; As far as I can see, the !block case cannot happen; if it can, we'd already have derferenced it with the is_timer_block() check in gtdt_arch_timer_mem_init(). Why do we not handle the !data check in gtdt_arch_timer_mem_init()? It seems fragile, given we add an index there... > + > + if (!block->block_address || !block->timer_count) > + return -EINVAL; Looking at Table 5-120 in the ACPI 6.1 spec, zero is not called out as an invalid physical address for the block... Surely if you don't have an MMIO timer, you don't have a GT Block Structure, rather than an invalid one!? The block->timer_count check should be more thorough, e.g. if (!block->timer_count) { pr_warn("GTDT present, but frame count is zero"); return -ENODEV: } if (block->timer_count > 8) { pr_warn(FW_BUG "GTDT lists %d frames, ACPI spec only allows 8\n", block->timer_count); } ... note that without the latter we could go off the end of the array... > + data->cntctlbase_phy = (phys_addr_t)block->block_address; > + data->timer_count = block->timer_count; > + > + frame = (void *)block + block->timer_offset; > + if (frame + block->timer_count != (void *)block + block->header.length) > + return -EINVAL; > + > + /* > + * Get the GT timer Frame data for every GT Block Timer > + */ > + for (i = 0; i < block->timer_count; i++, frame++) { > + if (!frame->base_address || !frame->timer_interrupt) > + return -EINVAL; > + > + data->timer[i].irq = map_gt_gsi(frame->timer_interrupt, > + frame->timer_flags); > + if (data->timer[i].irq <= 0) > + return -EINVAL; Can we please print something describing the failure, e.g. pr_warn("failed to map GTDT frame %d, physical timer interrupt\n", i); > + > + if (frame->virtual_timer_interrupt) { Same comment as previously about GSIV zero being valid; this is arguably a spec bug that should be reported... > + data->timer[i].virtual_irq = > + map_gt_gsi(frame->virtual_timer_interrupt, > + frame->virtual_timer_flags); > + if (data->timer[i].virtual_irq <= 0) > + return -EINVAL; Likewise, a message here would be useful, e.g. pr_warn("failed to map GTDT frame %d, virtual timer interrupt\n", i); > + } > + > + data->timer[i].frame_nr = frame->frame_number; > + data->timer[i].cntbase_phy = frame->base_address; What about CntEL0BaseX? > + } > + > + return 0; > +} > + > +/* > + * Get the GT block info for memory-mapped timer from GTDT table. > + */ > +int __init gtdt_arch_timer_mem_init(struct gt_block_data *data) > +{ > + void *platform_timer; > + int index = 0; > + int ret; > + > + for_each_platform_timer(platform_timer) { > + if (!is_timer_block(platform_timer)) > + continue; > + ret = gtdt_parse_gt_block(platform_timer, data + index); > + if (ret) > + return ret; > + index++; > + } > + > + if (index) > + pr_info("found %d memory-mapped timer block(s).\n", index); > + > + return index; > +} > diff --git a/include/clocksource/arm_arch_timer.h b/include/clocksource/arm_arch_timer.h > index 16dcd10..94a5d14 100644 > --- a/include/clocksource/arm_arch_timer.h > +++ b/include/clocksource/arm_arch_timer.h > @@ -56,6 +56,8 @@ enum spi_nr { > #define ARCH_TIMER_MEM_PHYS_ACCESS 2 > #define ARCH_TIMER_MEM_VIRT_ACCESS 3 > > +#define ARCH_TIMER_MEM_MAX_FRAME 8 Nit: please call this ARCH_TIMER_MEM_MAX_FRAMES, so it's clear that the maximum index is 7. > #define ARCH_TIMER_USR_PCT_ACCESS_EN (1 << 0) /* physical counter */ > #define ARCH_TIMER_USR_VCT_ACCESS_EN (1 << 1) /* virtual counter */ > #define ARCH_TIMER_VIRT_EVT_EN (1 << 2) > @@ -71,6 +73,19 @@ struct arch_timer_kvm_info { > int virtual_irq; > }; > > +struct gt_timer_data { s/gt_timer_data/arch_timer_mem_frame/ > + int frame_nr; > + phys_addr_t cntbase_phy; Please get rid of the '_phy' suffix; it clashes with other terminology, 'phys' is generally preferable, and given the name and type it's obvious that it's a physical address anyhow. Just call this 'cntbase'. > + int irq; > + int virtual_irq; Call these phys_irq and virt_irq. > +}; > + > +struct gt_block_data { s/gt_block_data/arch_timer_mem/ > + phys_addr_t cntctlbase_phy; Same comment w.r.t. the '_phy' suffix. Likewise, just call this 'cntctlbase_phy' > + int timer_count; s/timer_count/num_frames/ > + struct gt_timer_data timer[ARCH_TIMER_MEM_MAX_FRAME]; > +}; Please split this part out into a patch which moves the existing driver over to this new abstraction, *then* introduce the ACPI parser for it in a subsequent patch. Thanks, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v14 6/9] acpi/arm64: Add memory-mapped timer support in GTDT driver Date: Fri, 21 Oct 2016 12:19:27 +0100 [thread overview] Message-ID: <20161021111927.GB16630@leverpostej> (raw) In-Reply-To: <1475086637-1914-7-git-send-email-fu.wei@linaro.org> On Thu, Sep 29, 2016 at 02:17:14AM +0800, fu.wei at linaro.org wrote: > From: Fu Wei <fu.wei@linaro.org> > > On platforms booting with ACPI, architected memory-mapped timers' > configuration data is provided by firmware through the ACPI GTDT > static table. > > The clocksource architected timer kernel driver requires a firmware > interface to collect timer configuration and configure its driver. > this infrastructure is present for device tree systems, but it is > missing on systems booting with ACPI. > > Implement the kernel infrastructure required to parse the static > ACPI GTDT table so that the architected timer clocksource driver can > make use of it on systems booting with ACPI, therefore enabling > the corresponding timers configuration. > > Signed-off-by: Fu Wei <fu.wei@linaro.org> > Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> > --- > drivers/acpi/arm64/gtdt.c | 70 ++++++++++++++++++++++++++++++++++++ > include/clocksource/arm_arch_timer.h | 15 ++++++++ > include/linux/acpi.h | 1 + > 3 files changed, 86 insertions(+) > > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c > index b24844d..b6021db 100644 > --- a/drivers/acpi/arm64/gtdt.c > +++ b/drivers/acpi/arm64/gtdt.c > @@ -150,3 +150,73 @@ int __init acpi_gtdt_init(struct acpi_table_header *table) > > return gtdt->platform_timer_count; > } > + > +static int __init gtdt_parse_gt_block(struct acpi_gtdt_timer_block *block, > + struct gt_block_data *data) > +{ > + struct acpi_gtdt_timer_entry *frame; > + int i; > + > + if (!block || !data) > + return -EINVAL; As far as I can see, the !block case cannot happen; if it can, we'd already have derferenced it with the is_timer_block() check in gtdt_arch_timer_mem_init(). Why do we not handle the !data check in gtdt_arch_timer_mem_init()? It seems fragile, given we add an index there... > + > + if (!block->block_address || !block->timer_count) > + return -EINVAL; Looking at Table 5-120 in the ACPI 6.1 spec, zero is not called out as an invalid physical address for the block... Surely if you don't have an MMIO timer, you don't have a GT Block Structure, rather than an invalid one!? The block->timer_count check should be more thorough, e.g. if (!block->timer_count) { pr_warn("GTDT present, but frame count is zero"); return -ENODEV: } if (block->timer_count > 8) { pr_warn(FW_BUG "GTDT lists %d frames, ACPI spec only allows 8\n", block->timer_count); } ... note that without the latter we could go off the end of the array... > + data->cntctlbase_phy = (phys_addr_t)block->block_address; > + data->timer_count = block->timer_count; > + > + frame = (void *)block + block->timer_offset; > + if (frame + block->timer_count != (void *)block + block->header.length) > + return -EINVAL; > + > + /* > + * Get the GT timer Frame data for every GT Block Timer > + */ > + for (i = 0; i < block->timer_count; i++, frame++) { > + if (!frame->base_address || !frame->timer_interrupt) > + return -EINVAL; > + > + data->timer[i].irq = map_gt_gsi(frame->timer_interrupt, > + frame->timer_flags); > + if (data->timer[i].irq <= 0) > + return -EINVAL; Can we please print something describing the failure, e.g. pr_warn("failed to map GTDT frame %d, physical timer interrupt\n", i); > + > + if (frame->virtual_timer_interrupt) { Same comment as previously about GSIV zero being valid; this is arguably a spec bug that should be reported... > + data->timer[i].virtual_irq = > + map_gt_gsi(frame->virtual_timer_interrupt, > + frame->virtual_timer_flags); > + if (data->timer[i].virtual_irq <= 0) > + return -EINVAL; Likewise, a message here would be useful, e.g. pr_warn("failed to map GTDT frame %d, virtual timer interrupt\n", i); > + } > + > + data->timer[i].frame_nr = frame->frame_number; > + data->timer[i].cntbase_phy = frame->base_address; What about CntEL0BaseX? > + } > + > + return 0; > +} > + > +/* > + * Get the GT block info for memory-mapped timer from GTDT table. > + */ > +int __init gtdt_arch_timer_mem_init(struct gt_block_data *data) > +{ > + void *platform_timer; > + int index = 0; > + int ret; > + > + for_each_platform_timer(platform_timer) { > + if (!is_timer_block(platform_timer)) > + continue; > + ret = gtdt_parse_gt_block(platform_timer, data + index); > + if (ret) > + return ret; > + index++; > + } > + > + if (index) > + pr_info("found %d memory-mapped timer block(s).\n", index); > + > + return index; > +} > diff --git a/include/clocksource/arm_arch_timer.h b/include/clocksource/arm_arch_timer.h > index 16dcd10..94a5d14 100644 > --- a/include/clocksource/arm_arch_timer.h > +++ b/include/clocksource/arm_arch_timer.h > @@ -56,6 +56,8 @@ enum spi_nr { > #define ARCH_TIMER_MEM_PHYS_ACCESS 2 > #define ARCH_TIMER_MEM_VIRT_ACCESS 3 > > +#define ARCH_TIMER_MEM_MAX_FRAME 8 Nit: please call this ARCH_TIMER_MEM_MAX_FRAMES, so it's clear that the maximum index is 7. > #define ARCH_TIMER_USR_PCT_ACCESS_EN (1 << 0) /* physical counter */ > #define ARCH_TIMER_USR_VCT_ACCESS_EN (1 << 1) /* virtual counter */ > #define ARCH_TIMER_VIRT_EVT_EN (1 << 2) > @@ -71,6 +73,19 @@ struct arch_timer_kvm_info { > int virtual_irq; > }; > > +struct gt_timer_data { s/gt_timer_data/arch_timer_mem_frame/ > + int frame_nr; > + phys_addr_t cntbase_phy; Please get rid of the '_phy' suffix; it clashes with other terminology, 'phys' is generally preferable, and given the name and type it's obvious that it's a physical address anyhow. Just call this 'cntbase'. > + int irq; > + int virtual_irq; Call these phys_irq and virt_irq. > +}; > + > +struct gt_block_data { s/gt_block_data/arch_timer_mem/ > + phys_addr_t cntctlbase_phy; Same comment w.r.t. the '_phy' suffix. Likewise, just call this 'cntctlbase_phy' > + int timer_count; s/timer_count/num_frames/ > + struct gt_timer_data timer[ARCH_TIMER_MEM_MAX_FRAME]; > +}; Please split this part out into a patch which moves the existing driver over to this new abstraction, *then* introduce the ACPI parser for it in a subsequent patch. Thanks, Mark.
next prev parent reply other threads:[~2016-10-21 11:20 UTC|newest] Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-28 18:17 [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei [not found] ` <1475086637-1914-2-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-20 14:45 ` Mark Rutland 2016-10-20 14:45 ` Mark Rutland 2016-10-20 14:45 ` Mark Rutland 2016-10-26 8:31 ` Fu Wei 2016-10-26 8:31 ` Fu Wei 2016-10-26 8:31 ` Fu Wei 2016-10-26 10:51 ` Mark Rutland 2016-10-26 10:51 ` Mark Rutland 2016-10-26 10:51 ` Mark Rutland 2016-10-26 10:54 ` Fu Wei 2016-10-26 10:54 ` Fu Wei 2016-10-26 10:54 ` Fu Wei 2016-09-28 18:17 ` [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org 2016-10-20 15:32 ` Mark Rutland 2016-10-20 15:32 ` Mark Rutland 2016-10-26 8:28 ` Fu Wei 2016-10-26 8:28 ` Fu Wei 2016-10-26 8:28 ` Fu Wei [not found] ` <1475086637-1914-1-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-09-28 18:17 ` [PATCH v14 2/9] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei-QSEj5FYQhm4dnm+yROfE0A 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei [not found] ` <1475086637-1914-3-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-20 15:09 ` Mark Rutland 2016-10-20 15:09 ` Mark Rutland 2016-10-20 15:09 ` Mark Rutland 2016-10-26 8:26 ` Fu Wei 2016-10-26 8:26 ` Fu Wei 2016-10-26 8:26 ` Fu Wei 2016-09-28 18:17 ` [PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver fu.wei-QSEj5FYQhm4dnm+yROfE0A 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei [not found] ` <1475086637-1914-5-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-20 16:37 ` Mark Rutland 2016-10-20 16:37 ` Mark Rutland 2016-10-20 16:37 ` Mark Rutland 2016-10-26 11:10 ` Fu Wei 2016-10-26 11:10 ` Fu Wei 2016-10-26 11:10 ` Fu Wei 2016-10-26 12:11 ` Marc Zyngier 2016-10-26 12:11 ` Marc Zyngier 2016-10-26 12:11 ` Marc Zyngier 2016-10-26 13:41 ` Fu Wei 2016-10-26 13:41 ` Fu Wei 2016-10-26 13:41 ` Fu Wei 2016-11-11 13:43 ` Hanjun Guo 2016-11-11 13:43 ` Hanjun Guo 2016-11-11 13:43 ` Hanjun Guo 2016-11-11 13:46 ` Hanjun Guo 2016-11-11 13:46 ` Hanjun Guo 2016-11-11 13:58 ` Hanjun Guo 2016-11-11 13:58 ` Hanjun Guo 2016-11-11 15:32 ` Mark Rutland 2016-11-11 15:32 ` Mark Rutland 2016-09-28 18:17 ` [PATCH v14 6/9] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei-QSEj5FYQhm4dnm+yROfE0A 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei 2016-10-21 11:19 ` Mark Rutland [this message] 2016-10-21 11:19 ` Mark Rutland 2016-09-28 18:17 ` [PATCH v14 9/9] acpi/arm64: Add SBSA Generic Watchdog " fu.wei-QSEj5FYQhm4dnm+yROfE0A 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei 2016-10-20 14:31 ` [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Mark Rutland 2016-10-20 14:31 ` Mark Rutland 2016-10-20 14:31 ` Mark Rutland 2016-10-20 14:57 ` Lorenzo Pieralisi 2016-10-20 14:57 ` Lorenzo Pieralisi 2016-10-20 15:17 ` Mark Rutland 2016-10-20 15:17 ` Mark Rutland 2016-10-20 15:17 ` Mark Rutland 2016-10-26 8:24 ` Fu Wei 2016-10-26 8:24 ` Fu Wei 2016-10-26 8:24 ` Fu Wei 2016-09-28 18:17 ` [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org [not found] ` <1475086637-1914-6-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-20 16:58 ` Mark Rutland 2016-10-20 16:58 ` Mark Rutland 2016-10-20 16:58 ` Mark Rutland 2016-10-21 11:14 ` Mark Rutland 2016-10-21 11:14 ` Mark Rutland 2016-10-21 11:14 ` Mark Rutland 2016-10-21 11:21 ` Mark Rutland 2016-10-21 11:21 ` Mark Rutland 2016-10-26 8:54 ` Fu Wei 2016-10-26 8:54 ` Fu Wei 2016-10-26 8:54 ` Fu Wei 2016-11-11 13:55 ` Hanjun Guo 2016-11-11 13:55 ` Hanjun Guo 2016-11-11 13:55 ` Hanjun Guo 2016-09-28 18:17 ` [PATCH v14 7/9] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org [not found] ` <1475086637-1914-8-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-21 11:32 ` Mark Rutland 2016-10-21 11:32 ` Mark Rutland 2016-10-21 11:32 ` Mark Rutland 2016-10-26 15:24 ` Fu Wei 2016-10-26 15:24 ` Fu Wei 2016-10-26 15:24 ` Fu Wei 2016-10-26 15:46 ` Mark Rutland 2016-10-26 15:46 ` Mark Rutland 2016-10-26 15:46 ` Mark Rutland 2016-10-26 16:07 ` Fu Wei 2016-10-26 16:07 ` Fu Wei 2016-10-26 16:07 ` Fu Wei 2016-09-28 18:17 ` [PATCH v14 8/9] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei 2016-09-28 18:17 ` fu.wei at linaro.org 2016-09-28 18:17 ` fu.wei 2016-09-30 0:40 ` [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Xiongfeng Wang 2016-09-30 0:40 ` Xiongfeng Wang 2016-09-30 0:40 ` Xiongfeng Wang 2016-10-05 17:26 ` Fu Wei 2016-10-05 17:26 ` Fu Wei 2016-10-05 17:26 ` Fu Wei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161021111927.GB16630@leverpostej \ --to=mark.rutland@arm.com \ --cc=Suravee.Suthikulpanit@amd.com \ --cc=al.stone@linaro.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=christoffer.dall@linaro.org \ --cc=cov@codeaurora.org \ --cc=daniel.lezcano@linaro.org \ --cc=fu.wei@linaro.org \ --cc=graeme.gregory@linaro.org \ --cc=hanjun.guo@linaro.org \ --cc=harba@codeaurora.org \ --cc=jcm@redhat.com \ --cc=julien.grall@arm.com \ --cc=lenb@kernel.org \ --cc=leo.duran@amd.com \ --cc=linaro-acpi@lists.linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=lorenzo.pieralisi@arm.com \ --cc=marc.zyngier@arm.com \ --cc=rjw@rjwysocki.net \ --cc=rruigrok@codeaurora.org \ --cc=sudeep.holla@arm.com \ --cc=tglx@linutronix.de \ --cc=timur@codeaurora.org \ --cc=tn@semihalf.com \ --cc=wei@redhat.com \ --cc=will.deacon@arm.com \ --cc=wim@iguana.be \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.