All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Fu Wei <fu.wei@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Hanjun Guo <hanjun.guo@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	Linaro ACPI Mailman List <linaro-acpi@lists.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	rruigrok@codeaurora.org, "Abdulhamid,
	Harb" <harba@codeaurora.org>,
	Christopher Covington <cov@codeaurora.org>,
	Timur Tabi <timur@codeaurora.org>,
	G Gregory <graeme.gregory@linaro.org>,
	Al Stone <al.stone@linaro.org>, Jon Masters <jcm@redhat.com>
Subject: Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file
Date: Wed, 26 Oct 2016 11:51:45 +0100	[thread overview]
Message-ID: <20161026105144.GF19965@leverpostej> (raw)
In-Reply-To: <CADyBb7shWfCQycmo0GcheX2NSsrjYBpzdtYFqymvDNCKi0QM2A@mail.gmail.com>

On Wed, Oct 26, 2016 at 04:31:55PM +0800, Fu Wei wrote:
> On 20 October 2016 at 22:45, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Thu, Sep 29, 2016 at 02:17:09AM +0800, fu.wei@linaro.org wrote:
> >>  #include <linux/timecounter.h>
> >>  #include <linux/types.h>
> >>
> >> +#define ARCH_CP15_TIMER                      BIT(0)
> >> +#define ARCH_MEM_TIMER                       BIT(1)
> >
> > If we're going to expose these in a header, it would be better to rename
> > them to something that makes their usage/meaning clear. These should
> > probably be ARCH_TIMER_TYPE_{CP15,MEM}.

> > With those changes (regardless of the ARCH_TIMER_TYPE_* bits):
> >
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
> 
> For ARCH_TIMER_TYPE_*, maybe I should add a patch at the end of this
> patchset to fix it, OK ?

Sure. If you could put that *earlier* in the patchset it would be
preferable so as to minimize churn.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Fu Wei <fu.wei@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Hanjun Guo <hanjun.guo@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	Linaro ACPI Mailman List <linaro-acpi@lists.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	rruigrok@codeaurora.org, "Abdulhamid,
	Harb" <harba@codeaurora.org>,
	Christopher Covington <cov@codeaurora.org>,
	Timur Tabi <timur@codeaurora.org>,
	G Gregory <graeme.gregory@linaro.org>,
	Al Stone <al.stone@linaro.org>, Jon Masters <jcm@redhat.com>,
	Wei Huang <wei@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
	Leo Duran <leo.duran@amd.com>, Wim Van Sebroeck <wim@iguana.be>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-watchdog@vger.kernel.org, Tomasz Nowicki <tn@semihalf.com>,
	Christoffer Dall <christoffer.dall@linaro.org>,
	Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file
Date: Wed, 26 Oct 2016 11:51:45 +0100	[thread overview]
Message-ID: <20161026105144.GF19965@leverpostej> (raw)
In-Reply-To: <CADyBb7shWfCQycmo0GcheX2NSsrjYBpzdtYFqymvDNCKi0QM2A@mail.gmail.com>

On Wed, Oct 26, 2016 at 04:31:55PM +0800, Fu Wei wrote:
> On 20 October 2016 at 22:45, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Thu, Sep 29, 2016 at 02:17:09AM +0800, fu.wei@linaro.org wrote:
> >>  #include <linux/timecounter.h>
> >>  #include <linux/types.h>
> >>
> >> +#define ARCH_CP15_TIMER                      BIT(0)
> >> +#define ARCH_MEM_TIMER                       BIT(1)
> >
> > If we're going to expose these in a header, it would be better to rename
> > them to something that makes their usage/meaning clear. These should
> > probably be ARCH_TIMER_TYPE_{CP15,MEM}.

> > With those changes (regardless of the ARCH_TIMER_TYPE_* bits):
> >
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
> 
> For ARCH_TIMER_TYPE_*, maybe I should add a patch at the end of this
> patchset to fix it, OK ?

Sure. If you could put that *earlier* in the patchset it would be
preferable so as to minimize churn.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file
Date: Wed, 26 Oct 2016 11:51:45 +0100	[thread overview]
Message-ID: <20161026105144.GF19965@leverpostej> (raw)
In-Reply-To: <CADyBb7shWfCQycmo0GcheX2NSsrjYBpzdtYFqymvDNCKi0QM2A@mail.gmail.com>

On Wed, Oct 26, 2016 at 04:31:55PM +0800, Fu Wei wrote:
> On 20 October 2016 at 22:45, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Thu, Sep 29, 2016 at 02:17:09AM +0800, fu.wei at linaro.org wrote:
> >>  #include <linux/timecounter.h>
> >>  #include <linux/types.h>
> >>
> >> +#define ARCH_CP15_TIMER                      BIT(0)
> >> +#define ARCH_MEM_TIMER                       BIT(1)
> >
> > If we're going to expose these in a header, it would be better to rename
> > them to something that makes their usage/meaning clear. These should
> > probably be ARCH_TIMER_TYPE_{CP15,MEM}.

> > With those changes (regardless of the ARCH_TIMER_TYPE_* bits):
> >
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
> 
> For ARCH_TIMER_TYPE_*, maybe I should add a patch at the end of this
> patchset to fix it, OK ?

Sure. If you could put that *earlier* in the patchset it would be
preferable so as to minimize churn.

Thanks,
Mark.

  reply	other threads:[~2016-10-26 10:52 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 18:17 [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei
2016-09-28 18:17 ` fu.wei at linaro.org
2016-09-28 18:17 ` [PATCH v14 1/9] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei
2016-09-28 18:17   ` fu.wei at linaro.org
2016-09-28 18:17   ` fu.wei
     [not found]   ` <1475086637-1914-2-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-20 14:45     ` Mark Rutland
2016-10-20 14:45       ` Mark Rutland
2016-10-20 14:45       ` Mark Rutland
2016-10-26  8:31       ` Fu Wei
2016-10-26  8:31         ` Fu Wei
2016-10-26  8:31         ` Fu Wei
2016-10-26 10:51         ` Mark Rutland [this message]
2016-10-26 10:51           ` Mark Rutland
2016-10-26 10:51           ` Mark Rutland
2016-10-26 10:54           ` Fu Wei
2016-10-26 10:54             ` Fu Wei
2016-10-26 10:54             ` Fu Wei
2016-09-28 18:17 ` [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei
2016-09-28 18:17   ` fu.wei at linaro.org
2016-10-20 15:32   ` Mark Rutland
2016-10-20 15:32     ` Mark Rutland
2016-10-26  8:28     ` Fu Wei
2016-10-26  8:28       ` Fu Wei
2016-10-26  8:28       ` Fu Wei
     [not found] ` <1475086637-1914-1-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-09-28 18:17   ` [PATCH v14 2/9] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei-QSEj5FYQhm4dnm+yROfE0A
2016-09-28 18:17     ` fu.wei at linaro.org
2016-09-28 18:17     ` fu.wei
     [not found]     ` <1475086637-1914-3-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-20 15:09       ` Mark Rutland
2016-10-20 15:09         ` Mark Rutland
2016-10-20 15:09         ` Mark Rutland
2016-10-26  8:26         ` Fu Wei
2016-10-26  8:26           ` Fu Wei
2016-10-26  8:26           ` Fu Wei
2016-09-28 18:17   ` [PATCH v14 4/9] acpi/arm64: Add GTDT table parse driver fu.wei-QSEj5FYQhm4dnm+yROfE0A
2016-09-28 18:17     ` fu.wei at linaro.org
2016-09-28 18:17     ` fu.wei
     [not found]     ` <1475086637-1914-5-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-20 16:37       ` Mark Rutland
2016-10-20 16:37         ` Mark Rutland
2016-10-20 16:37         ` Mark Rutland
2016-10-26 11:10         ` Fu Wei
2016-10-26 11:10           ` Fu Wei
2016-10-26 11:10           ` Fu Wei
2016-10-26 12:11           ` Marc Zyngier
2016-10-26 12:11             ` Marc Zyngier
2016-10-26 12:11             ` Marc Zyngier
2016-10-26 13:41             ` Fu Wei
2016-10-26 13:41               ` Fu Wei
2016-10-26 13:41               ` Fu Wei
2016-11-11 13:43           ` Hanjun Guo
2016-11-11 13:43             ` Hanjun Guo
2016-11-11 13:43             ` Hanjun Guo
2016-11-11 13:46         ` Hanjun Guo
2016-11-11 13:46           ` Hanjun Guo
2016-11-11 13:58           ` Hanjun Guo
2016-11-11 13:58             ` Hanjun Guo
2016-11-11 15:32           ` Mark Rutland
2016-11-11 15:32             ` Mark Rutland
2016-09-28 18:17   ` [PATCH v14 6/9] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei-QSEj5FYQhm4dnm+yROfE0A
2016-09-28 18:17     ` fu.wei at linaro.org
2016-09-28 18:17     ` fu.wei
2016-10-21 11:19     ` Mark Rutland
2016-10-21 11:19       ` Mark Rutland
2016-09-28 18:17   ` [PATCH v14 9/9] acpi/arm64: Add SBSA Generic Watchdog " fu.wei-QSEj5FYQhm4dnm+yROfE0A
2016-09-28 18:17     ` fu.wei at linaro.org
2016-09-28 18:17     ` fu.wei
2016-10-20 14:31   ` [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Mark Rutland
2016-10-20 14:31     ` Mark Rutland
2016-10-20 14:31     ` Mark Rutland
2016-10-20 14:57     ` Lorenzo Pieralisi
2016-10-20 14:57       ` Lorenzo Pieralisi
2016-10-20 15:17       ` Mark Rutland
2016-10-20 15:17         ` Mark Rutland
2016-10-20 15:17         ` Mark Rutland
2016-10-26  8:24         ` Fu Wei
2016-10-26  8:24           ` Fu Wei
2016-10-26  8:24           ` Fu Wei
2016-09-28 18:17 ` [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei
2016-09-28 18:17   ` fu.wei at linaro.org
     [not found]   ` <1475086637-1914-6-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-20 16:58     ` Mark Rutland
2016-10-20 16:58       ` Mark Rutland
2016-10-20 16:58       ` Mark Rutland
2016-10-21 11:14       ` Mark Rutland
2016-10-21 11:14         ` Mark Rutland
2016-10-21 11:14         ` Mark Rutland
2016-10-21 11:21         ` Mark Rutland
2016-10-21 11:21           ` Mark Rutland
2016-10-26  8:54           ` Fu Wei
2016-10-26  8:54             ` Fu Wei
2016-10-26  8:54             ` Fu Wei
2016-11-11 13:55           ` Hanjun Guo
2016-11-11 13:55             ` Hanjun Guo
2016-11-11 13:55             ` Hanjun Guo
2016-09-28 18:17 ` [PATCH v14 7/9] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT fu.wei
2016-09-28 18:17   ` fu.wei at linaro.org
     [not found]   ` <1475086637-1914-8-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-21 11:32     ` Mark Rutland
2016-10-21 11:32       ` Mark Rutland
2016-10-21 11:32       ` Mark Rutland
2016-10-26 15:24       ` Fu Wei
2016-10-26 15:24         ` Fu Wei
2016-10-26 15:24         ` Fu Wei
2016-10-26 15:46         ` Mark Rutland
2016-10-26 15:46           ` Mark Rutland
2016-10-26 15:46           ` Mark Rutland
2016-10-26 16:07           ` Fu Wei
2016-10-26 16:07             ` Fu Wei
2016-10-26 16:07             ` Fu Wei
2016-09-28 18:17 ` [PATCH v14 8/9] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei
2016-09-28 18:17   ` fu.wei at linaro.org
2016-09-28 18:17   ` fu.wei
2016-09-30  0:40 ` [PATCH v14 0/9] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Xiongfeng Wang
2016-09-30  0:40   ` Xiongfeng Wang
2016-09-30  0:40   ` Xiongfeng Wang
2016-10-05 17:26   ` Fu Wei
2016-10-05 17:26     ` Fu Wei
2016-10-05 17:26     ` Fu Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161026105144.GF19965@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=al.stone@linaro.org \
    --cc=cov@codeaurora.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=fu.wei@linaro.org \
    --cc=graeme.gregory@linaro.org \
    --cc=hanjun.guo@linaro.org \
    --cc=harba@codeaurora.org \
    --cc=jcm@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marc.zyngier@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=rruigrok@codeaurora.org \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.