* [PATCH] dwc_eth_qos: drop duplicate headers
@ 2016-11-23 14:24 Geliang Tang
2016-11-23 14:24 ` [PATCH] GenWQE: " Geliang Tang
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Geliang Tang @ 2016-11-23 14:24 UTC (permalink / raw)
To: Lars Persson; +Cc: Geliang Tang, netdev, linux-kernel
Drop duplicate headers types.h and delay.h from dwc_eth_qos.c.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/net/ethernet/synopsys/dwc_eth_qos.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
index 7053301..acce385 100644
--- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c
+++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
@@ -33,7 +33,6 @@
#include <linux/stat.h>
#include <linux/types.h>
-#include <linux/types.h>
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/mm.h>
@@ -43,7 +42,6 @@
#include <linux/phy.h>
#include <linux/mii.h>
-#include <linux/delay.h>
#include <linux/dma-mapping.h>
#include <linux/vmalloc.h>
--
2.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] GenWQE: drop duplicate headers
2016-11-23 14:24 [PATCH] dwc_eth_qos: drop duplicate headers Geliang Tang
@ 2016-11-23 14:24 ` Geliang Tang
2016-11-24 12:51 ` Frank Haverkamp
2016-11-23 14:24 ` [PATCH] PNP: drop duplicate header pci.h Geliang Tang
2016-11-25 21:14 ` [PATCH] dwc_eth_qos: drop duplicate headers David Miller
2 siblings, 1 reply; 8+ messages in thread
From: Geliang Tang @ 2016-11-23 14:24 UTC (permalink / raw)
To: Frank Haverkamp, Gabriel Krisman Bertazi; +Cc: Geliang Tang, linux-kernel
Drop duplicate headers module.h and delay.h.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/misc/genwqe/card_base.c | 1 -
drivers/misc/genwqe/card_ddcb.c | 1 -
drivers/misc/genwqe/card_utils.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
index 6c1f49a..b6f2edf 100644
--- a/drivers/misc/genwqe/card_base.c
+++ b/drivers/misc/genwqe/card_base.c
@@ -34,7 +34,6 @@
#include <linux/wait.h>
#include <linux/delay.h>
#include <linux/dma-mapping.h>
-#include <linux/module.h>
#include <linux/notifier.h>
#include <linux/device.h>
#include <linux/log2.h>
diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
index ddfeefe..332a0d1 100644
--- a/drivers/misc/genwqe/card_ddcb.c
+++ b/drivers/misc/genwqe/card_ddcb.c
@@ -34,7 +34,6 @@
#include <linux/string.h>
#include <linux/dma-mapping.h>
#include <linux/delay.h>
-#include <linux/module.h>
#include <linux/interrupt.h>
#include <linux/crc-itu-t.h>
diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
index 147b830..a1859e5 100644
--- a/drivers/misc/genwqe/card_utils.c
+++ b/drivers/misc/genwqe/card_utils.c
@@ -36,7 +36,6 @@
#include <linux/ctype.h>
#include <linux/module.h>
#include <linux/platform_device.h>
-#include <linux/delay.h>
#include <asm/pgtable.h>
#include "genwqe_driver.h"
--
2.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] GenWQE: drop duplicate headers
2016-11-23 14:24 ` [PATCH] GenWQE: " Geliang Tang
@ 2016-11-24 12:51 ` Frank Haverkamp
2016-11-28 14:15 ` [PATCH] " Geliang Tang
0 siblings, 1 reply; 8+ messages in thread
From: Frank Haverkamp @ 2016-11-24 12:51 UTC (permalink / raw)
To: Geliang Tang; +Cc: Gabriel Krisman Bertazi, linux-kernel
Hi Geliang,
> On 23 Nov 2016, at 15:24, Geliang Tang <geliangtang@gmail.com> wrote:
>
> Drop duplicate headers module.h and delay.h.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/misc/genwqe/card_base.c | 1 -
> drivers/misc/genwqe/card_ddcb.c | 1 -
> drivers/misc/genwqe/card_utils.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
> index 6c1f49a..b6f2edf 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -34,7 +34,6 @@
> #include <linux/wait.h>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> -#include <linux/module.h>
> #include <linux/notifier.h>
> #include <linux/device.h>
> #include <linux/log2.h>
> diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
> index ddfeefe..332a0d1 100644
> --- a/drivers/misc/genwqe/card_ddcb.c
> +++ b/drivers/misc/genwqe/card_ddcb.c
> @@ -34,7 +34,6 @@
> #include <linux/string.h>
> #include <linux/dma-mapping.h>
> #include <linux/delay.h>
> -#include <linux/module.h>
> #include <linux/interrupt.h>
> #include <linux/crc-itu-t.h>
>
> diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
> index 147b830..a1859e5 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -36,7 +36,6 @@
> #include <linux/ctype.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/delay.h>
> #include <asm/pgtable.h>
>
> #include "genwqe_driver.h"
> --
> 2.9.3
>
thanks for the simplification. Did you find those by manual inspection, or did you use a tool?
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Re: [PATCH] GenWQE: drop duplicate headers
2016-11-24 12:51 ` Frank Haverkamp
@ 2016-11-28 14:15 ` Geliang Tang
2016-11-28 14:15 ` [PATCH v2] " Geliang Tang
2016-12-14 8:20 ` [PATCH] [PATCH] " Frank Haverkamp
0 siblings, 2 replies; 8+ messages in thread
From: Geliang Tang @ 2016-11-28 14:15 UTC (permalink / raw)
To: Frank Haverkamp, Gabriel Krisman Bertazi; +Cc: Geliang Tang, linux-kernel
On Thu, Nov 24, 2016 at 01:51:57PM +0100, Frank Haverkamp wrote:
> Hi Geliang,
>
> thanks for the simplification. Did you find those by manual inspection, or did you use a tool?
>
> Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
Hi Frank,
Thanks for your review.
I found those duplicate headers by a simple script written by myself.
I should have used scripts/checkincludes.pl to do this. Now I am using
scripts/checkincludes.pl to check GenWQE files, and I found another
duplicate header dma-mapping.h. So I updated this patch.
-Geliang
Geliang Tang (1):
GenWQE: drop duplicate headers
drivers/misc/genwqe/card_base.c | 1 -
drivers/misc/genwqe/card_ddcb.c | 1 -
drivers/misc/genwqe/card_utils.c | 2 --
3 files changed, 4 deletions(-)
--
2.9.3
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] GenWQE: drop duplicate headers
2016-11-28 14:15 ` [PATCH] " Geliang Tang
@ 2016-11-28 14:15 ` Geliang Tang
2016-12-14 8:20 ` [PATCH] [PATCH] " Frank Haverkamp
1 sibling, 0 replies; 8+ messages in thread
From: Geliang Tang @ 2016-11-28 14:15 UTC (permalink / raw)
To: Frank Haverkamp, Gabriel Krisman Bertazi; +Cc: Geliang Tang, linux-kernel
Drop duplicate headers module.h, delay.h and dma-mapping.h.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
---
Changes in v2:
- drop dma-mapping.h too.
---
drivers/misc/genwqe/card_base.c | 1 -
drivers/misc/genwqe/card_ddcb.c | 1 -
drivers/misc/genwqe/card_utils.c | 2 --
3 files changed, 4 deletions(-)
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
index 6c1f49a..b6f2edf 100644
--- a/drivers/misc/genwqe/card_base.c
+++ b/drivers/misc/genwqe/card_base.c
@@ -34,7 +34,6 @@
#include <linux/wait.h>
#include <linux/delay.h>
#include <linux/dma-mapping.h>
-#include <linux/module.h>
#include <linux/notifier.h>
#include <linux/device.h>
#include <linux/log2.h>
diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
index ddfeefe..332a0d1 100644
--- a/drivers/misc/genwqe/card_ddcb.c
+++ b/drivers/misc/genwqe/card_ddcb.c
@@ -34,7 +34,6 @@
#include <linux/string.h>
#include <linux/dma-mapping.h>
#include <linux/delay.h>
-#include <linux/module.h>
#include <linux/interrupt.h>
#include <linux/crc-itu-t.h>
diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
index 147b830..bfef2c0 100644
--- a/drivers/misc/genwqe/card_utils.c
+++ b/drivers/misc/genwqe/card_utils.c
@@ -32,11 +32,9 @@
#include <linux/iommu.h>
#include <linux/delay.h>
#include <linux/pci.h>
-#include <linux/dma-mapping.h>
#include <linux/ctype.h>
#include <linux/module.h>
#include <linux/platform_device.h>
-#include <linux/delay.h>
#include <asm/pgtable.h>
#include "genwqe_driver.h"
--
2.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] [PATCH] GenWQE: drop duplicate headers
2016-11-28 14:15 ` [PATCH] " Geliang Tang
2016-11-28 14:15 ` [PATCH v2] " Geliang Tang
@ 2016-12-14 8:20 ` Frank Haverkamp
1 sibling, 0 replies; 8+ messages in thread
From: Frank Haverkamp @ 2016-12-14 8:20 UTC (permalink / raw)
To: Geliang Tang; +Cc: Gabriel Krisman Bertazi, linux-kernel
Hi Geliang,
> On 28 Nov 2016, at 15:15, Geliang Tang <geliangtang@gmail.com> wrote:
>
> On Thu, Nov 24, 2016 at 01:51:57PM +0100, Frank Haverkamp wrote:
>> Hi Geliang,
>>
>> thanks for the simplification. Did you find those by manual inspection, or did you use a tool?
>>
>> Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
>
> Hi Frank,
>
> Thanks for your review.
>
> I found those duplicate headers by a simple script written by myself.
> I should have used scripts/checkincludes.pl to do this. Now I am using
> scripts/checkincludes.pl to check GenWQE files, and I found another
> duplicate header dma-mapping.h. So I updated this patch.
>
Nice. Thanks for checking our code.
> -Geliang
>
> Geliang Tang (1):
> GenWQE: drop duplicate headers
>
> drivers/misc/genwqe/card_base.c | 1 -
> drivers/misc/genwqe/card_ddcb.c | 1 -
> drivers/misc/genwqe/card_utils.c | 2 --
> 3 files changed, 4 deletions(-)
>
> --
> 2.9.3
>
I am ok with the updated version too.
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
Frank
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] PNP: drop duplicate header pci.h
2016-11-23 14:24 [PATCH] dwc_eth_qos: drop duplicate headers Geliang Tang
2016-11-23 14:24 ` [PATCH] GenWQE: " Geliang Tang
@ 2016-11-23 14:24 ` Geliang Tang
2016-11-25 21:14 ` [PATCH] dwc_eth_qos: drop duplicate headers David Miller
2 siblings, 0 replies; 8+ messages in thread
From: Geliang Tang @ 2016-11-23 14:24 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Geliang Tang, linux-kernel
Drop duplicate header pci.h from quirks.c.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/pnp/quirks.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
index d28e3ab..4001275 100644
--- a/drivers/pnp/quirks.c
+++ b/drivers/pnp/quirks.c
@@ -226,8 +226,6 @@ static void quirk_ad1815_mpu_resources(struct pnp_dev *dev)
dev_info(&dev->dev, "made independent IRQ optional\n");
}
-#include <linux/pci.h>
-
static void quirk_system_pci_resources(struct pnp_dev *dev)
{
struct pci_dev *pdev = NULL;
--
2.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] dwc_eth_qos: drop duplicate headers
2016-11-23 14:24 [PATCH] dwc_eth_qos: drop duplicate headers Geliang Tang
2016-11-23 14:24 ` [PATCH] GenWQE: " Geliang Tang
2016-11-23 14:24 ` [PATCH] PNP: drop duplicate header pci.h Geliang Tang
@ 2016-11-25 21:14 ` David Miller
2 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2016-11-25 21:14 UTC (permalink / raw)
To: geliangtang; +Cc: lars.persson, netdev, linux-kernel
From: Geliang Tang <geliangtang@gmail.com>
Date: Wed, 23 Nov 2016 22:24:35 +0800
> Drop duplicate headers types.h and delay.h from dwc_eth_qos.c.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-12-14 8:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-23 14:24 [PATCH] dwc_eth_qos: drop duplicate headers Geliang Tang
2016-11-23 14:24 ` [PATCH] GenWQE: " Geliang Tang
2016-11-24 12:51 ` Frank Haverkamp
2016-11-28 14:15 ` [PATCH] " Geliang Tang
2016-11-28 14:15 ` [PATCH v2] " Geliang Tang
2016-12-14 8:20 ` [PATCH] [PATCH] " Frank Haverkamp
2016-11-23 14:24 ` [PATCH] PNP: drop duplicate header pci.h Geliang Tang
2016-11-25 21:14 ` [PATCH] dwc_eth_qos: drop duplicate headers David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.