[PATCH] dwc_eth_qos: drop duplicate headers

[PATCH] dwc_eth_qos: drop duplicate headers

[Geliang Tang]

Drop duplicate headers types.h and delay.h from dwc_eth_qos.c.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/net/ethernet/synopsys/dwc_eth_qos.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
index 7053301..acce385 100644
--- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c
+++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
@@ -33,7 +33,6 @@
 #include <linux/stat.h>
 #include <linux/types.h>
 
-#include <linux/types.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/mm.h>
@@ -43,7 +42,6 @@
 
 #include <linux/phy.h>
 #include <linux/mii.h>
-#include <linux/delay.h>
 #include <linux/dma-mapping.h>
 #include <linux/vmalloc.h>
 
-- 
2.9.3

[PATCH] GenWQE: drop duplicate headers

[Geliang Tang]

Drop duplicate headers module.h and delay.h.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/misc/genwqe/card_base.c  | 1 -
 drivers/misc/genwqe/card_ddcb.c  | 1 -
 drivers/misc/genwqe/card_utils.c | 1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
index 6c1f49a..b6f2edf 100644
--- a/drivers/misc/genwqe/card_base.c
+++ b/drivers/misc/genwqe/card_base.c
@@ -34,7 +34,6 @@
 #include <linux/wait.h>
 #include <linux/delay.h>
 #include <linux/dma-mapping.h>
-#include <linux/module.h>
 #include <linux/notifier.h>
 #include <linux/device.h>
 #include <linux/log2.h>
diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
index ddfeefe..332a0d1 100644
--- a/drivers/misc/genwqe/card_ddcb.c
+++ b/drivers/misc/genwqe/card_ddcb.c
@@ -34,7 +34,6 @@
 #include <linux/string.h>
 #include <linux/dma-mapping.h>
 #include <linux/delay.h>
-#include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/crc-itu-t.h>
 
diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
index 147b830..a1859e5 100644
--- a/drivers/misc/genwqe/card_utils.c
+++ b/drivers/misc/genwqe/card_utils.c
@@ -36,7 +36,6 @@
 #include <linux/ctype.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
-#include <linux/delay.h>
 #include <asm/pgtable.h>
 
 #include "genwqe_driver.h"
-- 
2.9.3

[PATCH] PNP: drop duplicate header pci.h

[Geliang Tang]

Drop duplicate header pci.h from quirks.c.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/pnp/quirks.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
index d28e3ab..4001275 100644
--- a/drivers/pnp/quirks.c
+++ b/drivers/pnp/quirks.c
@@ -226,8 +226,6 @@ static void quirk_ad1815_mpu_resources(struct pnp_dev *dev)
 	dev_info(&dev->dev, "made independent IRQ optional\n");
 }
 
-#include <linux/pci.h>
-
 static void quirk_system_pci_resources(struct pnp_dev *dev)
 {
 	struct pci_dev *pdev = NULL;
-- 
2.9.3

Re: [PATCH] GenWQE: drop duplicate headers

[Frank Haverkamp]

Hi Geliang,


> On 23 Nov 2016, at 15:24, Geliang Tang <geliangtang@gmail.com> wrote:
> 
> Drop duplicate headers module.h and delay.h.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/misc/genwqe/card_base.c  | 1 -
> drivers/misc/genwqe/card_ddcb.c  | 1 -
> drivers/misc/genwqe/card_utils.c | 1 -
> 3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
> index 6c1f49a..b6f2edf 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -34,7 +34,6 @@
> #include <linux/wait.h>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> -#include <linux/module.h>
> #include <linux/notifier.h>
> #include <linux/device.h>
> #include <linux/log2.h>
> diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
> index ddfeefe..332a0d1 100644
> --- a/drivers/misc/genwqe/card_ddcb.c
> +++ b/drivers/misc/genwqe/card_ddcb.c
> @@ -34,7 +34,6 @@
> #include <linux/string.h>
> #include <linux/dma-mapping.h>
> #include <linux/delay.h>
> -#include <linux/module.h>
> #include <linux/interrupt.h>
> #include <linux/crc-itu-t.h>
> 
> diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
> index 147b830..a1859e5 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -36,7 +36,6 @@
> #include <linux/ctype.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/delay.h>
> #include <asm/pgtable.h>
> 
> #include "genwqe_driver.h"
> -- 
> 2.9.3
> 

thanks for the simplification. Did you find those by manual inspection, or did you use a tool?

Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>

Re: [PATCH] dwc_eth_qos: drop duplicate headers

[David Miller]

From: Geliang Tang <geliangtang@gmail.com>
Date: Wed, 23 Nov 2016 22:24:35 +0800

> Drop duplicate headers types.h and delay.h from dwc_eth_qos.c.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>

Applied.

[PATCH] Re: [PATCH] GenWQE: drop duplicate headers

[Geliang Tang]

On Thu, Nov 24, 2016 at 01:51:57PM +0100, Frank Haverkamp wrote:
> Hi Geliang,
> 
> thanks for the simplification. Did you find those by manual inspection, or did you use a tool?
> 
> Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>

Hi Frank,

Thanks for your review.

I found those duplicate headers by a simple script written by myself.
I should have used scripts/checkincludes.pl to do this. Now I am using
scripts/checkincludes.pl to check GenWQE files, and I found another
duplicate header dma-mapping.h. So I updated this patch.

-Geliang

Geliang Tang (1):
  GenWQE: drop duplicate headers

 drivers/misc/genwqe/card_base.c  | 1 -
 drivers/misc/genwqe/card_ddcb.c  | 1 -
 drivers/misc/genwqe/card_utils.c | 2 --
 3 files changed, 4 deletions(-)

-- 
2.9.3

[PATCH v2] GenWQE: drop duplicate headers

[Geliang Tang]

Drop duplicate headers module.h, delay.h and dma-mapping.h.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
---
Changes in v2:
 - drop dma-mapping.h too.
---
 drivers/misc/genwqe/card_base.c  | 1 -
 drivers/misc/genwqe/card_ddcb.c  | 1 -
 drivers/misc/genwqe/card_utils.c | 2 --
 3 files changed, 4 deletions(-)

diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
index 6c1f49a..b6f2edf 100644
--- a/drivers/misc/genwqe/card_base.c
+++ b/drivers/misc/genwqe/card_base.c
@@ -34,7 +34,6 @@
 #include <linux/wait.h>
 #include <linux/delay.h>
 #include <linux/dma-mapping.h>
-#include <linux/module.h>
 #include <linux/notifier.h>
 #include <linux/device.h>
 #include <linux/log2.h>
diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
index ddfeefe..332a0d1 100644
--- a/drivers/misc/genwqe/card_ddcb.c
+++ b/drivers/misc/genwqe/card_ddcb.c
@@ -34,7 +34,6 @@
 #include <linux/string.h>
 #include <linux/dma-mapping.h>
 #include <linux/delay.h>
-#include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/crc-itu-t.h>
 
diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
index 147b830..bfef2c0 100644
--- a/drivers/misc/genwqe/card_utils.c
+++ b/drivers/misc/genwqe/card_utils.c
@@ -32,11 +32,9 @@
 #include <linux/iommu.h>
 #include <linux/delay.h>
 #include <linux/pci.h>
-#include <linux/dma-mapping.h>
 #include <linux/ctype.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
-#include <linux/delay.h>
 #include <asm/pgtable.h>
 
 #include "genwqe_driver.h"
-- 
2.9.3

Re: [PATCH] [PATCH] GenWQE: drop duplicate headers

[Frank Haverkamp]

Hi Geliang,

> On 28 Nov 2016, at 15:15, Geliang Tang <geliangtang@gmail.com> wrote:
> 
> On Thu, Nov 24, 2016 at 01:51:57PM +0100, Frank Haverkamp wrote:
>> Hi Geliang,
>> 
>> thanks for the simplification. Did you find those by manual inspection, or did you use a tool?
>> 
>> Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
> 
> Hi Frank,
> 
> Thanks for your review.
> 
> I found those duplicate headers by a simple script written by myself.
> I should have used scripts/checkincludes.pl to do this. Now I am using
> scripts/checkincludes.pl to check GenWQE files, and I found another
> duplicate header dma-mapping.h. So I updated this patch.
> 

Nice. Thanks for checking our code.

> -Geliang
> 
> Geliang Tang (1):
>  GenWQE: drop duplicate headers
> 
> drivers/misc/genwqe/card_base.c  | 1 -
> drivers/misc/genwqe/card_ddcb.c  | 1 -
> drivers/misc/genwqe/card_utils.c | 2 --
> 3 files changed, 4 deletions(-)
> 
> -- 
> 2.9.3
> 

I am ok with the updated version too.

Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>

Frank