From: Peter Zijlstra <peterz@infradead.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: mingo@kernel.org, tglx@linutronix.de, walken@google.com,
boqun.feng@gmail.com, kirill@shutemov.name,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
npiggin@gmail.com, kernel-team@lge.com,
Michal Hocko <mhocko@kernel.org>,
Nikolay Borisov <nborisov@suse.com>, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature
Date: Fri, 3 Mar 2017 10:32:38 +0100 [thread overview]
Message-ID: <20170303093238.GI6536@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20170303091338.GH6536@twins.programming.kicks-ass.net>
On Fri, Mar 03, 2017 at 10:13:38AM +0100, Peter Zijlstra wrote:
> On Fri, Mar 03, 2017 at 09:14:16AM +0100, Peter Zijlstra wrote:
>
> > That said; I'd be fairly interested in numbers on how many links this
> > avoids, I'll go make a check_redundant() version of the above and put a
> > proper counter in so I can see what it does for a regular boot etc..
>
> Two boots + a make defconfig, the first didn't have the redundant bit
> in, the second did (full diff below still includes the reclaim rework,
> because that was still in that kernel and I forgot to reset the tree).
>
>
> lock-classes: 1168 1169 [max: 8191]
> direct dependencies: 7688 5812 [max: 32768]
> indirect dependencies: 25492 25937
> all direct dependencies: 220113 217512
> dependency chains: 9005 9008 [max: 65536]
> dependency chain hlocks: 34450 34366 [max: 327680]
> in-hardirq chains: 55 51
> in-softirq chains: 371 378
> in-process chains: 8579 8579
> stack-trace entries: 108073 88474 [max: 524288]
> combined max dependencies: 178738560 169094640
>
> max locking depth: 15 15
> max bfs queue depth: 320 329
>
> cyclic checks: 9123 9190
>
> redundant checks: 5046
> redundant links: 1828
>
> find-mask forwards checks: 2564 2599
> find-mask backwards checks: 39521 39789
>
OK, last email, I promise, then I'll go bury myself in futexes.
find-mask forwards checks: 2999
find-mask backwards checks: 56134
Is with a clean kernel, which shows how many __bfs() calls we save by
doing away with that RECLAIM state. OTOH:
lock-classes: 1167 [max: 8191]
direct dependencies: 7254 [max: 32768]
indirect dependencies: 23763
all direct dependencies: 219093
Shows that the added reclaim class isn't entirely free either ;-)
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: mingo@kernel.org, tglx@linutronix.de, walken@google.com,
boqun.feng@gmail.com, kirill@shutemov.name,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
npiggin@gmail.com, kernel-team@lge.com,
Michal Hocko <mhocko@kernel.org>,
Nikolay Borisov <nborisov@suse.com>, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature
Date: Fri, 3 Mar 2017 10:32:38 +0100 [thread overview]
Message-ID: <20170303093238.GI6536@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20170303091338.GH6536@twins.programming.kicks-ass.net>
On Fri, Mar 03, 2017 at 10:13:38AM +0100, Peter Zijlstra wrote:
> On Fri, Mar 03, 2017 at 09:14:16AM +0100, Peter Zijlstra wrote:
>
> > That said; I'd be fairly interested in numbers on how many links this
> > avoids, I'll go make a check_redundant() version of the above and put a
> > proper counter in so I can see what it does for a regular boot etc..
>
> Two boots + a make defconfig, the first didn't have the redundant bit
> in, the second did (full diff below still includes the reclaim rework,
> because that was still in that kernel and I forgot to reset the tree).
>
>
> lock-classes: 1168 1169 [max: 8191]
> direct dependencies: 7688 5812 [max: 32768]
> indirect dependencies: 25492 25937
> all direct dependencies: 220113 217512
> dependency chains: 9005 9008 [max: 65536]
> dependency chain hlocks: 34450 34366 [max: 327680]
> in-hardirq chains: 55 51
> in-softirq chains: 371 378
> in-process chains: 8579 8579
> stack-trace entries: 108073 88474 [max: 524288]
> combined max dependencies: 178738560 169094640
>
> max locking depth: 15 15
> max bfs queue depth: 320 329
>
> cyclic checks: 9123 9190
>
> redundant checks: 5046
> redundant links: 1828
>
> find-mask forwards checks: 2564 2599
> find-mask backwards checks: 39521 39789
>
OK, last email, I promise, then I'll go bury myself in futexes.
find-mask forwards checks: 2999
find-mask backwards checks: 56134
Is with a clean kernel, which shows how many __bfs() calls we save by
doing away with that RECLAIM state. OTOH:
lock-classes: 1167 [max: 8191]
direct dependencies: 7254 [max: 32768]
indirect dependencies: 23763
all direct dependencies: 219093
Shows that the added reclaim class isn't entirely free either ;-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-03 9:44 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 13:17 [PATCH v5 00/13] lockdep: Implement crossrelease feature Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 01/13] lockdep: Refactor lookup_chain_cache() Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-19 9:16 ` Boqun Feng
2017-01-19 9:52 ` Byungchul Park
2017-01-19 9:52 ` Byungchul Park
2017-01-26 7:53 ` Byungchul Park
2017-01-26 7:53 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 02/13] lockdep: Fix wrong condition to print bug msgs for MAX_LOCKDEP_CHAIN_HLOCKS Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 03/13] lockdep: Add a function building a chain between two classes Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 04/13] lockdep: Refactor save_trace() Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 05/13] lockdep: Pass a callback arg to check_prev_add() to handle stack_trace Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-26 7:43 ` Byungchul Park
2017-01-26 7:43 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 06/13] lockdep: Implement crossrelease feature Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-02-28 12:26 ` Peter Zijlstra
2017-02-28 12:26 ` Peter Zijlstra
2017-02-28 12:45 ` Peter Zijlstra
2017-02-28 12:45 ` Peter Zijlstra
2017-02-28 12:49 ` Peter Zijlstra
2017-02-28 12:49 ` Peter Zijlstra
2017-03-01 6:20 ` Byungchul Park
2017-03-01 6:20 ` Byungchul Park
2017-02-28 13:05 ` Peter Zijlstra
2017-02-28 13:05 ` Peter Zijlstra
2017-02-28 13:28 ` Byungchul Park
2017-02-28 13:28 ` Byungchul Park
2017-02-28 13:35 ` Peter Zijlstra
2017-02-28 13:35 ` Peter Zijlstra
2017-02-28 14:00 ` Byungchul Park
2017-02-28 14:00 ` Byungchul Park
2017-02-28 13:10 ` Peter Zijlstra
2017-02-28 13:10 ` Peter Zijlstra
2017-02-28 13:24 ` Byungchul Park
2017-02-28 13:24 ` Byungchul Park
2017-02-28 18:29 ` Peter Zijlstra
2017-02-28 18:29 ` Peter Zijlstra
2017-03-01 4:40 ` Byungchul Park
2017-03-01 4:40 ` Byungchul Park
2017-03-01 10:45 ` Peter Zijlstra
2017-03-01 10:45 ` Peter Zijlstra
2017-03-01 12:10 ` Byungchul Park
2017-03-01 12:10 ` Byungchul Park
2017-02-28 13:40 ` Peter Zijlstra
2017-02-28 13:40 ` Peter Zijlstra
2017-03-01 5:43 ` Byungchul Park
2017-03-01 5:43 ` Byungchul Park
2017-03-01 12:28 ` Peter Zijlstra
2017-03-01 12:28 ` Peter Zijlstra
2017-03-02 13:40 ` Peter Zijlstra
2017-03-02 13:40 ` Peter Zijlstra
2017-03-03 0:17 ` Byungchul Park
2017-03-03 0:17 ` Byungchul Park
2017-03-03 8:14 ` Peter Zijlstra
2017-03-03 8:14 ` Peter Zijlstra
2017-03-03 9:13 ` Peter Zijlstra
2017-03-03 9:13 ` Peter Zijlstra
2017-03-03 9:32 ` Peter Zijlstra [this message]
2017-03-03 9:32 ` Peter Zijlstra
2017-03-05 3:33 ` Byungchul Park
2017-03-05 3:33 ` Byungchul Park
2017-08-10 12:18 ` [tip:locking/core] locking/lockdep: Avoid creating redundant links tip-bot for Peter Zijlstra
2017-03-05 3:08 ` [PATCH v5 06/13] lockdep: Implement crossrelease feature Byungchul Park
2017-03-05 3:08 ` Byungchul Park
2017-03-07 11:42 ` Peter Zijlstra
2017-03-07 11:42 ` Peter Zijlstra
2017-03-03 0:39 ` Byungchul Park
2017-03-03 0:39 ` Byungchul Park
2017-02-28 15:49 ` Peter Zijlstra
2017-02-28 15:49 ` Peter Zijlstra
2017-03-01 5:17 ` Byungchul Park
2017-03-01 5:17 ` Byungchul Park
2017-03-01 6:18 ` Byungchul Park
2017-03-01 6:18 ` Byungchul Park
2017-03-02 2:52 ` Byungchul Park
2017-03-02 2:52 ` Byungchul Park
2017-02-28 18:15 ` Peter Zijlstra
2017-02-28 18:15 ` Peter Zijlstra
2017-03-01 7:21 ` Byungchul Park
2017-03-01 7:21 ` Byungchul Park
2017-03-01 10:43 ` Peter Zijlstra
2017-03-01 10:43 ` Peter Zijlstra
2017-03-01 12:27 ` Byungchul Park
2017-03-01 12:27 ` Byungchul Park
2017-03-02 4:20 ` Matthew Wilcox
2017-03-02 4:20 ` Matthew Wilcox
2017-03-02 4:45 ` byungchul.park
2017-03-02 4:45 ` byungchul.park
2017-03-02 14:39 ` Matthew Wilcox
2017-03-02 14:39 ` Matthew Wilcox
2017-03-02 23:50 ` Byungchul Park
2017-03-02 23:50 ` Byungchul Park
2017-03-05 8:01 ` Byungchul Park
2017-03-05 8:01 ` Byungchul Park
2017-03-14 7:36 ` Byungchul Park
2017-03-14 7:36 ` Byungchul Park
2017-03-02 13:41 ` Peter Zijlstra
2017-03-02 13:41 ` Peter Zijlstra
2017-03-02 23:43 ` Byungchul Park
2017-03-02 23:43 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 07/13] lockdep: Make print_circular_bug() aware of crossrelease Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 08/13] lockdep: Apply crossrelease to completions Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 09/13] pagemap.h: Remove trailing white space Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 10/13] lockdep: Apply crossrelease to PG_locked locks Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 11/13] lockdep: Apply lock_acquire(release) on __Set(__Clear)PageLocked Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 12/13] lockdep: Move data of CONFIG_LOCKDEP_PAGELOCK from page to page_ext Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-18 13:17 ` [PATCH v5 13/13] lockdep: Crossrelease feature documentation Byungchul Park
2017-01-18 13:17 ` Byungchul Park
2017-01-20 9:08 ` [REVISED DOCUMENT] " Byungchul Park
2017-01-20 9:08 ` Byungchul Park
2017-02-20 8:38 ` [PATCH v5 00/13] lockdep: Implement crossrelease feature Byungchul Park
2017-02-20 8:38 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303093238.GI6536@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=byungchul.park@lge.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-team@lge.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=nborisov@suse.com \
--cc=npiggin@gmail.com \
--cc=tglx@linutronix.de \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.