Re: [Xen-devel] [PATCH 6/7] xen/9pfs: receive responses

From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: jgross@suse.com, Latchesar Ionkov <lucho@ionkov.net>,
	Eric Van Hensbergen <ericvh@gmail.com>,
	linux-kernel@vger.kernel.org,
	Stefano Stabellini <stefano@aporeto.com>,
	v9fs-developer@lists.sourceforge.net,
	Ron Minnich <rminnich@sandia.gov>,
	xen-devel@lists.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH 6/7] xen/9pfs: receive responses
Date: Wed, 8 Mar 2017 15:11:57 -0500	[thread overview]
Message-ID: <20170308201157.GA9643@char.us.oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1703071712550.8160@sstabellini-ThinkPad-X260>

On Tue, Mar 07, 2017 at 05:13:59PM -0800, Stefano Stabellini wrote:
> On Tue, 7 Mar 2017, Stefano Stabellini wrote:
> > > > +
> > > > +	ring = container_of(work, struct xen_9pfs_dataring, work);
> > > > +	priv = ring->priv;
> > > > +
> > > > +	while (1) {
> > > > +		cons = ring->intf->in_cons;
> > > > +		prod = ring->intf->in_prod;
> > > > +		rmb();
> > > 
> > > 
> > > Is this rmb() or mb()? (Or, in fact, virt_XXX()?) You used mb() in the
> > > previous patch.
> >  
> > I think they should all be virt_XXX, thanks.
> 
> regarding mb() vs. rmb(), give a look at the workflow at the end of
> docs/misc/9pfs.markdown, under "Ring Usage".

That is not what Boris meant. He meant that you should use the
virt_ variants instead of the rmb() or wmb().

The reason that on UP kernels the rmb() and wmb() can be converted
to NOPs. While that is OK for a UP kernel it is not good in virtualization
as we need those barriers regardless of the flavor of the kernel.

> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel