From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, jgross@suse.com,
linux-kernel@vger.kernel.org,
Stefano Stabellini <stefano@aporeto.com>,
boris.ostrovsky@oracle.com
Subject: Re: [Xen-devel] [PATCH 1/7] xen: import new ring macros in ring.h
Date: Wed, 8 Mar 2017 11:14:03 +0000 [thread overview]
Message-ID: <dc2fed14-c454-8801-a2a9-42f995f6b673@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1703071612080.17906@sstabellini-ThinkPad-X260>
Hi Stefano,
On 08/03/17 00:12, Stefano Stabellini wrote:
> On Tue, 7 Mar 2017, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 03/06/2017 08:01 PM, Stefano Stabellini wrote:
>>> Sync the ring.h file with upstream Xen, to introduce the new ring macros.
>>> They will be used by the Xen transport for 9pfs.
>>>
>>> Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
>>> CC: konrad.wilk@oracle.com
>>> CC: boris.ostrovsky@oracle.com
>>> CC: jgross@suse.com
>>>
>>> ---
>>> NB: The new macros have not been committed to Xen yet. Do not apply this
>>> patch until they do.
>>> ---
>>> ---
>>> include/xen/interface/io/ring.h | 131
>>> ++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 131 insertions(+)
>>>
>>> diff --git a/include/xen/interface/io/ring.h
>>> b/include/xen/interface/io/ring.h
>>> index 21f4fbd..e16aa92 100644
>>> --- a/include/xen/interface/io/ring.h
>>> +++ b/include/xen/interface/io/ring.h
>>
>> [...]
>>
>>> +#define XEN_FLEX_RING_SIZE(order)
>>> \
>>> + (1UL << (order + PAGE_SHIFT - 1))
>>
>> This will need to be XEN_PAGE_SHIFT in order to works with 64K kernel.
>
> Good point! I had it right at the beginning but I lost the change in one
> of the updates from xen.git.
It is probably worth to consider introducing XEN_PAGE_SIZE in the
hypervisor code because we are likely to miss the change when the
headers will be re-sync in the future.
Cheers,
--
Julien Grall
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: jgross@suse.com, xen-devel@lists.xenproject.org,
Stefano Stabellini <stefano@aporeto.com>,
linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com
Subject: Re: [PATCH 1/7] xen: import new ring macros in ring.h
Date: Wed, 8 Mar 2017 11:14:03 +0000 [thread overview]
Message-ID: <dc2fed14-c454-8801-a2a9-42f995f6b673@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1703071612080.17906@sstabellini-ThinkPad-X260>
Hi Stefano,
On 08/03/17 00:12, Stefano Stabellini wrote:
> On Tue, 7 Mar 2017, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 03/06/2017 08:01 PM, Stefano Stabellini wrote:
>>> Sync the ring.h file with upstream Xen, to introduce the new ring macros.
>>> They will be used by the Xen transport for 9pfs.
>>>
>>> Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
>>> CC: konrad.wilk@oracle.com
>>> CC: boris.ostrovsky@oracle.com
>>> CC: jgross@suse.com
>>>
>>> ---
>>> NB: The new macros have not been committed to Xen yet. Do not apply this
>>> patch until they do.
>>> ---
>>> ---
>>> include/xen/interface/io/ring.h | 131
>>> ++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 131 insertions(+)
>>>
>>> diff --git a/include/xen/interface/io/ring.h
>>> b/include/xen/interface/io/ring.h
>>> index 21f4fbd..e16aa92 100644
>>> --- a/include/xen/interface/io/ring.h
>>> +++ b/include/xen/interface/io/ring.h
>>
>> [...]
>>
>>> +#define XEN_FLEX_RING_SIZE(order)
>>> \
>>> + (1UL << (order + PAGE_SHIFT - 1))
>>
>> This will need to be XEN_PAGE_SHIFT in order to works with 64K kernel.
>
> Good point! I had it right at the beginning but I lost the change in one
> of the updates from xen.git.
It is probably worth to consider introducing XEN_PAGE_SIZE in the
hypervisor code because we are likely to miss the change when the
headers will be re-sync in the future.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-08 11:40 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 20:00 [PATCH 0/7] Xen transport for 9pfs frontend driver Stefano Stabellini
2017-03-06 20:01 ` [PATCH 1/7] xen: import new ring macros in ring.h Stefano Stabellini
2017-03-06 20:01 ` Stefano Stabellini
2017-03-06 20:01 ` [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol Stefano Stabellini
2017-03-06 20:01 ` Stefano Stabellini
2017-03-06 21:22 ` Boris Ostrovsky
2017-03-06 21:22 ` Boris Ostrovsky
2017-03-06 21:36 ` Stefano Stabellini
2017-03-06 21:36 ` Stefano Stabellini
2017-03-06 21:42 ` Boris Ostrovsky
2017-03-06 21:42 ` Boris Ostrovsky
2017-03-06 20:01 ` [PATCH 3/7] xen/9pfs: introduce Xen 9pfs transport driver Stefano Stabellini
2017-03-06 20:01 ` Stefano Stabellini
2017-03-06 20:01 ` [PATCH 4/7] xen/9pfs: connect to the backend Stefano Stabellini
2017-03-06 20:01 ` Stefano Stabellini
2017-03-07 15:03 ` Boris Ostrovsky
2017-03-07 15:03 ` Boris Ostrovsky
2017-03-08 0:11 ` Stefano Stabellini
2017-03-08 0:11 ` Stefano Stabellini
2017-03-08 13:47 ` Boris Ostrovsky
2017-03-08 13:47 ` Boris Ostrovsky
2017-03-08 19:22 ` Stefano Stabellini
2017-03-08 19:22 ` Stefano Stabellini
2017-03-07 17:37 ` [Xen-devel] " Julien Grall
2017-03-07 17:37 ` Julien Grall
2017-03-08 0:49 ` [Xen-devel] " Stefano Stabellini
2017-03-08 0:49 ` Stefano Stabellini
2017-03-08 12:25 ` [Xen-devel] " Julien Grall
2017-03-08 12:25 ` Julien Grall
2017-03-08 19:08 ` [Xen-devel] " Stefano Stabellini
2017-03-08 19:08 ` Stefano Stabellini
2017-03-06 20:01 ` [PATCH 5/7] xen/9pfs: send requests " Stefano Stabellini
2017-03-06 20:01 ` Stefano Stabellini
2017-03-07 15:27 ` Boris Ostrovsky
2017-03-07 15:27 ` Boris Ostrovsky
2017-03-08 0:55 ` Stefano Stabellini
2017-03-08 0:55 ` Stefano Stabellini
2017-03-08 13:58 ` Boris Ostrovsky
2017-03-08 13:58 ` Boris Ostrovsky
2017-03-08 19:33 ` Stefano Stabellini
2017-03-08 19:33 ` Stefano Stabellini
2017-03-08 20:02 ` Boris Ostrovsky
2017-03-08 20:02 ` Boris Ostrovsky
2017-03-08 20:56 ` Stefano Stabellini
2017-03-08 20:56 ` Stefano Stabellini
2017-03-08 21:01 ` Boris Ostrovsky
2017-03-08 21:01 ` Boris Ostrovsky
2017-03-06 20:01 ` [PATCH 6/7] xen/9pfs: receive responses Stefano Stabellini
2017-03-06 20:01 ` Stefano Stabellini
2017-03-07 15:49 ` Boris Ostrovsky
2017-03-07 15:49 ` Boris Ostrovsky
2017-03-08 1:06 ` Stefano Stabellini
2017-03-08 1:06 ` Stefano Stabellini
2017-03-08 1:13 ` Stefano Stabellini
2017-03-08 1:13 ` Stefano Stabellini
2017-03-08 20:11 ` Konrad Rzeszutek Wilk
2017-03-08 20:11 ` [Xen-devel] " Konrad Rzeszutek Wilk
2017-03-08 14:33 ` Boris Ostrovsky
2017-03-08 14:33 ` Boris Ostrovsky
2017-03-08 19:26 ` Stefano Stabellini
2017-03-08 19:26 ` Stefano Stabellini
2017-03-06 20:01 ` [PATCH 7/7] xen/9pfs: build 9pfs Xen transport driver Stefano Stabellini
2017-03-06 20:01 ` Stefano Stabellini
2017-03-07 17:15 ` [Xen-devel] [PATCH 1/7] xen: import new ring macros in ring.h Julien Grall
2017-03-07 17:15 ` Julien Grall
2017-03-08 0:12 ` [Xen-devel] " Stefano Stabellini
2017-03-08 0:12 ` Stefano Stabellini
2017-03-08 11:14 ` Julien Grall [this message]
2017-03-08 11:14 ` Julien Grall
2017-03-07 16:38 ` [Xen-devel] [PATCH 0/7] Xen transport for 9pfs frontend driver Roger Pau Monné
2017-03-07 16:38 ` Roger Pau Monné
2017-03-07 18:27 ` [Xen-devel] " Stefano Stabellini
2017-03-07 18:27 ` Stefano Stabellini
2017-03-09 3:02 ` [Xen-devel] " Roger Pau Monné
2017-03-09 3:02 ` Roger Pau Monné
2017-03-13 22:36 ` Stefano Stabellini
2017-03-13 22:36 ` [Xen-devel] " Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc2fed14-c454-8801-a2a9-42f995f6b673@arm.com \
--to=julien.grall@arm.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.