From: Boris Ostrovsky <boris.ostrovsky@oracle.com> To: Stefano Stabellini <sstabellini@kernel.org> Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Stefano Stabellini <stefano@aporeto.com>, konrad.wilk@oracle.com, jgross@suse.com Subject: Re: [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol Date: Mon, 6 Mar 2017 16:42:13 -0500 [thread overview] Message-ID: <3c6439e1-5331-d7dc-92e8-6665942dfd6d@oracle.com> (raw) In-Reply-To: <alpine.DEB.2.10.1703061334520.17906@sstabellini-ThinkPad-X260> On 03/06/2017 04:36 PM, Stefano Stabellini wrote: > On Mon, 6 Mar 2017, Boris Ostrovsky wrote: >>> + uint32_t size; >>> + uint8_t id; >>> + uint16_t tag; >> I realize that this is in the spec now and it's probably too late to ask >> this question but wouldn't it be better if id and tag were swapped? No >> need to pack and potentially faster access to tag. > I cannot do anything about it: that struct is defined by the 9pfs > specification (not the Xen spec, the general 9pfs spec). See: Oh, I thought it was Xen-specific (because it's described in 9pfs.markdown). Nevermind then. -boris > > https://www.usenix.org/legacy/event/usenix05/tech/freenix/full_papers/hensbergen/hensbergen.pdf > >>> +} __attribute__((packed)); >>> + >>> +#define XEN_9PFS_RING_ORDER 6 >>> +#define XEN_9PFS_RING_SIZE XEN_FLEX_RING_SIZE(XEN_9PFS_RING_ORDER) >>> +DEFINE_XEN_FLEX_RING_AND_INTF(xen_9pfs); >>> + >>> +#endif
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com> To: Stefano Stabellini <sstabellini@kernel.org> Cc: Stefano Stabellini <stefano@aporeto.com>, xen-devel@lists.xenproject.org, jgross@suse.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol Date: Mon, 6 Mar 2017 16:42:13 -0500 [thread overview] Message-ID: <3c6439e1-5331-d7dc-92e8-6665942dfd6d@oracle.com> (raw) In-Reply-To: <alpine.DEB.2.10.1703061334520.17906@sstabellini-ThinkPad-X260> On 03/06/2017 04:36 PM, Stefano Stabellini wrote: > On Mon, 6 Mar 2017, Boris Ostrovsky wrote: >>> + uint32_t size; >>> + uint8_t id; >>> + uint16_t tag; >> I realize that this is in the spec now and it's probably too late to ask >> this question but wouldn't it be better if id and tag were swapped? No >> need to pack and potentially faster access to tag. > I cannot do anything about it: that struct is defined by the 9pfs > specification (not the Xen spec, the general 9pfs spec). See: Oh, I thought it was Xen-specific (because it's described in 9pfs.markdown). Nevermind then. -boris > > https://www.usenix.org/legacy/event/usenix05/tech/freenix/full_papers/hensbergen/hensbergen.pdf > >>> +} __attribute__((packed)); >>> + >>> +#define XEN_9PFS_RING_ORDER 6 >>> +#define XEN_9PFS_RING_SIZE XEN_FLEX_RING_SIZE(XEN_9PFS_RING_ORDER) >>> +DEFINE_XEN_FLEX_RING_AND_INTF(xen_9pfs); >>> + >>> +#endif _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-06 21:41 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-06 20:00 [PATCH 0/7] Xen transport for 9pfs frontend driver Stefano Stabellini 2017-03-06 20:01 ` [PATCH 1/7] xen: import new ring macros in ring.h Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-06 20:01 ` [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-06 21:22 ` Boris Ostrovsky 2017-03-06 21:22 ` Boris Ostrovsky 2017-03-06 21:36 ` Stefano Stabellini 2017-03-06 21:36 ` Stefano Stabellini 2017-03-06 21:42 ` Boris Ostrovsky [this message] 2017-03-06 21:42 ` Boris Ostrovsky 2017-03-06 20:01 ` [PATCH 3/7] xen/9pfs: introduce Xen 9pfs transport driver Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-06 20:01 ` [PATCH 4/7] xen/9pfs: connect to the backend Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-07 15:03 ` Boris Ostrovsky 2017-03-07 15:03 ` Boris Ostrovsky 2017-03-08 0:11 ` Stefano Stabellini 2017-03-08 0:11 ` Stefano Stabellini 2017-03-08 13:47 ` Boris Ostrovsky 2017-03-08 13:47 ` Boris Ostrovsky 2017-03-08 19:22 ` Stefano Stabellini 2017-03-08 19:22 ` Stefano Stabellini 2017-03-07 17:37 ` [Xen-devel] " Julien Grall 2017-03-07 17:37 ` Julien Grall 2017-03-08 0:49 ` [Xen-devel] " Stefano Stabellini 2017-03-08 0:49 ` Stefano Stabellini 2017-03-08 12:25 ` [Xen-devel] " Julien Grall 2017-03-08 12:25 ` Julien Grall 2017-03-08 19:08 ` [Xen-devel] " Stefano Stabellini 2017-03-08 19:08 ` Stefano Stabellini 2017-03-06 20:01 ` [PATCH 5/7] xen/9pfs: send requests " Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-07 15:27 ` Boris Ostrovsky 2017-03-07 15:27 ` Boris Ostrovsky 2017-03-08 0:55 ` Stefano Stabellini 2017-03-08 0:55 ` Stefano Stabellini 2017-03-08 13:58 ` Boris Ostrovsky 2017-03-08 13:58 ` Boris Ostrovsky 2017-03-08 19:33 ` Stefano Stabellini 2017-03-08 19:33 ` Stefano Stabellini 2017-03-08 20:02 ` Boris Ostrovsky 2017-03-08 20:02 ` Boris Ostrovsky 2017-03-08 20:56 ` Stefano Stabellini 2017-03-08 20:56 ` Stefano Stabellini 2017-03-08 21:01 ` Boris Ostrovsky 2017-03-08 21:01 ` Boris Ostrovsky 2017-03-06 20:01 ` [PATCH 6/7] xen/9pfs: receive responses Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-07 15:49 ` Boris Ostrovsky 2017-03-07 15:49 ` Boris Ostrovsky 2017-03-08 1:06 ` Stefano Stabellini 2017-03-08 1:06 ` Stefano Stabellini 2017-03-08 1:13 ` Stefano Stabellini 2017-03-08 1:13 ` Stefano Stabellini 2017-03-08 20:11 ` Konrad Rzeszutek Wilk 2017-03-08 20:11 ` [Xen-devel] " Konrad Rzeszutek Wilk 2017-03-08 14:33 ` Boris Ostrovsky 2017-03-08 14:33 ` Boris Ostrovsky 2017-03-08 19:26 ` Stefano Stabellini 2017-03-08 19:26 ` Stefano Stabellini 2017-03-06 20:01 ` [PATCH 7/7] xen/9pfs: build 9pfs Xen transport driver Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-07 17:15 ` [Xen-devel] [PATCH 1/7] xen: import new ring macros in ring.h Julien Grall 2017-03-07 17:15 ` Julien Grall 2017-03-08 0:12 ` [Xen-devel] " Stefano Stabellini 2017-03-08 0:12 ` Stefano Stabellini 2017-03-08 11:14 ` [Xen-devel] " Julien Grall 2017-03-08 11:14 ` Julien Grall 2017-03-07 16:38 ` [Xen-devel] [PATCH 0/7] Xen transport for 9pfs frontend driver Roger Pau Monné 2017-03-07 16:38 ` Roger Pau Monné 2017-03-07 18:27 ` [Xen-devel] " Stefano Stabellini 2017-03-07 18:27 ` Stefano Stabellini 2017-03-09 3:02 ` [Xen-devel] " Roger Pau Monné 2017-03-09 3:02 ` Roger Pau Monné 2017-03-13 22:36 ` Stefano Stabellini 2017-03-13 22:36 ` [Xen-devel] " Stefano Stabellini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3c6439e1-5331-d7dc-92e8-6665942dfd6d@oracle.com \ --to=boris.ostrovsky@oracle.com \ --cc=jgross@suse.com \ --cc=konrad.wilk@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=sstabellini@kernel.org \ --cc=stefano@aporeto.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.