* [PATCH 00/21] liblockdep fixes for v4.12
@ 2017-05-25 12:51 Levin, Alexander (Sasha Levin)
2017-05-25 12:51 ` [PATCH 01/21] liblockdep: Fix undefined symbol prandom_u32 Levin, Alexander (Sasha Levin)
0 siblings, 1 reply; 8+ messages in thread
From: Levin, Alexander (Sasha Levin) @ 2017-05-25 12:51 UTC (permalink / raw)
To: mingo
Cc: linux-kernel, ben, a.p.zijlstra, tglx, Levin, Alexander (Sasha Levin)
The following changes since commit 56fff1bb0f31358bf81a3c64a8dcd6da0dc44263:
Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux (2017-05-23 09:57:39 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes
for you to fetch changes up to 9e6d473e27d81ed1d0e3849d2ef9f35a94a64cd5:
tools: liblockdep: hide liblockdep output from test results (2017-05-25 08:27:54 -0400)
----------------------------------------------------------------
Alexander Sverdlin (2):
tools: add install make target for liblockdep
tools: liblockdep: Don't mix fd-based and stream IO
Ben Hutchings (10):
liblockdep: Fix undefined symbol prandom_u32
liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain::depth
liblockdep: Define the ARRAY_SIZE() macro
liblockdep: Enable -Wall by default
liblockdep: Fix 'unused value' warnings
liblockdep: Fix 'set but not used' warnings
liblockdep: Fix 'defined but not used' warning for init_utsname()
tools: liblockdep: Fix object file paths used in an out-of-tree build
tools: liblockdep: Remove double-quotes from soname
tools: liblockdep: Use LDFLAGS
Sasha Levin (8):
MAINTAINERS: update email for Sasha Levin
tools: liblockdep: fix compilation for 4.11
tools include: add empty include/linux/sched/mm.h
tools: liblockdep: include err.h
tools: liblockdep: add empty __is_[module,kernel]_percpu_address
tools include: add IS_ERR_OR_NULL to err.h
tools: liblockdep: add dummy current_gfp_context()
tools: liblockdep: hide liblockdep output from test results
Vishal Thanki (1):
liblockdep: Remove -lpthread compiler option
MAINTAINERS | 2 +-
tools/Makefile | 8 +++--
tools/include/linux/bitops.h | 10 ++++++
tools/include/linux/err.h | 5 +++
tools/include/linux/jhash.h | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tools/include/linux/sched/clock.h | 0
tools/include/linux/sched/mm.h | 0
tools/include/linux/sched/task.h | 0
tools/include/linux/unaligned/packed_struct.h | 46 +++++++++++++++++++++++++++
tools/lib/lockdep/Makefile | 9 +++---
tools/lib/lockdep/lockdep.c | 17 ++++++++++
tools/lib/lockdep/preload.c | 3 +-
tools/lib/lockdep/run_tests.sh | 8 ++---
tools/lib/lockdep/uinclude/linux/bitops.h | 3 --
tools/lib/lockdep/uinclude/linux/compiler.h | 2 ++
tools/lib/lockdep/uinclude/linux/debug_locks.h | 2 +-
tools/lib/lockdep/uinclude/linux/irqflags.h | 8 ++---
tools/lib/lockdep/uinclude/linux/kallsyms.h | 3 +-
tools/lib/lockdep/uinclude/linux/kernel.h | 20 ++++++++++--
tools/lib/lockdep/uinclude/linux/lockdep.h | 26 ++++++++--------
tools/lib/lockdep/uinclude/linux/module.h | 5 +++
tools/lib/lockdep/uinclude/linux/rcu.h | 2 ++
22 files changed, 317 insertions(+), 37 deletions(-)
create mode 100644 tools/include/linux/jhash.h
create mode 100644 tools/include/linux/sched/clock.h
create mode 100644 tools/include/linux/sched/mm.h
create mode 100644 tools/include/linux/sched/task.h
create mode 100644 tools/include/linux/unaligned/packed_struct.h
delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h
Alexander Sverdlin (2):
tools: add install make target for liblockdep
tools: liblockdep: Don't mix fd-based and stream IO
Ben Hutchings (10):
liblockdep: Fix undefined symbol prandom_u32
liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing
lock_chain::depth
liblockdep: Define the ARRAY_SIZE() macro
liblockdep: Enable -Wall by default
liblockdep: Fix 'unused value' warnings
liblockdep: Fix 'set but not used' warnings
liblockdep: Fix 'defined but not used' warning for init_utsname()
tools: liblockdep: Fix object file paths used in an out-of-tree build
tools: liblockdep: Remove double-quotes from soname
tools: liblockdep: Use LDFLAGS
Sasha Levin (8):
MAINTAINERS: update email for Sasha Levin
tools: liblockdep: fix compilation for 4.11
tools include: add empty include/linux/sched/mm.h
tools: liblockdep: include err.h
tools: liblockdep: add empty __is_[module,kernel]_percpu_address
tools include: add IS_ERR_OR_NULL to err.h
tools: liblockdep: add dummy current_gfp_context()
tools: liblockdep: hide liblockdep output from test results
Vishal Thanki (1):
liblockdep: Remove -lpthread compiler option
MAINTAINERS | 2 +-
tools/Makefile | 8 +-
tools/include/linux/bitops.h | 10 ++
tools/include/linux/err.h | 5 +
tools/include/linux/jhash.h | 175 +++++++++++++++++++++++++
tools/include/linux/sched/clock.h | 0
tools/include/linux/sched/mm.h | 0
tools/include/linux/sched/task.h | 0
tools/include/linux/unaligned/packed_struct.h | 46 +++++++
tools/lib/lockdep/Makefile | 9 +-
tools/lib/lockdep/lockdep.c | 17 +++
tools/lib/lockdep/preload.c | 3 +-
tools/lib/lockdep/run_tests.sh | 8 +-
tools/lib/lockdep/uinclude/linux/bitops.h | 3 -
tools/lib/lockdep/uinclude/linux/compiler.h | 2 +
tools/lib/lockdep/uinclude/linux/debug_locks.h | 2 +-
tools/lib/lockdep/uinclude/linux/irqflags.h | 8 +-
tools/lib/lockdep/uinclude/linux/kallsyms.h | 3 +-
tools/lib/lockdep/uinclude/linux/kernel.h | 20 ++-
tools/lib/lockdep/uinclude/linux/lockdep.h | 26 ++--
tools/lib/lockdep/uinclude/linux/module.h | 5 +
tools/lib/lockdep/uinclude/linux/rcu.h | 2 +
22 files changed, 317 insertions(+), 37 deletions(-)
create mode 100644 tools/include/linux/jhash.h
create mode 100644 tools/include/linux/sched/clock.h
create mode 100644 tools/include/linux/sched/mm.h
create mode 100644 tools/include/linux/sched/task.h
create mode 100644 tools/include/linux/unaligned/packed_struct.h
delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h
--
2.11.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 01/21] liblockdep: Fix undefined symbol prandom_u32
2017-05-25 12:51 [PATCH 00/21] liblockdep fixes for v4.12 Levin, Alexander (Sasha Levin)
@ 2017-05-25 12:51 ` Levin, Alexander (Sasha Levin)
0 siblings, 0 replies; 8+ messages in thread
From: Levin, Alexander (Sasha Levin) @ 2017-05-25 12:51 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel, ben, a.p.zijlstra, tglx, Sasha Levin
From: Ben Hutchings <ben@decadent.org.uk>
__lock_pin_lock() now calls prandom_u32() which is not defined in
liblockdep. __lock_pin_lock() and its caller lock_pin_lock() are dead
code in liblockdep, but we still need to provide a definition of
prandom_u32() in case lazy binding is disabled.
Fixes: e7904a28f533 ("locking/lockdep, sched/core: Implement a better ...")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
tools/lib/lockdep/lockdep.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/lib/lockdep/lockdep.c b/tools/lib/lockdep/lockdep.c
index a0a2e3a266af..443acb11f907 100644
--- a/tools/lib/lockdep/lockdep.c
+++ b/tools/lib/lockdep/lockdep.c
@@ -1,8 +1,15 @@
#include <linux/lockdep.h>
+#include <stdlib.h>
/* Trivial API wrappers, we don't (yet) have RCU in user-space: */
#define hlist_for_each_entry_rcu hlist_for_each_entry
#define hlist_add_head_rcu hlist_add_head
#define hlist_del_rcu hlist_del
+u32 prandom_u32(void)
+{
+ /* Used only by lock_pin_lock() which is dead code */
+ abort();
+}
+
#include "../../../kernel/locking/lockdep.c"
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 00/21] liblockdep fixes for v4.12
@ 2017-05-25 12:58 Levin, Alexander (Sasha Levin)
2017-05-26 6:52 ` Ingo Molnar
0 siblings, 1 reply; 8+ messages in thread
From: Levin, Alexander (Sasha Levin) @ 2017-05-25 12:58 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel, ben, a.p.zijlstra, tglx
The following changes since commit 56fff1bb0f31358bf81a3c64a8dcd6da0dc44263:
Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux (2017-05-23 09:57:39 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes
for you to fetch changes up to 9e6d473e27d81ed1d0e3849d2ef9f35a94a64cd5:
tools: liblockdep: hide liblockdep output from test results (2017-05-25 08:27:54 -0400)
----------------------------------------------------------------
Alexander Sverdlin (2):
tools: add install make target for liblockdep
tools: liblockdep: Don't mix fd-based and stream IO
Ben Hutchings (10):
liblockdep: Fix undefined symbol prandom_u32
liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain::depth
liblockdep: Define the ARRAY_SIZE() macro
liblockdep: Enable -Wall by default
liblockdep: Fix 'unused value' warnings
liblockdep: Fix 'set but not used' warnings
liblockdep: Fix 'defined but not used' warning for init_utsname()
tools: liblockdep: Fix object file paths used in an out-of-tree build
tools: liblockdep: Remove double-quotes from soname
tools: liblockdep: Use LDFLAGS
Sasha Levin (8):
MAINTAINERS: update email for Sasha Levin
tools: liblockdep: fix compilation for 4.11
tools include: add empty include/linux/sched/mm.h
tools: liblockdep: include err.h
tools: liblockdep: add empty __is_[module,kernel]_percpu_address
tools include: add IS_ERR_OR_NULL to err.h
tools: liblockdep: add dummy current_gfp_context()
tools: liblockdep: hide liblockdep output from test results
Vishal Thanki (1):
liblockdep: Remove -lpthread compiler option
MAINTAINERS | 2 +-
tools/Makefile | 8 +++--
tools/include/linux/bitops.h | 10 ++++++
tools/include/linux/err.h | 5 +++
tools/include/linux/jhash.h | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tools/include/linux/sched/clock.h | 0
tools/include/linux/sched/mm.h | 0
tools/include/linux/sched/task.h | 0
tools/include/linux/unaligned/packed_struct.h | 46 +++++++++++++++++++++++++++
tools/lib/lockdep/Makefile | 9 +++---
tools/lib/lockdep/lockdep.c | 17 ++++++++++
tools/lib/lockdep/preload.c | 3 +-
tools/lib/lockdep/run_tests.sh | 8 ++---
tools/lib/lockdep/uinclude/linux/bitops.h | 3 --
tools/lib/lockdep/uinclude/linux/compiler.h | 2 ++
tools/lib/lockdep/uinclude/linux/debug_locks.h | 2 +-
tools/lib/lockdep/uinclude/linux/irqflags.h | 8 ++---
tools/lib/lockdep/uinclude/linux/kallsyms.h | 3 +-
tools/lib/lockdep/uinclude/linux/kernel.h | 20 ++++++++++--
tools/lib/lockdep/uinclude/linux/lockdep.h | 26 ++++++++--------
tools/lib/lockdep/uinclude/linux/module.h | 5 +++
tools/lib/lockdep/uinclude/linux/rcu.h | 2 ++
22 files changed, 317 insertions(+), 37 deletions(-)
create mode 100644 tools/include/linux/jhash.h
create mode 100644 tools/include/linux/sched/clock.h
create mode 100644 tools/include/linux/sched/mm.h
create mode 100644 tools/include/linux/sched/task.h
create mode 100644 tools/include/linux/unaligned/packed_struct.h
delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h
Alexander Sverdlin (2):
tools: add install make target for liblockdep
tools: liblockdep: Don't mix fd-based and stream IO
Ben Hutchings (10):
liblockdep: Fix undefined symbol prandom_u32
liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing
lock_chain::depth
liblockdep: Define the ARRAY_SIZE() macro
liblockdep: Enable -Wall by default
liblockdep: Fix 'unused value' warnings
liblockdep: Fix 'set but not used' warnings
liblockdep: Fix 'defined but not used' warning for init_utsname()
tools: liblockdep: Fix object file paths used in an out-of-tree build
tools: liblockdep: Remove double-quotes from soname
tools: liblockdep: Use LDFLAGS
Sasha Levin (8):
MAINTAINERS: update email for Sasha Levin
tools: liblockdep: fix compilation for 4.11
tools include: add empty include/linux/sched/mm.h
tools: liblockdep: include err.h
tools: liblockdep: add empty __is_[module,kernel]_percpu_address
tools include: add IS_ERR_OR_NULL to err.h
tools: liblockdep: add dummy current_gfp_context()
tools: liblockdep: hide liblockdep output from test results
Vishal Thanki (1):
liblockdep: Remove -lpthread compiler option
MAINTAINERS | 2 +-
tools/Makefile | 8 +-
tools/include/linux/bitops.h | 10 ++
tools/include/linux/err.h | 5 +
tools/include/linux/jhash.h | 175 +++++++++++++++++++++++++
tools/include/linux/sched/clock.h | 0
tools/include/linux/sched/mm.h | 0
tools/include/linux/sched/task.h | 0
tools/include/linux/unaligned/packed_struct.h | 46 +++++++
tools/lib/lockdep/Makefile | 9 +-
tools/lib/lockdep/lockdep.c | 17 +++
tools/lib/lockdep/preload.c | 3 +-
tools/lib/lockdep/run_tests.sh | 8 +-
tools/lib/lockdep/uinclude/linux/bitops.h | 3 -
tools/lib/lockdep/uinclude/linux/compiler.h | 2 +
tools/lib/lockdep/uinclude/linux/debug_locks.h | 2 +-
tools/lib/lockdep/uinclude/linux/irqflags.h | 8 +-
tools/lib/lockdep/uinclude/linux/kallsyms.h | 3 +-
tools/lib/lockdep/uinclude/linux/kernel.h | 20 ++-
tools/lib/lockdep/uinclude/linux/lockdep.h | 26 ++--
tools/lib/lockdep/uinclude/linux/module.h | 5 +
tools/lib/lockdep/uinclude/linux/rcu.h | 2 +
22 files changed, 317 insertions(+), 37 deletions(-)
create mode 100644 tools/include/linux/jhash.h
create mode 100644 tools/include/linux/sched/clock.h
create mode 100644 tools/include/linux/sched/mm.h
create mode 100644 tools/include/linux/sched/task.h
create mode 100644 tools/include/linux/unaligned/packed_struct.h
delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h
--
2.11.0
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 00/21] liblockdep fixes for v4.12
2017-05-25 12:58 [PATCH 00/21] liblockdep fixes for v4.12 Levin, Alexander (Sasha Levin)
@ 2017-05-26 6:52 ` Ingo Molnar
2017-05-26 10:57 ` Levin, Alexander (Sasha Levin)
0 siblings, 1 reply; 8+ messages in thread
From: Ingo Molnar @ 2017-05-26 6:52 UTC (permalink / raw)
To: Levin, Alexander (Sasha Levin); +Cc: linux-kernel, ben, a.p.zijlstra, tglx
* Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:
> MAINTAINERS | 2 +-
> tools/Makefile | 8 +++--
> tools/include/linux/bitops.h | 10 ++++++
> tools/include/linux/err.h | 5 +++
> tools/include/linux/jhash.h | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> tools/include/linux/sched/clock.h | 0
> tools/include/linux/sched/mm.h | 0
> tools/include/linux/sched/task.h | 0
> tools/include/linux/unaligned/packed_struct.h | 46 +++++++++++++++++++++++++++
> tools/lib/lockdep/Makefile | 9 +++---
> tools/lib/lockdep/lockdep.c | 17 ++++++++++
> tools/lib/lockdep/preload.c | 3 +-
> tools/lib/lockdep/run_tests.sh | 8 ++---
> tools/lib/lockdep/uinclude/linux/bitops.h | 3 --
> tools/lib/lockdep/uinclude/linux/compiler.h | 2 ++
> tools/lib/lockdep/uinclude/linux/debug_locks.h | 2 +-
> tools/lib/lockdep/uinclude/linux/irqflags.h | 8 ++---
> tools/lib/lockdep/uinclude/linux/kallsyms.h | 3 +-
> tools/lib/lockdep/uinclude/linux/kernel.h | 20 ++++++++++--
> tools/lib/lockdep/uinclude/linux/lockdep.h | 26 ++++++++--------
> tools/lib/lockdep/uinclude/linux/module.h | 5 +++
> tools/lib/lockdep/uinclude/linux/rcu.h | 2 ++
> 22 files changed, 317 insertions(+), 37 deletions(-)
> create mode 100644 tools/include/linux/jhash.h
> create mode 100644 tools/include/linux/sched/clock.h
> create mode 100644 tools/include/linux/sched/mm.h
> create mode 100644 tools/include/linux/sched/task.h
> create mode 100644 tools/include/linux/unaligned/packed_struct.h
> delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h
Yeah, so what needs to be fixed as well is for liblockdep to exclusively use
tools/include/ (and extend those headers where required).
perf already uses that method and it works well.
liblockdep already uses tools/include/ in part, but even after I apply all your
patches, there's still lib/lockdep/uinclude/ which appears to duplicate a number
of headers.
I did a quick check - for example WARN_ON() et al is duplicated in
tools/lib/lockdep/uinclude/linux/kernel.h.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/21] liblockdep fixes for v4.12
2017-05-26 6:52 ` Ingo Molnar
@ 2017-05-26 10:57 ` Levin, Alexander (Sasha Levin)
2017-05-26 11:21 ` Ingo Molnar
0 siblings, 1 reply; 8+ messages in thread
From: Levin, Alexander (Sasha Levin) @ 2017-05-26 10:57 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, ben, a.p.zijlstra, tglx
On Fri, May 26, 2017 at 08:52:52AM +0200, Ingo Molnar wrote:
>
> * Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:
>
> > MAINTAINERS | 2 +-
> > tools/Makefile | 8 +++--
> > tools/include/linux/bitops.h | 10 ++++++
> > tools/include/linux/err.h | 5 +++
> > tools/include/linux/jhash.h | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > tools/include/linux/sched/clock.h | 0
> > tools/include/linux/sched/mm.h | 0
> > tools/include/linux/sched/task.h | 0
> > tools/include/linux/unaligned/packed_struct.h | 46 +++++++++++++++++++++++++++
> > tools/lib/lockdep/Makefile | 9 +++---
> > tools/lib/lockdep/lockdep.c | 17 ++++++++++
> > tools/lib/lockdep/preload.c | 3 +-
> > tools/lib/lockdep/run_tests.sh | 8 ++---
> > tools/lib/lockdep/uinclude/linux/bitops.h | 3 --
> > tools/lib/lockdep/uinclude/linux/compiler.h | 2 ++
> > tools/lib/lockdep/uinclude/linux/debug_locks.h | 2 +-
> > tools/lib/lockdep/uinclude/linux/irqflags.h | 8 ++---
> > tools/lib/lockdep/uinclude/linux/kallsyms.h | 3 +-
> > tools/lib/lockdep/uinclude/linux/kernel.h | 20 ++++++++++--
> > tools/lib/lockdep/uinclude/linux/lockdep.h | 26 ++++++++--------
> > tools/lib/lockdep/uinclude/linux/module.h | 5 +++
> > tools/lib/lockdep/uinclude/linux/rcu.h | 2 ++
> > 22 files changed, 317 insertions(+), 37 deletions(-)
> > create mode 100644 tools/include/linux/jhash.h
> > create mode 100644 tools/include/linux/sched/clock.h
> > create mode 100644 tools/include/linux/sched/mm.h
> > create mode 100644 tools/include/linux/sched/task.h
> > create mode 100644 tools/include/linux/unaligned/packed_struct.h
> > delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h
>
> Yeah, so what needs to be fixed as well is for liblockdep to exclusively use
> tools/include/ (and extend those headers where required).
>
> perf already uses that method and it works well.
>
> liblockdep already uses tools/include/ in part, but even after I apply all your
> patches, there's still lib/lockdep/uinclude/ which appears to duplicate a number
> of headers.
>
> I did a quick check - for example WARN_ON() et al is duplicated in
> tools/lib/lockdep/uinclude/linux/kernel.h.
Right, and as you can see from this patchset where we added to
tools/include/ when needed and removed from lib/lockdep/uinclude,
liblockdep is slowly creeping the "right" way.
perf, like liblockdep, didn't finish the switch to exclusively use
tools/include/ yet.
I can put more work into getting it done over the next few releases,
but it's not something I see as a critical fix for the upcoming
release.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/21] liblockdep fixes for v4.12
2017-05-26 10:57 ` Levin, Alexander (Sasha Levin)
@ 2017-05-26 11:21 ` Ingo Molnar
2017-05-26 11:41 ` Levin, Alexander (Sasha Levin)
0 siblings, 1 reply; 8+ messages in thread
From: Ingo Molnar @ 2017-05-26 11:21 UTC (permalink / raw)
To: Levin, Alexander (Sasha Levin); +Cc: linux-kernel, ben, a.p.zijlstra, tglx
* Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:
> Right, and as you can see from this patchset where we added to
> tools/include/ when needed and removed from lib/lockdep/uinclude,
> liblockdep is slowly creeping the "right" way.
>
> perf, like liblockdep, didn't finish the switch to exclusively use
> tools/include/ yet.
>
> I can put more work into getting it done over the next few releases,
> but it's not something I see as a critical fix for the upcoming
> release.
Since liblockdep was broken for an extended period of time I'd really
like to see this fixed before I apply any more patches.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/21] liblockdep fixes for v4.12
2017-05-26 11:21 ` Ingo Molnar
@ 2017-05-26 11:41 ` Levin, Alexander (Sasha Levin)
2017-05-28 9:11 ` Ingo Molnar
0 siblings, 1 reply; 8+ messages in thread
From: Levin, Alexander (Sasha Levin) @ 2017-05-26 11:41 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, ben, a.p.zijlstra, tglx
On Fri, May 26, 2017 at 01:21:51PM +0200, Ingo Molnar wrote:
>
> * Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:
>
> > Right, and as you can see from this patchset where we added to
> > tools/include/ when needed and removed from lib/lockdep/uinclude,
> > liblockdep is slowly creeping the "right" way.
> >
> > perf, like liblockdep, didn't finish the switch to exclusively use
> > tools/include/ yet.
> >
> > I can put more work into getting it done over the next few releases,
> > but it's not something I see as a critical fix for the upcoming
> > release.
>
> Since liblockdep was broken for an extended period of time I'd really
> like to see this fixed before I apply any more patches.
What does the build breakage has to do with converting the way we
use headers? There's no broken functionality as far as I can tell,
so why is the header thing defined as a "fix" to begin with?
I also don't see a single tools/ project to exclusively use tools/include
at this point.
Would you rather keep liblockdep broken for the next couple of months
until this is sorted? I really doubt I could get something (+ enough
time to soak in -next) for v4.13, so we're looking at v4.14 at the
earliest.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/21] liblockdep fixes for v4.12
2017-05-26 11:41 ` Levin, Alexander (Sasha Levin)
@ 2017-05-28 9:11 ` Ingo Molnar
0 siblings, 0 replies; 8+ messages in thread
From: Ingo Molnar @ 2017-05-28 9:11 UTC (permalink / raw)
To: Levin, Alexander (Sasha Levin); +Cc: linux-kernel, ben, a.p.zijlstra, tglx
* Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:
> On Fri, May 26, 2017 at 01:21:51PM +0200, Ingo Molnar wrote:
> >
> > * Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:
> >
> > > Right, and as you can see from this patchset where we added to
> > > tools/include/ when needed and removed from lib/lockdep/uinclude,
> > > liblockdep is slowly creeping the "right" way.
> > >
> > > perf, like liblockdep, didn't finish the switch to exclusively use
> > > tools/include/ yet.
> > >
> > > I can put more work into getting it done over the next few releases,
> > > but it's not something I see as a critical fix for the upcoming
> > > release.
> >
> > Since liblockdep was broken for an extended period of time I'd really
> > like to see this fixed before I apply any more patches.
>
> What does the build breakage has to do with converting the way we use headers?
> There's no broken functionality as far as I can tell, so why is the header thing
> defined as a "fix" to begin with?
liblockdep was essentially build-broken for almost a year.
I worry about and question liblockdep's general maintainability and as a
maintainer of lockdep I can see only two options going forward: either it's
cleaned up for good (going beyond what is needed to fix the build failures and
warnings), or we remove it (with the option of reintroducing it if/when it's clean
enough).
I.e. the quality bar has increased.
> I also don't see a single tools/ project to exclusively use tools/include at
> this point.
>
> Would you rather keep liblockdep broken for the next couple of months until this
> is sorted? I really doubt I could get something (+ enough time to soak in -next)
> for v4.13, so we're looking at v4.14 at the earliest.
No, if it does not improve then I'd rather remove it, and re-add it at a later
date if/when it's clean enough.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-05-28 9:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-25 12:51 [PATCH 00/21] liblockdep fixes for v4.12 Levin, Alexander (Sasha Levin)
2017-05-25 12:51 ` [PATCH 01/21] liblockdep: Fix undefined symbol prandom_u32 Levin, Alexander (Sasha Levin)
2017-05-25 12:58 [PATCH 00/21] liblockdep fixes for v4.12 Levin, Alexander (Sasha Levin)
2017-05-26 6:52 ` Ingo Molnar
2017-05-26 10:57 ` Levin, Alexander (Sasha Levin)
2017-05-26 11:21 ` Ingo Molnar
2017-05-26 11:41 ` Levin, Alexander (Sasha Levin)
2017-05-28 9:11 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.