[Qemu-devel] [PATCH 00/47] add missing entries in MAINTAINERS

[Qemu-devel] [PATCH 00/47] add missing entries in MAINTAINERS

[Philippe Mathieu-Daudé]

Hi,

I first prepared this series thinking about 2.10 but then realized if someone
is calling ./scripts/get_maintainer.pl he better is using an updated git
clone :)

Distribs do provide docs/ files in /usr/share/doc/qemu* but not the
MAINTAINERS file so no hurry for this series.

I provided the script I used in the last patch, I plan to improve it so
patchew/travis can start to use it: if a new file is added to the repository
without being covered in MAINTAINERS the script remember the submitter about
it and eventually he'll resend his patch, I think this is a good practice and
help the next contributors (anyway this is a valuable experience to look at a
file history to see who has been hacking around when there is no MAINTAINERS
entry).

I don't want to overburden current maintainers, so the last patches add
Orphans entries but I tried to select relevant commiters and include them in
each patch.

The criteria I used is "If I change this file, who should I notify? Who would
be interested?"

Regards,

Phil.

Philippe Mathieu-Daudé (47):
  MAINTAINERS: add missing entry for documentation
  MAINTAINERS: add missing ARM entries
  MAINTAINERS: add missing STM32 entry
  MAINTAINERS: add missing USB entry
  MAINTAINERS: add missing KVM entry
  MAINTAINERS: add missing entry for vhost
  MAINTAINERS: add missing entry for vfio/ccw
  MAINTAINERS: add missing entry for virtio
  MAINTAINERS: add missing entry for virtio/9p
  MAINTAINERS: add missing entry for virtio/blk
  MAINTAINERS: add missing entry for virtio/ccw
  MAINTAINERS: add missing entry for virtio/input
  MAINTAINERS: add missing entry for virtio/rng
  MAINTAINERS: add missing entry for virtio/crypto
  MAINTAINERS: add missing VMWare entry
  MAINTAINERS: add missing entry for gdb
  MAINTAINERS: add missing guest-agent entries
  MAINTAINERS: add missing TCG entry
  MAINTAINERS: add missing qcow2 entry
  MAINTAINERS: add missing PCI entries
  MAINTAINERS: add missing CRIS entry
  MAINTAINERS: add missing M68k entry
  MAINTAINERS: add missing LM32 entry
  MAINTAINERS: add missing MicroBlaze entry
  MAINTAINERS: add missing MIPS entry
  MAINTAINERS: add missing NiosII entry
  MAINTAINERS: add missing OpenRISC entry
  MAINTAINERS: add missing PowerPC entry
  MAINTAINERS: add missing SH-4 entry
  MAINTAINERS: add missing SPARC entry
  MAINTAINERS: add missing TriCore entry
  MAINTAINERS: add missing UniCore32 entry
  MAINTAINERS: add missing Xtensa entry
  MAINTAINERS: add missing X86 entries
  MAINTAINERS: add missing entries for throttling infra
  MAINTAINERS: add missing entry test for megasas
  MAINTAINERS: update docs/devel/ entries
  MAINTAINERS: update docs/interop/ entries
  RFC MAINTAINERS: add missing SSI entries
  RFC MAINTAINERS: add missing entry for AIO
  RFC MAINTAINERS: add missing I2C entries
  RFC MAINTAINERS: add missing Bluetooth entries
  RFC MAINTAINERS: add missing TPM entries
  RFC MAINTAINERS: add missing entry for tilegx
  RFC MAINTAINERS: add missing entries for loader
  RFC MAINTAINERS: add missing entries for Coccinelle scripts
  MAINTAINERS: script to find outdated entry

 MAINTAINERS                 | 102 ++++++++++++++++++++++++++++++++++++++++----
 scripts/check_maintainer.sh |  21 +++++++++
 2 files changed, 114 insertions(+), 9 deletions(-)
 create mode 100755 scripts/check_maintainer.sh

-- 
2.13.3

[Qemu-devel] [RFC PATCH 01/47] MAINTAINERS: add missing entry for documentation

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---

because having only a "Build system architecture" entry in Documentation seems
odd to me, so RFC.

 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5ea273f899..972118e70b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1886,6 +1886,9 @@ W: http://patchew.org/QEMU/
 
 Documentation
 -------------
+Overall
+F: docs/
+
 Build system architecture
 M: Daniel P. Berrange <berrange@redhat.com>
 S: Odd Fixes
-- 
2.13.3

Re: [Qemu-devel] [RFC PATCH 01/47] MAINTAINERS: add missing entry for documentation

[Thomas Huth]

On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> 
> because having only a "Build system architecture" entry in Documentation seems
> odd to me, so RFC.
> 
>  MAINTAINERS | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5ea273f899..972118e70b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1886,6 +1886,9 @@ W: http://patchew.org/QEMU/
>  
>  Documentation
>  -------------
> +Overall
> +F: docs/

But it also does not make sense to add such an entry without a "M:"
line, does it?

 Thomas

Re: [Qemu-devel] [RFC PATCH 01/47] MAINTAINERS: add missing entry for documentation

[Philippe Mathieu-Daudé]

On 07/28/2017 03:47 AM, Thomas Huth wrote:
> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>
>> because having only a "Build system architecture" entry in Documentation seems
>> odd to me, so RFC.
>>
>>   MAINTAINERS | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 5ea273f899..972118e70b 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1886,6 +1886,9 @@ W: http://patchew.org/QEMU/
>>   
>>   Documentation
>>   -------------
>> +Overall
>> +F: docs/
> 
> But it also does not make sense to add such an entry without a "M:"
> line, does it?

Indeed, dropped.

[Qemu-devel] [PATCH 02/47] MAINTAINERS: add missing ARM entries

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 972118e70b..795f89f709 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -120,6 +120,8 @@ F: include/hw/cpu/a*mpcore.h
 F: disas/arm.c
 F: disas/arm-a64.cc
 F: disas/libvixl/
+F: default-configs/arm-softmmu.mak
+F: default-configs/aarch64-softmmu.mak
 
 CRIS
 M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
@@ -380,6 +382,7 @@ M: Peter Maydell <peter.maydell@linaro.org>
 L: qemu-arm@nongnu.org
 S: Maintained
 F: hw/char/pl011.c
+F: include/hw/char/pl011.h
 F: hw/display/pl110*
 F: hw/dma/pl080.c
 F: hw/dma/pl330.c
@@ -402,14 +405,19 @@ F: hw/intc/arm*
 F: hw/intc/gic_internal.h
 F: hw/misc/a9scu.c
 F: hw/misc/arm11scu.c
+F: hw/misc/arm_sysctl.c
 F: hw/timer/a9gtimer*
 F: hw/timer/arm_*
+F: hw/timer/armv7m_systick.c
 F: include/hw/arm/arm.h
+F: include/hw/arm/armv7m*.h
 F: include/hw/intc/arm*
 F: include/hw/misc/a9scu.h
 F: include/hw/misc/arm11scu.h
 F: include/hw/timer/a9gtimer.h
 F: include/hw/timer/arm_mptimer.h
+F: include/hw/timer/armv7m_systick.h
+F: tests/test-arm-mptimer.c
 
 Exynos
 M: Igor Mitsyanko <i.mitsyanko@gmail.com>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 02/47] MAINTAINERS: add missing ARM entries

[Thomas Huth]

On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 972118e70b..795f89f709 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -120,6 +120,8 @@ F: include/hw/cpu/a*mpcore.h
>  F: disas/arm.c
>  F: disas/arm-a64.cc
>  F: disas/libvixl/
> +F: default-configs/arm-softmmu.mak
> +F: default-configs/aarch64-softmmu.mak

You've added this to the TCG CPU core section, but strictly speaking
these files are also used for the machine emulation in general (and also
for KVM). So not sure whether this is a good fit here ... up to Peter to
decide.

>  CRIS
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> @@ -380,6 +382,7 @@ M: Peter Maydell <peter.maydell@linaro.org>
>  L: qemu-arm@nongnu.org
>  S: Maintained
>  F: hw/char/pl011.c
> +F: include/hw/char/pl011.h
>  F: hw/display/pl110*
>  F: hw/dma/pl080.c
>  F: hw/dma/pl330.c
> @@ -402,14 +405,19 @@ F: hw/intc/arm*
>  F: hw/intc/gic_internal.h
>  F: hw/misc/a9scu.c
>  F: hw/misc/arm11scu.c
> +F: hw/misc/arm_sysctl.c

According to a comment in that file, it is about RealView/Versatile
boards instead, so this is the wrong section here?

>  F: hw/timer/a9gtimer*
>  F: hw/timer/arm_*
> +F: hw/timer/armv7m_systick.c

How about rather removing the underscore in the previous wildcard entry?

>  F: include/hw/arm/arm.h
> +F: include/hw/arm/armv7m*.h
>  F: include/hw/intc/arm*
>  F: include/hw/misc/a9scu.h
>  F: include/hw/misc/arm11scu.h
>  F: include/hw/timer/a9gtimer.h
>  F: include/hw/timer/arm_mptimer.h
> +F: include/hw/timer/armv7m_systick.h
> +F: tests/test-arm-mptimer.c
>  
>  Exynos
>  M: Igor Mitsyanko <i.mitsyanko@gmail.com>
> 

 Thomas

Re: [Qemu-devel] [PATCH 02/47] MAINTAINERS: add missing ARM entries

[Philippe Mathieu-Daudé]

On 07/28/2017 03:55 AM, Thomas Huth wrote:
> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>   MAINTAINERS | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 972118e70b..795f89f709 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -120,6 +120,8 @@ F: include/hw/cpu/a*mpcore.h
>>   F: disas/arm.c
>>   F: disas/arm-a64.cc
>>   F: disas/libvixl/
>> +F: default-configs/arm-softmmu.mak
>> +F: default-configs/aarch64-softmmu.mak
> 
> You've added this to the TCG CPU core section, but strictly speaking
> these files are also used for the machine emulation in general (and also
> for KVM). So not sure whether this is a good fit here ... up to Peter to
> decide.

You are right.

> 
>>   CRIS
>>   M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>> @@ -380,6 +382,7 @@ M: Peter Maydell <peter.maydell@linaro.org>
>>   L: qemu-arm@nongnu.org
>>   S: Maintained
>>   F: hw/char/pl011.c
>> +F: include/hw/char/pl011.h
>>   F: hw/display/pl110*
>>   F: hw/dma/pl080.c
>>   F: hw/dma/pl330.c
>> @@ -402,14 +405,19 @@ F: hw/intc/arm*
>>   F: hw/intc/gic_internal.h
>>   F: hw/misc/a9scu.c
>>   F: hw/misc/arm11scu.c
>> +F: hw/misc/arm_sysctl.c
> 
> According to a comment in that file, it is about RealView/Versatile
> boards instead, so this is the wrong section here?

Wrong section indeed.

> 
>>   F: hw/timer/a9gtimer*
>>   F: hw/timer/arm_*
>> +F: hw/timer/armv7m_systick.c
> 
> How about rather removing the underscore in the previous wildcard entry?

I also wondered, because I'm a slowly working branch where I try to boot 
some Marvell SoC, and I named the timer "armada_timer.c" following the 
Linux device-tree naming:

https://www.kernel.org/doc/Documentation/devicetree/bindings/timer/marvell%2Carmada-370-xp-timer.txt

But if I ever finish it I can add an exclude entry, so I'll follow your 
advice.

> 
>>   F: include/hw/arm/arm.h
>> +F: include/hw/arm/armv7m*.h
>>   F: include/hw/intc/arm*
>>   F: include/hw/misc/a9scu.h
>>   F: include/hw/misc/arm11scu.h
>>   F: include/hw/timer/a9gtimer.h
>>   F: include/hw/timer/arm_mptimer.h
>> +F: include/hw/timer/armv7m_systick.h
>> +F: tests/test-arm-mptimer.c
>>   
>>   Exynos
>>   M: Igor Mitsyanko <i.mitsyanko@gmail.com>
>>
> 
>   Thomas
> 

[Qemu-devel] [PATCH 03/47] MAINTAINERS: add missing STM32 entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 795f89f709..f10252c292 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -556,6 +556,7 @@ F: hw/char/stm32f2xx_usart.c
 F: hw/timer/stm32f2xx_timer.c
 F: hw/adc/*
 F: hw/ssi/stm32f2xx_spi.c
+F: include/hw/*/stm32*.h
 
 Netduino 2
 M: Alistair Francis <alistair@alistair23.me>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 03/47] MAINTAINERS: add missing STM32 entry

[Thomas Huth]

On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 795f89f709..f10252c292 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -556,6 +556,7 @@ F: hw/char/stm32f2xx_usart.c
>  F: hw/timer/stm32f2xx_timer.c
>  F: hw/adc/*
>  F: hw/ssi/stm32f2xx_spi.c
> +F: include/hw/*/stm32*.h
>  
>  Netduino 2
>  M: Alistair Francis <alistair@alistair23.me>
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH 03/47] MAINTAINERS: add missing STM32 entry

[Alistair Francis]

On Thu, Jul 27, 2017 at 11:58 PM, Thomas Huth <thuth@redhat.com> wrote:
> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>

Thanks,
Alistair

>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 795f89f709..f10252c292 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -556,6 +556,7 @@ F: hw/char/stm32f2xx_usart.c
>>  F: hw/timer/stm32f2xx_timer.c
>>  F: hw/adc/*
>>  F: hw/ssi/stm32f2xx_spi.c
>> +F: include/hw/*/stm32*.h
>>
>>  Netduino 2
>>  M: Alistair Francis <alistair@alistair23.me>
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>

Re: [Qemu-devel] [PATCH 03/47] MAINTAINERS: add missing STM32 entry

[Alistair Francis]

On Fri, Jul 28, 2017 at 9:47 AM, Alistair Francis <alistair23@gmail.com> wrote:
> On Thu, Jul 27, 2017 at 11:58 PM, Thomas Huth <thuth@redhat.com> wrote:
>> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>

Ah, different emails. I guess use this one instead.

Reviewed-by: Alistair Francis <alistair@alistair23.me>

Thanks,
Alistair


>
> Thanks,
> Alistair
>
>>> ---
>>>  MAINTAINERS | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 795f89f709..f10252c292 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -556,6 +556,7 @@ F: hw/char/stm32f2xx_usart.c
>>>  F: hw/timer/stm32f2xx_timer.c
>>>  F: hw/adc/*
>>>  F: hw/ssi/stm32f2xx_spi.c
>>> +F: include/hw/*/stm32*.h
>>>
>>>  Netduino 2
>>>  M: Alistair Francis <alistair@alistair23.me>
>>>
>>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>

[Qemu-devel] [PATCH 04/47] MAINTAINERS: add missing USB entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f10252c292..3b472d7a09 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1008,6 +1008,7 @@ F: docs/usb2.txt
 F: docs/usb-storage.txt
 F: include/hw/usb.h
 F: include/hw/usb/
+F: default-configs/usb.mak
 
 USB (serial adapter)
 M: Gerd Hoffmann <kraxel@redhat.com>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 04/47] MAINTAINERS: add missing USB entry

[Thomas Huth]

On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f10252c292..3b472d7a09 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1008,6 +1008,7 @@ F: docs/usb2.txt
>  F: docs/usb-storage.txt
>  F: include/hw/usb.h
>  F: include/hw/usb/
> +F: default-configs/usb.mak
>  
>  USB (serial adapter)
>  M: Gerd Hoffmann <kraxel@redhat.com>
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

[Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3b472d7a09..ece02522be 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -278,6 +278,7 @@ S: Supported
 F: */kvm.*
 F: accel/kvm/
 F: include/sysemu/kvm*.h
+F: linux-headers/asm-*/kvm*.h
 
 ARM
 M: Peter Maydell <peter.maydell@linaro.org>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry

[Thomas Huth]

On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3b472d7a09..ece02522be 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -278,6 +278,7 @@ S: Supported
>  F: */kvm.*
>  F: accel/kvm/
>  F: include/sysemu/kvm*.h
> +F: linux-headers/asm-*/kvm*.h

The linux-headers are not really maintained by the QEMU project - so I
guess we do not need an entry for these?

 Thomas

Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry

[Paolo Bonzini]

On 28/07/2017 09:00, Thomas Huth wrote:
> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 3b472d7a09..ece02522be 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -278,6 +278,7 @@ S: Supported
>>  F: */kvm.*
>>  F: accel/kvm/
>>  F: include/sysemu/kvm*.h
>> +F: linux-headers/asm-*/kvm*.h
> 
> The linux-headers are not really maintained by the QEMU project - so I
> guess we do not need an entry for these?

Actually I agree with the patch.  I'd like to be CCed on
update-linux-headers patches, and this achieves it. :)

Paolo

Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry

[Cornelia Huck]

On Fri, 28 Jul 2017 13:51:14 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 28/07/2017 09:00, Thomas Huth wrote:
> > On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:  
> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> ---
> >>  MAINTAINERS | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 3b472d7a09..ece02522be 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -278,6 +278,7 @@ S: Supported
> >>  F: */kvm.*
> >>  F: accel/kvm/
> >>  F: include/sysemu/kvm*.h
> >> +F: linux-headers/asm-*/kvm*.h  
> > 
> > The linux-headers are not really maintained by the QEMU project - so I
> > guess we do not need an entry for these?  
> 
> Actually I agree with the patch.  I'd like to be CCed on
> update-linux-headers patches, and this achieves it. :)

But would it not a better idea to add an entry for all headers touched
by update-linux-headers, then?

Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry

[Paolo Bonzini]

On 28/07/2017 13:56, Cornelia Huck wrote:
> On Fri, 28 Jul 2017 13:51:14 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
>> On 28/07/2017 09:00, Thomas Huth wrote:
>>> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:  
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>>  MAINTAINERS | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 3b472d7a09..ece02522be 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -278,6 +278,7 @@ S: Supported
>>>>  F: */kvm.*
>>>>  F: accel/kvm/
>>>>  F: include/sysemu/kvm*.h
>>>> +F: linux-headers/asm-*/kvm*.h  
>>>
>>> The linux-headers are not really maintained by the QEMU project - so I
>>> guess we do not need an entry for these?  
>>
>> Actually I agree with the patch.  I'd like to be CCed on
>> update-linux-headers patches, and this achieves it. :)
> 
> But would it not a better idea to add an entry for all headers touched
> by update-linux-headers, then?

One thing doesn't exclude the other.  That entry would also list the
script itself and linux-headers.  KVM, VFIO and virtio patterns can only
list the files they care about.  Migration could list userfaultfd,
possibly.  And there's also include/standard-headers/, which includes
PCI and input subsystem files...  It has to be perfected, but it's a
good idea.

Paolo

Paolo

Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry

[Cornelia Huck]

On Fri, 28 Jul 2017 13:59:08 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 28/07/2017 13:56, Cornelia Huck wrote:
> > On Fri, 28 Jul 2017 13:51:14 +0200
> > Paolo Bonzini <pbonzini@redhat.com> wrote:
> >   
> >> On 28/07/2017 09:00, Thomas Huth wrote:  
> >>> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:    
> >>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >>>> ---
> >>>>  MAINTAINERS | 1 +
> >>>>  1 file changed, 1 insertion(+)
> >>>>
> >>>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>>> index 3b472d7a09..ece02522be 100644
> >>>> --- a/MAINTAINERS
> >>>> +++ b/MAINTAINERS
> >>>> @@ -278,6 +278,7 @@ S: Supported
> >>>>  F: */kvm.*
> >>>>  F: accel/kvm/
> >>>>  F: include/sysemu/kvm*.h
> >>>> +F: linux-headers/asm-*/kvm*.h    
> >>>
> >>> The linux-headers are not really maintained by the QEMU project - so I
> >>> guess we do not need an entry for these?    
> >>
> >> Actually I agree with the patch.  I'd like to be CCed on
> >> update-linux-headers patches, and this achieves it. :)  
> > 
> > But would it not a better idea to add an entry for all headers touched
> > by update-linux-headers, then?  
> 
> One thing doesn't exclude the other.  That entry would also list the
> script itself and linux-headers.  KVM, VFIO and virtio patterns can only
> list the files they care about.  Migration could list userfaultfd,
> possibly.  And there's also include/standard-headers/, which includes
> PCI and input subsystem files...  It has to be perfected, but it's a
> good idea.

Personally, I'm not really a fan. If something is changed in one of the
headers, it implies that either it has already been changed in the
original headers in Linux (and I will have seen it then), or that
someone is sending a preliminary patch (and I should hope that I'm
already cc:ed for the changes that this headers change is for then). It
does not really hurt, but it feels wrong.

Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry

[Paolo Bonzini]

On 28/07/2017 14:13, Cornelia Huck wrote:
>>> But would it not a better idea to add an entry for all headers touched
>>> by update-linux-headers, then?  
>>
>> One thing doesn't exclude the other.  That entry would also list the
>> script itself and linux-headers.  KVM, VFIO and virtio patterns can only
>> list the files they care about.  Migration could list userfaultfd,
>> possibly.  And there's also include/standard-headers/, which includes
>> PCI and input subsystem files...  It has to be perfected, but it's a
>> good idea.
> 
> Personally, I'm not really a fan. If something is changed in one of the
> headers, it implies that either it has already been changed in the
> original headers in Linux (and I will have seen it then), or that
> someone is sending a preliminary patch (and I should hope that I'm
> already cc:ed for the changes that this headers change is for then). It
> does not really hurt, but it feels wrong.

Sometime people pull changes too early, or otherwise I want to comment
on the timing of the change... I don't know, I already get too much
qemu-devel email. :)

Paolo

Re: [Qemu-devel] [PATCH 05/47] MAINTAINERS: add missing KVM entry

[Cornelia Huck]

On Fri, 28 Jul 2017 14:25:08 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Sometime people pull changes too early, or otherwise I want to comment
> on the timing of the change...

Might be helpful to add magic to checkpatch to verify that any headers
change is done via running the script against a specified Linux
version. (This is beyond my non-existing perl skills, unfortunately.)

> I don't know, I already get too much
> qemu-devel email. :)

I can certainly agree with that statement :)

[Qemu-devel] [PATCH 06/47] MAINTAINERS: add missing entry for vhost

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ece02522be..ddf6f3f6d8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1035,6 +1035,7 @@ vhost
 M: Michael S. Tsirkin <mst@redhat.com>
 S: Supported
 F: hw/*/*vhost*
+F: docs/interop/vhost-user.txt
 
 virtio
 M: Michael S. Tsirkin <mst@redhat.com>
-- 
2.13.3

[Qemu-devel] [PATCH 07/47] MAINTAINERS: add missing entry for vfio/ccw

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ddf6f3f6d8..69987b5e5b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1029,6 +1029,7 @@ S: Supported
 F: hw/vfio/ccw.c
 F: hw/s390x/s390-ccw.c
 F: include/hw/s390x/s390-ccw.h
+F: linux-headers/linux/vfio_ccw.h
 T: git git://github.com/cohuck/qemu.git s390-next
 
 vhost
-- 
2.13.3

Re: [Qemu-devel] [PATCH 07/47] MAINTAINERS: add missing entry for vfio/ccw

[Thomas Huth]

On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ddf6f3f6d8..69987b5e5b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1029,6 +1029,7 @@ S: Supported
>  F: hw/vfio/ccw.c
>  F: hw/s390x/s390-ccw.c
>  F: include/hw/s390x/s390-ccw.h
> +F: linux-headers/linux/vfio_ccw.h

Again a linux-header ... I don't think we need an entry for this in
MAINTAINERS since the file is maintained in the Linux kernel instead.

 Thomas

Re: [Qemu-devel] [PATCH 07/47] MAINTAINERS: add missing entry for vfio/ccw

[Cornelia Huck]

On Fri, 28 Jul 2017 09:02:27 +0200
Thomas Huth <thuth@redhat.com> wrote:

> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ddf6f3f6d8..69987b5e5b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1029,6 +1029,7 @@ S: Supported
> >  F: hw/vfio/ccw.c
> >  F: hw/s390x/s390-ccw.c
> >  F: include/hw/s390x/s390-ccw.h
> > +F: linux-headers/linux/vfio_ccw.h  
> 
> Again a linux-header ... I don't think we need an entry for this in
> MAINTAINERS since the file is maintained in the Linux kernel instead.

Agreed, even if it's the same maintainer in this case.

What about a catchall pattern for the linux-headers instead that points
to the update-headers script? If you're updating these without running
the script, you're doing something wrong (as soon as the patchset is
ready for inclusion, at least.)

[Qemu-devel] [PATCH 08/47] MAINTAINERS: add missing entry for virtio

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 69987b5e5b..6da3264d4e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1046,6 +1046,7 @@ F: hw/virtio/Makefile.objs
 F: hw/virtio/trace-events
 F: net/vhost-user.c
 F: include/hw/virtio/
+F: include/standard-headers/linux/virtio_*
 F: tests/virtio-balloon-test.c
 
 virtio-9p
-- 
2.13.3

Re: [Qemu-devel] [PATCH 08/47] MAINTAINERS: add missing entry for virtio

[Thomas Huth]

On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 69987b5e5b..6da3264d4e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1046,6 +1046,7 @@ F: hw/virtio/Makefile.objs
>  F: hw/virtio/trace-events
>  F: net/vhost-user.c
>  F: include/hw/virtio/
> +F: include/standard-headers/linux/virtio_*

Same as for the linux-headers folder: include/standard-headers comes
from the Linux kernel ... not sure whether it makes sense to add an
entry in our MAINTAINERS file here...

 Thomas

Re: [Qemu-devel] [PATCH 08/47] MAINTAINERS: add missing entry for virtio

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

On Fri, Jul 28, 2017 at 09:05:13AM +0200, Thomas Huth wrote:
> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 69987b5e5b..6da3264d4e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1046,6 +1046,7 @@ F: hw/virtio/Makefile.objs
> >  F: hw/virtio/trace-events
> >  F: net/vhost-user.c
> >  F: include/hw/virtio/
> > +F: include/standard-headers/linux/virtio_*
> 
> Same as for the linux-headers folder: include/standard-headers comes
> from the Linux kernel ... not sure whether it makes sense to add an
> entry in our MAINTAINERS file here...

I think it doesn't hurt for the virtio maintainer to be CCed on emails
that update the header files.  Most of the time changes are made by
mechanically importing header files using a script, but sometimes they
may be manual edits that are worth reviewing by someone familiar with
the domain.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[Qemu-devel] [PATCH 09/47] MAINTAINERS: add missing entry for virtio/9p

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6da3264d4e..4f9ce6e686 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1056,6 +1056,7 @@ S: Supported
 F: hw/9pfs/
 F: fsdev/
 F: tests/virtio-9p-test.c
+F: include/standard-headers/linux/virtio_9p.h
 T: git git://github.com/kvaneesh/QEMU.git
 T: git git://github.com/gkurz/qemu.git 9p-next
 
-- 
2.13.3

Re: [Qemu-devel] [PATCH 09/47] MAINTAINERS: add missing entry for virtio/9p

[Greg Kurz]

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

On Fri, 28 Jul 2017 02:35:32 -0300
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6da3264d4e..4f9ce6e686 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1056,6 +1056,7 @@ S: Supported
>  F: hw/9pfs/
>  F: fsdev/
>  F: tests/virtio-9p-test.c
> +F: include/standard-headers/linux/virtio_9p.h

I don't really know what to do here... I see no other standard headers in
the MAINTAINERS file.

>  T: git git://github.com/kvaneesh/QEMU.git
>  T: git git://github.com/gkurz/qemu.git 9p-next
>  


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[Qemu-devel] [PATCH 10/47] MAINTAINERS: add missing entry for virtio/blk

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4f9ce6e686..2958dd2479 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1067,6 +1067,7 @@ S: Supported
 F: hw/block/virtio-blk.c
 F: hw/block/dataplane/*
 F: tests/virtio-blk-test.c
+F: include/standard-headers/linux/virtio_blk.h
 T: git git://github.com/stefanha/qemu.git block
 
 virtio-ccw
-- 
2.13.3

Re: [Qemu-devel] [PATCH 10/47] MAINTAINERS: add missing entry for virtio/blk

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

On Fri, Jul 28, 2017 at 02:35:33AM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4f9ce6e686..2958dd2479 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1067,6 +1067,7 @@ S: Supported
>  F: hw/block/virtio-blk.c
>  F: hw/block/dataplane/*
>  F: tests/virtio-blk-test.c
> +F: include/standard-headers/linux/virtio_blk.h

This file is imported from Linux mechanically using a script.  I'm still
happy to review changes to the file though.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[Qemu-devel] [PATCH 11/47] MAINTAINERS: add missing entry for virtio/ccw

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2958dd2479..bfdb2f8928 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1075,6 +1075,7 @@ M: Cornelia Huck <cohuck@redhat.com>
 M: Christian Borntraeger <borntraeger@de.ibm.com>
 S: Supported
 F: hw/s390x/virtio-ccw.[hc]
+F: include/standard-headers/asm-s390/virtio-ccw.h
 T: git git://github.com/cohuck/qemu.git s390-next
 T: git git://github.com/borntraeger/qemu.git s390-next
 
-- 
2.13.3

Re: [Qemu-devel] [PATCH 11/47] MAINTAINERS: add missing entry for virtio/ccw

[Cornelia Huck]

On Fri, 28 Jul 2017 02:35:34 -0300
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2958dd2479..bfdb2f8928 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1075,6 +1075,7 @@ M: Cornelia Huck <cohuck@redhat.com>
>  M: Christian Borntraeger <borntraeger@de.ibm.com>
>  S: Supported
>  F: hw/s390x/virtio-ccw.[hc]
> +F: include/standard-headers/asm-s390/virtio-ccw.h
>  T: git git://github.com/cohuck/qemu.git s390-next
>  T: git git://github.com/borntraeger/qemu.git s390-next
>  

This one is also a linux header and should not be added to MAINTAINERS.

[Qemu-devel] [PATCH 12/47] MAINTAINERS: add missing entry for virtio/input

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index bfdb2f8928..a9f950248a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1084,6 +1084,7 @@ M: Gerd Hoffmann <kraxel@redhat.com>
 S: Maintained
 F: hw/input/virtio-input*.c
 F: include/hw/virtio/virtio-input.h
+F: include/standard-headers/linux/virtio_input.h
 
 virtio-serial
 M: Amit Shah <amit@kernel.org>
-- 
2.13.3

[Qemu-devel] [PATCH 13/47] MAINTAINERS: add missing entry for virtio/rng

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index a9f950248a..842c66c325 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1103,6 +1103,7 @@ F: include/hw/virtio/virtio-rng.h
 F: include/sysemu/rng*.h
 F: backends/rng*.c
 F: tests/virtio-rng-test.c
+F: include/standard-headers/linux/virtio_rng.h
 
 virtio-crypto
 M: Gonglei <arei.gonglei@huawei.com>
-- 
2.13.3

[Qemu-devel] [PATCH 14/47] MAINTAINERS: add missing entry for virtio/crypto

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 842c66c325..d8aef164ca 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1111,6 +1111,7 @@ S: Supported
 F: hw/virtio/virtio-crypto.c
 F: hw/virtio/virtio-crypto-pci.c
 F: include/hw/virtio/virtio-crypto.h
+F: include/standard-headers/linux/virtio_crypto.h
 
 nvme
 M: Keith Busch <keith.busch@intel.com>
-- 
2.13.3

[Qemu-devel] [RFC PATCH 15/47] MAINTAINERS: add missing VMWare entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---

RFC because I'm not sure about tests/

 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index d8aef164ca..9670a3901a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1140,6 +1140,7 @@ M: Dmitry Fleytman <dmitry@daynix.com>
 S: Maintained
 F: hw/net/vmxnet*
 F: hw/scsi/vmw_pvscsi*
+F: tests/vmxnet3-test.c
 
 Rocker
 M: Jiri Pirko <jiri@resnulli.us>
-- 
2.13.3

Re: [Qemu-devel] [RFC PATCH 15/47] MAINTAINERS: add missing VMWare entry

[Thomas Huth]

On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> 
> RFC because I'm not sure about tests/

I think that should be fine, we've got a couple of such entries already
in the MAINTAINERS file.

>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d8aef164ca..9670a3901a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1140,6 +1140,7 @@ M: Dmitry Fleytman <dmitry@daynix.com>
>  S: Maintained
>  F: hw/net/vmxnet*
>  F: hw/scsi/vmw_pvscsi*
> +F: tests/vmxnet3-test.c
>  

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [RFC PATCH 15/47] MAINTAINERS: add missing VMWare entry

[Dmitry Fleytman]

> On 28 Jul 2017, at 10:08, Thomas Huth <thuth@redhat.com> wrote:
> 
>> On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> 
>> RFC because I'm not sure about tests/
> 
> I think that should be fine, we've got a couple of such entries already
> in the MAINTAINERS file.
> 
>> MAINTAINERS | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d8aef164ca..9670a3901a 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1140,6 +1140,7 @@ M: Dmitry Fleytman <dmitry@daynix.com>
>> S: Maintained
>> F: hw/net/vmxnet*
>> F: hw/scsi/vmw_pvscsi*
>> +F: tests/vmxnet3-test.c
>> 
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>

[Qemu-devel] [PATCH 16/47] MAINTAINERS: add missing entry for gdb

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9670a3901a..653c2a1db1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1320,6 +1320,7 @@ L: qemu-devel@nongnu.org
 S: Odd Fixes
 F: gdbstub*
 F: gdb-xml/
+F: scripts/qemugdb/
 
 Memory API
 M: Paolo Bonzini <pbonzini@redhat.com>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 16/47] MAINTAINERS: add missing entry for gdb

[Paolo Bonzini]

On 28/07/2017 07:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9670a3901a..653c2a1db1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1320,6 +1320,7 @@ L: qemu-devel@nongnu.org
>  S: Odd Fixes
>  F: gdbstub*
>  F: gdb-xml/
> +F: scripts/qemugdb/

This is unrelated.  It's for debugging QEMU, while the others are for
debugging QEMU guests.

Paolo

>  Memory API
>  M: Paolo Bonzini <pbonzini@redhat.com>
> 

Re: [Qemu-devel] [PATCH 16/47] MAINTAINERS: add missing entry for gdb

[Philippe Mathieu-Daudé]

On 07/28/2017 09:00 AM, Paolo Bonzini wrote:
> On 28/07/2017 07:35, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 9670a3901a..653c2a1db1 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1320,6 +1320,7 @@ L: qemu-devel@nongnu.org
>>   S: Odd Fixes
>>   F: gdbstub*
>>   F: gdb-xml/
>> +F: scripts/qemugdb/
> 
> This is unrelated.  It's for debugging QEMU, while the others are for
> debugging QEMU guests.

Thank for clarifying it, dropped.

> 
> Paolo
> 
>>   Memory API
>>   M: Paolo Bonzini <pbonzini@redhat.com>
>>
> 

[Qemu-devel] [PATCH 17/47] MAINTAINERS: add missing Guest Agent entries

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 653c2a1db1..8cb94af6c5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1448,6 +1448,10 @@ QEMU Guest Agent
 M: Michael Roth <mdroth@linux.vnet.ibm.com>
 S: Maintained
 F: qga/
+F: qemu-ga.texi
+F: scripts/qemu-guest-agent/
+F: tests/test-qga.c
+F: docs/interop/qemu-ga-ref.texi
 T: git git://github.com/mdroth/qemu.git qga
 
 QOM
-- 
2.13.3

[Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 8cb94af6c5..6b83dac812 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1633,6 +1633,7 @@ Common code
 M: Richard Henderson <rth@twiddle.net>
 S: Maintained
 F: tcg/
+F: disas.c
 
 AArch64 target
 M: Claudio Fontana <claudio.fontana@huawei.com>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Alex Bennée]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8cb94af6c5..6b83dac812 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1633,6 +1633,7 @@ Common code
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: tcg/
> +F: disas.c

Is this really TCG only? Can't the monitor call monitor_disas in any
mode?

>
>  AArch64 target
>  M: Claudio Fontana <claudio.fontana@huawei.com>


--
Alex Bennée

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Philippe Mathieu-Daudé]

On 08/08/2017 12:11 PM, Alex Bennée wrote:
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
[...]>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 8cb94af6c5..6b83dac812 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1633,6 +1633,7 @@ Common code
>>   M: Richard Henderson <rth@twiddle.net>
>>   S: Maintained
>>   F: tcg/
>> +F: disas.c
> 
> Is this really TCG only? Can't the monitor call monitor_disas in any
> mode?

Indeed, this doesn't seem TCG only.

Do you think there should be another entry in "Block QAPI, monitor, 
command line"?
or this file (and related include) rather deserves an own section 
(possibly tagged Odd Fixes) to unburden Richard?

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Alex Bennée]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> On 08/08/2017 12:11 PM, Alex Bennée wrote:
>> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> [...]>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 8cb94af6c5..6b83dac812 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1633,6 +1633,7 @@ Common code
>>>   M: Richard Henderson <rth@twiddle.net>
>>>   S: Maintained
>>>   F: tcg/
>>> +F: disas.c
>>
>> Is this really TCG only? Can't the monitor call monitor_disas in any
>> mode?
>
> Indeed, this doesn't seem TCG only.
>
> Do you think there should be another entry in "Block QAPI, monitor,
> command line"?
> or this file (and related include) rather deserves an own section
> (possibly tagged Odd Fixes) to unburden Richard?

Well the default for un-matched files is qemu-devel right? It would be
nice for it to be properly maintained but that requires someone to
step-up to the plate.

--
Alex Bennée

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Philippe Mathieu-Daudé]

[I added mails of other person who reply to this series, this mail is 
not directly addressed to Alex]

On 08/09/2017 11:38 AM, Alex Bennée wrote:
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
[...]
>> Do you think there should be another entry in "Block QAPI, monitor,
>> command line"?
>> or this file (and related include) rather deserves an own section
>> (possibly tagged Odd Fixes) to unburden Richard?
> 
> Well the default for un-matched files is qemu-devel right? It would be
> nice for it to be properly maintained but that requires someone to
> step-up to the plate.

I wonder if I'm understanding correctly what the MAINTAINERS file is for 
and how to use it.

 From an submitter view I feel a bit confused. I thought 
./get_maintainer.pl would give me the list of person to email the 
changes I did on some file from the repository. This script seems 
correctly named, I'm looking for some ./get_reviewers.pl instead, to 
know who I'v to keep updated, apart from the ./get_maintainer.pl.

currently we have:
"M: Mail patches to: FullName <address@domain>"
Does this imply FullName is a maintainer?
If so is it ok I do this change:

-    M: Mail patches to: FullName <address@domain>
+    M: Maintainer: FullName <address@domain>
+       These maintainers must be mailed on patches.
      R: Designated reviewer: FullName <address@domain>
         These reviewers should be CCed on patches.


actual default for un-matched: "recent contributors" + qemu-devel@

   $ ./scripts/get_maintainer.pl -f disas.c
   get_maintainer.pl: No maintainers found, printing recent contributors.
   get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
   Peter Maydell <peter.maydell@linaro.org> (commit_signer:2/3=67%)
   Richard Henderson <rth@twiddle.net> (commit_signer:1/3=33%)
   Thomas Huth <thuth@redhat.com> (commit_signer:1/3=33%)
   Michael Tokarev <mjt@tls.msk.ru> (commit_signer:1/3=33%)
   Julian Brown <julian@codesourcery.com> (commit_signer:1/3=33%)
   qemu-devel@nongnu.org (open list:All patches CC here)

I find the un-matched "recent contributors" list often confuse, due to 
files being moved, header updated, checkpatch indented.
Most of the time you get the list of queue maintainers since they accept 
patches and sign-of the pull request.

Having to use 'git log --follow' and 'git blame' to figure out is not 
bad, to be aware of who modified this file before you, but there are 
some files I already hit 3 times in different series, and wondered about 
how avoid those manual steps.

Anyway I now understand these recent contributors are not maintainers 
but no-designated reviewers, unwilling to be maintainers (else they'd 
have added a section/entry by themselves).

I also understand why Fam said it sounds weird to add an new section as 
"Orphan".

For the linux-headers case, if people want to be notified of changes the 
easiest seems to modify the update-linux-headers.sh script.

I'll review the whole series thinking differently and resend when 2.11 
opens.

Regards,

Phil.

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Cornelia Huck]

On Wed, 9 Aug 2017 18:30:25 -0300
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:

> [I added mails of other person who reply to this series, this mail is 
> not directly addressed to Alex]

Hey, a maintainership discussion! I don't think we had one before 8)

> 
> On 08/09/2017 11:38 AM, Alex Bennée wrote:
> > Philippe Mathieu-Daudé <f4bug@amsat.org> writes:  
> [...]
> >> Do you think there should be another entry in "Block QAPI, monitor,
> >> command line"?
> >> or this file (and related include) rather deserves an own section
> >> (possibly tagged Odd Fixes) to unburden Richard?  
> > 
> > Well the default for un-matched files is qemu-devel right? It would be
> > nice for it to be properly maintained but that requires someone to
> > step-up to the plate.  
> 
> I wonder if I'm understanding correctly what the MAINTAINERS file is for 
> and how to use it.

The blurb at the start of MAINTAINERS should describe this; I'm
wondering how much it reflects current reality, though (the 'ownership'
part).

> 
>  From an submitter view I feel a bit confused. I thought 
> ./get_maintainer.pl would give me the list of person to email the 
> changes I did on some file from the repository. This script seems 
> correctly named, I'm looking for some ./get_reviewers.pl instead, to 
> know who I'v to keep updated, apart from the ./get_maintainer.pl.
> 
> currently we have:
> "M: Mail patches to: FullName <address@domain>"
> Does this imply FullName is a maintainer?
> If so is it ok I do this change:
> 
> -    M: Mail patches to: FullName <address@domain>
> +    M: Maintainer: FullName <address@domain>
> +       These maintainers must be mailed on patches.

This line seems to have originally come from the Linux kernel's
MAINTAINERS file. But I like your version better.

>       R: Designated reviewer: FullName <address@domain>
>          These reviewers should be CCed on patches.

I'm wondering whether we need some more detailed descriptions about the
roles of maintainers and reviewers, i.e.
- maintainers are responsible for an area; they review and pick up
  patches; a non-trivial patch merged through someone else needs at
  least an ack from them
- reviewers are interested in an area, the entries are mostly there so
  that they are sure to get cc:ed on patches; while their feedback
  (like everyone's) is valued, it is not essential to getting a change
  merged

> 
> 
> actual default for un-matched: "recent contributors" + qemu-devel@
> 
>    $ ./scripts/get_maintainer.pl -f disas.c
>    get_maintainer.pl: No maintainers found, printing recent contributors.
>    get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
>    Peter Maydell <peter.maydell@linaro.org> (commit_signer:2/3=67%)
>    Richard Henderson <rth@twiddle.net> (commit_signer:1/3=33%)
>    Thomas Huth <thuth@redhat.com> (commit_signer:1/3=33%)
>    Michael Tokarev <mjt@tls.msk.ru> (commit_signer:1/3=33%)
>    Julian Brown <julian@codesourcery.com> (commit_signer:1/3=33%)
>    qemu-devel@nongnu.org (open list:All patches CC here)
> 
> I find the un-matched "recent contributors" list often confuse, due to 
> files being moved, header updated, checkpatch indented.
> Most of the time you get the list of queue maintainers since they accept 
> patches and sign-of the pull request.
> 
> Having to use 'git log --follow' and 'git blame' to figure out is not 
> bad, to be aware of who modified this file before you, but there are 
> some files I already hit 3 times in different series, and wondered about 
> how avoid those manual steps.
> 
> Anyway I now understand these recent contributors are not maintainers 
> but no-designated reviewers, unwilling to be maintainers (else they'd 
> have added a section/entry by themselves).

The root problem is "some files have no maintainers". The reasons range
from "forgot to include the file in the pattern" (easily fixed), over
"file is updated via a script" (the linux-headers case), to "nobody
feels up to the task" (which is the worst case).

In most cases, I don't think the recent contributors list is very
helpful. Somebody who simply did a tree-wide rename is unlikely to be
able to make a good judgment about a complicated logic change. Just
printing qemu-devel as the address to send this to is probably better;
unfortunately, it may cause patches to languish on the list if nobody
takes pity on them.

Do we need someone collecting non-trivial patches like that, who either
pesters others or picks up the patches themselves?

> 
> I also understand why Fam said it sounds weird to add an new section as 
> "Orphan".
> 
> For the linux-headers case, if people want to be notified of changes the 
> easiest seems to modify the update-linux-headers.sh script.

The approach I like the most for this is to add a pattern that covers
both the script and the directories updated by it. If someone
explicitly wants notifications for header changes that are used by
their code, they can add it to their files as well, but I don't think
that should be the default.

> 
> I'll review the whole series thinking differently and resend when 2.11 
> opens.
> 
> Regards,
> 
> Phil.

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Peter Maydell]

On 10 August 2017 at 09:46, Cornelia Huck <cohuck@redhat.com> wrote:
> The root problem is "some files have no maintainers". The reasons range
> from "forgot to include the file in the pattern" (easily fixed), over
> "file is updated via a script" (the linux-headers case), to "nobody
> feels up to the task" (which is the worst case).
>
> In most cases, I don't think the recent contributors list is very
> helpful. Somebody who simply did a tree-wide rename is unlikely to be
> able to make a good judgment about a complicated logic change. Just
> printing qemu-devel as the address to send this to is probably better;
> unfortunately, it may cause patches to languish on the list if nobody
> takes pity on them.
>
> Do we need someone collecting non-trivial patches like that, who either
> pesters others or picks up the patches themselves?

The problem is that if nobody's feeling up to the task of taking
on a particular single file which has no maintainer, then it's
definitely true that nobody's going to feel up to taking on
the entire collection of unmaintained files...

I think the UI (giving no consideration to how we might implement
this!) would ideally be something like:
 * if anybody mails a patch which touches an "unmaintained" file,
   a robot should send a reply along the lines of "thanks for the
   patch; unfortunately file X is not maintained so it may be
   tricky to get patch review for this. You'll need to be
   persistent and do more of the legwork than if you were patching
   a file that did have an active maintainer" so contributors
   know when they've wandered into the swamp
 * some mechanism for easily finding patches to unmaintained
   files which haven't got review yet, so that anybody with some
   spare time and interest can move some of them along (the idea
   being to spread the load rather than trying to designate a
   particular "owner" for this headache)
 * ditto for finding patches to unmaintained files which have got
   review but which haven't been committed

thanks
-- PMM

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Cornelia Huck]

On Thu, 10 Aug 2017 10:22:54 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On 10 August 2017 at 09:46, Cornelia Huck <cohuck@redhat.com> wrote:
> > The root problem is "some files have no maintainers". The reasons range
> > from "forgot to include the file in the pattern" (easily fixed), over
> > "file is updated via a script" (the linux-headers case), to "nobody
> > feels up to the task" (which is the worst case).
> >
> > In most cases, I don't think the recent contributors list is very
> > helpful. Somebody who simply did a tree-wide rename is unlikely to be
> > able to make a good judgment about a complicated logic change. Just
> > printing qemu-devel as the address to send this to is probably better;
> > unfortunately, it may cause patches to languish on the list if nobody
> > takes pity on them.
> >
> > Do we need someone collecting non-trivial patches like that, who either
> > pesters others or picks up the patches themselves?  
> 
> The problem is that if nobody's feeling up to the task of taking
> on a particular single file which has no maintainer, then it's
> definitely true that nobody's going to feel up to taking on
> the entire collection of unmaintained files...
> 
> I think the UI (giving no consideration to how we might implement
> this!) would ideally be something like:
>  * if anybody mails a patch which touches an "unmaintained" file,
>    a robot should send a reply along the lines of "thanks for the
>    patch; unfortunately file X is not maintained so it may be
>    tricky to get patch review for this. You'll need to be
>    persistent and do more of the legwork than if you were patching
>    a file that did have an active maintainer" so contributors
>    know when they've wandered into the swamp

That's a good idea.

>  * some mechanism for easily finding patches to unmaintained
>    files which haven't got review yet, so that anybody with some
>    spare time and interest can move some of them along (the idea
>    being to spread the load rather than trying to designate a
>    particular "owner" for this headache)

Can maybe patchew set a special flag for patches that only touch
unmaintained files?

>  * ditto for finding patches to unmaintained files which have got
>    review but which haven't been committed
> 
> thanks
> -- PMM

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Fam Zheng]

On Thu, 08/10 12:25, Cornelia Huck wrote:
> > I think the UI (giving no consideration to how we might implement
> > this!) would ideally be something like:
> >  * if anybody mails a patch which touches an "unmaintained" file,
> >    a robot should send a reply along the lines of "thanks for the
> >    patch; unfortunately file X is not maintained so it may be
> >    tricky to get patch review for this. You'll need to be
> >    persistent and do more of the legwork than if you were patching
> >    a file that did have an active maintainer" so contributors
> >    know when they've wandered into the swamp
> 
> That's a good idea.
> 
> >  * some mechanism for easily finding patches to unmaintained
> >    files which haven't got review yet, so that anybody with some
> >    spare time and interest can move some of them along (the idea
> >    being to spread the load rather than trying to designate a
> >    particular "owner" for this headache)
> 
> Can maybe patchew set a special flag for patches that only touch
> unmaintained files?

Interesting idea. We have a number of patch status tracking feature requests for
patchew already. We can tackle them one by one. (The next priority is implement
"merged".)

> 
> >  * ditto for finding patches to unmaintained files which have got
> >    review but which haven't been committed
> > 
> > thanks
> > -- PMM
> 

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Paolo Bonzini]

On 11/08/2017 09:54, Fam Zheng wrote:
> On Thu, 08/10 12:25, Cornelia Huck wrote:
>>> I think the UI (giving no consideration to how we might implement
>>> this!) would ideally be something like:
>>>  * if anybody mails a patch which touches an "unmaintained" file,
>>>    a robot should send a reply along the lines of "thanks for the
>>>    patch; unfortunately file X is not maintained so it may be
>>>    tricky to get patch review for this. You'll need to be
>>>    persistent and do more of the legwork than if you were patching
>>>    a file that did have an active maintainer" so contributors
>>>    know when they've wandered into the swamp
>>
>> That's a good idea.
>>
>>>  * some mechanism for easily finding patches to unmaintained
>>>    files which haven't got review yet, so that anybody with some
>>>    spare time and interest can move some of them along (the idea
>>>    being to spread the load rather than trying to designate a
>>>    particular "owner" for this headache)
>>
>> Can maybe patchew set a special flag for patches that only touch
>> unmaintained files?
> 
> Interesting idea. We have a number of patch status tracking feature requests for
> patchew already. We can tackle them one by one. (The next priority is implement
> "merged".)

Do you use github issues?

Paolo

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Fam Zheng]

On Fri, 08/11 14:06, Paolo Bonzini wrote:
> On 11/08/2017 09:54, Fam Zheng wrote:
> > On Thu, 08/10 12:25, Cornelia Huck wrote:
> >>> I think the UI (giving no consideration to how we might implement
> >>> this!) would ideally be something like:
> >>>  * if anybody mails a patch which touches an "unmaintained" file,
> >>>    a robot should send a reply along the lines of "thanks for the
> >>>    patch; unfortunately file X is not maintained so it may be
> >>>    tricky to get patch review for this. You'll need to be
> >>>    persistent and do more of the legwork than if you were patching
> >>>    a file that did have an active maintainer" so contributors
> >>>    know when they've wandered into the swamp
> >>
> >> That's a good idea.
> >>
> >>>  * some mechanism for easily finding patches to unmaintained
> >>>    files which haven't got review yet, so that anybody with some
> >>>    spare time and interest can move some of them along (the idea
> >>>    being to spread the load rather than trying to designate a
> >>>    particular "owner" for this headache)
> >>
> >> Can maybe patchew set a special flag for patches that only touch
> >> unmaintained files?
> > 
> > Interesting idea. We have a number of patch status tracking feature requests for
> > patchew already. We can tackle them one by one. (The next priority is implement
> > "merged".)
> 
> Do you use github issues?

I have a private trello board that is slightly more up to date, but github
issues does have a few entries too. We can certainly discuss things there.

Fam

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Peter Maydell]

On 9 August 2017 at 22:30, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> I wonder if I'm understanding correctly what the MAINTAINERS file is for and
> how to use it.
>
> From an submitter view I feel a bit confused. I thought ./get_maintainer.pl
> would give me the list of person to email the changes I did on some file
> from the repository. This script seems correctly named, I'm looking for some
> ./get_reviewers.pl instead, to know who I'v to keep updated, apart from the
> ./get_maintainer.pl.
>
> currently we have:
> "M: Mail patches to: FullName <address@domain>"
> Does this imply FullName is a maintainer?

Does it matter? As a contributor, what you want to know is
"who cares enough about this file to be worth cc'ing, if anybody",
and get_maintainer.pl does that for you.
Hopefully at least one of those people is also in a position
to shepherd the patch through into git master, but that doesn't
affect what you need to do as a patch submitter.
If anybody cares enough about a particular area of the codebase
to want to be cc'd on all patches so they can review them, then
to my mind that makes them effectively a co-maintainer on those
files, and they can be listed in MAINTAINERS.

> If so is it ok I do this change:
>
> -    M: Mail patches to: FullName <address@domain>
> +    M: Maintainer: FullName <address@domain>
> +       These maintainers must be mailed on patches.
>      R: Designated reviewer: FullName <address@domain>
>         These reviewers should be CCed on patches.
>
>
> actual default for un-matched: "recent contributors" + qemu-devel@
>
>   $ ./scripts/get_maintainer.pl -f disas.c
>   get_maintainer.pl: No maintainers found, printing recent contributors.
>   get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
>   Peter Maydell <peter.maydell@linaro.org> (commit_signer:2/3=67%)
>   Richard Henderson <rth@twiddle.net> (commit_signer:1/3=33%)
>   Thomas Huth <thuth@redhat.com> (commit_signer:1/3=33%)
>   Michael Tokarev <mjt@tls.msk.ru> (commit_signer:1/3=33%)
>   Julian Brown <julian@codesourcery.com> (commit_signer:1/3=33%)
>   qemu-devel@nongnu.org (open list:All patches CC here)
>
> I find the un-matched "recent contributors" list often confuse, due to files
> being moved, header updated, checkpatch indented.

Yes, the recent-contributors list is often unhelpful, which
is partly why the script warns about them. We might perhaps
switch the default to --no-git-fallback".

> Anyway I now understand these recent contributors are not maintainers but
> no-designated reviewers, unwilling to be maintainers (else they'd have added
> a section/entry by themselves).

They're just people who touched a file more often, that's all;
the script does a little of the git log mining for you in
case it's useful (often it isn't).

The underlying problem, as Cornelia points out, is that some
parts of QEMU have no maintainer at all, or have a theoretical
maintainer who in practice doesn't these days have enough time
to do code reviews very promptly, or have a email listed that
actually bounces because they changed employer 3 years ago and
stopped working on QEMU, etc. Changing wording in the
MAINTAINERS file is not going to help with this :-(

thanks
-- PMM

Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry

[Paolo Bonzini]

On 10/08/2017 11:35, Peter Maydell wrote:
>> actual default for un-matched: "recent contributors" + qemu-devel@
>>
>>   $ ./scripts/get_maintainer.pl -f disas.c
>>   get_maintainer.pl: No maintainers found, printing recent contributors.
>>   get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
>>   Peter Maydell <peter.maydell@linaro.org> (commit_signer:2/3=67%)
>>   Richard Henderson <rth@twiddle.net> (commit_signer:1/3=33%)
>>   Thomas Huth <thuth@redhat.com> (commit_signer:1/3=33%)
>>   Michael Tokarev <mjt@tls.msk.ru> (commit_signer:1/3=33%)
>>   Julian Brown <julian@codesourcery.com> (commit_signer:1/3=33%)
>>   qemu-devel@nongnu.org (open list:All patches CC here)
>>
>> I find the un-matched "recent contributors" list often confuse, due to files
>> being moved, header updated, checkpatch indented.
> 
> Yes, the recent-contributors list is often unhelpful, which
> is partly why the script warns about them. We might perhaps
> switch the default to --no-git-fallback".

Note that if a patch touches both maintained and unmaintained files, the
recent contributors list is omitted:

    $ scripts/get_maintainer.pl -f util/cutils.c hw/ide/core.c
    John Snow <jsnow@redhat.com> (supporter:IDE)
    qemu-devel@nongnu.org (open list:All patches CC here)
    qemu-block@nongnu.org (open list:IDE)

"--no-git-fallback" is probably the right thing to do when sending a
patch series.  The maintainer that shepherds the series will take care
of unmaintained files too.

However, when sending a single patch to an unmaintained file the
contributors list usually does get the patch to the inbox of a
maintainer.  This increases the odds of getting someone's attention.
Because inexperienced contributors usually don't send large series, my
feeling is that overall "--git-fallback"'s advantage are more than the
disadvantages, especially with the above logic that was introduced in
commit c6561586f0 ("get_maintainer.pl: restrict cases where it falls
back to --git", 2014-10-23).

Paolo

[Qemu-devel] [PATCH 19/47] MAINTAINERS: add missing qcow2 entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6b83dac812..2dcdda4cd5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1856,6 +1856,7 @@ M: Max Reitz <mreitz@redhat.com>
 L: qemu-block@nongnu.org
 S: Supported
 F: block/qcow2*
+F: docs/interop/qcow2.txt
 
 qcow
 M: Kevin Wolf <kwolf@redhat.com>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 19/47] MAINTAINERS: add missing qcow2 entry

[Kevin Wolf]

Am 28.07.2017 um 07:35 hat Philippe Mathieu-Daudé geschrieben:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6b83dac812..2dcdda4cd5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1856,6 +1856,7 @@ M: Max Reitz <mreitz@redhat.com>
>  L: qemu-block@nongnu.org
>  S: Supported
>  F: block/qcow2*
> +F: docs/interop/qcow2.txt

Acked-by: Kevin Wolf <kwolf@redhat.com>

Re: [Qemu-devel] [PATCH 19/47] MAINTAINERS: add missing qcow2 entry

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

On Fri, Jul 28, 2017 at 02:35:42AM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[Qemu-devel] [PATCH 20/47] MAINTAINERS: add missing PCI entries

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2dcdda4cd5..286ff7e509 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -933,6 +933,9 @@ F: include/hw/pci/*
 F: hw/misc/pci-testdev.c
 F: hw/pci/*
 F: hw/pci-bridge/*
+F: default-configs/pci.mak
+F: docs/pci*
+F: docs/specs/*pci*
 
 ACPI/SMBIOS
 M: Michael S. Tsirkin <mst@redhat.com>
-- 
2.13.3

[Qemu-devel] [PATCH 21/47] MAINTAINERS: add missing CRIS entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 286ff7e509..14109f4513 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -131,6 +131,7 @@ F: hw/cris/
 F: include/hw/cris/
 F: tests/tcg/cris/
 F: disas/cris.c
+F: default-configs/cris-softmmu.mak
 
 HPPA (PA-RISC)
 M: Richard Henderson <rth@twiddle.net>
-- 
2.13.3

[Qemu-devel] [PATCH 22/47] MAINTAINERS: add missing M68k entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 14109f4513..06b092bf85 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -156,6 +156,7 @@ M: Laurent Vivier <laurent@vivier.eu>
 S: Maintained
 F: target/m68k/
 F: disas/m68k.c
+F: default-configs/m68k-softmmu.mak
 
 MicroBlaze
 M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 22/47] MAINTAINERS: add missing M68k entry

[Laurent Vivier]

Le 28/07/2017 à 07:35, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 14109f4513..06b092bf85 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -156,6 +156,7 @@ M: Laurent Vivier <laurent@vivier.eu>
>  S: Maintained
>  F: target/m68k/
>  F: disas/m68k.c
> +F: default-configs/m68k-softmmu.mak

I think *-softmmu.mak would better fit under a machine section, but I
agree it is easier to manage by adding it here, so:

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Laurent

[Qemu-devel] [PATCH 23/47] MAINTAINERS: add missing LM32 entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 06b092bf85..1424788a9d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -150,6 +150,7 @@ F: hw/*/milkymist-*
 F: include/hw/char/lm32_juart.h
 F: include/hw/lm32/
 F: tests/tcg/lm32/
+F: default-configs/lm32-softmmu.mak
 
 M68K
 M: Laurent Vivier <laurent@vivier.eu>
-- 
2.13.3

[Qemu-devel] [PATCH 24/47] MAINTAINERS: add missing MicroBlaze entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1424788a9d..fa6b0d189a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -165,6 +165,7 @@ S: Maintained
 F: target/microblaze/
 F: hw/microblaze/
 F: disas/microblaze.c
+F: default-configs/microblaze*-softmmu.mak
 
 MIPS
 M: Aurelien Jarno <aurelien@aurel32.net>
-- 
2.13.3

[Qemu-devel] [PATCH 25/47] MAINTAINERS: add missing MIPS entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index fa6b0d189a..7354afb9f4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -182,6 +182,7 @@ F: include/hw/intc/mips_gic.h
 F: include/hw/timer/mips_gictimer.h
 F: tests/tcg/mips/
 F: disas/mips.c
+F: default-configs/mips*-softmmu.mak
 
 Moxie
 M: Anthony Green <green@moxielogic.com>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 25/47] MAINTAINERS: add missing MIPS entry

[Yongbok Kim]

On 28/07/2017 06:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fa6b0d189a..7354afb9f4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -182,6 +182,7 @@ F: include/hw/intc/mips_gic.h
>  F: include/hw/timer/mips_gictimer.h
>  F: tests/tcg/mips/
>  F: disas/mips.c
> +F: default-configs/mips*-softmmu.mak
>  
>  Moxie
>  M: Anthony Green <green@moxielogic.com>
> 

Acked-by: Yongbok Kim <yongbok.kim@imgtec.com>

Regards,
Yongbok

[Qemu-devel] [PATCH 26/47] MAINTAINERS: add missing NiosII entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7354afb9f4..a4df19d304 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -199,6 +199,7 @@ S: Maintained
 F: target/nios2/
 F: hw/nios2/
 F: disas/nios2.c
+F: default-configs/nios2-softmmu.mak
 
 OpenRISC
 M: Stafford Horne <shorne@gmail.com>
-- 
2.13.3

[Qemu-devel] [PATCH 27/47] MAINTAINERS: add missing OpenRISC entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index a4df19d304..35a7253e22 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -207,6 +207,7 @@ S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/
+F: default-configs/or1k-softmmu.mak
 
 PowerPC
 M: David Gibson <david@gibson.dropbear.id.au>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 27/47] MAINTAINERS: add missing OpenRISC entry

[Stafford Horne]

On Fri, Jul 28, 2017 at 02:35:50AM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a4df19d304..35a7253e22 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -207,6 +207,7 @@ S: Odd Fixes
>  F: target/openrisc/
>  F: hw/openrisc/
>  F: tests/tcg/openrisc/
> +F: default-configs/or1k-softmmu.mak

This looks fine,

Acked-by: Stafford Horne <shorne@gmail.com>

>  PowerPC
>  M: David Gibson <david@gibson.dropbear.id.au>
> -- 
> 2.13.3
> 

[Qemu-devel] [PATCH 28/47] MAINTAINERS: add missing PowerPC entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 35a7253e22..9a0da13bcd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -218,6 +218,7 @@ F: target/ppc/
 F: hw/ppc/
 F: include/hw/ppc/
 F: disas/ppc.c
+F: default-configs/ppc*-softmmu.mak
 
 S390
 M: Richard Henderson <rth@twiddle.net>
-- 
2.13.3

[Qemu-devel] [PATCH 29/47] MAINTAINERS: add missing SH-4 entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9a0da13bcd..bb1cb1fc1c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -235,6 +235,7 @@ F: target/sh4/
 F: hw/sh4/
 F: disas/sh4.c
 F: include/hw/sh4/
+F: default-configs/sh4*-softmmu.mak
 
 SPARC
 M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 29/47] MAINTAINERS: add missing SH-4 entry

[Aurelien Jarno]

On 2017-07-28 02:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9a0da13bcd..bb1cb1fc1c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -235,6 +235,7 @@ F: target/sh4/
>  F: hw/sh4/
>  F: disas/sh4.c
>  F: include/hw/sh4/
> +F: default-configs/sh4*-softmmu.mak
>  
>  SPARC
>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Acked-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

[Qemu-devel] [PATCH 30/47] MAINTAINERS: add missing SPARC entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index bb1cb1fc1c..e363a18631 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -245,6 +245,7 @@ F: target/sparc/
 F: hw/sparc/
 F: hw/sparc64/
 F: disas/sparc.c
+F: default-configs/sparc*-softmmu.mak
 
 UniCore32
 M: Guan Xuetao <gxt@mprc.pku.edu.cn>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 30/47] MAINTAINERS: add missing SPARC entry

[Artyom Tarasenko]

On Fri, Jul 28, 2017 at 7:35 AM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Acked-By: Artyom Tarasenko <atar4qemu@gmail.com>

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bb1cb1fc1c..e363a18631 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -245,6 +245,7 @@ F: target/sparc/
>  F: hw/sparc/
>  F: hw/sparc64/
>  F: disas/sparc.c
> +F: default-configs/sparc*-softmmu.mak
>
>  UniCore32
>  M: Guan Xuetao <gxt@mprc.pku.edu.cn>
> --
> 2.13.3
>



-- 
Regards,
Artyom Tarasenko

SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu

[Qemu-devel] [PATCH 31/47] MAINTAINERS: add missing TriCore entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e363a18631..7997c90be8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -277,6 +277,7 @@ S: Maintained
 F: target/tricore/
 F: hw/tricore/
 F: include/hw/tricore/
+F: default-configs/tricore-softmmu.mak
 
 Guest CPU Cores (KVM):
 ----------------------
-- 
2.13.3

[Qemu-devel] [PATCH 32/47] MAINTAINERS: add missing UniCore32 entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7997c90be8..6d805b081d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -253,6 +253,7 @@ S: Maintained
 F: target/unicore32/
 F: hw/unicore32/
 F: include/hw/unicore32/
+F: default-configs/unicore32-softmmu.mak
 
 X86
 M: Paolo Bonzini <pbonzini@redhat.com>
-- 
2.13.3

[Qemu-devel] [PATCH 33/47] MAINTAINERS: add missing Xtensa entry

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6d805b081d..b2c9945299 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -271,6 +271,7 @@ S: Maintained
 F: target/xtensa/
 F: hw/xtensa/
 F: tests/tcg/xtensa/
+F: default-configs/xtensa*-softmmu.mak
 
 TriCore
 M: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
-- 
2.13.3

[Qemu-devel] [PATCH 34/47] MAINTAINERS: add missing X86 entries

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index b2c9945299..a2b008e305 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -263,6 +263,8 @@ S: Maintained
 F: target/i386/
 F: hw/i386/
 F: disas/i386.c
+F: default-configs/i386-softmmu.mak
+F: default-configs/x86_64-softmmu.mak
 
 Xtensa
 M: Max Filippov <jcmvbkbc@gmail.com>
-- 
2.13.3

[Qemu-devel] [PATCH 35/47] MAINTAINERS: add missing entries for throttling infra

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index a2b008e305..b9a132d964 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1584,8 +1584,10 @@ M: Alberto Garcia <berto@igalia.com>
 S: Supported
 F: block/throttle-groups.c
 F: include/block/throttle-groups.h
-F: include/qemu/throttle.h
+F: include/qemu/throttle*.h
 F: util/throttle.c
+F: docs/throttle.txt
+F: tests/test-throttle.c
 L: qemu-block@nongnu.org
 
 UUID
-- 
2.13.3

Re: [Qemu-devel] [PATCH 35/47] MAINTAINERS: add missing entries for throttling infra

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

On Fri, Jul 28, 2017 at 02:35:58AM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[Qemu-devel] [PATCH 36/47] MAINTAINERS: add missing entry test for megasas

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index b9a132d964..7649d57e0f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1144,6 +1144,7 @@ L: qemu-block@nongnu.org
 S: Supported
 F: hw/scsi/megasas.c
 F: hw/scsi/mfi.h
+F: tests/megasas-test.c
 
 Network packet abstractions
 M: Dmitry Fleytman <dmitry@daynix.com>
-- 
2.13.3

[Qemu-devel] [PATCH 37/47] MAINTAINERS: update docs/devel/ entries

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7649d57e0f..23de632424 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1438,7 +1438,7 @@ F: tests/test-qapi-*.c
 F: tests/test-qmp-*.c
 F: tests/test-visitor-serialization.c
 F: scripts/qapi*
-F: docs/qapi*
+F: docs/devel/qapi*
 T: git git://repo.or.cz/qemu/armbru.git qapi-next
 
 QAPI Schema
@@ -1490,7 +1490,7 @@ M: Markus Armbruster <armbru@redhat.com>
 S: Supported
 F: qmp.c
 F: monitor.c
-F: docs/*qmp-*
+F: docs/devel/*qmp-*
 F: scripts/qmp/
 F: tests/qmp-test.c
 T: git git://repo.or.cz/qemu/armbru.git qapi-next
@@ -1521,7 +1521,7 @@ S: Maintained
 F: trace/
 F: scripts/tracetool.py
 F: scripts/tracetool/
-F: docs/tracing.txt
+F: docs/devel/tracing.txt
 T: git git://github.com/stefanha/qemu.git tracing
 
 Checkpatch
@@ -1536,7 +1536,7 @@ F: include/migration/
 F: migration/
 F: scripts/vmstate-static-checker.py
 F: tests/vmstate-static-checker-data/
-F: docs/migration.txt
+F: docs/devel/migration.txt
 
 Seccomp
 M: Eduardo Otubo <otubo@redhat.com>
@@ -1941,5 +1941,5 @@ F: docs/
 Build system architecture
 M: Daniel P. Berrange <berrange@redhat.com>
 S: Odd Fixes
-F: docs/build-system.txt
+F: docs/devel/build-system.txt
 
-- 
2.13.3

Re: [Qemu-devel] [PATCH 37/47] MAINTAINERS: update docs/devel/ entries

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

On 07/28/2017 12:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Might be useful to point to the commit id that moved locations of the docs.

> ---
>  MAINTAINERS | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

[Qemu-devel] [PATCH 38/47] MAINTAINERS: update docs/interop/ entries

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 23de632424..54e35fdab9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1283,7 +1283,7 @@ F: block/dirty-bitmap.c
 F: include/qemu/hbitmap.h
 F: include/block/dirty-bitmap.h
 F: tests/test-hbitmap.c
-F: docs/bitmaps.md
+F: docs/interop/bitmaps.rst
 T: git git://github.com/famz/qemu.git bitmaps
 T: git git://github.com/jnsnow/qemu.git bitmaps
 
@@ -1852,7 +1852,7 @@ M: Denis V. Lunev <den@openvz.org>
 L: qemu-block@nongnu.org
 S: Supported
 F: block/parallels.c
-F: docs/specs/parallels.txt
+F: docs/interop/parallels.txt
 
 qed
 M: Stefan Hajnoczi <stefanha@redhat.com>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 38/47] MAINTAINERS: update docs/interop/ entries

[Fam Zheng]

On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 23de632424..54e35fdab9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1283,7 +1283,7 @@ F: block/dirty-bitmap.c
>  F: include/qemu/hbitmap.h
>  F: include/block/dirty-bitmap.h
>  F: tests/test-hbitmap.c
> -F: docs/bitmaps.md
> +F: docs/interop/bitmaps.rst
>  T: git git://github.com/famz/qemu.git bitmaps
>  T: git git://github.com/jnsnow/qemu.git bitmaps
>  
> @@ -1852,7 +1852,7 @@ M: Denis V. Lunev <den@openvz.org>
>  L: qemu-block@nongnu.org
>  S: Supported
>  F: block/parallels.c
> -F: docs/specs/parallels.txt
> +F: docs/interop/parallels.txt
>  
>  qed
>  M: Stefan Hajnoczi <stefanha@redhat.com>
> -- 
> 2.13.3
> 

Acked-by: Fam Zheng <famz@redhat.com>

Re: [Qemu-devel] [PATCH 38/47] MAINTAINERS: update docs/interop/ entries

[John Snow]

On 07/28/2017 02:16 AM, Fam Zheng wrote:
> On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>   MAINTAINERS | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 23de632424..54e35fdab9 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1283,7 +1283,7 @@ F: block/dirty-bitmap.c
>>   F: include/qemu/hbitmap.h
>>   F: include/block/dirty-bitmap.h
>>   F: tests/test-hbitmap.c
>> -F: docs/bitmaps.md
>> +F: docs/interop/bitmaps.rst
>>   T: git git://github.com/famz/qemu.git bitmaps
>>   T: git git://github.com/jnsnow/qemu.git bitmaps
>>   
>> @@ -1852,7 +1852,7 @@ M: Denis V. Lunev <den@openvz.org>
>>   L: qemu-block@nongnu.org
>>   S: Supported
>>   F: block/parallels.c
>> -F: docs/specs/parallels.txt
>> +F: docs/interop/parallels.txt
>>   
>>   qed
>>   M: Stefan Hajnoczi <stefanha@redhat.com>
>> -- 
>> 2.13.3
>>
> 
> Acked-by: Fam Zheng <famz@redhat.com>
> 

"Me too"

Acked-by: John Snow <jsnow@redhat.com>

[Qemu-devel] [PATCH 39/47] MAINTAINERS: add missing SSI entries

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
RFC because I'm not sure m25p80 fits.

 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 54e35fdab9..83597fca4e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1010,7 +1010,9 @@ M: Peter Crosthwaite <crosthwaite.peter@gmail.com>
 S: Maintained
 F: hw/ssi/*
 F: hw/block/m25p80.c
+F: include/hw/ssi/ssi.h
 X: hw/ssi/xilinx_*
+F: tests/m25p80-test.c
 
 Xilinx SPI
 M: Alistair Francis <alistair.francis@xilinx.com>
-- 
2.13.3

Re: [Qemu-devel] [PATCH 39/47] MAINTAINERS: add missing SSI entries

[Alistair Francis]

On Thu, Jul 27, 2017 at 10:36 PM, Philippe Mathieu-Daudé
<f4bug@amsat.org> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> RFC because I'm not sure m25p80 fits.
>
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 54e35fdab9..83597fca4e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1010,7 +1010,9 @@ M: Peter Crosthwaite <crosthwaite.peter@gmail.com>
>  S: Maintained
>  F: hw/ssi/*
>  F: hw/block/m25p80.c
> +F: include/hw/ssi/ssi.h
>  X: hw/ssi/xilinx_*
> +F: tests/m25p80-test.c

I'm not sure if Peter is still maintaining this. Maybe it's worth
adding another Xilinx email in here as well.

Thanks,
Alistair

>
>  Xilinx SPI
>  M: Alistair Francis <alistair.francis@xilinx.com>
> --
> 2.13.3
>
>

Re: [Qemu-devel] [PATCH 39/47] MAINTAINERS: add missing SSI entries

[Philippe Mathieu-Daudé]

On 07/28/2017 08:56 PM, Alistair Francis wrote:
> On Thu, Jul 27, 2017 at 10:36 PM, Philippe Mathieu-Daudé
> <f4bug@amsat.org> wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> RFC because I'm not sure m25p80 fits.
>>
>>   MAINTAINERS | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 54e35fdab9..83597fca4e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1010,7 +1010,9 @@ M: Peter Crosthwaite <crosthwaite.peter@gmail.com>
>>   S: Maintained
>>   F: hw/ssi/*
>>   F: hw/block/m25p80.c
>> +F: include/hw/ssi/ssi.h
>>   X: hw/ssi/xilinx_*
>> +F: tests/m25p80-test.c
> 
> I'm not sure if Peter is still maintaining this. Maybe it's worth
> adding another Xilinx email in here as well.

you mean yours? M: Alistair Francis <alistair.francis@xilinx.com> below 
Peter's?

> 
> Thanks,
> Alistair
> 
>>
>>   Xilinx SPI
>>   M: Alistair Francis <alistair.francis@xilinx.com>
>> --
>> 2.13.3
>>
>>

Re: [Qemu-devel] [PATCH 39/47] MAINTAINERS: add missing SSI entries

[Alistair Francis]

On Fri, Jul 28, 2017 at 5:49 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On 07/28/2017 08:56 PM, Alistair Francis wrote:
>>
>> On Thu, Jul 27, 2017 at 10:36 PM, Philippe Mathieu-Daudé
>> <f4bug@amsat.org> wrote:
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> RFC because I'm not sure m25p80 fits.
>>>
>>>   MAINTAINERS | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 54e35fdab9..83597fca4e 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1010,7 +1010,9 @@ M: Peter Crosthwaite <crosthwaite.peter@gmail.com>
>>>   S: Maintained
>>>   F: hw/ssi/*
>>>   F: hw/block/m25p80.c
>>> +F: include/hw/ssi/ssi.h
>>>   X: hw/ssi/xilinx_*
>>> +F: tests/m25p80-test.c
>>
>>
>> I'm not sure if Peter is still maintaining this. Maybe it's worth
>> adding another Xilinx email in here as well.
>
>
> you mean yours? M: Alistair Francis <alistair.francis@xilinx.com> below
> Peter's?

I think that's a good idea. Peter hasn't responded to this, so it's
probably best to have someone else on the list.

Thanks,
Alistair

>
>
>>
>> Thanks,
>> Alistair
>>
>>>
>>>   Xilinx SPI
>>>   M: Alistair Francis <alistair.francis@xilinx.com>
>>> --
>>> 2.13.3
>>>
>>>
>

[Qemu-devel] [PATCH 40/47] MAINTAINERS: add missing entry for AIO

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 83597fca4e..fb6a82c1ad 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1253,6 +1253,7 @@ F: util/aio-*.c
 F: block/io.c
 F: migration/block*
 F: include/block/aio.h
+F: scripts/qemugdb/aio.py
 T: git git://github.com/stefanha/qemu.git block
 
 Block Jobs
-- 
2.13.3

Re: [Qemu-devel] [PATCH 40/47] MAINTAINERS: add missing entry for AIO

[Fam Zheng]

On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 83597fca4e..fb6a82c1ad 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1253,6 +1253,7 @@ F: util/aio-*.c
>  F: block/io.c
>  F: migration/block*
>  F: include/block/aio.h
> +F: scripts/qemugdb/aio.py
>  T: git git://github.com/stefanha/qemu.git block
>  
>  Block Jobs
> -- 
> 2.13.3
> 

Acked-by: Fam Zheng <famz@redhat.com>

Re: [Qemu-devel] [PATCH 40/47] MAINTAINERS: add missing entry for AIO

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

On Fri, Jul 28, 2017 at 02:36:03AM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[Qemu-devel] [RFC PATCH 41/47] MAINTAINERS: add missing I2C entries

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index fb6a82c1ad..46807decf5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1630,6 +1630,12 @@ F: include/sysemu/replay.h
 F: docs/replay.txt
 F: stubs/replay.c
 
+I2C
+S: Orphan
+F: hw/i2c/core.c
+F: include/hw/i2c/i2c.h
+F: tests/libqos/i2c.?
+
 Usermode Emulation
 ------------------
 Overall
-- 
2.13.3

[Qemu-devel] [RFC PATCH 42/47] MAINTAINERS: add missing Bluetooth entries

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 46807decf5..10c34f2d6d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1636,6 +1636,12 @@ F: hw/i2c/core.c
 F: include/hw/i2c/i2c.h
 F: tests/libqos/i2c.?
 
+Bluetooth
+S: Orphan
+F: bt-*.c
+F: hw/bt/
+F: include/hw/bt.h
+
 Usermode Emulation
 ------------------
 Overall
-- 
2.13.3

[Qemu-devel] [RFC PATCH 43/47] MAINTAINERS: add missing TPM entries

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 10c34f2d6d..453f5fb3d7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1642,6 +1642,13 @@ F: bt-*.c
 F: hw/bt/
 F: include/hw/bt.h
 
+TPM:
+S: Orphan
+F: tpm.c
+F: hw/tpm/
+F: include/sysemu/tpm*.h
+F: backends/tpm.c
+
 Usermode Emulation
 ------------------
 Overall
-- 
2.13.3

[Qemu-devel] [RFC PATCH 44/47] MAINTAINERS: add missing entry for tilegx

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 453f5fb3d7..dc1a69051c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -283,6 +283,10 @@ F: hw/tricore/
 F: include/hw/tricore/
 F: default-configs/tricore-softmmu.mak
 
+TILE-Gx
+S: Orphan
+F: target/tilegx/
+
 Guest CPU Cores (KVM):
 ----------------------
 
-- 
2.13.3

Re: [Qemu-devel] [RFC PATCH 44/47] MAINTAINERS: add missing entry for tilegx

[Philippe Mathieu-Daudé]

ping?

I suppose no answer/ping timeout confirms there is no maintainer for 
"Odd Fixes" so the "Orphan" status is correct.

On 07/28/2017 02:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   MAINTAINERS | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 453f5fb3d7..dc1a69051c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -283,6 +283,10 @@ F: hw/tricore/
>   F: include/hw/tricore/
>   F: default-configs/tricore-softmmu.mak
>   
> +TILE-Gx
> +S: Orphan
> +F: target/tilegx/
> +
>   Guest CPU Cores (KVM):
>   ----------------------
>   
> 

[Qemu-devel] [RFC PATCH 45/47] MAINTAINERS: add missing entries for loader

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---

RFC because I'm not sure 'loader' is the same goal than 'generic-loader'

 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index dc1a69051c..224890643d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1196,6 +1196,8 @@ M: Alistair Francis <alistair.francis@xilinx.com>
 S: Maintained
 F: hw/core/generic-loader.c
 F: include/hw/core/generic-loader.h
+F: docs/generic-loader.txt
+F: hw/core/loader.c
 
 CHRP NVRAM
 M: Thomas Huth <thuth@redhat.com>
-- 
2.13.3

Re: [Qemu-devel] [RFC PATCH 45/47] MAINTAINERS: add missing entries for loader

[Alistair Francis]

On Thu, Jul 27, 2017 at 10:36 PM, Philippe Mathieu-Daudé
<f4bug@amsat.org> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>
> RFC because I'm not sure 'loader' is the same goal than 'generic-loader'

loader.c is not the same, it is the core loading framework for QEMU
while generic-loader is just something that uses it. This greatly
increases the amount on maintainership here.

In saying that if no one else wants it I can maintain it.

Thanks,
Alistair

>
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dc1a69051c..224890643d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1196,6 +1196,8 @@ M: Alistair Francis <alistair.francis@xilinx.com>
>  S: Maintained
>  F: hw/core/generic-loader.c
>  F: include/hw/core/generic-loader.h
> +F: docs/generic-loader.txt
> +F: hw/core/loader.c
>
>  CHRP NVRAM
>  M: Thomas Huth <thuth@redhat.com>
> --
> 2.13.3
>
>

[Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts

[Philippe Mathieu-Daudé]

and voluntary myself as reviewer

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---

I'm not a Coccinelle specialist but willing to learn and help!

 MAINTAINERS | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 224890643d..7854792765 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1537,6 +1537,12 @@ Checkpatch
 S: Odd Fixes
 F: scripts/checkpatch.pl
 
+Coccinelle scripts
+R: Philippe Mathieu-Daudé <f4bug@amsat.org>
+S: Orphan
+F: scripts/cocci-macro-file.h
+F: scripts/coccinelle/
+
 Migration
 M: Juan Quintela <quintela@redhat.com>
 M: Dr. David Alan Gilbert <dgilbert@redhat.com>
@@ -1970,4 +1976,3 @@ Build system architecture
 M: Daniel P. Berrange <berrange@redhat.com>
 S: Odd Fixes
 F: docs/devel/build-system.txt
-
-- 
2.13.3

Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts

[Fam Zheng]

On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote:
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 224890643d..7854792765 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1537,6 +1537,12 @@ Checkpatch
>  S: Odd Fixes
>  F: scripts/checkpatch.pl
>  
> +Coccinelle scripts
> +R: Philippe Mathieu-Daudé <f4bug@amsat.org>
> +S: Orphan

"Orphan" sounds like we don't care much anymore but I suppose this is not the
case. But I don't have any better idea either.

Fam

> +F: scripts/cocci-macro-file.h
> +F: scripts/coccinelle/
> +
>  Migration
>  M: Juan Quintela <quintela@redhat.com>
>  M: Dr. David Alan Gilbert <dgilbert@redhat.com>
> @@ -1970,4 +1976,3 @@ Build system architecture
>  M: Daniel P. Berrange <berrange@redhat.com>
>  S: Odd Fixes
>  F: docs/devel/build-system.txt

Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts

[Paolo Bonzini]

On 28/07/2017 08:24, Fam Zheng wrote:
> On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote:
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 224890643d..7854792765 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1537,6 +1537,12 @@ Checkpatch
>>  S: Odd Fixes
>>  F: scripts/checkpatch.pl
>>  
>> +Coccinelle scripts
>> +R: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> +S: Orphan
> 
> "Orphan" sounds like we don't care much anymore but I suppose this is not the
> case. But I don't have any better idea either.

Just don't add it to the file.  It doesn't have a specific owner.

Paolo

> 
> Fam
> 
>> +F: scripts/cocci-macro-file.h
>> +F: scripts/coccinelle/
>> +
>>  Migration
>>  M: Juan Quintela <quintela@redhat.com>
>>  M: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> @@ -1970,4 +1976,3 @@ Build system architecture
>>  M: Daniel P. Berrange <berrange@redhat.com>
>>  S: Odd Fixes
>>  F: docs/devel/build-system.txt

Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts

[Philippe Mathieu-Daudé]

On 07/28/2017 08:50 AM, Paolo Bonzini wrote:
> On 28/07/2017 08:24, Fam Zheng wrote:
>> On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote:
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 224890643d..7854792765 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1537,6 +1537,12 @@ Checkpatch
>>>   S: Odd Fixes
>>>   F: scripts/checkpatch.pl
>>>   
>>> +Coccinelle scripts
>>> +R: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> +S: Orphan
>>
>> "Orphan" sounds like we don't care much anymore but I suppose this is not the
>> case. But I don't have any better idea either.

         M: Mail patches to: FullName <address@domain>
         R: Designated reviewer: FullName <address@domain>

M: is mail of maintainer
R: is mail of reviewer

         S: Status, one of the following:

            Maintained:  Someone actually looks after it.
            Odd Fixes:   It has a maintainer but they don't have time
                         to do much other than throw the odd patch in.
->         Orphan:      No current maintainer

"Orphan" sounds the best fit... Do you want to raise it to "Odd Fixes"? 
This implies having a maintainer... I don't feel confident enough to Ack 
cocci scripts but an incorrect cocci script will not break QEMU so maybe 
I cat take M: for Odd Fixes, and lowering it back to Orphan without 
maintainer is 1 commit easy :)

> 
> Just don't add it to the file.  It doesn't have a specific owner.

Paolo you mean don't add the "S: Status" to the MAINTAINERS file, or the 
"F: *cocci*" entries?

Regards,

Phil.

> 
> Paolo
> 
>>
>> Fam
>>
>>> +F: scripts/cocci-macro-file.h
>>> +F: scripts/coccinelle/
>>> +
>>>   Migration
>>>   M: Juan Quintela <quintela@redhat.com>
>>>   M: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>> @@ -1970,4 +1976,3 @@ Build system architecture
>>>   M: Daniel P. Berrange <berrange@redhat.com>
>>>   S: Odd Fixes
>>>   F: docs/devel/build-system.txt
> 

Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts

[Philippe Mathieu-Daudé]

Hi Paolo,

On 07/28/2017 08:50 AM, Paolo Bonzini wrote:
> On 28/07/2017 08:24, Fam Zheng wrote:
>> On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote:
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 224890643d..7854792765 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1537,6 +1537,12 @@ Checkpatch
>>>   S: Odd Fixes
>>>   F: scripts/checkpatch.pl
>>>   
>>> +Coccinelle scripts
>>> +R: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> +S: Orphan
>>
>> "Orphan" sounds like we don't care much anymore but I suppose this is not the
>> case. But I don't have any better idea either.
> 
> Just don't add it to the file.  It doesn't have a specific owner
I thought an entry with F: but no M: was incorrect but apparently 
get_maintainer.pl works and report it as "unknown" status, as for the 
"Coroutines" section:

$ ./scripts/get_maintainer.pl -f util/coroutine-ucontext.c
Stefan Hajnoczi <stefanha@redhat.com> (unknown:Coroutines)
Kevin Wolf <kwolf@redhat.com> (unknown:Coroutines)
qemu-devel@nongnu.org (open list:All patches CC here)

So to enjoy the R-tag I'll remove the S-tag in v2 and see if Eric is ok 
with it :)

Regards,

Phil.

> 
> Paolo
> 
>>
>> Fam
>>
>>> +F: scripts/cocci-macro-file.h
>>> +F: scripts/coccinelle/
>>> +
>>>   Migration
>>>   M: Juan Quintela <quintela@redhat.com>
>>>   M: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>> @@ -1970,4 +1976,3 @@ Build system architecture
>>>   M: Daniel P. Berrange <berrange@redhat.com>
>>>   S: Odd Fixes
>>>   F: docs/devel/build-system.txt
> 

Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

On 07/28/2017 12:36 AM, Philippe Mathieu-Daudé wrote:
> and voluntary myself as reviewer

s/voluntary/volunteer/

> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> 
> I'm not a Coccinelle specialist but willing to learn and help!
> 

I'm not sure adding an orphan-only section helps; and some of the
particular scripts have specific maintainers (qobject.cocci).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

[Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 scripts/check_maintainer.sh | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100755 scripts/check_maintainer.sh

diff --git a/scripts/check_maintainer.sh b/scripts/check_maintainer.sh
new file mode 100755
index 0000000000..074a6acf69
--- /dev/null
+++ b/scripts/check_maintainer.sh
@@ -0,0 +1,21 @@
+#! /bin/bash
+#
+# This script checks MAINTAINERS consistency
+#
+# Copyright (C) 2017 Philippe Mathieu-Daudé. GPLv2+.
+#
+# Usage:
+# ./scripts/check_maintainer.sh | tee MAINTAINERS.missing
+
+echo "Incorrect MAINTAINERS paths:" 1>&2
+egrep ^F: MAINTAINERS | cut -d\  -f2 | while read p; do
+    ls -ld $p 1>/dev/null
+done
+
+echo "No maintainers found for:" 1>&2
+git ls-files|while read f; do
+    OUT=$(./scripts/get_maintainer.pl -f $f 2>&1)
+    if [[ "$OUT" == *"No maintainers found"* ]]; then
+        echo $f
+    fi
+done
-- 
2.13.3

Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS

[Markus Armbruster]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  scripts/check_maintainer.sh | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100755 scripts/check_maintainer.sh
>
> diff --git a/scripts/check_maintainer.sh b/scripts/check_maintainer.sh
> new file mode 100755
> index 0000000000..074a6acf69
> --- /dev/null
> +++ b/scripts/check_maintainer.sh
> @@ -0,0 +1,21 @@
> +#! /bin/bash
> +#
> +# This script checks MAINTAINERS consistency

Consistency?  I think you mean coverage.

> +#
> +# Copyright (C) 2017 Philippe Mathieu-Daudé. GPLv2+.
> +#
> +# Usage:
> +# ./scripts/check_maintainer.sh | tee MAINTAINERS.missing
> +
> +echo "Incorrect MAINTAINERS paths:" 1>&2
> +egrep ^F: MAINTAINERS | cut -d\  -f2 | while read p; do
> +    ls -ld $p 1>/dev/null
> +done
> +
> +echo "No maintainers found for:" 1>&2
> +git ls-files|while read f; do
> +    OUT=$(./scripts/get_maintainer.pl -f $f 2>&1)
> +    if [[ "$OUT" == *"No maintainers found"* ]]; then
> +        echo $f
> +    fi
> +done

Good idea.

But what I really want is checkpatch whining when it happens.  Thomas
posted a patch some time ago.  Would you be willing to revive it?

https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05742.html
Message-Id: <1485436265-12573-5-git-send-email-thuth@redhat.com>

Basically:

* Patch deletes a file

  - still in MAINTAINERS after the patch: warn
  - else: ok

* Patch creates a file

  - not in in MAINTAINERS after the patch: warn
  - else: ok

* Patch moves a file

  - old still in MAINTAINERS after the patch: warn
  - new not in in MAINTAINERS after the patch: warn
  - neither: ok

May have to ignore "uninteresting" files to reduce the noise.  But even
ignoring everything but *.[ch] would be an improvement!

Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1845 bytes --]

On 07/28/2017 11:26 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> 
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---

>> +# This script checks MAINTAINERS consistency
> 
> Consistency?  I think you mean coverage.

Indeed - consistency implies even more, such as all email addresses and
git trees are still valid.  Coverage is merely that all files at least
have one listed owner, whether or not that owner is still correct.

> But what I really want is checkpatch whining when it happens.  Thomas
> posted a patch some time ago.  Would you be willing to revive it?
> 
> https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05742.html
> Message-Id: <1485436265-12573-5-git-send-email-thuth@redhat.com>
> 
> Basically:
> 
> * Patch deletes a file
> 
>   - still in MAINTAINERS after the patch: warn
>   - else: ok
> 

Careful, since we have globs in MAINTAINERS.  I guess it really means:

* Patch deletes a file:
   - check all lines in MAINTAINERS; if any no longer maps to a file: warn
   - else: ok

> * Patch creates a file
> 
>   - not in in MAINTAINERS after the patch: warn
>   - else: ok
> 
> * Patch moves a file

Same as delete + move, even if it shows up in git differently.

> 
> May have to ignore "uninteresting" files to reduce the noise.  But even
> ignoring everything but *.[ch] would be an improvement!

And like all checkpatch warnings, maintainers (or, in this case, lack of
maintainer?) can ignore the warning and submit pull request anyway.  But
the key part is that by making it part of checkpatch, coupled with
patchew CI, the whole list would know who's ignoring the warnings :)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

On 07/28/2017 12:36 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  scripts/check_maintainer.sh | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100755 scripts/check_maintainer.sh
> 

> +echo "Incorrect MAINTAINERS paths:" 1>&2
> +egrep ^F: MAINTAINERS | cut -d\  -f2 | while read p; do
> +    ls -ld $p 1>/dev/null
> +done

Ah, you uses this in a cover letter of your other series, where I
responded without thinking it was going into git.  But now that I see we
are trying to commit it, I really think that one 'ls -l >/dev/null' per
filename is inefficient; this should be

egrep ^F: MAINTAINERS | cut -d\  -f2 | xargs ls -d >/dev/null

if we really like the side effect of ls writing to stdout as the way to
identify globs that no longer map anywhere, or even something like:

for glob in $(egrep ... | cut ...); do
    set - $glob
    if test -n "$2" && ! test -e "$1"; then
        echo "glob $glob no longer resolves" 2>&1
    fi
done

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

Re: [Qemu-devel] [PATCH 00/47] add missing entries in MAINTAINERS

[Markus Armbruster]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Hi,
>
> I first prepared this series thinking about 2.10 but then realized if someone
> is calling ./scripts/get_maintainer.pl he better is using an updated git
> clone :)
>
> Distribs do provide docs/ files in /usr/share/doc/qemu* but not the
> MAINTAINERS file so no hurry for this series.
>
> I provided the script I used in the last patch, I plan to improve it so
> patchew/travis can start to use it: if a new file is added to the repository
> without being covered in MAINTAINERS the script remember the submitter about
> it and eventually he'll resend his patch, I think this is a good practice and
> help the next contributors (anyway this is a valuable experience to look at a
> file history to see who has been hacking around when there is no MAINTAINERS
> entry).
>
> I don't want to overburden current maintainers, so the last patches add
> Orphans entries but I tried to select relevant commiters and include them in
> each patch.
>
> The criteria I used is "If I change this file, who should I notify? Who would
> be interested?"

Where do we stand with this series?

Re: [Qemu-devel] [PATCH 00/47] add missing entries in MAINTAINERS

[Philippe Mathieu-Daudé]

Hi Markus,

On 08/28/2017 08:28 AM, Markus Armbruster wrote:
> Where do we stand with this series?

I was giving time to eventual adoptive maintainers until 2.11 opening :)

Regards,

Phil.