All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Sinan Kaya <okaya@codeaurora.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Yehezkel Bernat <yehezkel.bernat@intel.com>,
	Michael Jamet <michael.jamet@intel.com>,
	linux-pci@vger.kernel.org
Subject: Re: Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown
Date: Fri, 12 Jan 2018 12:03:24 +0100	[thread overview]
Message-ID: <20180112110324.GB10599@wunner.de> (raw)
In-Reply-To: <20180112104929.GA10599@wunner.de>

On Fri, Jan 12, 2018 at 11:49:29AM +0100, Lukas Wunner wrote:
> I'm not sure which Thunderbolt controllers fake the ability to send
> CC interrupts but my old Light Ridge is definitely affected and I recall
> seeing logs of newer Cactus Ridge and Falcon Ridge (Thunderbolt 2)
> controllers which also had this issue.  I'm cc'ing Intel folks in the
> hope that they may know the details.  I believe Mika has a MacBookPro13,3
> with Alpine Ridge (Thunderbolt 3) and could verify if that also has
> this issue. These MacBook Pros have two Thunderbolt controllers,
> so if affected, the commit would delay reboot by 16 seconds.

I managed to dig up lspci output for a MacBookPro13,3 and Alpine Ridge
has 1b in the No Command Completed Support field of the Slot Capabilities
register, so no delay is observed at all and these newer machines are not
affected.

Question is, do the older controllers likewise not need a delay?

Lukas

  reply	other threads:[~2018-01-12 11:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 10:49 Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown Lukas Wunner
2018-01-12 11:03 ` Lukas Wunner [this message]
2018-01-12 14:26 ` Sinan Kaya
2018-01-12 15:12   ` Lukas Wunner
2018-01-12 15:31     ` Sinan Kaya
2018-01-13  7:32       ` Lukas Wunner
2018-01-13 17:58         ` okaya
2018-01-13 19:39           ` Lukas Wunner
2018-01-13 20:49             ` okaya
2018-01-12 16:34 ` Mika Westerberg
2018-01-13  7:14   ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180112110324.GB10599@wunner.de \
    --to=lukas@wunner.de \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=okaya@codeaurora.org \
    --cc=yehezkel.bernat@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.