All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: okaya@codeaurora.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Yehezkel Bernat <yehezkel.bernat@intel.com>,
	Michael Jamet <michael.jamet@intel.com>,
	linux-pci@vger.kernel.org
Subject: Re: Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown
Date: Sat, 13 Jan 2018 20:39:31 +0100	[thread overview]
Message-ID: <20180113193931.GA3585@wunner.de> (raw)
In-Reply-To: <0134d7603402079fd4f3a7b15406bd26@codeaurora.org>

On Sat, Jan 13, 2018 at 12:58:53PM -0500, okaya@codeaurora.org wrote:
> I waa thinking of using nowait variant of write function in notification
> disable function in order to not introduce new behavior for existing
> silicon.

After writing to the Slot Control register to turn off IRQ notification,
we free the IRQ with pciehp_free_irq().  If we don't wait for the command
to complete, we risk getting an interrupt after the IRQ was freed.

Kind regards,

Lukas

  reply	other threads:[~2018-01-13 19:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 10:49 Lukas Wunner
2018-01-12 11:03 ` Lukas Wunner
2018-01-12 14:26 ` Sinan Kaya
2018-01-12 15:12   ` Lukas Wunner
2018-01-12 15:31     ` Sinan Kaya
2018-01-13  7:32       ` Lukas Wunner
2018-01-13 17:58         ` okaya
2018-01-13 19:39           ` Lukas Wunner [this message]
2018-01-13 20:49             ` okaya
2018-01-12 16:34 ` Mika Westerberg
2018-01-13  7:14   ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180113193931.GA3585@wunner.de \
    --to=lukas@wunner.de \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=okaya@codeaurora.org \
    --cc=yehezkel.bernat@intel.com \
    --subject='Re: Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.