From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Ilia Lin <ilialin@codeaurora.org> Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, mark.rutland@arm.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, andy.gross@linaro.org, david.brown@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rnayak@codeaurora.org, amit.kucheria@linaro.org, nicolas.dechesne@linaro.org, celster@codeaurora.org, tfinkel@codeaurora.org Subject: Re: [PATCH v4 01/14] soc: qcom: Separate kryo l2 accessors from PMU driver Date: Sun, 1 Apr 2018 15:34:56 -0700 [thread overview] Message-ID: <20180401223456.GG510@tuxbook-pro> (raw) In-Reply-To: <1522358807-10413-2-git-send-email-ilialin@codeaurora.org> On Thu 29 Mar 14:26 PDT 2018, Ilia Lin wrote: > diff --git a/drivers/soc/qcom/kryo-l2-accessors.c b/drivers/soc/qcom/kryo-l2-accessors.c > new file mode 100644 > index 0000000..b0356c2 > --- /dev/null > +++ b/drivers/soc/qcom/kryo-l2-accessors.c > @@ -0,0 +1,66 @@ > +/* > + * Copyright (c) 2014-2015, 2018, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 and > + * only version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ The copyright header in the C file should be: // SPDX-License-Identifier: GPL-2.0 /* * Copyright (c) 2014-2015, 2018, The Linux Foundation. All rights reserved. */ > + > +#include <linux/spinlock.h> > +#include <asm/sysreg.h> > +#include <soc/qcom/kryo-l2-accessors.h> > + > +#define L2CPUSRSELR_EL1 sys_reg(3, 3, 15, 0, 6) > +#define L2CPUSRDR_EL1 sys_reg(3, 3, 15, 0, 7) > + > +static DEFINE_RAW_SPINLOCK(l2_access_lock); > + > +/** > + * set_l2_indirect_reg: write value to an L2 register * set_l2_indirect_reg() - write value to an L2 register > + * @reg: Address of L2 register. > + * @value: Value to be written to register. > + * > + * Use architecturally required barriers for ordering between system register > + * accesses, and system registers with respect to device memory > + */ > +void set_l2_indirect_reg(u64 reg, u64 val) As these are now kernel-global functions I recommend that you give them a slightly more specific name; e.g. kryo_l2_set_indirect_reg() and kryo_l2_get_indirect_reg(). [..] > diff --git a/include/soc/qcom/kryo-l2-accessors.h b/include/soc/qcom/kryo-l2-accessors.h > new file mode 100644 > index 0000000..3c796cf > --- /dev/null > +++ b/include/soc/qcom/kryo-l2-accessors.h > @@ -0,0 +1,20 @@ > +/* > + * Copyright (c) 2018, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 and > + * only version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ And in the header file it should be: /* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2014-2015, 2018, The Linux Foundation. All rights reserved. */ > + > +#ifndef __SOC_ARCH_QCOM_KRYO_L2_ACCESSORS_H > +#define __SOC_ARCH_QCOM_KRYO_L2_ACCESSORS_H > + > +void set_l2_indirect_reg(u64 reg_addr, u64 val); > +u64 get_l2_indirect_reg(u64 reg_addr); Rename "reg_addr" to "reg" to match the implementation. Regards, Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 01/14] soc: qcom: Separate kryo l2 accessors from PMU driver Date: Sun, 1 Apr 2018 15:34:56 -0700 [thread overview] Message-ID: <20180401223456.GG510@tuxbook-pro> (raw) In-Reply-To: <1522358807-10413-2-git-send-email-ilialin@codeaurora.org> On Thu 29 Mar 14:26 PDT 2018, Ilia Lin wrote: > diff --git a/drivers/soc/qcom/kryo-l2-accessors.c b/drivers/soc/qcom/kryo-l2-accessors.c > new file mode 100644 > index 0000000..b0356c2 > --- /dev/null > +++ b/drivers/soc/qcom/kryo-l2-accessors.c > @@ -0,0 +1,66 @@ > +/* > + * Copyright (c) 2014-2015, 2018, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 and > + * only version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ The copyright header in the C file should be: // SPDX-License-Identifier: GPL-2.0 /* * Copyright (c) 2014-2015, 2018, The Linux Foundation. All rights reserved. */ > + > +#include <linux/spinlock.h> > +#include <asm/sysreg.h> > +#include <soc/qcom/kryo-l2-accessors.h> > + > +#define L2CPUSRSELR_EL1 sys_reg(3, 3, 15, 0, 6) > +#define L2CPUSRDR_EL1 sys_reg(3, 3, 15, 0, 7) > + > +static DEFINE_RAW_SPINLOCK(l2_access_lock); > + > +/** > + * set_l2_indirect_reg: write value to an L2 register * set_l2_indirect_reg() - write value to an L2 register > + * @reg: Address of L2 register. > + * @value: Value to be written to register. > + * > + * Use architecturally required barriers for ordering between system register > + * accesses, and system registers with respect to device memory > + */ > +void set_l2_indirect_reg(u64 reg, u64 val) As these are now kernel-global functions I recommend that you give them a slightly more specific name; e.g. kryo_l2_set_indirect_reg() and kryo_l2_get_indirect_reg(). [..] > diff --git a/include/soc/qcom/kryo-l2-accessors.h b/include/soc/qcom/kryo-l2-accessors.h > new file mode 100644 > index 0000000..3c796cf > --- /dev/null > +++ b/include/soc/qcom/kryo-l2-accessors.h > @@ -0,0 +1,20 @@ > +/* > + * Copyright (c) 2018, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 and > + * only version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ And in the header file it should be: /* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2014-2015, 2018, The Linux Foundation. All rights reserved. */ > + > +#ifndef __SOC_ARCH_QCOM_KRYO_L2_ACCESSORS_H > +#define __SOC_ARCH_QCOM_KRYO_L2_ACCESSORS_H > + > +void set_l2_indirect_reg(u64 reg_addr, u64 val); > +u64 get_l2_indirect_reg(u64 reg_addr); Rename "reg_addr" to "reg" to match the implementation. Regards, Bjorn
next prev parent reply other threads:[~2018-04-01 22:34 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-29 21:26 [PATCH v4 00/14] CPU scaling support for msm8996 Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 01/14] soc: qcom: Separate kryo l2 accessors from PMU driver Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-31 4:39 ` kbuild test robot 2018-03-31 4:39 ` kbuild test robot 2018-03-31 4:39 ` kbuild test robot 2018-04-01 22:34 ` Bjorn Andersson [this message] 2018-04-01 22:34 ` Bjorn Andersson 2018-03-29 21:26 ` [PATCH v4 02/14] clk: qcom: Make clk_alpha_pll_configure available to modules Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 03/14] clk: qcom: Add CPU clock driver for msm8996 Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 04/14] clk: qcom: Add DT bindings for " Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-04-05 13:18 ` Rob Herring 2018-04-05 13:18 ` Rob Herring 2018-03-29 21:26 ` [PATCH v4 05/14] clk: qcom: cpu-8996: Add support to switch to alternate PLL Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 06/14] clk: qcom: cpu-8996: Add support to switch below 600Mhz Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 07/14] clk: qcom: Add ACD path to CPU clock driver for msm8996 Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 08/14] dt: qcom: Add opp and thermal to the msm8996 Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-04-02 9:16 ` Viresh Kumar 2018-04-02 9:16 ` Viresh Kumar 2018-05-04 6:04 ` Viresh Kumar 2018-05-04 6:04 ` Viresh Kumar 2018-05-04 6:04 ` Viresh Kumar 2018-05-04 6:48 ` ilialin 2018-05-04 6:48 ` ilialin at codeaurora.org 2018-05-04 6:48 ` ilialin 2018-05-04 6:48 ` ilialin 2018-05-04 7:03 ` Viresh Kumar 2018-05-04 7:03 ` Viresh Kumar 2018-05-04 7:03 ` Viresh Kumar 2018-03-29 21:26 ` [PATCH v4 09/14] regulator: qcom_spmi: Add support for SAW Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 10/14] dt-bindings: Add support for SAW documentation Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-04-09 20:21 ` Rob Herring 2018-04-09 20:21 ` Rob Herring 2018-04-17 11:09 ` Mark Brown 2018-04-17 11:09 ` Mark Brown 2018-03-29 21:26 ` [PATCH v4 11/14] dt: qcom: Add SAW regulator for 8x96 CPUs Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-03-29 21:26 ` [PATCH v4 12/14] cpufreq: Add Kryo CPU scaling driver Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-04-02 9:26 ` Viresh Kumar 2018-04-02 9:26 ` Viresh Kumar 2018-04-02 14:56 ` Sricharan R 2018-04-02 14:56 ` Sricharan R 2018-03-29 21:26 ` [PATCH v4 13/14] dt-bindings: cpufreq: Document operating-points-v2-kryo-cpu Ilia Lin 2018-03-29 21:26 ` Ilia Lin 2018-04-02 9:30 ` Viresh Kumar 2018-04-02 9:30 ` Viresh Kumar 2018-04-02 15:07 ` Sricharan R 2018-04-02 15:07 ` Sricharan R 2018-04-03 2:41 ` Sricharan R 2018-04-03 2:41 ` Sricharan R 2018-04-03 4:23 ` Viresh Kumar 2018-04-03 4:23 ` Viresh Kumar 2018-04-03 16:39 ` Sricharan R 2018-04-03 16:39 ` Sricharan R 2018-03-29 21:26 ` [PATCH v4 14/14] dt: qcom: Add qcom-cpufreq-kryo driver configuration Ilia Lin 2018-03-29 21:26 ` Ilia Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180401223456.GG510@tuxbook-pro \ --to=bjorn.andersson@linaro.org \ --cc=amit.kucheria@linaro.org \ --cc=andy.gross@linaro.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=celster@codeaurora.org \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=ilialin@codeaurora.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=nicolas.dechesne@linaro.org \ --cc=rjw@rjwysocki.net \ --cc=rnayak@codeaurora.org \ --cc=robh@kernel.org \ --cc=sboyd@kernel.org \ --cc=tfinkel@codeaurora.org \ --cc=viresh.kumar@linaro.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.