From: Vinod Koul <vinod.koul@intel.com> To: Baolin Wang <baolin.wang@linaro.org> Cc: dan.j.williams@intel.com, eric.long@spreadtrum.com, broonie@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Date: Wed, 11 Apr 2018 15:06:34 +0530 [thread overview] Message-ID: <20180411093634.GC6014@localhost> (raw) On Tue, Apr 10, 2018 at 03:46:06PM +0800, Baolin Wang wrote: > +/* > + * struct sprd_dma_config - DMA configuration structure > + * @config: dma slave channel config > + * @fragment_len: specify one fragment transfer length > + * @block_len: specify one block transfer length > + * @transcation_len: specify one transcation transfer length > + * @wrap_ptr: wrap pointer address, once the transfer address reaches the > + * 'wrap_ptr', the next transfer address will jump to the 'wrap_to' address. > + * @wrap_to: wrap jump to address > + * @req_mode: specify the DMA request mode > + * @int_mode: specify the DMA interrupt type > + */ > +struct sprd_dma_config { > + struct dma_slave_config config; > + u32 fragment_len; why not use _maxburst? > + u32 block_len; > + u32 transcation_len; what does block and transaction len refer to here > + phys_addr_t wrap_ptr; > + phys_addr_t wrap_to; this sound sg_list to me, why are we not using that here > + enum sprd_dma_req_mode req_mode; Looking at definition of request mode we have frag, block, transaction list etc.. That should depend upon dma request. If you have been asked to transfer a list, you shall configure list mode. if it is a single transaction then it should be transaction mode! > + enum sprd_dma_int_type int_mode; Here again I think driver needs to take a call based on dma_ctrl_flags. Okay I dont think we are proceeding in right direction on this one. This seems to be fairly generic dma controller and in line with other IP blocks and you should take reference from those one. I dont think we need this configuration and can do with generic api and configuration provided. Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com> To: Baolin Wang <baolin.wang@linaro.org> Cc: dan.j.williams@intel.com, eric.long@spreadtrum.com, broonie@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Date: Wed, 11 Apr 2018 15:06:34 +0530 [thread overview] Message-ID: <20180411093634.GC6014@localhost> (raw) In-Reply-To: <0c2b76aba6a49e583f920ae582d6815fa9cc4361.1523346135.git.baolin.wang@linaro.org> On Tue, Apr 10, 2018 at 03:46:06PM +0800, Baolin Wang wrote: > +/* > + * struct sprd_dma_config - DMA configuration structure > + * @config: dma slave channel config > + * @fragment_len: specify one fragment transfer length > + * @block_len: specify one block transfer length > + * @transcation_len: specify one transcation transfer length > + * @wrap_ptr: wrap pointer address, once the transfer address reaches the > + * 'wrap_ptr', the next transfer address will jump to the 'wrap_to' address. > + * @wrap_to: wrap jump to address > + * @req_mode: specify the DMA request mode > + * @int_mode: specify the DMA interrupt type > + */ > +struct sprd_dma_config { > + struct dma_slave_config config; > + u32 fragment_len; why not use _maxburst? > + u32 block_len; > + u32 transcation_len; what does block and transaction len refer to here > + phys_addr_t wrap_ptr; > + phys_addr_t wrap_to; this sound sg_list to me, why are we not using that here > + enum sprd_dma_req_mode req_mode; Looking at definition of request mode we have frag, block, transaction list etc.. That should depend upon dma request. If you have been asked to transfer a list, you shall configure list mode. if it is a single transaction then it should be transaction mode! > + enum sprd_dma_int_type int_mode; Here again I think driver needs to take a call based on dma_ctrl_flags. Okay I dont think we are proceeding in right direction on this one. This seems to be fairly generic dma controller and in line with other IP blocks and you should take reference from those one. I dont think we need this configuration and can do with generic api and configuration provided. Thanks -- ~Vinod
next reply other threads:[~2018-04-11 9:36 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-11 9:36 Vinod Koul [this message] 2018-04-11 9:36 ` [PATCH 4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Vinod Koul -- strict thread matches above, loose matches on Subject: below -- 2018-04-18 5:40 [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang 2018-04-18 5:40 ` [PATCH 5/5] " Baolin Wang 2018-04-17 10:45 [5/5] " Lars-Peter Clausen 2018-04-17 10:45 ` [PATCH 5/5] " Lars-Peter Clausen 2018-04-17 6:06 [4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Baolin Wang 2018-04-17 6:06 ` [PATCH 4/5] " Baolin Wang 2018-04-16 15:35 [4/5] " Vinod Koul 2018-04-16 15:35 ` [PATCH 4/5] " Vinod Koul 2018-04-16 6:32 [4/5] " Baolin Wang 2018-04-16 6:32 ` [PATCH 4/5] " Baolin Wang 2018-04-16 3:58 [4/5] " Vinod Koul 2018-04-16 3:58 ` [PATCH 4/5] " Vinod Koul 2018-04-13 10:48 [4/5] " Baolin Wang 2018-04-13 10:48 ` [PATCH 4/5] " Baolin Wang 2018-04-13 10:11 [4/5] " Vinod Koul 2018-04-13 10:11 ` [PATCH 4/5] " Vinod Koul 2018-04-13 6:41 [4/5] " Baolin Wang 2018-04-13 6:41 ` [PATCH 4/5] " Baolin Wang 2018-04-13 6:36 [4/5] " Vinod Koul 2018-04-13 6:36 ` [PATCH 4/5] " Vinod Koul 2018-04-13 6:17 [4/5] " Baolin Wang 2018-04-13 6:17 ` [PATCH 4/5] " Baolin Wang 2018-04-13 5:44 [4/5] " Baolin Wang 2018-04-13 5:44 ` [PATCH 4/5] " Baolin Wang 2018-04-13 3:43 [4/5] " Vinod Koul 2018-04-13 3:43 ` [PATCH 4/5] " Vinod Koul 2018-04-13 3:39 [4/5] " Vinod Koul 2018-04-13 3:39 ` [PATCH 4/5] " Vinod Koul 2018-04-12 11:36 [4/5] " Baolin Wang 2018-04-12 11:36 ` [PATCH 4/5] " Baolin Wang 2018-04-12 11:30 [4/5] " Baolin Wang 2018-04-12 11:30 ` [PATCH 4/5] " Baolin Wang 2018-04-12 9:37 [4/5] " Vinod Koul 2018-04-12 9:37 ` [PATCH 4/5] " Vinod Koul 2018-04-11 12:13 [4/5] " Baolin Wang 2018-04-11 12:13 ` [PATCH 4/5] " Baolin Wang 2018-04-11 10:51 [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang 2018-04-11 10:51 ` [PATCH 5/5] " Baolin Wang 2018-04-11 10:49 [1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang 2018-04-11 10:49 ` [PATCH 1/5] " Baolin Wang 2018-04-11 9:40 [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Vinod Koul 2018-04-11 9:40 ` [PATCH 5/5] " Vinod Koul 2018-04-11 9:24 [1/5] dmaengine: sprd: Define the DMA transfer step type Vinod Koul 2018-04-11 9:24 ` [PATCH 1/5] " Vinod Koul 2018-04-10 7:46 [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang 2018-04-10 7:46 ` [PATCH 5/5] " Baolin Wang 2018-04-10 7:46 [4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Baolin Wang 2018-04-10 7:46 ` [PATCH 4/5] " Baolin Wang 2018-04-10 7:46 [3/5] dmaengine: sprd: Move DMA request mode and interrupt type into head file Baolin Wang 2018-04-10 7:46 ` [PATCH 3/5] " Baolin Wang 2018-04-10 7:46 [2/5] dmaengine: sprd: Define the DMA data width type Baolin Wang 2018-04-10 7:46 ` [PATCH 2/5] " Baolin Wang 2018-04-10 7:46 [1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang 2018-04-10 7:46 ` [PATCH 1/5] " Baolin Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180411093634.GC6014@localhost \ --to=vinod.koul@intel.com \ --cc=baolin.wang@linaro.org \ --cc=broonie@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=eric.long@spreadtrum.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.