From: Lars-Peter Clausen <lars@metafoo.de>
To: Baolin Wang <baolin.wang@linaro.org>,
dan.j.williams@intel.com, vinod.koul@intel.com
Cc: eric.long@spreadtrum.com, broonie@kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces
Date: Tue, 17 Apr 2018 12:45:20 +0200 [thread overview]
Message-ID: <5c951129-b167-3ed6-48f4-0a42cd2df28e@metafoo.de> (raw)
On 04/10/2018 09:46 AM, Baolin Wang wrote:
[...]
> +static int sprd_dma_slave_config(struct dma_chan *chan,
> + struct dma_slave_config *config)
> +{
> + struct sprd_dma_chn *schan = to_sprd_dma_chan(chan);
> + struct sprd_dma_config *slave_cfg =
> + container_of(config, struct sprd_dma_config, config);
> +
Please do not overload standard API with custom semantics. This makes the
driver incompatible to the API and negates the whole idea of having a common
API. E.g. this will crash when somebody passes a normal dma_slave_config
struct to this function.
> + memcpy(&schan->slave_cfg, slave_cfg, sizeof(*slave_cfg));
> + return 0;
> +}
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Baolin Wang <baolin.wang@linaro.org>,
dan.j.williams@intel.com, vinod.koul@intel.com
Cc: eric.long@spreadtrum.com, broonie@kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces
Date: Tue, 17 Apr 2018 12:45:20 +0200 [thread overview]
Message-ID: <5c951129-b167-3ed6-48f4-0a42cd2df28e@metafoo.de> (raw)
In-Reply-To: <0a9fa618bd74e74c135ebee2e40b30d361c1d905.1523346135.git.baolin.wang@linaro.org>
On 04/10/2018 09:46 AM, Baolin Wang wrote:
[...]
> +static int sprd_dma_slave_config(struct dma_chan *chan,
> + struct dma_slave_config *config)
> +{
> + struct sprd_dma_chn *schan = to_sprd_dma_chan(chan);
> + struct sprd_dma_config *slave_cfg =
> + container_of(config, struct sprd_dma_config, config);
> +
Please do not overload standard API with custom semantics. This makes the
driver incompatible to the API and negates the whole idea of having a common
API. E.g. this will crash when somebody passes a normal dma_slave_config
struct to this function.
> + memcpy(&schan->slave_cfg, slave_cfg, sizeof(*slave_cfg));
> + return 0;
> +}
next reply other threads:[~2018-04-17 10:45 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 10:45 Lars-Peter Clausen [this message]
2018-04-17 10:45 ` [PATCH 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Lars-Peter Clausen
-- strict thread matches above, loose matches on Subject: below --
2018-04-18 5:40 [5/5] " Baolin Wang
2018-04-18 5:40 ` [PATCH 5/5] " Baolin Wang
2018-04-17 6:06 [4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Baolin Wang
2018-04-17 6:06 ` [PATCH 4/5] " Baolin Wang
2018-04-16 15:35 [4/5] " Vinod Koul
2018-04-16 15:35 ` [PATCH 4/5] " Vinod Koul
2018-04-16 6:32 [4/5] " Baolin Wang
2018-04-16 6:32 ` [PATCH 4/5] " Baolin Wang
2018-04-16 3:58 [4/5] " Vinod Koul
2018-04-16 3:58 ` [PATCH 4/5] " Vinod Koul
2018-04-13 10:48 [4/5] " Baolin Wang
2018-04-13 10:48 ` [PATCH 4/5] " Baolin Wang
2018-04-13 10:11 [4/5] " Vinod Koul
2018-04-13 10:11 ` [PATCH 4/5] " Vinod Koul
2018-04-13 6:41 [4/5] " Baolin Wang
2018-04-13 6:41 ` [PATCH 4/5] " Baolin Wang
2018-04-13 6:36 [4/5] " Vinod Koul
2018-04-13 6:36 ` [PATCH 4/5] " Vinod Koul
2018-04-13 6:17 [4/5] " Baolin Wang
2018-04-13 6:17 ` [PATCH 4/5] " Baolin Wang
2018-04-13 5:44 [4/5] " Baolin Wang
2018-04-13 5:44 ` [PATCH 4/5] " Baolin Wang
2018-04-13 3:43 [4/5] " Vinod Koul
2018-04-13 3:43 ` [PATCH 4/5] " Vinod Koul
2018-04-13 3:39 [4/5] " Vinod Koul
2018-04-13 3:39 ` [PATCH 4/5] " Vinod Koul
2018-04-12 11:36 [4/5] " Baolin Wang
2018-04-12 11:36 ` [PATCH 4/5] " Baolin Wang
2018-04-12 11:30 [4/5] " Baolin Wang
2018-04-12 11:30 ` [PATCH 4/5] " Baolin Wang
2018-04-12 9:37 [4/5] " Vinod Koul
2018-04-12 9:37 ` [PATCH 4/5] " Vinod Koul
2018-04-11 12:13 [4/5] " Baolin Wang
2018-04-11 12:13 ` [PATCH 4/5] " Baolin Wang
2018-04-11 10:51 [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang
2018-04-11 10:51 ` [PATCH 5/5] " Baolin Wang
2018-04-11 10:49 [1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang
2018-04-11 10:49 ` [PATCH 1/5] " Baolin Wang
2018-04-11 9:40 [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Vinod Koul
2018-04-11 9:40 ` [PATCH 5/5] " Vinod Koul
2018-04-11 9:36 [4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Vinod Koul
2018-04-11 9:36 ` [PATCH 4/5] " Vinod Koul
2018-04-11 9:24 [1/5] dmaengine: sprd: Define the DMA transfer step type Vinod Koul
2018-04-11 9:24 ` [PATCH 1/5] " Vinod Koul
2018-04-10 7:46 [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang
2018-04-10 7:46 ` [PATCH 5/5] " Baolin Wang
2018-04-10 7:46 [4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Baolin Wang
2018-04-10 7:46 ` [PATCH 4/5] " Baolin Wang
2018-04-10 7:46 [3/5] dmaengine: sprd: Move DMA request mode and interrupt type into head file Baolin Wang
2018-04-10 7:46 ` [PATCH 3/5] " Baolin Wang
2018-04-10 7:46 [2/5] dmaengine: sprd: Define the DMA data width type Baolin Wang
2018-04-10 7:46 ` [PATCH 2/5] " Baolin Wang
2018-04-10 7:46 [1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang
2018-04-10 7:46 ` [PATCH 1/5] " Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c951129-b167-3ed6-48f4-0a42cd2df28e@metafoo.de \
--to=lars@metafoo.de \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.long@spreadtrum.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.