[5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Baolin Wang <baolin.wang@linaro.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Vinod Koul <vinod.koul@intel.com>,
	Eric Long <eric.long@spreadtrum.com>,
	Mark Brown <broonie@kernel.org>,
	dmaengine@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces
Date: Wed, 18 Apr 2018 13:40:54 +0800	[thread overview]
Message-ID: <CAMz4ku+zPiucHyLF5HBtH9LhcTDUUec-kTLQG2YQ3hBK=9HHDw@mail.gmail.com> (raw)

On 17 April 2018 at 18:45, Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 04/10/2018 09:46 AM, Baolin Wang wrote:
> [...]
>> +static int sprd_dma_slave_config(struct dma_chan *chan,
>> +                              struct dma_slave_config *config)
>> +{
>> +     struct sprd_dma_chn *schan = to_sprd_dma_chan(chan);
>> +     struct sprd_dma_config *slave_cfg =
>> +             container_of(config, struct sprd_dma_config, config);
>> +
>
> Please do not overload standard API with custom semantics. This makes the
> driver incompatible to the API and negates the whole idea of having a common
> API. E.g. this will crash when somebody passes a normal dma_slave_config
> struct to this function.
>

Yes, we have discussed with Vinod how to use 'dma_slave_config' to
reach our requirements. Thanks for your comments.

WARNING: multiple messages have this Message-ID (diff)

From: Baolin Wang <baolin.wang@linaro.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Vinod Koul <vinod.koul@intel.com>,
	Eric Long <eric.long@spreadtrum.com>,
	Mark Brown <broonie@kernel.org>,
	dmaengine@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces
Date: Wed, 18 Apr 2018 13:40:54 +0800	[thread overview]
Message-ID: <CAMz4ku+zPiucHyLF5HBtH9LhcTDUUec-kTLQG2YQ3hBK=9HHDw@mail.gmail.com> (raw)
In-Reply-To: <5c951129-b167-3ed6-48f4-0a42cd2df28e@metafoo.de>

On 17 April 2018 at 18:45, Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 04/10/2018 09:46 AM, Baolin Wang wrote:
> [...]
>> +static int sprd_dma_slave_config(struct dma_chan *chan,
>> +                              struct dma_slave_config *config)
>> +{
>> +     struct sprd_dma_chn *schan = to_sprd_dma_chan(chan);
>> +     struct sprd_dma_config *slave_cfg =
>> +             container_of(config, struct sprd_dma_config, config);
>> +
>
> Please do not overload standard API with custom semantics. This makes the
> driver incompatible to the API and negates the whole idea of having a common
> API. E.g. this will crash when somebody passes a normal dma_slave_config
> struct to this function.
>

Yes, we have discussed with Vinod how to use 'dma_slave_config' to
reach our requirements. Thanks for your comments.

-- 
Baolin.wang
Best Regards

next             reply	other threads:[~2018-04-18  5:40 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18  5:40 Baolin Wang [this message]
2018-04-18  5:40 ` [PATCH 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang
  -- strict thread matches above, loose matches on Subject: below --
2018-04-17 10:45 [5/5] " Lars-Peter Clausen
2018-04-17 10:45 ` [PATCH 5/5] " Lars-Peter Clausen
2018-04-17  6:06 [4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Baolin Wang
2018-04-17  6:06 ` [PATCH 4/5] " Baolin Wang
2018-04-16 15:35 [4/5] " Vinod Koul
2018-04-16 15:35 ` [PATCH 4/5] " Vinod Koul
2018-04-16  6:32 [4/5] " Baolin Wang
2018-04-16  6:32 ` [PATCH 4/5] " Baolin Wang
2018-04-16  3:58 [4/5] " Vinod Koul
2018-04-16  3:58 ` [PATCH 4/5] " Vinod Koul
2018-04-13 10:48 [4/5] " Baolin Wang
2018-04-13 10:48 ` [PATCH 4/5] " Baolin Wang
2018-04-13 10:11 [4/5] " Vinod Koul
2018-04-13 10:11 ` [PATCH 4/5] " Vinod Koul
2018-04-13  6:41 [4/5] " Baolin Wang
2018-04-13  6:41 ` [PATCH 4/5] " Baolin Wang
2018-04-13  6:36 [4/5] " Vinod Koul
2018-04-13  6:36 ` [PATCH 4/5] " Vinod Koul
2018-04-13  6:17 [4/5] " Baolin Wang
2018-04-13  6:17 ` [PATCH 4/5] " Baolin Wang
2018-04-13  5:44 [4/5] " Baolin Wang
2018-04-13  5:44 ` [PATCH 4/5] " Baolin Wang
2018-04-13  3:43 [4/5] " Vinod Koul
2018-04-13  3:43 ` [PATCH 4/5] " Vinod Koul
2018-04-13  3:39 [4/5] " Vinod Koul
2018-04-13  3:39 ` [PATCH 4/5] " Vinod Koul
2018-04-12 11:36 [4/5] " Baolin Wang
2018-04-12 11:36 ` [PATCH 4/5] " Baolin Wang
2018-04-12 11:30 [4/5] " Baolin Wang
2018-04-12 11:30 ` [PATCH 4/5] " Baolin Wang
2018-04-12  9:37 [4/5] " Vinod Koul
2018-04-12  9:37 ` [PATCH 4/5] " Vinod Koul
2018-04-11 12:13 [4/5] " Baolin Wang
2018-04-11 12:13 ` [PATCH 4/5] " Baolin Wang
2018-04-11 10:51 [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang
2018-04-11 10:51 ` [PATCH 5/5] " Baolin Wang
2018-04-11 10:49 [1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang
2018-04-11 10:49 ` [PATCH 1/5] " Baolin Wang
2018-04-11  9:40 [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Vinod Koul
2018-04-11  9:40 ` [PATCH 5/5] " Vinod Koul
2018-04-11  9:36 [4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Vinod Koul
2018-04-11  9:36 ` [PATCH 4/5] " Vinod Koul
2018-04-11  9:24 [1/5] dmaengine: sprd: Define the DMA transfer step type Vinod Koul
2018-04-11  9:24 ` [PATCH 1/5] " Vinod Koul
2018-04-10  7:46 [5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang
2018-04-10  7:46 ` [PATCH 5/5] " Baolin Wang
2018-04-10  7:46 [4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Baolin Wang
2018-04-10  7:46 ` [PATCH 4/5] " Baolin Wang
2018-04-10  7:46 [3/5] dmaengine: sprd: Move DMA request mode and interrupt type into head file Baolin Wang
2018-04-10  7:46 ` [PATCH 3/5] " Baolin Wang
2018-04-10  7:46 [2/5] dmaengine: sprd: Define the DMA data width type Baolin Wang
2018-04-10  7:46 ` [PATCH 2/5] " Baolin Wang
2018-04-10  7:46 [1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang
2018-04-10  7:46 ` [PATCH 1/5] " Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMz4ku+zPiucHyLF5HBtH9LhcTDUUec-kTLQG2YQ3hBK=9HHDw@mail.gmail.com' \
    --to=baolin.wang@linaro.org \
    --cc=broonie@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=eric.long@spreadtrum.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.