From: Russell King - ARM Linux <linux@armlinux.org.uk> To: Ilia Lin <ilialin@codeaurora.org> Cc: viresh.kumar@linaro.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver Date: Mon, 21 May 2018 11:54:28 +0100 [thread overview] Message-ID: <20180521105428.GM17671@n2100.armlinux.org.uk> (raw) In-Reply-To: <1526898690-4018-1-git-send-email-ilialin@codeaurora.org> On Mon, May 21, 2018 at 01:31:30PM +0300, Ilia Lin wrote: > +#define SILVER_LEAD 0 > +#define GOLD_LEAD 2 Okay, two different values here, but "GOLD_LEAD" appears unused. > + cpu_dev_silver = get_cpu_device(SILVER_LEAD); > + if (NULL == cpu_dev_silver) > + return -ENODEV; > + > + cpu_dev_gold = get_cpu_device(SILVER_LEAD); > + if (NULL == cpu_dev_gold) > + return -ENODEV; get_cpu_device() takes the logical CPU number. So the above gets CPU 0 each time, and so cpu_dev_silver == cpu_dev_gold here. So what's the point of the second get_cpu_device() ? If it's supposed to be: cpu_dev_gold = get_cpu_device(GOLD_LEAD); That would get CPU 2, but in terms of these defines, it doesn't make that much sense. What exactly does "silver lead" and "gold lead" refer to in these definitions? > + opp_silver = dev_pm_opp_set_supported_hw(cpu_dev_silver,&versions,1); > + if (IS_ERR(opp_silver)) { > + dev_err(cpu_dev_silver, "Failed to set supported hardware\n"); > + ret = PTR_ERR(opp_silver); > + goto free_np; > + } > + > + opp_gold = dev_pm_opp_set_supported_hw(cpu_dev_gold,&versions,1); > + if (IS_ERR(opp_gold)) { > + dev_err(cpu_dev_gold, "Failed to set supported hardware\n"); > + ret = PTR_ERR(opp_gold); > + goto free_opp_silver; > + } Given that cpu_dev_silver == cpu_dev_gold, doesn't the second call to dev_pm_opp_set_supported_hw() always fail, as opp_table->supported_hw will be set by the first call? To me, this driver looks completely useless as it will always fail to initialise, and I question whether this code has even been runtime tested. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] cpufreq: Add Kryo CPU scaling driver Date: Mon, 21 May 2018 11:54:28 +0100 [thread overview] Message-ID: <20180521105428.GM17671@n2100.armlinux.org.uk> (raw) In-Reply-To: <1526898690-4018-1-git-send-email-ilialin@codeaurora.org> On Mon, May 21, 2018 at 01:31:30PM +0300, Ilia Lin wrote: > +#define SILVER_LEAD 0 > +#define GOLD_LEAD 2 Okay, two different values here, but "GOLD_LEAD" appears unused. > + cpu_dev_silver = get_cpu_device(SILVER_LEAD); > + if (NULL == cpu_dev_silver) > + return -ENODEV; > + > + cpu_dev_gold = get_cpu_device(SILVER_LEAD); > + if (NULL == cpu_dev_gold) > + return -ENODEV; get_cpu_device() takes the logical CPU number. So the above gets CPU 0 each time, and so cpu_dev_silver == cpu_dev_gold here. So what's the point of the second get_cpu_device() ? If it's supposed to be: cpu_dev_gold = get_cpu_device(GOLD_LEAD); That would get CPU 2, but in terms of these defines, it doesn't make that much sense. What exactly does "silver lead" and "gold lead" refer to in these definitions? > + opp_silver = dev_pm_opp_set_supported_hw(cpu_dev_silver,&versions,1); > + if (IS_ERR(opp_silver)) { > + dev_err(cpu_dev_silver, "Failed to set supported hardware\n"); > + ret = PTR_ERR(opp_silver); > + goto free_np; > + } > + > + opp_gold = dev_pm_opp_set_supported_hw(cpu_dev_gold,&versions,1); > + if (IS_ERR(opp_gold)) { > + dev_err(cpu_dev_gold, "Failed to set supported hardware\n"); > + ret = PTR_ERR(opp_gold); > + goto free_opp_silver; > + } Given that cpu_dev_silver == cpu_dev_gold, doesn't the second call to dev_pm_opp_set_supported_hw() always fail, as opp_table->supported_hw will be set by the first call? To me, this driver looks completely useless as it will always fail to initialise, and I question whether this code has even been runtime tested. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2018-05-21 10:54 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-17 11:19 [PATCH v8 00/15] CPU scaling support for msm8996 Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 01/15] soc: qcom: Separate kryo l2 accessors from PMU driver Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 02/15] clk: qcom: Make clk_alpha_pll_configure available to modules Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 03/15] clk: Use devm_ in the register fixed factor clock Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 04/15] clk: qcom: Add CPU clock driver for msm8996 Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-22 13:49 ` kbuild test robot 2018-05-22 13:49 ` kbuild test robot 2018-05-22 13:49 ` kbuild test robot 2018-05-17 11:19 ` [PATCH v8 05/15] dt-bindings: clk: qcom: Add bindings for CPU clock " Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 06/15] clk: qcom: cpu-8996: Add support to switch to alternate PLL Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 07/15] clk: qcom: cpu-8996: Add support to switch below 600Mhz Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 08/15] clk: qcom: Add ACD path to CPU clock driver for msm8996 Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 09/15] dt: qcom: Add opp and thermal to the msm8996 Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-18 1:45 ` Viresh Kumar 2018-05-18 1:45 ` Viresh Kumar 2018-05-19 11:09 ` ilialin 2018-05-19 11:09 ` ilialin at codeaurora.org 2018-05-19 11:09 ` ilialin 2018-05-19 11:54 ` Russell King - ARM Linux 2018-05-19 11:54 ` Russell King - ARM Linux 2018-05-19 11:41 ` ilialin 2018-05-19 11:41 ` ilialin at codeaurora.org 2018-05-19 11:41 ` ilialin 2018-05-19 11:45 ` ilialin 2018-05-19 11:45 ` ilialin at codeaurora.org 2018-05-19 11:45 ` ilialin 2018-05-21 4:49 ` Viresh Kumar 2018-05-21 4:49 ` Viresh Kumar 2018-05-21 9:00 ` ilialin 2018-05-21 9:00 ` ilialin at codeaurora.org 2018-05-21 9:00 ` ilialin 2018-05-21 9:05 ` Viresh Kumar 2018-05-21 9:05 ` Viresh Kumar 2018-05-19 11:35 ` [PATCH] " Ilia Lin 2018-05-19 11:35 ` Ilia Lin 2018-05-21 5:04 ` Viresh Kumar 2018-05-21 5:04 ` Viresh Kumar 2018-05-21 12:50 ` Sudeep Holla 2018-05-21 12:50 ` Sudeep Holla 2018-05-21 12:57 ` ilialin 2018-05-21 12:57 ` ilialin at codeaurora.org 2018-05-21 12:57 ` ilialin 2018-05-21 12:57 ` ilialin 2018-05-21 13:04 ` Sudeep Holla 2018-05-21 13:04 ` Sudeep Holla 2018-05-22 6:56 ` ilialin 2018-05-22 6:56 ` ilialin at codeaurora.org 2018-05-22 6:56 ` ilialin 2018-05-22 6:56 ` ilialin 2018-05-22 9:12 ` Sudeep Holla 2018-05-22 9:12 ` Sudeep Holla 2018-05-22 7:59 ` ilialin 2018-05-22 7:59 ` ilialin at codeaurora.org 2018-05-22 7:59 ` ilialin 2018-05-22 7:59 ` ilialin 2018-05-22 9:18 ` Sudeep Holla 2018-05-22 9:18 ` Sudeep Holla 2018-05-22 9:38 ` Viresh Kumar 2018-05-22 9:38 ` Viresh Kumar 2018-05-22 11:29 ` Ilia Lin 2018-05-22 11:29 ` Ilia Lin 2018-05-22 13:07 ` Sudeep Holla 2018-05-22 13:07 ` Sudeep Holla 2018-05-23 5:44 ` Viresh Kumar 2018-05-23 5:44 ` Viresh Kumar 2018-05-23 9:05 ` Ilia Lin 2018-05-23 9:05 ` Ilia Lin 2018-05-23 9:32 ` Viresh Kumar 2018-05-23 9:32 ` Viresh Kumar 2018-05-23 9:40 ` Russell King - ARM Linux 2018-05-23 9:40 ` Russell King - ARM Linux 2018-05-23 9:59 ` Viresh Kumar 2018-05-23 9:59 ` Viresh Kumar 2018-05-21 10:31 ` Ilia Lin 2018-05-21 10:31 ` Ilia Lin 2018-05-21 10:37 ` Viresh Kumar 2018-05-21 10:37 ` Viresh Kumar 2018-05-21 10:54 ` Russell King - ARM Linux [this message] 2018-05-21 10:54 ` Russell King - ARM Linux 2018-05-21 11:05 ` ilialin 2018-05-21 11:05 ` ilialin at codeaurora.org 2018-05-21 11:05 ` ilialin 2018-05-21 12:11 ` Russell King - ARM Linux 2018-05-21 12:11 ` Russell King - ARM Linux 2018-05-21 12:35 ` ilialin 2018-05-21 12:35 ` ilialin at codeaurora.org 2018-05-21 12:35 ` ilialin 2018-05-21 12:41 ` Russell King - ARM Linux 2018-05-21 12:41 ` Russell King - ARM Linux 2018-05-17 11:19 ` [PATCH v8 11/15] dt-bindings: cpufreq: Document operating-points-v2-kryo-cpu Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-18 14:26 ` Rob Herring 2018-05-18 14:26 ` Rob Herring 2018-05-17 11:19 ` [PATCH v8 12/15] dt: qcom: Add qcom-cpufreq-kryo driver configuration Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 13/15] regulator: qcom_spmi: Add support for SAW Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 14/15] dt-bindings: qcom_spmi: Document SAW support Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 15/15] dt: qcom: Add SAW regulator for 8x96 CPUs Ilia Lin 2018-05-17 11:19 ` Ilia Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180521105428.GM17671@n2100.armlinux.org.uk \ --to=linux@armlinux.org.uk \ --cc=devicetree@vger.kernel.org \ --cc=ilialin@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.