From: Sudeep Holla <sudeep.holla@arm.com> To: ilialin@codeaurora.org, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, mark.rutland@arm.com, viresh.kumar@linaro.org, nm@ti.com, lgirdwood@gmail.com, broonie@kernel.org, andy.gross@linaro.org, david.brown@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, linux-clk@vger.kernel.org Cc: Sudeep Holla <sudeep.holla@arm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rnayak@codeaurora.org, amit.kucheria@linaro.org, nicolas.dechesne@linaro.org, celster@codeaurora.org, tfinkel@codeaurora.org Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver Date: Tue, 22 May 2018 10:12:34 +0100 [thread overview] Message-ID: <5b2eb27b-b852-97ff-b099-fe4c22b44937@arm.com> (raw) In-Reply-To: <001201d3f19a$0130a860$0391f920$@codeaurora.org> On 22/05/18 07:56, ilialin@codeaurora.org wrote: > > >> -----Original Message----- >> From: Sudeep Holla <sudeep.holla@arm.com> >> Sent: Monday, May 21, 2018 16:05 [...] >> >> >> That may be true and I am not that bothered about it. But assuming physical >> ordering from the logical cpu number is *incorrect* and will break if kernel >> decides to change the allocation algorithm. Kernel provides no guarantee on >> that, so you need to depend on some physical ID or may be DT to achieve >> what your want. But the current code as it stands is wrong. > > Got your point. In fact CPUs are numbered 0-3 and ordered into 2 clusters in the DT: > > cpus { > #address-cells = <2>; > #size-cells = <0>; > > CPU0: cpu@0 { > ... > reg = <0x0 0x0>; > ... > }; > > CPU1: cpu@1 { > ... > reg = <0x0 0x1>; > ... > }; > > CPU2: cpu@100 { > ... > reg = <0x0 0x100>; > ... > }; > > CPU3: cpu@101 { > ... > reg = <0x0 0x101>; > ... > }; > > cpu-map { > cluster0 { > core0 { > cpu = <&CPU0>; > }; > > core1 { > cpu = <&CPU1>; > }; > }; > > cluster1 { > core0 { > cpu = <&CPU2>; > }; > > core1 { > cpu = <&CPU3>; > }; > }; > }; > }; > > As far, as I understand, they are probed in the same order. Yes that's correct today, will that have to remain same for ever ? No it's not user ABI and kernel can decide to change the allocation order. What if for some reason one/more CPUs fails to boot or even configured not to boot ? > However, to be certain that the physical CPU is the one I intend to > configure, I have to fetch the device structure pointer for the cpu-map -> > clusterX -> core0 -> cpu path. Could you suggest a kernel API to do > that? > Let's rewind a bit. Do you supply OPPs only on CPU0 and CPU2 ? If yes, that's again wrong. Simple solution is to parse all logical CPUs and skip if the share OPPs with some other CPUs. I think that logic already exists in OPP library IIRC. -- Regards, Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: sudeep.holla@arm.com (Sudeep Holla) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] cpufreq: Add Kryo CPU scaling driver Date: Tue, 22 May 2018 10:12:34 +0100 [thread overview] Message-ID: <5b2eb27b-b852-97ff-b099-fe4c22b44937@arm.com> (raw) In-Reply-To: <001201d3f19a$0130a860$0391f920$@codeaurora.org> On 22/05/18 07:56, ilialin at codeaurora.org wrote: > > >> -----Original Message----- >> From: Sudeep Holla <sudeep.holla@arm.com> >> Sent: Monday, May 21, 2018 16:05 [...] >> >> >> That may be true and I am not that bothered about it. But assuming physical >> ordering from the logical cpu number is *incorrect* and will break if kernel >> decides to change the allocation algorithm. Kernel provides no guarantee on >> that, so you need to depend on some physical ID or may be DT to achieve >> what your want. But the current code as it stands is wrong. > > Got your point. In fact CPUs are numbered 0-3 and ordered into 2 clusters in the DT: > > cpus { > #address-cells = <2>; > #size-cells = <0>; > > CPU0: cpu at 0 { > ... > reg = <0x0 0x0>; > ... > }; > > CPU1: cpu at 1 { > ... > reg = <0x0 0x1>; > ... > }; > > CPU2: cpu at 100 { > ... > reg = <0x0 0x100>; > ... > }; > > CPU3: cpu at 101 { > ... > reg = <0x0 0x101>; > ... > }; > > cpu-map { > cluster0 { > core0 { > cpu = <&CPU0>; > }; > > core1 { > cpu = <&CPU1>; > }; > }; > > cluster1 { > core0 { > cpu = <&CPU2>; > }; > > core1 { > cpu = <&CPU3>; > }; > }; > }; > }; > > As far, as I understand, they are probed in the same order. Yes that's correct today, will that have to remain same for ever ? No it's not user ABI and kernel can decide to change the allocation order. What if for some reason one/more CPUs fails to boot or even configured not to boot ? > However, to be certain that the physical CPU is the one I intend to > configure, I have to fetch the device structure pointer for the cpu-map -> > clusterX -> core0 -> cpu path. Could you suggest a kernel API to do > that? > Let's rewind a bit. Do you supply OPPs only on CPU0 and CPU2 ? If yes, that's again wrong. Simple solution is to parse all logical CPUs and skip if the share OPPs with some other CPUs. I think that logic already exists in OPP library IIRC. -- Regards, Sudeep
next prev parent reply other threads:[~2018-05-22 9:12 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-17 11:19 [PATCH v8 00/15] CPU scaling support for msm8996 Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 01/15] soc: qcom: Separate kryo l2 accessors from PMU driver Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 02/15] clk: qcom: Make clk_alpha_pll_configure available to modules Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 03/15] clk: Use devm_ in the register fixed factor clock Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 04/15] clk: qcom: Add CPU clock driver for msm8996 Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-22 13:49 ` kbuild test robot 2018-05-22 13:49 ` kbuild test robot 2018-05-22 13:49 ` kbuild test robot 2018-05-17 11:19 ` [PATCH v8 05/15] dt-bindings: clk: qcom: Add bindings for CPU clock " Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 06/15] clk: qcom: cpu-8996: Add support to switch to alternate PLL Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 07/15] clk: qcom: cpu-8996: Add support to switch below 600Mhz Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 08/15] clk: qcom: Add ACD path to CPU clock driver for msm8996 Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 09/15] dt: qcom: Add opp and thermal to the msm8996 Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-18 1:45 ` Viresh Kumar 2018-05-18 1:45 ` Viresh Kumar 2018-05-19 11:09 ` ilialin 2018-05-19 11:09 ` ilialin at codeaurora.org 2018-05-19 11:09 ` ilialin 2018-05-19 11:54 ` Russell King - ARM Linux 2018-05-19 11:54 ` Russell King - ARM Linux 2018-05-19 11:41 ` ilialin 2018-05-19 11:41 ` ilialin at codeaurora.org 2018-05-19 11:41 ` ilialin 2018-05-19 11:45 ` ilialin 2018-05-19 11:45 ` ilialin at codeaurora.org 2018-05-19 11:45 ` ilialin 2018-05-21 4:49 ` Viresh Kumar 2018-05-21 4:49 ` Viresh Kumar 2018-05-21 9:00 ` ilialin 2018-05-21 9:00 ` ilialin at codeaurora.org 2018-05-21 9:00 ` ilialin 2018-05-21 9:05 ` Viresh Kumar 2018-05-21 9:05 ` Viresh Kumar 2018-05-19 11:35 ` [PATCH] " Ilia Lin 2018-05-19 11:35 ` Ilia Lin 2018-05-21 5:04 ` Viresh Kumar 2018-05-21 5:04 ` Viresh Kumar 2018-05-21 12:50 ` Sudeep Holla 2018-05-21 12:50 ` Sudeep Holla 2018-05-21 12:57 ` ilialin 2018-05-21 12:57 ` ilialin at codeaurora.org 2018-05-21 12:57 ` ilialin 2018-05-21 12:57 ` ilialin 2018-05-21 13:04 ` Sudeep Holla 2018-05-21 13:04 ` Sudeep Holla 2018-05-22 6:56 ` ilialin 2018-05-22 6:56 ` ilialin at codeaurora.org 2018-05-22 6:56 ` ilialin 2018-05-22 6:56 ` ilialin 2018-05-22 9:12 ` Sudeep Holla [this message] 2018-05-22 9:12 ` Sudeep Holla 2018-05-22 7:59 ` ilialin 2018-05-22 7:59 ` ilialin at codeaurora.org 2018-05-22 7:59 ` ilialin 2018-05-22 7:59 ` ilialin 2018-05-22 9:18 ` Sudeep Holla 2018-05-22 9:18 ` Sudeep Holla 2018-05-22 9:38 ` Viresh Kumar 2018-05-22 9:38 ` Viresh Kumar 2018-05-22 11:29 ` Ilia Lin 2018-05-22 11:29 ` Ilia Lin 2018-05-22 13:07 ` Sudeep Holla 2018-05-22 13:07 ` Sudeep Holla 2018-05-23 5:44 ` Viresh Kumar 2018-05-23 5:44 ` Viresh Kumar 2018-05-23 9:05 ` Ilia Lin 2018-05-23 9:05 ` Ilia Lin 2018-05-23 9:32 ` Viresh Kumar 2018-05-23 9:32 ` Viresh Kumar 2018-05-23 9:40 ` Russell King - ARM Linux 2018-05-23 9:40 ` Russell King - ARM Linux 2018-05-23 9:59 ` Viresh Kumar 2018-05-23 9:59 ` Viresh Kumar 2018-05-21 10:31 ` Ilia Lin 2018-05-21 10:31 ` Ilia Lin 2018-05-21 10:37 ` Viresh Kumar 2018-05-21 10:37 ` Viresh Kumar 2018-05-21 10:54 ` Russell King - ARM Linux 2018-05-21 10:54 ` Russell King - ARM Linux 2018-05-21 11:05 ` ilialin 2018-05-21 11:05 ` ilialin at codeaurora.org 2018-05-21 11:05 ` ilialin 2018-05-21 12:11 ` Russell King - ARM Linux 2018-05-21 12:11 ` Russell King - ARM Linux 2018-05-21 12:35 ` ilialin 2018-05-21 12:35 ` ilialin at codeaurora.org 2018-05-21 12:35 ` ilialin 2018-05-21 12:41 ` Russell King - ARM Linux 2018-05-21 12:41 ` Russell King - ARM Linux 2018-05-17 11:19 ` [PATCH v8 11/15] dt-bindings: cpufreq: Document operating-points-v2-kryo-cpu Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-18 14:26 ` Rob Herring 2018-05-18 14:26 ` Rob Herring 2018-05-17 11:19 ` [PATCH v8 12/15] dt: qcom: Add qcom-cpufreq-kryo driver configuration Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 13/15] regulator: qcom_spmi: Add support for SAW Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 14/15] dt-bindings: qcom_spmi: Document SAW support Ilia Lin 2018-05-17 11:19 ` Ilia Lin 2018-05-17 11:19 ` [PATCH v8 15/15] dt: qcom: Add SAW regulator for 8x96 CPUs Ilia Lin 2018-05-17 11:19 ` Ilia Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5b2eb27b-b852-97ff-b099-fe4c22b44937@arm.com \ --to=sudeep.holla@arm.com \ --cc=amit.kucheria@linaro.org \ --cc=andy.gross@linaro.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=celster@codeaurora.org \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=ilialin@codeaurora.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=nicolas.dechesne@linaro.org \ --cc=nm@ti.com \ --cc=rjw@rjwysocki.net \ --cc=rnayak@codeaurora.org \ --cc=robh@kernel.org \ --cc=sboyd@kernel.org \ --cc=tfinkel@codeaurora.org \ --cc=viresh.kumar@linaro.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.