Re: [Outreachy kernel] Re: [PATCH 4/5] staging: greybus Match with open parentheses

[Ioannis Valasakis <code@wizofe.uk>]

On Fri, Nov 02, 2018 at 10:31:14AM -0400, Sasha Levin wrote:
> On Fri, Nov 02, 2018 at 01:43:42PM +0100, Julia Lawall wrote:
> > 
> > 
> > On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
> > 
> > > On Fri, Nov 02, 2018 at 05:53:00AM +0100, Greg KH wrote:
> > > > On Fri, Nov 02, 2018 at 02:04:49AM +0000, Ioannis Valasakis wrote:
> > > > > Fix the arguments by open parentheses
> > > > > Reported by checkpatch.
> > > > >
> > > > > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> > > > > ---
> > > > >  drivers/staging/greybus/control.h | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> > > > > index 9c453e0b1b33..08a51c652a10 100644
> > > > > --- a/drivers/staging/greybus/control.h
> > > > > +++ b/drivers/staging/greybus/control.h
> > > > > @@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
> > > > >  int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
> > > > >  int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
> > > > >  int gb_control_disconnecting_operation(struct gb_control *control,
> > > > > -					u16 cport_id);
> > > > > +				       u17 cport_id);
> > > >
> > > > I don't think you built this code :(
> > > I did built it indeed but I didn't include the module on the make
> > > menuconfig, so I had the false impression of compiling. Silly me.
> > 
> > You can check for a .o file of the .c file you have modified.
> 
> My local workflow for this is to do a 'make allmodconfig' to enable
> pretty much everything, and then just do targetted builds of subsystems
> I touch. In this case I would do 'make drivers/staging/greybus/'.
> 
> This way you don't have to worry about enabling the right things in
> menuconfig.
> 
> --
> Thanks,
> Sasha
That is very useful, thank you! Noted.
-- 
ta
ioannis