From: Ioannis Valasakis <code@wizofe.uk>
To: outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org
Subject: [PATCH 1/5] staging: greybus Fix styling, parenthesis matching
Date: Fri, 2 Nov 2018 02:02:04 +0000 [thread overview]
Message-ID: <833e98c464540e296f7a577fe672ab5c7931ee10.1541123999.git.code@wizofe.uk> (raw)
In-Reply-To: <cover.1541123999.git.code@wizofe.uk>
Fix two instances where a styling issue is found. That is unmatched
parentheses correct to match.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
index dafa430d176e..d28773e06838 100644
--- a/drivers/staging/greybus/core.c
+++ b/drivers/staging/greybus/core.c
@@ -28,7 +28,7 @@ int greybus_disabled(void)
EXPORT_SYMBOL_GPL(greybus_disabled);
static bool greybus_match_one_id(struct gb_bundle *bundle,
- const struct greybus_bundle_id *id)
+ const struct greybus_bundle_id *id)
{
if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
(id->vendor != bundle->intf->vendor_id))
@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
static const struct greybus_bundle_id *
greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
{
- if (id == NULL)
+ if (!id == NULL)
return NULL;
for (; id->vendor || id->product || id->class || id->driver_info;
@@ -266,7 +266,7 @@ static int greybus_remove(struct device *dev)
}
int greybus_register_driver(struct greybus_driver *driver, struct module *owner,
- const char *mod_name)
+ const char *mod_name)
{
int retval;
--
2.19.1
next prev parent reply other threads:[~2018-11-02 2:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 2:00 [PATCH 0/5] staging: greybus Various stylistic errors Ioannis Valasakis
2018-11-02 2:02 ` Ioannis Valasakis [this message]
2018-11-02 7:15 ` [Outreachy kernel] [PATCH 1/5] staging: greybus Fix styling, parenthesis matching Julia Lawall
2018-11-02 10:06 ` Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 2/5] staging: greybus Change comparison to NULL Ioannis Valasakis
2018-11-02 7:10 ` [Outreachy kernel] " Julia Lawall
2018-11-02 2:04 ` [PATCH 3/5] staging: greybus Add a blank line after declaration Ioannis Valasakis
2018-11-02 2:04 ` [PATCH 4/5] staging: greybus Match with open parentheses Ioannis Valasakis
2018-11-02 4:53 ` Greg KH
2018-11-02 12:25 ` Ioannis Valasakis
2018-11-02 12:43 ` [Outreachy kernel] " Julia Lawall
2018-11-02 14:31 ` Sasha Levin
2018-11-02 14:33 ` Ioannis Valasakis
2018-11-02 2:05 ` [PATCH 5/5] staging: greybus Fix SPDX identifier Ioannis Valasakis
2018-11-02 7:08 ` [Outreachy kernel] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=833e98c464540e296f7a577fe672ab5c7931ee10.1541123999.git.code@wizofe.uk \
--to=code@wizofe.uk \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.