Re: [Outreachy kernel] [PATCH 1/5] staging: greybus Fix styling, parenthesis matching

[Julia Lawall <julia.lawall@lip6.fr>]

On Fri, 2 Nov 2018, Ioannis Valasakis wrote:

> Fix two instances where a styling issue is found. That is unmatched
> parentheses correct to match.

This makes three changes and the second one is quit incorrect.
The first sentence of the log message gives no information.  I don't know
what s styling issue is; there are lots of them.  I don't understand the
second sentence, and I don't see the connection with the change that is
made.  It looks like Align parameters to the right side of the
corresponing (.

Sorry to be picky about your English, which seems to not be your native
language.  I realize that of my suggestions, only "avoid fix" is the only
one that is easily generalizable.  Still it is important to be clear.  For
what you want to say, try to find an appropriate verb, and put it at the
beginning of the sentence.  Your messages often contain many words, with
the important part coming later.

julia


> Reported by checkpatch.
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
>  drivers/staging/greybus/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
> index dafa430d176e..d28773e06838 100644
> --- a/drivers/staging/greybus/core.c
> +++ b/drivers/staging/greybus/core.c
> @@ -28,7 +28,7 @@ int greybus_disabled(void)
>  EXPORT_SYMBOL_GPL(greybus_disabled);
>
>  static bool greybus_match_one_id(struct gb_bundle *bundle,
> -				     const struct greybus_bundle_id *id)
> +				 const struct greybus_bundle_id *id)
>  {
>  	if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
>  	    (id->vendor != bundle->intf->vendor_id))
> @@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
>  static const struct greybus_bundle_id *
>  greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
>  {
> -	if (id == NULL)
> +	if (!id == NULL)
>  		return NULL;
>
>  	for (; id->vendor || id->product || id->class || id->driver_info;
> @@ -266,7 +266,7 @@ static int greybus_remove(struct device *dev)
>  }
>
>  int greybus_register_driver(struct greybus_driver *driver, struct module *owner,
> -		const char *mod_name)
> +			    const char *mod_name)
>  {
>  	int retval;
>
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/833e98c464540e296f7a577fe672ab5c7931ee10.1541123999.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>