From: Julia Lawall <julia.lawall@lip6.fr>
To: Ioannis Valasakis <code@wizofe.uk>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH 5/5] staging: greybus Fix SPDX identifier
Date: Fri, 2 Nov 2018 08:08:23 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1811020807180.3064@hadrien> (raw)
In-Reply-To: <a37d37114de31fc8bb116bceadd2cb0fbc28f56c.1541123999.git.code@wizofe.uk>
On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
> Fix the SPDX identifier as by replacing with standard C comment the
> file
> Reported by checkpatch
Try not to use Fix in your log messages. It takes up a word and doesn't
give any information. Here you could start the sentence wit Replace, and
the Fix would go away.
julia
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
> drivers/staging/greybus/control.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> index 08a51c652a10..efa0d30a88c2 100644
> --- a/drivers/staging/greybus/control.h
> +++ b/drivers/staging/greybus/control.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Greybus CPort control protocol
> *
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a37d37114de31fc8bb116bceadd2cb0fbc28f56c.1541123999.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>
prev parent reply other threads:[~2018-11-02 7:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 2:00 [PATCH 0/5] staging: greybus Various stylistic errors Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 1/5] staging: greybus Fix styling, parenthesis matching Ioannis Valasakis
2018-11-02 7:15 ` [Outreachy kernel] " Julia Lawall
2018-11-02 10:06 ` Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 2/5] staging: greybus Change comparison to NULL Ioannis Valasakis
2018-11-02 7:10 ` [Outreachy kernel] " Julia Lawall
2018-11-02 2:04 ` [PATCH 3/5] staging: greybus Add a blank line after declaration Ioannis Valasakis
2018-11-02 2:04 ` [PATCH 4/5] staging: greybus Match with open parentheses Ioannis Valasakis
2018-11-02 4:53 ` Greg KH
2018-11-02 12:25 ` Ioannis Valasakis
2018-11-02 12:43 ` [Outreachy kernel] " Julia Lawall
2018-11-02 14:31 ` Sasha Levin
2018-11-02 14:33 ` Ioannis Valasakis
2018-11-02 2:05 ` [PATCH 5/5] staging: greybus Fix SPDX identifier Ioannis Valasakis
2018-11-02 7:08 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1811020807180.3064@hadrien \
--to=julia.lawall@lip6.fr \
--cc=code@wizofe.uk \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.