All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Ioannis Valasakis <code@wizofe.uk>
Cc: Greg KH <gregkh@linuxfoundation.org>, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH 4/5] staging: greybus Match with open parentheses
Date: Fri, 2 Nov 2018 13:43:42 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1811021343160.3863@hadrien> (raw)
In-Reply-To: <20181102122539.GA1372@kvasir.local>



On Fri, 2 Nov 2018, Ioannis Valasakis wrote:

> On Fri, Nov 02, 2018 at 05:53:00AM +0100, Greg KH wrote:
> > On Fri, Nov 02, 2018 at 02:04:49AM +0000, Ioannis Valasakis wrote:
> > > Fix the arguments by open parentheses
> > > Reported by checkpatch.
> > >
> > > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> > > ---
> > >  drivers/staging/greybus/control.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> > > index 9c453e0b1b33..08a51c652a10 100644
> > > --- a/drivers/staging/greybus/control.h
> > > +++ b/drivers/staging/greybus/control.h
> > > @@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
> > >  int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
> > >  int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
> > >  int gb_control_disconnecting_operation(struct gb_control *control,
> > > -					u16 cport_id);
> > > +				       u17 cport_id);
> >
> > I don't think you built this code :(
> I did built it indeed but I didn't include the module on the make
> menuconfig, so I had the false impression of compiling. Silly me.

You can check for a .o file of the .c file you have modified.

julia

>
> Thanks gregkh for the node.
>
> ta
> ioannis
> >
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181102122539.GA1372%40kvasir.local.
> For more options, visit https://groups.google.com/d/optout.
>


  reply	other threads:[~2018-11-02 12:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02  2:00 [PATCH 0/5] staging: greybus Various stylistic errors Ioannis Valasakis
2018-11-02  2:02 ` [PATCH 1/5] staging: greybus Fix styling, parenthesis matching Ioannis Valasakis
2018-11-02  7:15   ` [Outreachy kernel] " Julia Lawall
2018-11-02 10:06     ` Ioannis Valasakis
2018-11-02  2:02 ` [PATCH 2/5] staging: greybus Change comparison to NULL Ioannis Valasakis
2018-11-02  7:10   ` [Outreachy kernel] " Julia Lawall
2018-11-02  2:04 ` [PATCH 3/5] staging: greybus Add a blank line after declaration Ioannis Valasakis
2018-11-02  2:04 ` [PATCH 4/5] staging: greybus Match with open parentheses Ioannis Valasakis
2018-11-02  4:53   ` Greg KH
2018-11-02 12:25     ` Ioannis Valasakis
2018-11-02 12:43       ` Julia Lawall [this message]
2018-11-02 14:31         ` [Outreachy kernel] " Sasha Levin
2018-11-02 14:33           ` Ioannis Valasakis
2018-11-02  2:05 ` [PATCH 5/5] staging: greybus Fix SPDX identifier Ioannis Valasakis
2018-11-02  7:08   ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1811021343160.3863@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=code@wizofe.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.