Re: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

Hi Pawel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.20-rc6 next-20181214]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Pawel-Laszczak/dt-bindings-add-binding-for-USBSS-DRD-controller/20181211-025348
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

   drivers/usb//cdns3/host.c: In function 'cdns3_host_init':
>> drivers/usb//cdns3/host.c:65:5: warning: "CONFIG_PM" is not defined, evaluates to 0 [-Wundef]
    #if CONFIG_PM
        ^~~~~~~~~

vim +/CONFIG_PM +65 drivers/usb//cdns3/host.c

    53	
    54	int cdns3_host_init(struct cdns3 *cdns)
    55	{
    56		struct cdns3_role_driver *rdrv;
    57	
    58		rdrv = devm_kzalloc(cdns->dev, sizeof(*rdrv), GFP_KERNEL);
    59		if (!rdrv)
    60			return -ENOMEM;
    61	
    62		rdrv->start	= __cdns3_host_init;
    63		rdrv->stop	= cdns3_host_exit;
    64		rdrv->state	= CDNS3_ROLE_STATE_INACTIVE;
  > 65	#if CONFIG_PM

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47677 bytes --]