From: Rob Herring <robh@kernel.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"balbi@kernel.org" <balbi@kernel.org>,
"rogerq@ti.com" <rogerq@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alan Douglas <adouglas@cadence.com>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
"peter.chen@nxp.com" <peter.chen@nxp.com>,
Pawel Jez <pjez@cadence.com>, Rahul Kumar <kurahul@cadence.com>
Subject: Re: [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller.
Date: Thu, 27 Dec 2018 15:01:39 -0600 [thread overview]
Message-ID: <CAL_JsqLQ83f74kMRsRX=Bo+xwP05v+2dLQaPLVV3EU7k=QwvSQ@mail.gmail.com> (raw)
In-Reply-To: <BYAPR07MB4709910A6EE4B54BA455E713DDB90@BYAPR07MB4709.namprd07.prod.outlook.com>
On Sat, Dec 22, 2018 at 4:24 PM Pawel Laszczak <pawell@cadence.com> wrote:
>
> Hi Rob,
>
> >On Mon, Dec 10, 2018 at 12:39:14PM +0000, Pawel Laszczak wrote:
> >> This patch aim at documenting USB related dt-bindings for the
> >> Cadence USBSS-DRD controller.
> >>
> >> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
[...]
> >> + - phys: reference to the USB PHY
> >> + - phy-names: name of the USB PHY, should be "cdns3,usbphy"
> >
> >Don't need -names when there is only one.
>
> But in the future probably we will need to add next phy version.
> So maybe it's better to leave this name ?
'-names' are for when there is more than one phy connected, not
different phy versions. For example, if you had separate phys for HS
and SS.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"balbi@kernel.org" <balbi@kernel.org>,
"rogerq@ti.com" <rogerq@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alan Douglas <adouglas@cadence.com>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
"peter.chen@nxp.com" <peter.chen@nxp.com>,
Pawel Jez <pjez@cadence.com>, Rahul Kumar <kurahul@cadence.com>
Subject: [v1,1/2] dt-bindings: add binding for USBSS-DRD controller.
Date: Thu, 27 Dec 2018 15:01:39 -0600 [thread overview]
Message-ID: <CAL_JsqLQ83f74kMRsRX=Bo+xwP05v+2dLQaPLVV3EU7k=QwvSQ@mail.gmail.com> (raw)
On Sat, Dec 22, 2018 at 4:24 PM Pawel Laszczak <pawell@cadence.com> wrote:
>
> Hi Rob,
>
> >On Mon, Dec 10, 2018 at 12:39:14PM +0000, Pawel Laszczak wrote:
> >> This patch aim at documenting USB related dt-bindings for the
> >> Cadence USBSS-DRD controller.
> >>
> >> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
[...]
> >> + - phys: reference to the USB PHY
> >> + - phy-names: name of the USB PHY, should be "cdns3,usbphy"
> >
> >Don't need -names when there is only one.
>
> But in the future probably we will need to add next phy version.
> So maybe it's better to leave this name ?
'-names' are for when there is more than one phy connected, not
different phy versions. For example, if you had separate phys for HS
and SS.
Rob
next prev parent reply other threads:[~2018-12-27 21:01 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 12:39 [PATCH v1 0/2] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2018-12-10 12:39 ` Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-10 12:39 ` [v1,1/2] " Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-11 10:16 ` Roger Quadros
2018-12-11 10:16 ` [v1,1/2] " Roger Quadros
2018-12-11 10:16 ` [PATCH v1 1/2] " Roger Quadros
2018-12-13 9:20 ` Peter Chen
2018-12-13 9:20 ` [v1,1/2] " Peter Chen
2018-12-13 9:25 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-13 9:25 ` [v1,1/2] " Pawel Laszczak
2018-12-20 20:01 ` [PATCH v1 1/2] " Rob Herring
2018-12-20 20:01 ` [v1,1/2] " Rob Herring
2018-12-22 22:24 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-22 22:24 ` [v1,1/2] " Pawel Laszczak
2018-12-27 21:01 ` Rob Herring [this message]
2018-12-27 21:01 ` Rob Herring
2018-12-31 5:35 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-31 5:35 ` [v1,1/2] " Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2018-12-10 12:39 ` [v1,2/2] " Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-11 9:39 ` Roger Quadros
2018-12-11 9:39 ` [v1,2/2] " Roger Quadros
2018-12-11 9:39 ` [PATCH v1 2/2] " Roger Quadros
2018-12-11 10:01 ` Pawel Laszczak
2018-12-11 10:01 ` [v1,2/2] " Pawel Laszczak
2018-12-11 12:15 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 12:15 ` [v1,2/2] " Felipe Balbi
2018-12-11 12:15 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 11:46 ` Felipe Balbi
2018-12-11 11:46 ` [v1,2/2] " Felipe Balbi
2018-12-11 12:14 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 12:14 ` [v1,2/2] " Felipe Balbi
2018-12-11 12:14 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 19:04 ` Pawel Laszczak
2018-12-11 19:04 ` [v1,2/2] " Pawel Laszczak
2018-12-11 19:04 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-12 2:04 ` Peter Chen
2018-12-12 2:04 ` [v1,2/2] " Peter Chen
2018-12-12 6:55 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12 6:55 ` [v1,2/2] " Felipe Balbi
2018-12-12 7:38 ` [PATCH v1 2/2] " Peter Chen
2018-12-12 7:38 ` [v1,2/2] " Peter Chen
2018-12-12 8:34 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12 8:34 ` [v1,2/2] " Felipe Balbi
2018-12-12 8:34 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12 9:24 ` Peter Chen
2018-12-12 9:24 ` [v1,2/2] " Peter Chen
2018-12-12 15:53 ` [PATCH v1 2/2] " Bin Liu
2018-12-12 15:53 ` [v1,2/2] " Bin Liu
2018-12-12 15:53 ` [PATCH v1 2/2] " Bin Liu
2018-12-13 1:21 ` Peter Chen
2018-12-13 1:21 ` [v1,2/2] " Peter Chen
2018-12-12 6:52 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12 6:52 ` [v1,2/2] " Felipe Balbi
2018-12-12 6:52 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-14 3:46 ` Kishon Vijay Abraham I
2018-12-14 3:46 ` [v1,2/2] " Kishon Vijay Abraham I
2018-12-17 5:46 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-17 5:46 ` [v1,2/2] " Pawel Laszczak
2018-12-17 11:25 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-17 11:25 ` [v1,2/2] " Pawel Laszczak
2018-12-17 11:34 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-17 11:34 ` [v1,2/2] " Felipe Balbi
2018-12-17 11:34 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-17 11:51 ` Pawel Laszczak
2018-12-17 11:51 ` [v1,2/2] " Pawel Laszczak
2018-12-17 11:56 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-17 11:56 ` [v1,2/2] " Felipe Balbi
2018-12-17 11:56 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-13 9:35 ` Peter Chen
2018-12-13 9:35 ` [v1,2/2] " Peter Chen
2018-12-16 13:01 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-16 13:01 ` [v1,2/2] " Pawel Laszczak
2018-12-14 22:56 ` [PATCH v1 2/2] " kbuild test robot
2018-12-14 22:56 ` [v1,2/2] " kbuild test robot
2018-12-14 22:56 ` [PATCH v1 2/2] " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLQ83f74kMRsRX=Bo+xwP05v+2dLQaPLVV3EU7k=QwvSQ@mail.gmail.com' \
--to=robh@kernel.org \
--cc=adouglas@cadence.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=pjez@cadence.com \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.