All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pawel Laszczak <pawell@cadence.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
	Felipe Balbi <balbi@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"rogerq@ti.com" <rogerq@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alan Douglas <adouglas@cadence.com>,
	"jbergsagel@ti.com" <jbergsagel@ti.com>,
	"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
	Suresh Punnoose <sureshp@cadence.com>,
	"peter.chen@nxp.com" <peter.chen@nxp.com>,
	Pawel Jez <pjez@cadence.com>, Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Mon, 17 Dec 2018 05:46:43 +0000	[thread overview]
Message-ID: <BYAPR07MB47093D9B4AFA4BFAF11C43AFDDBC0@BYAPR07MB4709.namprd07.prod.outlook.com> (raw)
In-Reply-To: <d77b4083-6641-4a60-1629-b8edacc36c26@ti.com>

Hi,

>
>On 12/12/18 12:22 PM, Felipe Balbi wrote:
>>
>> Hi
>>
>> Pawel Laszczak <pawell@cadence.com> writes:
>>>>> +	cdns->phy = devm_phy_get(dev, "cdns3,usbphy");
>>>>> +	if (IS_ERR(cdns->phy)) {
>>>>> +		ret = PTR_ERR(cdns->phy);
>>>>> +		if (ret == -ENOSYS || ret == -ENODEV) {
>>>>
>>>> Are you sure you can get ENOSYS here? Have you checked output of
>>>> checkpatch --strict?
>>>> -:852: WARNING: ENOSYS means 'invalid syscall nr' and nothing else
>>>
>>> Yes this error code can be returned by related to phy function if
>>> CONFIG_GENERIC_PHY is disabled.
>>>
>>> I have seen this warning in output of checkpatch --strict .
>>
>> Kishon, seems like you shouldn't be using that error value.
>
>hmm, yeah should change the return value to -ENODEV when GENERIC_PHY is disabled.
>

So I will remove this ENOSYS from next patch. I assume that it will be removed also from generic phy driver. 

Thanks,
Pawel

WARNING: multiple messages have this Message-ID (diff)
From: Pawel Laszczak <pawell@cadence.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
	Felipe Balbi <balbi@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"rogerq@ti.com" <rogerq@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alan Douglas <adouglas@cadence.com>,
	"jbergsagel@ti.com" <jbergsagel@ti.com>,
	"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
	Suresh Punnoose <sureshp@cadence.com>,
	"peter.chen@nxp.com" <peter.chen@nxp.com>,
	Pawel Jez <pjez@cadence.com>, Rahul Kumar <kurahul@cadence.com>
Subject: [v1,2/2] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Mon, 17 Dec 2018 05:46:43 +0000	[thread overview]
Message-ID: <BYAPR07MB47093D9B4AFA4BFAF11C43AFDDBC0@BYAPR07MB4709.namprd07.prod.outlook.com> (raw)

Hi,

>
>On 12/12/18 12:22 PM, Felipe Balbi wrote:
>>
>> Hi
>>
>> Pawel Laszczak <pawell@cadence.com> writes:
>>>>> +	cdns->phy = devm_phy_get(dev, "cdns3,usbphy");
>>>>> +	if (IS_ERR(cdns->phy)) {
>>>>> +		ret = PTR_ERR(cdns->phy);
>>>>> +		if (ret == -ENOSYS || ret == -ENODEV) {
>>>>
>>>> Are you sure you can get ENOSYS here? Have you checked output of
>>>> checkpatch --strict?
>>>> -:852: WARNING: ENOSYS means 'invalid syscall nr' and nothing else
>>>
>>> Yes this error code can be returned by related to phy function if
>>> CONFIG_GENERIC_PHY is disabled.
>>>
>>> I have seen this warning in output of checkpatch --strict .
>>
>> Kishon, seems like you shouldn't be using that error value.
>
>hmm, yeah should change the return value to -ENODEV when GENERIC_PHY is disabled.
>

So I will remove this ENOSYS from next patch. I assume that it will be removed also from generic phy driver. 

Thanks,
Pawel

  reply	other threads:[~2018-12-17  5:47 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 12:39 [PATCH v1 0/2] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2018-12-10 12:39 ` Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-10 12:39   ` [v1,1/2] " Pawel Laszczak
2018-12-10 12:39   ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-11 10:16   ` Roger Quadros
2018-12-11 10:16     ` [v1,1/2] " Roger Quadros
2018-12-11 10:16     ` [PATCH v1 1/2] " Roger Quadros
2018-12-13  9:20     ` Peter Chen
2018-12-13  9:20       ` [v1,1/2] " Peter Chen
2018-12-13  9:25       ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-13  9:25         ` [v1,1/2] " Pawel Laszczak
2018-12-20 20:01   ` [PATCH v1 1/2] " Rob Herring
2018-12-20 20:01     ` [v1,1/2] " Rob Herring
2018-12-22 22:24     ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-22 22:24       ` [v1,1/2] " Pawel Laszczak
2018-12-27 21:01       ` [PATCH v1 1/2] " Rob Herring
2018-12-27 21:01         ` [v1,1/2] " Rob Herring
2018-12-31  5:35         ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-31  5:35           ` [v1,1/2] " Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2018-12-10 12:39   ` [v1,2/2] " Pawel Laszczak
2018-12-10 12:39   ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-11  9:39   ` Roger Quadros
2018-12-11  9:39     ` [v1,2/2] " Roger Quadros
2018-12-11  9:39     ` [PATCH v1 2/2] " Roger Quadros
2018-12-11 10:01     ` Pawel Laszczak
2018-12-11 10:01       ` [v1,2/2] " Pawel Laszczak
2018-12-11 12:15       ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 12:15         ` [v1,2/2] " Felipe Balbi
2018-12-11 12:15         ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 11:46     ` Felipe Balbi
2018-12-11 11:46       ` [v1,2/2] " Felipe Balbi
2018-12-11 12:14   ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 12:14     ` [v1,2/2] " Felipe Balbi
2018-12-11 12:14     ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 19:04     ` Pawel Laszczak
2018-12-11 19:04       ` [v1,2/2] " Pawel Laszczak
2018-12-11 19:04       ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-12  2:04       ` Peter Chen
2018-12-12  2:04         ` [v1,2/2] " Peter Chen
2018-12-12  6:55         ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12  6:55           ` [v1,2/2] " Felipe Balbi
2018-12-12  7:38           ` [PATCH v1 2/2] " Peter Chen
2018-12-12  7:38             ` [v1,2/2] " Peter Chen
2018-12-12  8:34             ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12  8:34               ` [v1,2/2] " Felipe Balbi
2018-12-12  8:34               ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12  9:24               ` Peter Chen
2018-12-12  9:24                 ` [v1,2/2] " Peter Chen
2018-12-12 15:53         ` [PATCH v1 2/2] " Bin Liu
2018-12-12 15:53           ` [v1,2/2] " Bin Liu
2018-12-12 15:53           ` [PATCH v1 2/2] " Bin Liu
2018-12-13  1:21           ` Peter Chen
2018-12-13  1:21             ` [v1,2/2] " Peter Chen
2018-12-12  6:52       ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12  6:52         ` [v1,2/2] " Felipe Balbi
2018-12-12  6:52         ` [PATCH v1 2/2] " Felipe Balbi
2018-12-14  3:46         ` Kishon Vijay Abraham I
2018-12-14  3:46           ` [v1,2/2] " Kishon Vijay Abraham I
2018-12-17  5:46           ` Pawel Laszczak [this message]
2018-12-17  5:46             ` Pawel Laszczak
2018-12-17 11:25         ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-17 11:25           ` [v1,2/2] " Pawel Laszczak
2018-12-17 11:34           ` [PATCH v1 2/2] " Felipe Balbi
2018-12-17 11:34             ` [v1,2/2] " Felipe Balbi
2018-12-17 11:34             ` [PATCH v1 2/2] " Felipe Balbi
2018-12-17 11:51         ` Pawel Laszczak
2018-12-17 11:51           ` [v1,2/2] " Pawel Laszczak
2018-12-17 11:56           ` [PATCH v1 2/2] " Felipe Balbi
2018-12-17 11:56             ` [v1,2/2] " Felipe Balbi
2018-12-17 11:56             ` [PATCH v1 2/2] " Felipe Balbi
2018-12-13  9:35   ` Peter Chen
2018-12-13  9:35     ` [v1,2/2] " Peter Chen
2018-12-16 13:01     ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-16 13:01       ` [v1,2/2] " Pawel Laszczak
2018-12-14 22:56   ` [PATCH v1 2/2] " kbuild test robot
2018-12-14 22:56     ` [v1,2/2] " kbuild test robot
2018-12-14 22:56     ` [PATCH v1 2/2] " kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR07MB47093D9B4AFA4BFAF11C43AFDDBC0@BYAPR07MB4709.namprd07.prod.outlook.com \
    --to=pawell@cadence.com \
    --cc=adouglas@cadence.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbergsagel@ti.com \
    --cc=kishon@ti.com \
    --cc=kurahul@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=peter.chen@nxp.com \
    --cc=pjez@cadence.com \
    --cc=rogerq@ti.com \
    --cc=sureshp@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.