From: Rob Herring <robh@kernel.org> To: Yu Chen <chenyu56@huawei.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, Mark Rutland <mark.rutland@arm.com>, John Stultz <john.stultz@linaro.org>, Binghui Wang <wangbinghui@hisilicon.com> Subject: Re: [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Date: Wed, 19 Dec 2018 08:14:19 -0600 [thread overview] Message-ID: <20181219141419.GA17302@bogus> (raw) In-Reply-To: <20181203034515.91412-3-chenyu56@huawei.com> On Mon, Dec 03, 2018 at 11:45:05AM +0800, Yu Chen wrote: > This patch adds binding documentation for supporting the hi3660 usb > phy on boards like the HiKey960. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: John Stultz <john.stultz@linaro.org> > Cc: Binghui Wang <wangbinghui@hisilicon.com> > Signed-off-by: Yu Chen <chenyu56@huawei.com> > -- > v1: Fix some format error as suggested by Rob. > -- > --- > .../devicetree/bindings/phy/phy-hi3660-usb3.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > > diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > new file mode 100644 > index 000000000000..8ea52d51aa13 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > @@ -0,0 +1,21 @@ > +Hisilicon hi3660 usb PHY s/usb/USB/ > +----------------------- > + > +Required properties: > +- compatible: should be "hisilicon,hi3660-usb-phy" > +- #phy-cells: must be 0 > +- hisilicon,pericrg-syscon: phandle of syscon used to control phy. > +- hisilicon,pctrl-syscon: phandle of syscon used to control phy. > +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy. > +- hisilicon,eye-diagram-param: parameter set for phy > +Refer to phy/phy-bindings.txt for the generic PHY binding properties Doesn't a phy need some clocks? > + > +Example: > + usb-phy { > + compatible = "hisilicon,hi3660-usb-phy"; > + #phy-cells = <0>; > + hisilicon,pericrg-syscon = <&crg_ctrl>; > + hisilicon,pctrl-syscon = <&pctrl>; > + hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>; Is one of these the "main" registers for the phy? If so, then make this a child of that syscon node. > + hisilicon,eye-diagram-param = <0x22466e4>; > + }; > -- > 2.15.0-rc2 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Yu Chen <chenyu56@huawei.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, Mark Rutland <mark.rutland@arm.com>, John Stultz <john.stultz@linaro.org>, Binghui Wang <wangbinghui@hisilicon.com> Subject: [v1,02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Date: Wed, 19 Dec 2018 08:14:19 -0600 [thread overview] Message-ID: <20181219141419.GA17302@bogus> (raw) On Mon, Dec 03, 2018 at 11:45:05AM +0800, Yu Chen wrote: > This patch adds binding documentation for supporting the hi3660 usb > phy on boards like the HiKey960. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: John Stultz <john.stultz@linaro.org> > Cc: Binghui Wang <wangbinghui@hisilicon.com> > Signed-off-by: Yu Chen <chenyu56@huawei.com> > -- > v1: Fix some format error as suggested by Rob. > -- > --- > .../devicetree/bindings/phy/phy-hi3660-usb3.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > > diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > new file mode 100644 > index 000000000000..8ea52d51aa13 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > @@ -0,0 +1,21 @@ > +Hisilicon hi3660 usb PHY s/usb/USB/ > +----------------------- > + > +Required properties: > +- compatible: should be "hisilicon,hi3660-usb-phy" > +- #phy-cells: must be 0 > +- hisilicon,pericrg-syscon: phandle of syscon used to control phy. > +- hisilicon,pctrl-syscon: phandle of syscon used to control phy. > +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy. > +- hisilicon,eye-diagram-param: parameter set for phy > +Refer to phy/phy-bindings.txt for the generic PHY binding properties Doesn't a phy need some clocks? > + > +Example: > + usb-phy { > + compatible = "hisilicon,hi3660-usb-phy"; > + #phy-cells = <0>; > + hisilicon,pericrg-syscon = <&crg_ctrl>; > + hisilicon,pctrl-syscon = <&pctrl>; > + hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>; Is one of these the "main" registers for the phy? If so, then make this a child of that syscon node. > + hisilicon,eye-diagram-param = <0x22466e4>; > + }; > -- > 2.15.0-rc2 >
next prev parent reply other threads:[~2018-12-19 14:14 UTC|newest] Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-03 3:45 [PATCH v1 00/12] Add support for usb on Hikey960 Yu Chen 2018-12-03 3:45 ` Yu Chen 2018-12-03 3:45 ` [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs Yu Chen 2018-12-03 3:45 ` [v1,01/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 01/12] " Yu Chen 2018-12-03 8:35 ` Sergei Shtylyov 2018-12-03 8:35 ` [v1,01/12] " Sergei Shtylyov 2018-12-03 8:51 ` [PATCH v1 01/12] " Chen Yu 2018-12-03 8:51 ` [v1,01/12] " Yu Chen 2018-12-03 8:51 ` [PATCH v1 01/12] " Chen Yu 2018-12-03 8:59 ` Sergei Shtylyov 2018-12-03 8:59 ` [v1,01/12] " Sergei Shtylyov 2018-12-03 9:28 ` [PATCH v1 01/12] " Chen Yu 2018-12-03 9:28 ` [v1,01/12] " Yu Chen 2018-12-03 9:28 ` [PATCH v1 01/12] " Chen Yu 2018-12-19 14:09 ` Rob Herring 2018-12-19 14:09 ` [v1,01/12] " Rob Herring 2018-12-20 1:33 ` [PATCH v1 01/12] " Chen Yu 2018-12-20 1:33 ` [v1,01/12] " Yu Chen 2018-12-20 1:33 ` [PATCH v1 01/12] " Chen Yu 2018-12-20 6:46 ` Felipe Balbi 2018-12-20 6:46 ` [v1,01/12] " Felipe Balbi 2018-12-20 13:48 ` [PATCH v1 01/12] " Rob Herring 2018-12-20 13:48 ` [v1,01/12] " Rob Herring 2018-12-03 3:45 ` [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen 2018-12-03 3:45 ` [v1,02/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 02/12] " Yu Chen 2018-12-19 14:14 ` Rob Herring [this message] 2018-12-19 14:14 ` [v1,02/12] " Rob Herring 2018-12-20 1:52 ` [PATCH v1 02/12] " Chen Yu 2018-12-20 1:52 ` [v1,02/12] " Yu Chen 2018-12-20 1:52 ` [PATCH v1 02/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen 2018-12-03 3:45 ` [v1,03/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 03/12] " Yu Chen 2018-12-19 14:21 ` Rob Herring 2018-12-19 14:21 ` [v1,03/12] " Rob Herring 2018-12-20 2:02 ` [PATCH v1 03/12] " Chen Yu 2018-12-20 2:02 ` [v1,03/12] " Yu Chen 2018-12-20 2:02 ` [PATCH v1 03/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform Yu Chen 2018-12-03 3:45 ` [v1,04/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 04/12] " Yu Chen 2018-12-03 8:12 ` Andy Shevchenko 2018-12-03 8:12 ` [v1,04/12] " Andy Shevchenko 2018-12-03 8:30 ` [PATCH v1 04/12] " Chen Yu 2018-12-03 8:30 ` [v1,04/12] " Yu Chen 2018-12-03 8:30 ` [PATCH v1 04/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen 2018-12-03 3:45 ` [v1,05/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 05/12] " Yu Chen 2018-12-03 8:02 ` Andy Shevchenko 2018-12-03 8:02 ` [v1,05/12] " Andy Shevchenko 2018-12-03 8:23 ` [PATCH v1 05/12] " Chen Yu 2018-12-03 8:23 ` [v1,05/12] " Yu Chen 2018-12-03 8:23 ` [PATCH v1 05/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen 2018-12-03 3:45 ` [v1,06/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 06/12] " Yu Chen 2018-12-03 8:14 ` Andy Shevchenko 2018-12-03 8:14 ` [v1,06/12] " Andy Shevchenko 2018-12-03 3:45 ` [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node Yu Chen 2018-12-03 3:45 ` [v1,07/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 07/12] " Yu Chen 2018-12-03 8:17 ` Andy Shevchenko 2018-12-03 8:17 ` [v1,07/12] " Andy Shevchenko 2018-12-03 12:25 ` [PATCH v1 07/12] " Heikki Krogerus 2018-12-03 12:25 ` [v1,07/12] " Heikki Krogerus 2019-01-21 8:36 ` [PATCH v1 07/12] " Chen Yu 2019-01-21 8:36 ` [v1,07/12] " Yu Chen 2019-01-21 8:36 ` [PATCH v1 07/12] " Chen Yu 2019-01-21 13:51 ` Heikki Krogerus 2019-01-21 13:51 ` [v1,07/12] " Heikki Krogerus 2019-01-25 12:35 ` [PATCH v1 07/12] " Heikki Krogerus 2019-01-25 12:35 ` [v1,07/12] " Heikki Krogerus 2018-12-03 3:45 ` [PATCH v1 08/12] usb: roles: Add usb role switch notifier Yu Chen 2018-12-03 3:45 ` [v1,08/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 08/12] " Yu Chen 2018-12-03 12:38 ` Heikki Krogerus 2018-12-03 12:38 ` [v1,08/12] " Heikki Krogerus 2018-12-04 1:07 ` [PATCH v1 08/12] " Chen Yu 2018-12-04 1:07 ` [v1,08/12] " Yu Chen 2018-12-04 1:07 ` [PATCH v1 08/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen 2018-12-03 3:45 ` [v1,09/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 09/12] " Yu Chen 2018-12-03 9:15 ` Andy Shevchenko 2018-12-03 9:15 ` [v1,09/12] " Andy Shevchenko 2018-12-03 9:30 ` [PATCH v1 09/12] " Chen Yu 2018-12-03 9:30 ` [v1,09/12] " Yu Chen 2018-12-03 9:30 ` [PATCH v1 09/12] " Chen Yu 2018-12-03 12:43 ` Heikki Krogerus 2018-12-03 12:43 ` [v1,09/12] " Heikki Krogerus 2018-12-04 10:54 ` [PATCH v1 09/12] " Heikki Krogerus 2018-12-04 10:54 ` [v1,09/12] " Heikki Krogerus 2018-12-05 0:56 ` [PATCH v1 09/12] " Chen Yu 2018-12-05 0:56 ` [v1,09/12] " Yu Chen 2018-12-05 0:56 ` [PATCH v1 09/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 Yu Chen 2018-12-03 3:45 ` [v1,10/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 10/12] " Yu Chen 2018-12-03 9:23 ` Andy Shevchenko 2018-12-03 9:23 ` [v1,10/12] " Andy Shevchenko 2018-12-04 1:40 ` [PATCH v1 10/12] " Chen Yu 2018-12-04 1:40 ` [v1,10/12] " Yu Chen 2018-12-04 1:40 ` [PATCH v1 10/12] " Chen Yu 2018-12-04 17:47 ` Andy Shevchenko 2018-12-04 17:47 ` [v1,10/12] " Andy Shevchenko 2018-12-05 1:57 ` [PATCH v1 10/12] " Chen Yu 2018-12-05 1:57 ` [v1,10/12] " Yu Chen 2018-12-05 1:57 ` [PATCH v1 10/12] " Chen Yu 2018-12-05 8:44 ` Andy Shevchenko 2018-12-05 8:44 ` [v1,10/12] " Andy Shevchenko 2018-12-03 3:45 ` [PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen 2018-12-03 3:45 ` [v1,11/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 11/12] " Yu Chen 2018-12-03 9:25 ` Andy Shevchenko 2018-12-03 9:25 ` [v1,11/12] " Andy Shevchenko 2018-12-04 1:22 ` [PATCH v1 11/12] " Chen Yu 2018-12-04 1:22 ` [v1,11/12] " Yu Chen 2018-12-04 1:22 ` [PATCH v1 11/12] " Chen Yu 2018-12-03 9:53 ` Krzysztof Opasiak 2018-12-03 9:53 ` [v1,11/12] " Krzysztof Opasiak 2018-12-03 3:45 ` [PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen 2018-12-03 3:45 ` Yu Chen 2018-12-03 3:45 ` [v1,12/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 12/12] " Yu Chen 2018-12-04 12:45 ` Heikki Krogerus 2018-12-04 12:45 ` Heikki Krogerus 2018-12-04 12:45 ` [v1,12/12] " Heikki Krogerus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181219141419.GA17302@bogus \ --to=robh@kernel.org \ --cc=chenyu56@huawei.com \ --cc=devicetree@vger.kernel.org \ --cc=john.stultz@linaro.org \ --cc=kongfei@hisilicon.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=suzhuangluan@hisilicon.com \ --cc=wangbinghui@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.