From: Chen Yu <chenyu56@huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: <wangbinghui@hisilicon.com>, USB <linux-usb@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Suzhuangluan <suzhuangluan@hisilicon.com>,
Kongfei <kongfei@hisilicon.com>, Felipe Balbi <balbi@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform
Date: Mon, 3 Dec 2018 16:23:09 +0800 [thread overview]
Message-ID: <4214e332-dd8d-a6a3-b693-54287b178c80@huawei.com> (raw)
In-Reply-To: <CAHp75VcbNumAGa8NsYp9tL-ZRP4stApuTFtY1LARHMnJjxA4dw@mail.gmail.com>
On 2018/12/3 16:02, Andy Shevchenko wrote:
> On Mon, Dec 3, 2018 at 5:48 AM Yu Chen <chenyu56@huawei.com> wrote:
>>
>> There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc.
>> 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode
>> 2)A GCTL soft reset should be executed when switch mode
>
>> +static void dwc3_gctl_core_soft_reset(struct dwc3 *dwc)
>> +{
>
>> + int reg;
>
> u32? int for register value looks confusing a bit.
Yes, it should be u32.
>
>> + reg = dwc3_readl(dwc->regs, DWC3_GCTL);
>> + reg |= (DWC3_GCTL_CORESOFTRESET);
>> + dwc3_writel(dwc->regs, DWC3_GCTL, reg);
>> +
>> + reg = dwc3_readl(dwc->regs, DWC3_GCTL);
>> + reg &= ~(DWC3_GCTL_CORESOFTRESET);
>> + dwc3_writel(dwc->regs, DWC3_GCTL, reg);
>> +}
>
>> + int reg;
>
> Ditto.
>
WARNING: multiple messages have this Message-ID (diff)
From: Chen Yu <chenyu56@huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: wangbinghui@hisilicon.com, USB <linux-usb@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Suzhuangluan <suzhuangluan@hisilicon.com>,
Kongfei <kongfei@hisilicon.com>, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform
Date: Mon, 3 Dec 2018 16:23:09 +0800 [thread overview]
Message-ID: <4214e332-dd8d-a6a3-b693-54287b178c80@huawei.com> (raw)
In-Reply-To: <CAHp75VcbNumAGa8NsYp9tL-ZRP4stApuTFtY1LARHMnJjxA4dw@mail.gmail.com>
On 2018/12/3 16:02, Andy Shevchenko wrote:
> On Mon, Dec 3, 2018 at 5:48 AM Yu Chen <chenyu56@huawei.com> wrote:
>>
>> There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc.
>> 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode
>> 2)A GCTL soft reset should be executed when switch mode
>
>> +static void dwc3_gctl_core_soft_reset(struct dwc3 *dwc)
>> +{
>
>> + int reg;
>
> u32? int for register value looks confusing a bit.
Yes, it should be u32.
>
>> + reg = dwc3_readl(dwc->regs, DWC3_GCTL);
>> + reg |= (DWC3_GCTL_CORESOFTRESET);
>> + dwc3_writel(dwc->regs, DWC3_GCTL, reg);
>> +
>> + reg = dwc3_readl(dwc->regs, DWC3_GCTL);
>> + reg &= ~(DWC3_GCTL_CORESOFTRESET);
>> + dwc3_writel(dwc->regs, DWC3_GCTL, reg);
>> +}
>
>> + int reg;
>
> Ditto.
>
WARNING: multiple messages have this Message-ID (diff)
From: Yu Chen <chenyu56@huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: wangbinghui@hisilicon.com, USB <linux-usb@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Suzhuangluan <suzhuangluan@hisilicon.com>,
Kongfei <kongfei@hisilicon.com>, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>
Subject: [v1,05/12] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform
Date: Mon, 3 Dec 2018 16:23:09 +0800 [thread overview]
Message-ID: <4214e332-dd8d-a6a3-b693-54287b178c80@huawei.com> (raw)
On 2018/12/3 16:02, Andy Shevchenko wrote:
> On Mon, Dec 3, 2018 at 5:48 AM Yu Chen <chenyu56@huawei.com> wrote:
>>
>> There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc.
>> 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode
>> 2)A GCTL soft reset should be executed when switch mode
>
>> +static void dwc3_gctl_core_soft_reset(struct dwc3 *dwc)
>> +{
>
>> + int reg;
>
> u32? int for register value looks confusing a bit.
Yes, it should be u32.
>
>> + reg = dwc3_readl(dwc->regs, DWC3_GCTL);
>> + reg |= (DWC3_GCTL_CORESOFTRESET);
>> + dwc3_writel(dwc->regs, DWC3_GCTL, reg);
>> +
>> + reg = dwc3_readl(dwc->regs, DWC3_GCTL);
>> + reg &= ~(DWC3_GCTL_CORESOFTRESET);
>> + dwc3_writel(dwc->regs, DWC3_GCTL, reg);
>> +}
>
>> + int reg;
>
> Ditto.
>
next prev parent reply other threads:[~2018-12-03 8:23 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 3:45 [PATCH v1 00/12] Add support for usb on Hikey960 Yu Chen
2018-12-03 3:45 ` Yu Chen
2018-12-03 3:45 ` [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs Yu Chen
2018-12-03 3:45 ` [v1,01/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 01/12] " Yu Chen
2018-12-03 8:35 ` Sergei Shtylyov
2018-12-03 8:35 ` [v1,01/12] " Sergei Shtylyov
2018-12-03 8:51 ` [PATCH v1 01/12] " Chen Yu
2018-12-03 8:51 ` [v1,01/12] " Yu Chen
2018-12-03 8:51 ` [PATCH v1 01/12] " Chen Yu
2018-12-03 8:59 ` Sergei Shtylyov
2018-12-03 8:59 ` [v1,01/12] " Sergei Shtylyov
2018-12-03 9:28 ` [PATCH v1 01/12] " Chen Yu
2018-12-03 9:28 ` [v1,01/12] " Yu Chen
2018-12-03 9:28 ` [PATCH v1 01/12] " Chen Yu
2018-12-19 14:09 ` Rob Herring
2018-12-19 14:09 ` [v1,01/12] " Rob Herring
2018-12-20 1:33 ` [PATCH v1 01/12] " Chen Yu
2018-12-20 1:33 ` [v1,01/12] " Yu Chen
2018-12-20 1:33 ` [PATCH v1 01/12] " Chen Yu
2018-12-20 6:46 ` Felipe Balbi
2018-12-20 6:46 ` [v1,01/12] " Felipe Balbi
2018-12-20 13:48 ` [PATCH v1 01/12] " Rob Herring
2018-12-20 13:48 ` [v1,01/12] " Rob Herring
2018-12-03 3:45 ` [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2018-12-03 3:45 ` [v1,02/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 02/12] " Yu Chen
2018-12-19 14:14 ` Rob Herring
2018-12-19 14:14 ` [v1,02/12] " Rob Herring
2018-12-20 1:52 ` [PATCH v1 02/12] " Chen Yu
2018-12-20 1:52 ` [v1,02/12] " Yu Chen
2018-12-20 1:52 ` [PATCH v1 02/12] " Chen Yu
2018-12-03 3:45 ` [PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2018-12-03 3:45 ` [v1,03/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 03/12] " Yu Chen
2018-12-19 14:21 ` Rob Herring
2018-12-19 14:21 ` [v1,03/12] " Rob Herring
2018-12-20 2:02 ` [PATCH v1 03/12] " Chen Yu
2018-12-20 2:02 ` [v1,03/12] " Yu Chen
2018-12-20 2:02 ` [PATCH v1 03/12] " Chen Yu
2018-12-03 3:45 ` [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform Yu Chen
2018-12-03 3:45 ` [v1,04/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 04/12] " Yu Chen
2018-12-03 8:12 ` Andy Shevchenko
2018-12-03 8:12 ` [v1,04/12] " Andy Shevchenko
2018-12-03 8:30 ` [PATCH v1 04/12] " Chen Yu
2018-12-03 8:30 ` [v1,04/12] " Yu Chen
2018-12-03 8:30 ` [PATCH v1 04/12] " Chen Yu
2018-12-03 3:45 ` [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen
2018-12-03 3:45 ` [v1,05/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 05/12] " Yu Chen
2018-12-03 8:02 ` Andy Shevchenko
2018-12-03 8:02 ` [v1,05/12] " Andy Shevchenko
2018-12-03 8:23 ` Chen Yu [this message]
2018-12-03 8:23 ` Yu Chen
2018-12-03 8:23 ` [PATCH v1 05/12] " Chen Yu
2018-12-03 3:45 ` [PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2018-12-03 3:45 ` [v1,06/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 06/12] " Yu Chen
2018-12-03 8:14 ` Andy Shevchenko
2018-12-03 8:14 ` [v1,06/12] " Andy Shevchenko
2018-12-03 3:45 ` [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node Yu Chen
2018-12-03 3:45 ` [v1,07/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 07/12] " Yu Chen
2018-12-03 8:17 ` Andy Shevchenko
2018-12-03 8:17 ` [v1,07/12] " Andy Shevchenko
2018-12-03 12:25 ` [PATCH v1 07/12] " Heikki Krogerus
2018-12-03 12:25 ` [v1,07/12] " Heikki Krogerus
2019-01-21 8:36 ` [PATCH v1 07/12] " Chen Yu
2019-01-21 8:36 ` [v1,07/12] " Yu Chen
2019-01-21 8:36 ` [PATCH v1 07/12] " Chen Yu
2019-01-21 13:51 ` Heikki Krogerus
2019-01-21 13:51 ` [v1,07/12] " Heikki Krogerus
2019-01-25 12:35 ` [PATCH v1 07/12] " Heikki Krogerus
2019-01-25 12:35 ` [v1,07/12] " Heikki Krogerus
2018-12-03 3:45 ` [PATCH v1 08/12] usb: roles: Add usb role switch notifier Yu Chen
2018-12-03 3:45 ` [v1,08/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 08/12] " Yu Chen
2018-12-03 12:38 ` Heikki Krogerus
2018-12-03 12:38 ` [v1,08/12] " Heikki Krogerus
2018-12-04 1:07 ` [PATCH v1 08/12] " Chen Yu
2018-12-04 1:07 ` [v1,08/12] " Yu Chen
2018-12-04 1:07 ` [PATCH v1 08/12] " Chen Yu
2018-12-03 3:45 ` [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2018-12-03 3:45 ` [v1,09/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 09/12] " Yu Chen
2018-12-03 9:15 ` Andy Shevchenko
2018-12-03 9:15 ` [v1,09/12] " Andy Shevchenko
2018-12-03 9:30 ` [PATCH v1 09/12] " Chen Yu
2018-12-03 9:30 ` [v1,09/12] " Yu Chen
2018-12-03 9:30 ` [PATCH v1 09/12] " Chen Yu
2018-12-03 12:43 ` Heikki Krogerus
2018-12-03 12:43 ` [v1,09/12] " Heikki Krogerus
2018-12-04 10:54 ` [PATCH v1 09/12] " Heikki Krogerus
2018-12-04 10:54 ` [v1,09/12] " Heikki Krogerus
2018-12-05 0:56 ` [PATCH v1 09/12] " Chen Yu
2018-12-05 0:56 ` [v1,09/12] " Yu Chen
2018-12-05 0:56 ` [PATCH v1 09/12] " Chen Yu
2018-12-03 3:45 ` [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2018-12-03 3:45 ` [v1,10/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 10/12] " Yu Chen
2018-12-03 9:23 ` Andy Shevchenko
2018-12-03 9:23 ` [v1,10/12] " Andy Shevchenko
2018-12-04 1:40 ` [PATCH v1 10/12] " Chen Yu
2018-12-04 1:40 ` [v1,10/12] " Yu Chen
2018-12-04 1:40 ` [PATCH v1 10/12] " Chen Yu
2018-12-04 17:47 ` Andy Shevchenko
2018-12-04 17:47 ` [v1,10/12] " Andy Shevchenko
2018-12-05 1:57 ` [PATCH v1 10/12] " Chen Yu
2018-12-05 1:57 ` [v1,10/12] " Yu Chen
2018-12-05 1:57 ` [PATCH v1 10/12] " Chen Yu
2018-12-05 8:44 ` Andy Shevchenko
2018-12-05 8:44 ` [v1,10/12] " Andy Shevchenko
2018-12-03 3:45 ` [PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2018-12-03 3:45 ` [v1,11/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 11/12] " Yu Chen
2018-12-03 9:25 ` Andy Shevchenko
2018-12-03 9:25 ` [v1,11/12] " Andy Shevchenko
2018-12-04 1:22 ` [PATCH v1 11/12] " Chen Yu
2018-12-04 1:22 ` [v1,11/12] " Yu Chen
2018-12-04 1:22 ` [PATCH v1 11/12] " Chen Yu
2018-12-03 9:53 ` Krzysztof Opasiak
2018-12-03 9:53 ` [v1,11/12] " Krzysztof Opasiak
2018-12-03 3:45 ` [PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2018-12-03 3:45 ` Yu Chen
2018-12-03 3:45 ` [v1,12/12] " Yu Chen
2018-12-03 3:45 ` [PATCH v1 12/12] " Yu Chen
2018-12-04 12:45 ` Heikki Krogerus
2018-12-04 12:45 ` Heikki Krogerus
2018-12-04 12:45 ` [v1,12/12] " Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4214e332-dd8d-a6a3-b693-54287b178c80@huawei.com \
--to=chenyu56@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=suzhuangluan@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.