From: Andy Shevchenko <andy.shevchenko@gmail.com> To: chenyu56@huawei.com Cc: USB <linux-usb@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Suzhuangluan <suzhuangluan@hisilicon.com>, Kongfei <kongfei@hisilicon.com>, Kishon Vijay Abraham I <kishon@ti.com>, "David S. Miller" <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawnguo@kernel.org>, lpc.li@hisilicon.com, sunjianguo1@huawei.com, Masahiro Yamada <yamada.masahiro@socionext.com>, xuejiancheng@hisilicon.com, John Stultz <john.stultz@linaro.org>, Wangbinghui <wangbinghui@hisilicon.com> Subject: Re: [PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Date: Mon, 3 Dec 2018 10:14:30 +0200 [thread overview] Message-ID: <CAHp75Vepvab=fD-3vps_RXewrb-Nfe8947soAmbNHatS4YQR4w@mail.gmail.com> (raw) In-Reply-To: <20181203034515.91412-7-chenyu56@huawei.com> On Mon, Dec 3, 2018 at 5:47 AM Yu Chen <chenyu56@huawei.com> wrote: > > This driver handles usb phy power on and shutdown for hi3660 Soc of > Hisilicon. > +// SPDX-License-Identifier: GPL-2.0+ Ambigous license through the code reading. > +#define PERI_CRG_CLK_EN4 (0x40) > +#define PERI_CRG_CLK_DIS4 (0x44) > +#define GT_CLK_USB3OTG_REF BIT(0) > +#define GT_ACLK_USB3OTG BIT(1) > + > +#define PERI_CRG_RSTEN4 (0x90) > +#define PERI_CRG_RSTDIS4 (0x94) > +#define IP_RST_USB3OTGPHY_POR BIT(3) > +#define IP_RST_USB3OTG BIT(5) > + > +#define PERI_CRG_ISODIS (0x148) > +#define USB_REFCLK_ISO_EN BIT(25) > + > +#define PCTRL_PERI_CTRL3 (0x10) > +#define PCTRL_PERI_CTRL3_MSK_START (16) > +#define USB_TCXO_EN BIT(1) > + > +#define PCTRL_PERI_CTRL24 (0x64) > +#define SC_CLK_USB3PHY_3MUX1_SEL BIT(25) > + > +#define USBOTG3_CTRL0 (0x00) > +#define SC_USB3PHY_ABB_GT_EN BIT(15) > + > +#define USBOTG3_CTRL2 (0x08) > +#define USBOTG3CTRL2_POWERDOWN_HSP BIT(0) > +#define USBOTG3CTRL2_POWERDOWN_SSP BIT(1) > + > +#define USBOTG3_CTRL3 (0x0C) > +#define USBOTG3_CTRL3_VBUSVLDEXT BIT(6) > +#define USBOTG3_CTRL3_VBUSVLDEXTSEL BIT(5) > + > +#define USBOTG3_CTRL4 (0x10) > + > +#define USBOTG3_CTRL7 (0x1c) > +#define REF_SSP_EN BIT(16) > + > +#define HI3660_USB_DEFAULT_PHY_PARAM (0x1c466e3) A lot of redundant parens. > +static const struct of_device_id hi3660_phy_of_match[] = { > + {.compatible = "hisilicon,hi3660-usb-phy",}, > + { }, No comma needed. > +}; -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: chenyu56@huawei.com Cc: USB <linux-usb@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Suzhuangluan <suzhuangluan@hisilicon.com>, Kongfei <kongfei@hisilicon.com>, Kishon Vijay Abraham I <kishon@ti.com>, "David S. Miller" <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawnguo@kernel.org>, lpc.li@hisilicon.com, sunjianguo1@huawei.com, Masahiro Yamada <yamada.masahiro@socionext.com>, xuejiancheng@hisilicon.com, John Stultz <john.stultz@linaro.org>, Wangbinghui <wangbinghui@hisilicon.com> Subject: [v1,06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Date: Mon, 3 Dec 2018 10:14:30 +0200 [thread overview] Message-ID: <CAHp75Vepvab=fD-3vps_RXewrb-Nfe8947soAmbNHatS4YQR4w@mail.gmail.com> (raw) On Mon, Dec 3, 2018 at 5:47 AM Yu Chen <chenyu56@huawei.com> wrote: > > This driver handles usb phy power on and shutdown for hi3660 Soc of > Hisilicon. > +// SPDX-License-Identifier: GPL-2.0+ Ambigous license through the code reading. > +#define PERI_CRG_CLK_EN4 (0x40) > +#define PERI_CRG_CLK_DIS4 (0x44) > +#define GT_CLK_USB3OTG_REF BIT(0) > +#define GT_ACLK_USB3OTG BIT(1) > + > +#define PERI_CRG_RSTEN4 (0x90) > +#define PERI_CRG_RSTDIS4 (0x94) > +#define IP_RST_USB3OTGPHY_POR BIT(3) > +#define IP_RST_USB3OTG BIT(5) > + > +#define PERI_CRG_ISODIS (0x148) > +#define USB_REFCLK_ISO_EN BIT(25) > + > +#define PCTRL_PERI_CTRL3 (0x10) > +#define PCTRL_PERI_CTRL3_MSK_START (16) > +#define USB_TCXO_EN BIT(1) > + > +#define PCTRL_PERI_CTRL24 (0x64) > +#define SC_CLK_USB3PHY_3MUX1_SEL BIT(25) > + > +#define USBOTG3_CTRL0 (0x00) > +#define SC_USB3PHY_ABB_GT_EN BIT(15) > + > +#define USBOTG3_CTRL2 (0x08) > +#define USBOTG3CTRL2_POWERDOWN_HSP BIT(0) > +#define USBOTG3CTRL2_POWERDOWN_SSP BIT(1) > + > +#define USBOTG3_CTRL3 (0x0C) > +#define USBOTG3_CTRL3_VBUSVLDEXT BIT(6) > +#define USBOTG3_CTRL3_VBUSVLDEXTSEL BIT(5) > + > +#define USBOTG3_CTRL4 (0x10) > + > +#define USBOTG3_CTRL7 (0x1c) > +#define REF_SSP_EN BIT(16) > + > +#define HI3660_USB_DEFAULT_PHY_PARAM (0x1c466e3) A lot of redundant parens. > +static const struct of_device_id hi3660_phy_of_match[] = { > + {.compatible = "hisilicon,hi3660-usb-phy",}, > + { }, No comma needed. > +};
next prev parent reply other threads:[~2018-12-03 8:14 UTC|newest] Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-03 3:45 [PATCH v1 00/12] Add support for usb on Hikey960 Yu Chen 2018-12-03 3:45 ` Yu Chen 2018-12-03 3:45 ` [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs Yu Chen 2018-12-03 3:45 ` [v1,01/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 01/12] " Yu Chen 2018-12-03 8:35 ` Sergei Shtylyov 2018-12-03 8:35 ` [v1,01/12] " Sergei Shtylyov 2018-12-03 8:51 ` [PATCH v1 01/12] " Chen Yu 2018-12-03 8:51 ` [v1,01/12] " Yu Chen 2018-12-03 8:51 ` [PATCH v1 01/12] " Chen Yu 2018-12-03 8:59 ` Sergei Shtylyov 2018-12-03 8:59 ` [v1,01/12] " Sergei Shtylyov 2018-12-03 9:28 ` [PATCH v1 01/12] " Chen Yu 2018-12-03 9:28 ` [v1,01/12] " Yu Chen 2018-12-03 9:28 ` [PATCH v1 01/12] " Chen Yu 2018-12-19 14:09 ` Rob Herring 2018-12-19 14:09 ` [v1,01/12] " Rob Herring 2018-12-20 1:33 ` [PATCH v1 01/12] " Chen Yu 2018-12-20 1:33 ` [v1,01/12] " Yu Chen 2018-12-20 1:33 ` [PATCH v1 01/12] " Chen Yu 2018-12-20 6:46 ` Felipe Balbi 2018-12-20 6:46 ` [v1,01/12] " Felipe Balbi 2018-12-20 13:48 ` [PATCH v1 01/12] " Rob Herring 2018-12-20 13:48 ` [v1,01/12] " Rob Herring 2018-12-03 3:45 ` [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen 2018-12-03 3:45 ` [v1,02/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 02/12] " Yu Chen 2018-12-19 14:14 ` Rob Herring 2018-12-19 14:14 ` [v1,02/12] " Rob Herring 2018-12-20 1:52 ` [PATCH v1 02/12] " Chen Yu 2018-12-20 1:52 ` [v1,02/12] " Yu Chen 2018-12-20 1:52 ` [PATCH v1 02/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen 2018-12-03 3:45 ` [v1,03/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 03/12] " Yu Chen 2018-12-19 14:21 ` Rob Herring 2018-12-19 14:21 ` [v1,03/12] " Rob Herring 2018-12-20 2:02 ` [PATCH v1 03/12] " Chen Yu 2018-12-20 2:02 ` [v1,03/12] " Yu Chen 2018-12-20 2:02 ` [PATCH v1 03/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform Yu Chen 2018-12-03 3:45 ` [v1,04/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 04/12] " Yu Chen 2018-12-03 8:12 ` Andy Shevchenko 2018-12-03 8:12 ` [v1,04/12] " Andy Shevchenko 2018-12-03 8:30 ` [PATCH v1 04/12] " Chen Yu 2018-12-03 8:30 ` [v1,04/12] " Yu Chen 2018-12-03 8:30 ` [PATCH v1 04/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen 2018-12-03 3:45 ` [v1,05/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 05/12] " Yu Chen 2018-12-03 8:02 ` Andy Shevchenko 2018-12-03 8:02 ` [v1,05/12] " Andy Shevchenko 2018-12-03 8:23 ` [PATCH v1 05/12] " Chen Yu 2018-12-03 8:23 ` [v1,05/12] " Yu Chen 2018-12-03 8:23 ` [PATCH v1 05/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen 2018-12-03 3:45 ` [v1,06/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 06/12] " Yu Chen 2018-12-03 8:14 ` Andy Shevchenko [this message] 2018-12-03 8:14 ` [v1,06/12] " Andy Shevchenko 2018-12-03 3:45 ` [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node Yu Chen 2018-12-03 3:45 ` [v1,07/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 07/12] " Yu Chen 2018-12-03 8:17 ` Andy Shevchenko 2018-12-03 8:17 ` [v1,07/12] " Andy Shevchenko 2018-12-03 12:25 ` [PATCH v1 07/12] " Heikki Krogerus 2018-12-03 12:25 ` [v1,07/12] " Heikki Krogerus 2019-01-21 8:36 ` [PATCH v1 07/12] " Chen Yu 2019-01-21 8:36 ` [v1,07/12] " Yu Chen 2019-01-21 8:36 ` [PATCH v1 07/12] " Chen Yu 2019-01-21 13:51 ` Heikki Krogerus 2019-01-21 13:51 ` [v1,07/12] " Heikki Krogerus 2019-01-25 12:35 ` [PATCH v1 07/12] " Heikki Krogerus 2019-01-25 12:35 ` [v1,07/12] " Heikki Krogerus 2018-12-03 3:45 ` [PATCH v1 08/12] usb: roles: Add usb role switch notifier Yu Chen 2018-12-03 3:45 ` [v1,08/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 08/12] " Yu Chen 2018-12-03 12:38 ` Heikki Krogerus 2018-12-03 12:38 ` [v1,08/12] " Heikki Krogerus 2018-12-04 1:07 ` [PATCH v1 08/12] " Chen Yu 2018-12-04 1:07 ` [v1,08/12] " Yu Chen 2018-12-04 1:07 ` [PATCH v1 08/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen 2018-12-03 3:45 ` [v1,09/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 09/12] " Yu Chen 2018-12-03 9:15 ` Andy Shevchenko 2018-12-03 9:15 ` [v1,09/12] " Andy Shevchenko 2018-12-03 9:30 ` [PATCH v1 09/12] " Chen Yu 2018-12-03 9:30 ` [v1,09/12] " Yu Chen 2018-12-03 9:30 ` [PATCH v1 09/12] " Chen Yu 2018-12-03 12:43 ` Heikki Krogerus 2018-12-03 12:43 ` [v1,09/12] " Heikki Krogerus 2018-12-04 10:54 ` [PATCH v1 09/12] " Heikki Krogerus 2018-12-04 10:54 ` [v1,09/12] " Heikki Krogerus 2018-12-05 0:56 ` [PATCH v1 09/12] " Chen Yu 2018-12-05 0:56 ` [v1,09/12] " Yu Chen 2018-12-05 0:56 ` [PATCH v1 09/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 Yu Chen 2018-12-03 3:45 ` [v1,10/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 10/12] " Yu Chen 2018-12-03 9:23 ` Andy Shevchenko 2018-12-03 9:23 ` [v1,10/12] " Andy Shevchenko 2018-12-04 1:40 ` [PATCH v1 10/12] " Chen Yu 2018-12-04 1:40 ` [v1,10/12] " Yu Chen 2018-12-04 1:40 ` [PATCH v1 10/12] " Chen Yu 2018-12-04 17:47 ` Andy Shevchenko 2018-12-04 17:47 ` [v1,10/12] " Andy Shevchenko 2018-12-05 1:57 ` [PATCH v1 10/12] " Chen Yu 2018-12-05 1:57 ` [v1,10/12] " Yu Chen 2018-12-05 1:57 ` [PATCH v1 10/12] " Chen Yu 2018-12-05 8:44 ` Andy Shevchenko 2018-12-05 8:44 ` [v1,10/12] " Andy Shevchenko 2018-12-03 3:45 ` [PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen 2018-12-03 3:45 ` [v1,11/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 11/12] " Yu Chen 2018-12-03 9:25 ` Andy Shevchenko 2018-12-03 9:25 ` [v1,11/12] " Andy Shevchenko 2018-12-04 1:22 ` [PATCH v1 11/12] " Chen Yu 2018-12-04 1:22 ` [v1,11/12] " Yu Chen 2018-12-04 1:22 ` [PATCH v1 11/12] " Chen Yu 2018-12-03 9:53 ` Krzysztof Opasiak 2018-12-03 9:53 ` [v1,11/12] " Krzysztof Opasiak 2018-12-03 3:45 ` [PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen 2018-12-03 3:45 ` Yu Chen 2018-12-03 3:45 ` [v1,12/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 12/12] " Yu Chen 2018-12-04 12:45 ` Heikki Krogerus 2018-12-04 12:45 ` Heikki Krogerus 2018-12-04 12:45 ` [v1,12/12] " Heikki Krogerus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHp75Vepvab=fD-3vps_RXewrb-Nfe8947soAmbNHatS4YQR4w@mail.gmail.com' \ --to=andy.shevchenko@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=chenyu56@huawei.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=john.stultz@linaro.org \ --cc=kishon@ti.com \ --cc=kongfei@hisilicon.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=lpc.li@hisilicon.com \ --cc=mchehab+samsung@kernel.org \ --cc=shawnguo@kernel.org \ --cc=sunjianguo1@huawei.com \ --cc=suzhuangluan@hisilicon.com \ --cc=wangbinghui@hisilicon.com \ --cc=xuejiancheng@hisilicon.com \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.