From: Andy Shevchenko <andy.shevchenko@gmail.com> To: chenyu56@huawei.com Cc: USB <linux-usb@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Suzhuangluan <suzhuangluan@hisilicon.com>, Kongfei <kongfei@hisilicon.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, John Stultz <john.stultz@linaro.org>, Wangbinghui <wangbinghui@hisilicon.com>, "Krogerus, Heikki" <heikki.krogerus@linux.intel.com> Subject: Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 Date: Mon, 3 Dec 2018 11:23:00 +0200 [thread overview] Message-ID: <CAHp75VdSowHk4meQqqUamSjJJoVT59+pMZ1qjmmWd-W5nWBcUw@mail.gmail.com> (raw) In-Reply-To: <20181203034515.91412-11-chenyu56@huawei.com> On Mon, Dec 3, 2018 at 5:47 AM Yu Chen <chenyu56@huawei.com> wrote: > > This driver handles usb hub power on and typeC port event of HiKey960 board: > 1)DP&DM switching between usb hub and typeC port base on typeC port > state > 2)Control power of usb hub on Hikey960 > 3)Control vbus of typeC port > +config HISI_HIKEY_USB > + tristate "USB functionality of HiSilicon Hikey Platform" > + depends on GPIOLIB > + default n No, Linus is not happy about this. Default n _is_ a default. > + help > + If you say yes here you get support for usb functionality of HiSilicon Hikey Platform. > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * hisi_hikey_usb.c > + * > + * Copyright (c) Hisilicon Tech. Co., Ltd. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + */ Same comments to the above lines. > +#include <linux/module.h> > +#include <linux/kernel.h> > +#include <linux/slab.h> > +#include <linux/platform_device.h> > +#include <linux/of.h> > +#include <linux/gpio/consumer.h> > +#include <linux/usb/role.h> > +#include <linux/notifier.h> Order? > + pr_debug("%s: set hub power %d\n", __func__, value); Noise. > + pr_debug("%s: switch to %s\n", __func__, switch_to_str); Noise. > + pr_debug("%s: set typec vbus gpio to %d\n", __func__, value); Noise. > + if (!nb) > + return -EINVAL; On which conditions this happen? > + pr_info("%s:set typec state to %lu\n", __func__, state); Noise! Guys, you perhaps can read about tracepoints and function tracer facilities in the kernel. > +static int hisi_hikey_usb_probe(struct platform_device *pdev) > +{ > + pr_info("%s: typc_vbus_enable_val can't get\n", __func__); Noise! > + if (IS_ERR_OR_NULL(hisi_hikey_usb->typec_vbus)) { So, this check is redundant. You are repeating it below. > + if (!hisi_hikey_usb->typec_vbus) > + ret = -EINVAL; > + else > + ret = PTR_ERR(hisi_hikey_usb->typec_vbus); > + return ret; > + } > + if (IS_ERR_OR_NULL(hisi_hikey_usb->role_sw)) { > + pr_err("%s: usb_role_switch_get failed\n", __func__); Noise and same comment to the conditional check as above > + if (!hisi_hikey_usb->role_sw) > + ret = -ENOENT; > + else > + ret = PTR_ERR(hisi_hikey_usb->role_sw); > + return ret; > + } > + .of_match_table = of_match_ptr(id_table_hisi_hikey_usb), Does it compiles for non-OF case? Why macro is in use? -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: chenyu56@huawei.com Cc: USB <linux-usb@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Suzhuangluan <suzhuangluan@hisilicon.com>, Kongfei <kongfei@hisilicon.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, John Stultz <john.stultz@linaro.org>, Wangbinghui <wangbinghui@hisilicon.com>, "Krogerus, Heikki" <heikki.krogerus@linux.intel.com> Subject: [v1,10/12] hikey960: Support usb functionality of Hikey960 Date: Mon, 3 Dec 2018 11:23:00 +0200 [thread overview] Message-ID: <CAHp75VdSowHk4meQqqUamSjJJoVT59+pMZ1qjmmWd-W5nWBcUw@mail.gmail.com> (raw) On Mon, Dec 3, 2018 at 5:47 AM Yu Chen <chenyu56@huawei.com> wrote: > > This driver handles usb hub power on and typeC port event of HiKey960 board: > 1)DP&DM switching between usb hub and typeC port base on typeC port > state > 2)Control power of usb hub on Hikey960 > 3)Control vbus of typeC port > +config HISI_HIKEY_USB > + tristate "USB functionality of HiSilicon Hikey Platform" > + depends on GPIOLIB > + default n No, Linus is not happy about this. Default n _is_ a default. > + help > + If you say yes here you get support for usb functionality of HiSilicon Hikey Platform. > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * hisi_hikey_usb.c > + * > + * Copyright (c) Hisilicon Tech. Co., Ltd. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + */ Same comments to the above lines. > +#include <linux/module.h> > +#include <linux/kernel.h> > +#include <linux/slab.h> > +#include <linux/platform_device.h> > +#include <linux/of.h> > +#include <linux/gpio/consumer.h> > +#include <linux/usb/role.h> > +#include <linux/notifier.h> Order? > + pr_debug("%s: set hub power %d\n", __func__, value); Noise. > + pr_debug("%s: switch to %s\n", __func__, switch_to_str); Noise. > + pr_debug("%s: set typec vbus gpio to %d\n", __func__, value); Noise. > + if (!nb) > + return -EINVAL; On which conditions this happen? > + pr_info("%s:set typec state to %lu\n", __func__, state); Noise! Guys, you perhaps can read about tracepoints and function tracer facilities in the kernel. > +static int hisi_hikey_usb_probe(struct platform_device *pdev) > +{ > + pr_info("%s: typc_vbus_enable_val can't get\n", __func__); Noise! > + if (IS_ERR_OR_NULL(hisi_hikey_usb->typec_vbus)) { So, this check is redundant. You are repeating it below. > + if (!hisi_hikey_usb->typec_vbus) > + ret = -EINVAL; > + else > + ret = PTR_ERR(hisi_hikey_usb->typec_vbus); > + return ret; > + } > + if (IS_ERR_OR_NULL(hisi_hikey_usb->role_sw)) { > + pr_err("%s: usb_role_switch_get failed\n", __func__); Noise and same comment to the conditional check as above > + if (!hisi_hikey_usb->role_sw) > + ret = -ENOENT; > + else > + ret = PTR_ERR(hisi_hikey_usb->role_sw); > + return ret; > + } > + .of_match_table = of_match_ptr(id_table_hisi_hikey_usb), Does it compiles for non-OF case? Why macro is in use?
next prev parent reply other threads:[~2018-12-03 9:23 UTC|newest] Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-03 3:45 [PATCH v1 00/12] Add support for usb on Hikey960 Yu Chen 2018-12-03 3:45 ` Yu Chen 2018-12-03 3:45 ` [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs Yu Chen 2018-12-03 3:45 ` [v1,01/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 01/12] " Yu Chen 2018-12-03 8:35 ` Sergei Shtylyov 2018-12-03 8:35 ` [v1,01/12] " Sergei Shtylyov 2018-12-03 8:51 ` [PATCH v1 01/12] " Chen Yu 2018-12-03 8:51 ` [v1,01/12] " Yu Chen 2018-12-03 8:51 ` [PATCH v1 01/12] " Chen Yu 2018-12-03 8:59 ` Sergei Shtylyov 2018-12-03 8:59 ` [v1,01/12] " Sergei Shtylyov 2018-12-03 9:28 ` [PATCH v1 01/12] " Chen Yu 2018-12-03 9:28 ` [v1,01/12] " Yu Chen 2018-12-03 9:28 ` [PATCH v1 01/12] " Chen Yu 2018-12-19 14:09 ` Rob Herring 2018-12-19 14:09 ` [v1,01/12] " Rob Herring 2018-12-20 1:33 ` [PATCH v1 01/12] " Chen Yu 2018-12-20 1:33 ` [v1,01/12] " Yu Chen 2018-12-20 1:33 ` [PATCH v1 01/12] " Chen Yu 2018-12-20 6:46 ` Felipe Balbi 2018-12-20 6:46 ` [v1,01/12] " Felipe Balbi 2018-12-20 13:48 ` [PATCH v1 01/12] " Rob Herring 2018-12-20 13:48 ` [v1,01/12] " Rob Herring 2018-12-03 3:45 ` [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen 2018-12-03 3:45 ` [v1,02/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 02/12] " Yu Chen 2018-12-19 14:14 ` Rob Herring 2018-12-19 14:14 ` [v1,02/12] " Rob Herring 2018-12-20 1:52 ` [PATCH v1 02/12] " Chen Yu 2018-12-20 1:52 ` [v1,02/12] " Yu Chen 2018-12-20 1:52 ` [PATCH v1 02/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen 2018-12-03 3:45 ` [v1,03/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 03/12] " Yu Chen 2018-12-19 14:21 ` Rob Herring 2018-12-19 14:21 ` [v1,03/12] " Rob Herring 2018-12-20 2:02 ` [PATCH v1 03/12] " Chen Yu 2018-12-20 2:02 ` [v1,03/12] " Yu Chen 2018-12-20 2:02 ` [PATCH v1 03/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform Yu Chen 2018-12-03 3:45 ` [v1,04/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 04/12] " Yu Chen 2018-12-03 8:12 ` Andy Shevchenko 2018-12-03 8:12 ` [v1,04/12] " Andy Shevchenko 2018-12-03 8:30 ` [PATCH v1 04/12] " Chen Yu 2018-12-03 8:30 ` [v1,04/12] " Yu Chen 2018-12-03 8:30 ` [PATCH v1 04/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen 2018-12-03 3:45 ` [v1,05/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 05/12] " Yu Chen 2018-12-03 8:02 ` Andy Shevchenko 2018-12-03 8:02 ` [v1,05/12] " Andy Shevchenko 2018-12-03 8:23 ` [PATCH v1 05/12] " Chen Yu 2018-12-03 8:23 ` [v1,05/12] " Yu Chen 2018-12-03 8:23 ` [PATCH v1 05/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen 2018-12-03 3:45 ` [v1,06/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 06/12] " Yu Chen 2018-12-03 8:14 ` Andy Shevchenko 2018-12-03 8:14 ` [v1,06/12] " Andy Shevchenko 2018-12-03 3:45 ` [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node Yu Chen 2018-12-03 3:45 ` [v1,07/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 07/12] " Yu Chen 2018-12-03 8:17 ` Andy Shevchenko 2018-12-03 8:17 ` [v1,07/12] " Andy Shevchenko 2018-12-03 12:25 ` [PATCH v1 07/12] " Heikki Krogerus 2018-12-03 12:25 ` [v1,07/12] " Heikki Krogerus 2019-01-21 8:36 ` [PATCH v1 07/12] " Chen Yu 2019-01-21 8:36 ` [v1,07/12] " Yu Chen 2019-01-21 8:36 ` [PATCH v1 07/12] " Chen Yu 2019-01-21 13:51 ` Heikki Krogerus 2019-01-21 13:51 ` [v1,07/12] " Heikki Krogerus 2019-01-25 12:35 ` [PATCH v1 07/12] " Heikki Krogerus 2019-01-25 12:35 ` [v1,07/12] " Heikki Krogerus 2018-12-03 3:45 ` [PATCH v1 08/12] usb: roles: Add usb role switch notifier Yu Chen 2018-12-03 3:45 ` [v1,08/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 08/12] " Yu Chen 2018-12-03 12:38 ` Heikki Krogerus 2018-12-03 12:38 ` [v1,08/12] " Heikki Krogerus 2018-12-04 1:07 ` [PATCH v1 08/12] " Chen Yu 2018-12-04 1:07 ` [v1,08/12] " Yu Chen 2018-12-04 1:07 ` [PATCH v1 08/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen 2018-12-03 3:45 ` [v1,09/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 09/12] " Yu Chen 2018-12-03 9:15 ` Andy Shevchenko 2018-12-03 9:15 ` [v1,09/12] " Andy Shevchenko 2018-12-03 9:30 ` [PATCH v1 09/12] " Chen Yu 2018-12-03 9:30 ` [v1,09/12] " Yu Chen 2018-12-03 9:30 ` [PATCH v1 09/12] " Chen Yu 2018-12-03 12:43 ` Heikki Krogerus 2018-12-03 12:43 ` [v1,09/12] " Heikki Krogerus 2018-12-04 10:54 ` [PATCH v1 09/12] " Heikki Krogerus 2018-12-04 10:54 ` [v1,09/12] " Heikki Krogerus 2018-12-05 0:56 ` [PATCH v1 09/12] " Chen Yu 2018-12-05 0:56 ` [v1,09/12] " Yu Chen 2018-12-05 0:56 ` [PATCH v1 09/12] " Chen Yu 2018-12-03 3:45 ` [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 Yu Chen 2018-12-03 3:45 ` [v1,10/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 10/12] " Yu Chen 2018-12-03 9:23 ` Andy Shevchenko [this message] 2018-12-03 9:23 ` [v1,10/12] " Andy Shevchenko 2018-12-04 1:40 ` [PATCH v1 10/12] " Chen Yu 2018-12-04 1:40 ` [v1,10/12] " Yu Chen 2018-12-04 1:40 ` [PATCH v1 10/12] " Chen Yu 2018-12-04 17:47 ` Andy Shevchenko 2018-12-04 17:47 ` [v1,10/12] " Andy Shevchenko 2018-12-05 1:57 ` [PATCH v1 10/12] " Chen Yu 2018-12-05 1:57 ` [v1,10/12] " Yu Chen 2018-12-05 1:57 ` [PATCH v1 10/12] " Chen Yu 2018-12-05 8:44 ` Andy Shevchenko 2018-12-05 8:44 ` [v1,10/12] " Andy Shevchenko 2018-12-03 3:45 ` [PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen 2018-12-03 3:45 ` [v1,11/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 11/12] " Yu Chen 2018-12-03 9:25 ` Andy Shevchenko 2018-12-03 9:25 ` [v1,11/12] " Andy Shevchenko 2018-12-04 1:22 ` [PATCH v1 11/12] " Chen Yu 2018-12-04 1:22 ` [v1,11/12] " Yu Chen 2018-12-04 1:22 ` [PATCH v1 11/12] " Chen Yu 2018-12-03 9:53 ` Krzysztof Opasiak 2018-12-03 9:53 ` [v1,11/12] " Krzysztof Opasiak 2018-12-03 3:45 ` [PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen 2018-12-03 3:45 ` Yu Chen 2018-12-03 3:45 ` [v1,12/12] " Yu Chen 2018-12-03 3:45 ` [PATCH v1 12/12] " Yu Chen 2018-12-04 12:45 ` Heikki Krogerus 2018-12-04 12:45 ` Heikki Krogerus 2018-12-04 12:45 ` [v1,12/12] " Heikki Krogerus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHp75VdSowHk4meQqqUamSjJJoVT59+pMZ1qjmmWd-W5nWBcUw@mail.gmail.com \ --to=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=chenyu56@huawei.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=heikki.krogerus@linux.intel.com \ --cc=john.stultz@linaro.org \ --cc=kongfei@hisilicon.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=suzhuangluan@hisilicon.com \ --cc=wangbinghui@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.