* [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
@ 2019-02-27 19:05 Heinrich Schuchardt
2019-04-01 5:51 ` Heinrich Schuchardt
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2019-02-27 19:05 UTC (permalink / raw)
To: u-boot
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit
is exceeded.
CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's
disable it.
Suggested-by: David Wu <david.wu@rock-chips.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
This solves only one of the problems with the boards in v2019.04.
The next problem is that reading the environment from MMC fails.
The patch
[PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
makes the problem visibe.
---
configs/tinker-rk3288_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig
index 68adf7635bf..03a7f81d63d 100644
--- a/configs/tinker-rk3288_defconfig
+++ b/configs/tinker-rk3288_defconfig
@@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb"
CONFIG_DISPLAY_BOARDINFO_LATE=y
CONFIG_SPL_STACK_R=y
CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000
-CONFIG_SPL_I2C_SUPPORT=y
CONFIG_CMD_GPIO=y
CONFIG_CMD_GPT=y
CONFIG_CMD_I2C=y
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
2019-02-27 19:05 [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT Heinrich Schuchardt
@ 2019-04-01 5:51 ` Heinrich Schuchardt
2019-04-01 10:20 ` David Wu
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2019-04-01 5:51 UTC (permalink / raw)
To: u-boot
On 2/27/19 8:05 PM, Heinrich Schuchardt wrote:
> The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit
> is exceeded.
>
> CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's
> disable it.
>
> Suggested-by: David Wu <david.wu@rock-chips.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Hello Philipp,
the patch has been assigned to you in patchwork. Is there any reason not
to merge it into U-Boot v2019.04?
Best regards
Heinrich
> ---
> This solves only one of the problems with the boards in v2019.04.
> The next problem is that reading the environment from MMC fails.
>
> The patch
> [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
> https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
> makes the problem visibe.
> ---
> configs/tinker-rk3288_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig
> index 68adf7635bf..03a7f81d63d 100644
> --- a/configs/tinker-rk3288_defconfig
> +++ b/configs/tinker-rk3288_defconfig
> @@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb"
> CONFIG_DISPLAY_BOARDINFO_LATE=y
> CONFIG_SPL_STACK_R=y
> CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000
> -CONFIG_SPL_I2C_SUPPORT=y
> CONFIG_CMD_GPIO=y
> CONFIG_CMD_GPT=y
> CONFIG_CMD_I2C=y
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
2019-02-27 19:05 [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT Heinrich Schuchardt
2019-04-01 5:51 ` Heinrich Schuchardt
@ 2019-04-01 10:20 ` David Wu
2019-04-21 16:57 ` [U-Boot] [U-Boot, " Philipp Tomsich
2019-06-11 12:13 ` [U-Boot] [PATCH " Tom Rini
3 siblings, 0 replies; 6+ messages in thread
From: David Wu @ 2019-04-01 10:20 UTC (permalink / raw)
To: u-boot
Hi Philipp,
This config does not look like it will be used in SPL and can be
deleted.
Reviewed-by: David Wu <david.wu@rock-chips.com>
在 2019/2/28 上午3:05, Heinrich Schuchardt 写道:
> The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit
> is exceeded.
>
> CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's
> disable it.
>
> Suggested-by: David Wu <david.wu@rock-chips.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> This solves only one of the problems with the boards in v2019.04.
> The next problem is that reading the environment from MMC fails.
>
> The patch
> [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
> https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
> makes the problem visibe.
> ---
> configs/tinker-rk3288_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig
> index 68adf7635bf..03a7f81d63d 100644
> --- a/configs/tinker-rk3288_defconfig
> +++ b/configs/tinker-rk3288_defconfig
> @@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb"
> CONFIG_DISPLAY_BOARDINFO_LATE=y
> CONFIG_SPL_STACK_R=y
> CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000
> -CONFIG_SPL_I2C_SUPPORT=y
> CONFIG_CMD_GPIO=y
> CONFIG_CMD_GPT=y
> CONFIG_CMD_I2C=y
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [U-Boot, 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
2019-02-27 19:05 [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT Heinrich Schuchardt
2019-04-01 5:51 ` Heinrich Schuchardt
2019-04-01 10:20 ` David Wu
@ 2019-04-21 16:57 ` Philipp Tomsich
2019-06-11 10:40 ` Heinrich Schuchardt
2019-06-11 12:13 ` [U-Boot] [PATCH " Tom Rini
3 siblings, 1 reply; 6+ messages in thread
From: Philipp Tomsich @ 2019-04-21 16:57 UTC (permalink / raw)
To: u-boot
> The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit
> is exceeded.
>
> CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's
> disable it.
>
> Suggested-by: David Wu <david.wu@rock-chips.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: David Wu <david.wu@rock-chips.com>
> ---
> This solves only one of the problems with the boards in v2019.04.
> The next problem is that reading the environment from MMC fails.
>
> The patch
> [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
> https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
> makes the problem visibe.
> ---
> configs/tinker-rk3288_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [U-Boot, 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
2019-04-21 16:57 ` [U-Boot] [U-Boot, " Philipp Tomsich
@ 2019-06-11 10:40 ` Heinrich Schuchardt
0 siblings, 0 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2019-06-11 10:40 UTC (permalink / raw)
To: u-boot
On 4/21/19 6:57 PM, Philipp Tomsich wrote:
>> The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit
>> is exceeded.
>>
>> CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's
>> disable it.
>>
>> Suggested-by: David Wu <david.wu@rock-chips.com>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> Reviewed-by: David Wu <david.wu@rock-chips.com>
>> ---
>> This solves only one of the problems with the boards in v2019.04.
>> The next problem is that reading the environment from MMC fails.
>>
>> The patch
>> [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
>> https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
>> makes the problem visibe.
>> ---
>> configs/tinker-rk3288_defconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Hello Tom,
could you, please, merge this patch that has been lingering since
February to fix the build issue for the TinkerBoard:
https://lists.denx.de/pipermail/u-boot/2019-February/360367.html
https://patchwork.ozlabs.org/patch/1049112/
You will have to rebase the patch:
CONFIG_SPL_TEXT_BASE=0xff704000 <<<< change this line
CONFIG_SPL_STACK_R=y
CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000
-CONFIG_SPL_I2C_SUPPORT=y
CONFIG_CMD_GPIO=y
CONFIG_CMD_GPT=y
CONFIG_CMD_I2C=y
Best regards
Heinrich
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
2019-02-27 19:05 [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT Heinrich Schuchardt
` (2 preceding siblings ...)
2019-04-21 16:57 ` [U-Boot] [U-Boot, " Philipp Tomsich
@ 2019-06-11 12:13 ` Tom Rini
3 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2019-06-11 12:13 UTC (permalink / raw)
To: u-boot
On Wed, Feb 27, 2019 at 08:05:43PM +0100, Heinrich Schuchardt wrote:
> The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit
> is exceeded.
>
> CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's
> disable it.
>
> Suggested-by: David Wu <david.wu@rock-chips.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: David Wu <david.wu@rock-chips.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190611/3795a00b/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-11 12:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-27 19:05 [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT Heinrich Schuchardt
2019-04-01 5:51 ` Heinrich Schuchardt
2019-04-01 10:20 ` David Wu
2019-04-21 16:57 ` [U-Boot] [U-Boot, " Philipp Tomsich
2019-06-11 10:40 ` Heinrich Schuchardt
2019-06-11 12:13 ` [U-Boot] [PATCH " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.