[Qemu-devel] [PATCH 0/3] MAINTAINERS: Clean up and improve section headlines

[Qemu-devel] [PATCH 0/3] MAINTAINERS: Clean up and improve section headlines

[Markus Armbruster]

Markus Armbruster (3):
  MAINTAINERS: Drop redundant L: qemu-devel@nongnu.org
  MAINTAINERS: Improve section headlines
  MAINTAINERS: Polish headline decorations

 MAINTAINERS | 113 +++++++++++++++++++++++-----------------------------
 1 file changed, 50 insertions(+), 63 deletions(-)

-- 
2.17.2

[Qemu-devel] [PATCH 1/3] MAINTAINERS: Drop redundant L: qemu-devel@nongnu.org

[Markus Armbruster]

Redundant since commit c9a19d5b95 "MAINTAINERS: add all-match entry
for qemu-devel@".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 MAINTAINERS | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1f5f8b7a2c..edc260e503 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -109,7 +109,6 @@ L: qemu-s390x@nongnu.org
 Guest CPU cores (TCG):
 ----------------------
 Overall
-L: qemu-devel@nongnu.org
 M: Richard Henderson <rth@twiddle.net>
 R: Paolo Bonzini <pbonzini@redhat.com>
 S: Maintained
@@ -444,19 +443,16 @@ F: util/*posix*.c
 F: include/qemu/*posix*.h
 
 NETBSD
-L: qemu-devel@nongnu.org
 M: Kamil Rytarowski <kamil@netbsd.org>
 S: Maintained
 K: ^Subject:.*(?i)NetBSD
 
 OPENBSD
-L: qemu-devel@nongnu.org
 M: Brad Smith <brad@comstyle.com>
 S: Maintained
 K: ^Subject:.*(?i)OpenBSD
 
 W32, W64
-L: qemu-devel@nongnu.org
 M: Stefan Weil <sw@weilnetz.de>
 S: Maintained
 F: *win32*
@@ -565,7 +561,6 @@ F: include/hw/*/digic*
 Gumstix
 M: Peter Maydell <peter.maydell@linaro.org>
 R: Philippe Mathieu-Daudé <f4bug@amsat.org>
-L: qemu-devel@nongnu.org
 L: qemu-arm@nongnu.org
 S: Odd Fixes
 F: hw/arm/gumstix.c
@@ -1044,7 +1039,6 @@ F: pc-bios/qemu_vga.ndrv
 
 PReP
 M: Hervé Poussineau <hpoussin@reactos.org>
-L: qemu-devel@nongnu.org
 L: qemu-ppc@nongnu.org
 S: Maintained
 F: hw/ppc/prep.c
@@ -1831,7 +1825,6 @@ S: Supported
 F: scripts/coverity-model.c
 
 CPU
-L: qemu-devel@nongnu.org
 S: Supported
 F: qom/cpu.c
 F: include/qom/cpu.h
@@ -2566,7 +2559,6 @@ F: qapi/rdma.json
 
 Semihosting
 M: Alex Bennée <alex.bennee@linaro.org>
-L: qemu-devel@nongnu.org
 S: Maintained
 F: hw/semihosting/
 F: include/hw/semihosting/
@@ -2577,7 +2569,6 @@ Build and test automation
 M: Alex Bennée <alex.bennee@linaro.org>
 M: Fam Zheng <fam@euphon.net>
 R: Philippe Mathieu-Daudé <philmd@redhat.com>
-L: qemu-devel@nongnu.org
 S: Maintained
 F: .travis.yml
 F: scripts/travis/
@@ -2592,7 +2583,6 @@ W: http://patchew.org/QEMU/
 FreeBSD Hosted Continuous Integration
 M: Ed Maste <emaste@freebsd.org>
 M: Li-Wen Hsu <lwhsu@freebsd.org>
-L: qemu-devel@nongnu.org
 S: Maintained
 F: .cirrus.yml
 W: https://cirrus-ci.com/github/qemu/qemu
@@ -2608,7 +2598,6 @@ R: Philippe Mathieu-Daudé <f4bug@amsat.org>
 S: Maintained
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
-L: qemu-devel@nongnu.org
 
 Documentation
 -------------
-- 
2.17.2

[Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Markus Armbruster]

When scripts/get_maintainer.pl reports something like

    John Doe <jdoe@example.org> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections
applies.  We have three, one each under "Guest CPU cores (TCG)",
"Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture
  support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index edc260e503..196282d165 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -83,7 +83,7 @@ T: git https://github.com/vivier/qemu.git trivial-patches
 
 Architecture support
 --------------------
-S390
+S390 general architecture support
 M: Cornelia Huck <cohuck@redhat.com>
 S: Supported
 F: default-configs/s390x-softmmu.mak
@@ -108,7 +108,7 @@ L: qemu-s390x@nongnu.org
 
 Guest CPU cores (TCG):
 ----------------------
-Overall
+Overall CPU cores (TCG)
 M: Richard Henderson <rth@twiddle.net>
 R: Paolo Bonzini <pbonzini@redhat.com>
 S: Maintained
@@ -133,14 +133,14 @@ F: fpu/
 F: include/fpu/
 F: tests/fp/
 
-Alpha
+Alpha CPU cores (TCG)
 M: Richard Henderson <rth@twiddle.net>
 S: Maintained
 F: target/alpha/
 F: tests/tcg/alpha/
 F: disas/alpha.c
 
-ARM
+ARM CPU cores (TCG)
 M: Peter Maydell <peter.maydell@linaro.org>
 L: qemu-arm@nongnu.org
 S: Maintained
@@ -161,7 +161,7 @@ S: Maintained
 F: hw/arm/smmu*
 F: include/hw/arm/smmu*
 
-CRIS
+CRIS CPU cores (TCG)
 M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
 S: Maintained
 F: target/cris/
@@ -170,14 +170,14 @@ F: include/hw/cris/
 F: tests/tcg/cris/
 F: disas/cris.c
 
-HPPA (PA-RISC)
+HPPA (PA-RISC) CPU cores (TCG)
 M: Richard Henderson <rth@twiddle.net>
 S: Maintained
 F: target/hppa/
 F: hw/hppa/
 F: disas/hppa.c
 
-LM32
+LM32 CPU cores (TCG)
 M: Michael Walle <michael@walle.cc>
 S: Maintained
 F: target/lm32/
@@ -190,20 +190,20 @@ F: include/hw/char/lm32_juart.h
 F: include/hw/lm32/
 F: tests/tcg/lm32/
 
-M68K
+M68K CPU cores (TCG)
 M: Laurent Vivier <laurent@vivier.eu>
 S: Maintained
 F: target/m68k/
 F: disas/m68k.c
 
-MicroBlaze
+MicroBlaze CPU cores (TCG)
 M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
 S: Maintained
 F: target/microblaze/
 F: hw/microblaze/
 F: disas/microblaze.c
 
-MIPS
+MIPS CPU cores (TCG)
 M: Aurelien Jarno <aurelien@aurel32.net>
 M: Aleksandar Markovic <amarkovic@wavecomp.com>
 R: Aleksandar Rikalo <arikalo@wavecomp.com>
@@ -224,7 +224,7 @@ F: include/hw/timer/mips_gictimer.h
 F: tests/tcg/mips/
 K: ^Subject:.*(?i)mips
 
-Moxie
+Moxie CPU cores (TCG)
 M: Anthony Green <green@moxielogic.com>
 S: Maintained
 F: target/moxie/
@@ -232,7 +232,7 @@ F: disas/moxie.c
 F: hw/moxie/
 F: default-configs/moxie-softmmu.mak
 
-NiosII
+NiosII CPU cores (TCG)
 M: Chris Wulff <crwulff@gmail.com>
 M: Marek Vasut <marex@denx.de>
 S: Maintained
@@ -242,14 +242,14 @@ F: hw/intc/nios2_iic.c
 F: disas/nios2.c
 F: default-configs/nios2-softmmu.mak
 
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <shorne@gmail.com>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/
 
-PowerPC
+PowerPC CPU cores (TCG)
 M: David Gibson <david@gibson.dropbear.id.au>
 L: qemu-ppc@nongnu.org
 S: Maintained
@@ -258,7 +258,7 @@ F: hw/ppc/
 F: include/hw/ppc/
 F: disas/ppc.c
 
-RISC-V
+RISC-V CPU cores (TCG)
 M: Palmer Dabbelt <palmer@sifive.com>
 M: Alistair Francis <Alistair.Francis@wdc.com>
 M: Sagar Karandikar <sagark@eecs.berkeley.edu>
@@ -271,7 +271,7 @@ F: include/hw/riscv/
 F: linux-user/host/riscv32/
 F: linux-user/host/riscv64/
 
-S390
+S390 CPU cores (TCG)
 M: Richard Henderson <rth@twiddle.net>
 M: David Hildenbrand <david@redhat.com>
 S: Maintained
@@ -281,7 +281,7 @@ F: disas/s390.c
 F: tests/tcg/s390x/
 L: qemu-s390x@nongnu.org
 
-SH4
+SH4 CPU cores (TCG)
 M: Aurelien Jarno <aurelien@aurel32.net>
 S: Odd Fixes
 F: target/sh4/
@@ -289,7 +289,7 @@ F: hw/sh4/
 F: disas/sh4.c
 F: include/hw/sh4/
 
-SPARC
+SPARC CPU cores (TCG)
 M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
 M: Artyom Tarasenko <atar4qemu@gmail.com>
 S: Maintained
@@ -299,14 +299,14 @@ F: hw/sparc64/
 F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
-UniCore32
+UniCore32 CPU cores (TCG)
 M: Guan Xuetao <gxt@mprc.pku.edu.cn>
 S: Maintained
 F: target/unicore32/
 F: hw/unicore32/
 F: include/hw/unicore32/
 
-X86
+X86 CPU cores (TCG)
 M: Paolo Bonzini <pbonzini@redhat.com>
 M: Richard Henderson <rth@twiddle.net>
 M: Eduardo Habkost <ehabkost@redhat.com>
@@ -319,7 +319,7 @@ F: disas/i386.c
 F: docs/qemu-cpu-models.texi
 T: git https://github.com/ehabkost/qemu.git x86-next
 
-Xtensa
+Xtensa CPU cores (TCG)
 M: Max Filippov <jcmvbkbc@gmail.com>
 W: http://wiki.osll.ru/doku.php?id=etc:users:jcmvbkbc:qemu-target-xtensa
 S: Maintained
@@ -330,7 +330,7 @@ F: disas/xtensa.c
 F: include/hw/xtensa/xtensa-isa.h
 F: default-configs/xtensa*.mak
 
-TriCore
+TriCore CPU cores (TCG)
 M: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
 S: Maintained
 F: target/tricore/
@@ -345,7 +345,7 @@ F: tests/tcg/multiarch/
 Guest CPU Cores (KVM):
 ----------------------
 
-Overall
+Overall CPU cores (KVM)
 M: Paolo Bonzini <pbonzini@redhat.com>
 L: kvm@vger.kernel.org
 S: Supported
@@ -356,24 +356,24 @@ F: include/hw/kvm/
 F: include/sysemu/kvm*.h
 F: scripts/kvm/kvm_flightrecorder
 
-ARM
+ARM CPU cores (KVM)
 M: Peter Maydell <peter.maydell@linaro.org>
 L: qemu-arm@nongnu.org
 S: Maintained
 F: target/arm/kvm.c
 
-MIPS
+MIPS CPU cores (KVM)
 M: James Hogan <jhogan@kernel.org>
 R: Aleksandar Rikalo <arikalo@wavecomp.com>
 S: Maintained
 F: target/mips/kvm.c
 
-PPC
+PPC CPU cores (KVM)
 M: David Gibson <david@gibson.dropbear.id.au>
 S: Maintained
 F: target/ppc/kvm.c
 
-S390
+S390 CPU cores (KVM)
 M: Halil Pasic <pasic@linux.ibm.com>
 M: Cornelia Huck <cohuck@redhat.com>
 M: Christian Borntraeger <borntraeger@de.ibm.com>
@@ -392,7 +392,7 @@ T: git https://github.com/cohuck/qemu.git s390-next
 T: git https://github.com/borntraeger/qemu.git s390-next
 L: qemu-s390x@nongnu.org
 
-X86
+X86 CPU cores (KVM)
 M: Paolo Bonzini <pbonzini@redhat.com>
 M: Marcelo Tosatti <mtosatti@redhat.com>
 L: kvm@vger.kernel.org
@@ -403,7 +403,7 @@ F: scripts/kvm/vmxcap
 Guest CPU Cores (Xen):
 ----------------------
 
-X86
+X86 CPU cores (Xen)
 M: Stefano Stabellini <sstabellini@kernel.org>
 M: Anthony Perard <anthony.perard@citrix.com>
 M: Paul Durrant <paul.durrant@citrix.com>
@@ -2256,7 +2256,7 @@ F: tests/uefi-test-tools/
 
 Usermode Emulation
 ------------------
-Overall
+Overall usermode emulation
 M: Riku Voipio <riku.voipio@iki.fi>
 S: Maintained
 F: thunk.c
@@ -2282,7 +2282,7 @@ M: Richard Henderson <rth@twiddle.net>
 S: Maintained
 F: tcg/
 
-AArch64 target
+AArch64 TCG target
 M: Claudio Fontana <claudio.fontana@huawei.com>
 M: Claudio Fontana <claudio.fontana@gmail.com>
 S: Maintained
@@ -2291,33 +2291,33 @@ F: tcg/aarch64/
 F: disas/arm-a64.cc
 F: disas/libvixl/
 
-ARM target
+ARM TCG target
 M: Andrzej Zaborowski <balrogg@gmail.com>
 S: Maintained
 L: qemu-arm@nongnu.org
 F: tcg/arm/
 F: disas/arm.c
 
-i386 target
+i386 TCG target
 M: Richard Henderson <rth@twiddle.net>
 S: Maintained
 F: tcg/i386/
 F: disas/i386.c
 
-MIPS target
+MIPS TCG target
 M: Aurelien Jarno <aurelien@aurel32.net>
 R: Aleksandar Rikalo <arikalo@wavecomp.com>
 S: Maintained
 F: tcg/mips/
 F: disas/mips.c
 
-PPC
+PPC TCG target
 M: Richard Henderson <rth@twiddle.net>
 S: Odd Fixes
 F: tcg/ppc/
 F: disas/ppc.c
 
-RISC-V
+RISC-V TCG target
 M: Palmer Dabbelt <palmer@sifive.com>
 M: Alistair Francis <Alistair.Francis@wdc.com>
 L: qemu-riscv@nongnu.org
@@ -2325,19 +2325,19 @@ S: Maintained
 F: tcg/riscv/
 F: disas/riscv.c
 
-S390 target
+S390 TCG target
 M: Richard Henderson <rth@twiddle.net>
 S: Maintained
 F: tcg/s390/
 F: disas/s390.c
 L: qemu-s390x@nongnu.org
 
-SPARC target
+SPARC TCG target
 S: Odd Fixes
 F: tcg/sparc/
 F: disas/sparc.c
 
-TCI target
+TCI TCG target
 M: Stefan Weil <sw@weilnetz.de>
 S: Maintained
 F: tcg/tci/
-- 
2.17.2

[Qemu-devel] [PATCH 3/3] MAINTAINERS: Polish headline decorations

[Markus Armbruster]

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 MAINTAINERS | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 196282d165..f8a5a3d448 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -65,7 +65,7 @@ F: *
 F: */
 
 Responsible Disclosure, Reporting Security Issues
-------------------------------
+-------------------------------------------------
 W: https://wiki.qemu.org/SecurityProcess
 M: Michael S. Tsirkin <mst@redhat.com>
 L: secalert@redhat.com
@@ -106,8 +106,8 @@ K: ^Subject:.*(?i)s390x?
 T: git https://github.com/cohuck/qemu.git s390-next
 L: qemu-s390x@nongnu.org
 
-Guest CPU cores (TCG):
-----------------------
+Guest CPU cores (TCG)
+---------------------
 Overall CPU cores (TCG)
 M: Richard Henderson <rth@twiddle.net>
 R: Paolo Bonzini <pbonzini@redhat.com>
@@ -342,9 +342,8 @@ M: Alex Bennée <alex.bennee@linaro.org>
 S: Maintained
 F: tests/tcg/multiarch/
 
-Guest CPU Cores (KVM):
-----------------------
-
+Guest CPU Cores (KVM)
+---------------------
 Overall CPU cores (KVM)
 M: Paolo Bonzini <pbonzini@redhat.com>
 L: kvm@vger.kernel.org
@@ -400,9 +399,8 @@ S: Supported
 F: target/i386/kvm.c
 F: scripts/kvm/vmxcap
 
-Guest CPU Cores (Xen):
-----------------------
-
+Guest CPU Cores (Xen)
+---------------------
 X86 CPU cores (Xen)
 M: Stefano Stabellini <sstabellini@kernel.org>
 M: Anthony Perard <anthony.perard@citrix.com>
@@ -423,9 +421,8 @@ F: include/hw/block/dataplane/xen*
 F: include/hw/xen/
 F: include/sysemu/xen-mapcache.h
 
-Hosts:
-------
-
+Hosts
+-----
 LINUX
 M: Michael S. Tsirkin <mst@redhat.com>
 M: Cornelia Huck <cohuck@redhat.com>
@@ -462,6 +459,7 @@ X: qga/*win32*
 F: qemu.nsi
 
 Alpha Machines
+--------------
 M: Richard Henderson <rth@twiddle.net>
 S: Maintained
 F: hw/alpha/
@@ -1196,7 +1194,7 @@ F: hw/s390x/s390-pci*
 L: qemu-s390x@nongnu.org
 
 UniCore32 Machines
--------------
+------------------
 PKUnity-3 SoC initramfs-with-busybox
 M: Guan Xuetao <gxt@mprc.pku.edu.cn>
 S: Maintained
-- 
2.17.2

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

On 5/29/19 10:08 AM, Markus Armbruster wrote:
> When scripts/get_maintainer.pl reports something like
> 
>     John Doe <jdoe@example.org> (maintainer:Overall)
> 
> the user is left to wonder *which* of our three "Overall" sections
> applies.  We have three, one each under "Guest CPU cores (TCG)",
> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
> 
> Rename sections under
> 
> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
> 
> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
> 
> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
> 
> * "Architecture support" from "FOO" to "FOO general architecture
>   support"
> 
> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
> 
> While there,
> 

Unintentional truncation? Or leftover thought that should be removed
after you instead split things?

> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>  1 file changed, 39 insertions(+), 39 deletions(-)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [Qemu-devel] [PATCH 1/3] MAINTAINERS: Drop redundant L: qemu-devel@nongnu.org

[Philippe Mathieu-Daudé]

On 5/29/19 5:08 PM, Markus Armbruster wrote:
> Redundant since commit c9a19d5b95 "MAINTAINERS: add all-match entry
> for qemu-devel@".

https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05019.html

:(

> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  MAINTAINERS | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1f5f8b7a2c..edc260e503 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -109,7 +109,6 @@ L: qemu-s390x@nongnu.org
>  Guest CPU cores (TCG):
>  ----------------------
>  Overall
> -L: qemu-devel@nongnu.org
>  M: Richard Henderson <rth@twiddle.net>
>  R: Paolo Bonzini <pbonzini@redhat.com>
>  S: Maintained
> @@ -444,19 +443,16 @@ F: util/*posix*.c
>  F: include/qemu/*posix*.h
>  
>  NETBSD
> -L: qemu-devel@nongnu.org
>  M: Kamil Rytarowski <kamil@netbsd.org>
>  S: Maintained
>  K: ^Subject:.*(?i)NetBSD
>  
>  OPENBSD
> -L: qemu-devel@nongnu.org
>  M: Brad Smith <brad@comstyle.com>
>  S: Maintained
>  K: ^Subject:.*(?i)OpenBSD
>  
>  W32, W64
> -L: qemu-devel@nongnu.org
>  M: Stefan Weil <sw@weilnetz.de>
>  S: Maintained
>  F: *win32*
> @@ -565,7 +561,6 @@ F: include/hw/*/digic*
>  Gumstix
>  M: Peter Maydell <peter.maydell@linaro.org>
>  R: Philippe Mathieu-Daudé <f4bug@amsat.org>
> -L: qemu-devel@nongnu.org
>  L: qemu-arm@nongnu.org
>  S: Odd Fixes
>  F: hw/arm/gumstix.c
> @@ -1044,7 +1039,6 @@ F: pc-bios/qemu_vga.ndrv
>  
>  PReP
>  M: Hervé Poussineau <hpoussin@reactos.org>
> -L: qemu-devel@nongnu.org
>  L: qemu-ppc@nongnu.org
>  S: Maintained
>  F: hw/ppc/prep.c
> @@ -1831,7 +1825,6 @@ S: Supported
>  F: scripts/coverity-model.c
>  
>  CPU
> -L: qemu-devel@nongnu.org
>  S: Supported
>  F: qom/cpu.c
>  F: include/qom/cpu.h
> @@ -2566,7 +2559,6 @@ F: qapi/rdma.json
>  
>  Semihosting
>  M: Alex Bennée <alex.bennee@linaro.org>
> -L: qemu-devel@nongnu.org
>  S: Maintained
>  F: hw/semihosting/
>  F: include/hw/semihosting/
> @@ -2577,7 +2569,6 @@ Build and test automation
>  M: Alex Bennée <alex.bennee@linaro.org>
>  M: Fam Zheng <fam@euphon.net>
>  R: Philippe Mathieu-Daudé <philmd@redhat.com>
> -L: qemu-devel@nongnu.org
>  S: Maintained
>  F: .travis.yml
>  F: scripts/travis/
> @@ -2592,7 +2583,6 @@ W: http://patchew.org/QEMU/
>  FreeBSD Hosted Continuous Integration
>  M: Ed Maste <emaste@freebsd.org>
>  M: Li-Wen Hsu <lwhsu@freebsd.org>
> -L: qemu-devel@nongnu.org
>  S: Maintained
>  F: .cirrus.yml
>  W: https://cirrus-ci.com/github/qemu/qemu
> @@ -2608,7 +2598,6 @@ R: Philippe Mathieu-Daudé <f4bug@amsat.org>
>  S: Maintained
>  F: tests/tcg/Makefile
>  F: tests/tcg/Makefile.include
> -L: qemu-devel@nongnu.org
>  
>  Documentation
>  -------------
> 

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Philippe Mathieu-Daudé]

On 5/29/19 5:16 PM, Eric Blake wrote:
> On 5/29/19 10:08 AM, Markus Armbruster wrote:
>> When scripts/get_maintainer.pl reports something like
>>
>>     John Doe <jdoe@example.org> (maintainer:Overall)
>>
>> the user is left to wonder *which* of our three "Overall" sections
>> applies.  We have three, one each under "Guest CPU cores (TCG)",
>> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>>
>> Rename sections under
>>
>> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>>
>> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>>
>> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>>
>> * "Architecture support" from "FOO" to "FOO general architecture
>>   support"
>>
>> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>>
>> While there,
>>
> 
> Unintentional truncation? Or leftover thought that should be removed
> after you instead split things?

leftover :)

"While there, polish headline decorations"

> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>>  1 file changed, 39 insertions(+), 39 deletions(-)
> 

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Philippe Mathieu-Daudé]

On 5/29/19 5:08 PM, Markus Armbruster wrote:
> When scripts/get_maintainer.pl reports something like
> 
>     John Doe <jdoe@example.org> (maintainer:Overall)
> 
> the user is left to wonder *which* of our three "Overall" sections
> applies.  We have three, one each under "Guest CPU cores (TCG)",
> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
> 
> Rename sections under
> 
> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
> 
> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
> 
> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
> 
> * "Architecture support" from "FOO" to "FOO general architecture
>   support"
> 
> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

I find the "cores" pattern more confusing now :S

> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>  1 file changed, 39 insertions(+), 39 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index edc260e503..196282d165 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -83,7 +83,7 @@ T: git https://github.com/vivier/qemu.git trivial-patches
>  
>  Architecture support
>  --------------------
> -S390
> +S390 general architecture support

OK

>  M: Cornelia Huck <cohuck@redhat.com>
>  S: Supported
>  F: default-configs/s390x-softmmu.mak
> @@ -108,7 +108,7 @@ L: qemu-s390x@nongnu.org
>  
>  Guest CPU cores (TCG):
>  ----------------------
> -Overall
> +Overall CPU cores (TCG)

What about "TCG (Overall)"?

>  M: Richard Henderson <rth@twiddle.net>
>  R: Paolo Bonzini <pbonzini@redhat.com>
>  S: Maintained
> @@ -133,14 +133,14 @@ F: fpu/
>  F: include/fpu/
>  F: tests/fp/
>  
> -Alpha
> +Alpha CPU cores (TCG)

I find "cores" confusing here, why not use "Alpha CPU (TCG)"?

>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: target/alpha/
>  F: tests/tcg/alpha/
>  F: disas/alpha.c
>  
> -ARM
> +ARM CPU cores (TCG)

Ditto.

>  M: Peter Maydell <peter.maydell@linaro.org>
>  L: qemu-arm@nongnu.org
>  S: Maintained
> @@ -161,7 +161,7 @@ S: Maintained
>  F: hw/arm/smmu*
>  F: include/hw/arm/smmu*
>  
> -CRIS
> +CRIS CPU cores (TCG)
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  S: Maintained
>  F: target/cris/
> @@ -170,14 +170,14 @@ F: include/hw/cris/
>  F: tests/tcg/cris/
>  F: disas/cris.c
>  
> -HPPA (PA-RISC)
> +HPPA (PA-RISC) CPU cores (TCG)
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: target/hppa/
>  F: hw/hppa/
>  F: disas/hppa.c
>  
> -LM32
> +LM32 CPU cores (TCG)
>  M: Michael Walle <michael@walle.cc>
>  S: Maintained
>  F: target/lm32/
> @@ -190,20 +190,20 @@ F: include/hw/char/lm32_juart.h
>  F: include/hw/lm32/
>  F: tests/tcg/lm32/
>  
> -M68K
> +M68K CPU cores (TCG)
>  M: Laurent Vivier <laurent@vivier.eu>
>  S: Maintained
>  F: target/m68k/
>  F: disas/m68k.c
>  
> -MicroBlaze
> +MicroBlaze CPU cores (TCG)
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  S: Maintained
>  F: target/microblaze/
>  F: hw/microblaze/
>  F: disas/microblaze.c
>  
> -MIPS
> +MIPS CPU cores (TCG)
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  M: Aleksandar Markovic <amarkovic@wavecomp.com>
>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
> @@ -224,7 +224,7 @@ F: include/hw/timer/mips_gictimer.h
>  F: tests/tcg/mips/
>  K: ^Subject:.*(?i)mips
>  
> -Moxie
> +Moxie CPU cores (TCG)
>  M: Anthony Green <green@moxielogic.com>
>  S: Maintained
>  F: target/moxie/
> @@ -232,7 +232,7 @@ F: disas/moxie.c
>  F: hw/moxie/
>  F: default-configs/moxie-softmmu.mak
>  
> -NiosII
> +NiosII CPU cores (TCG)
>  M: Chris Wulff <crwulff@gmail.com>
>  M: Marek Vasut <marex@denx.de>
>  S: Maintained
> @@ -242,14 +242,14 @@ F: hw/intc/nios2_iic.c
>  F: disas/nios2.c
>  F: default-configs/nios2-softmmu.mak
>  
> -OpenRISC
> +OpenRISC CPU cores (TCG)
>  M: Stafford Horne <shorne@gmail.com>
>  S: Odd Fixes
>  F: target/openrisc/
>  F: hw/openrisc/
>  F: tests/tcg/openrisc/
>  
> -PowerPC
> +PowerPC CPU cores (TCG)
>  M: David Gibson <david@gibson.dropbear.id.au>
>  L: qemu-ppc@nongnu.org
>  S: Maintained
> @@ -258,7 +258,7 @@ F: hw/ppc/
>  F: include/hw/ppc/
>  F: disas/ppc.c
>  
> -RISC-V
> +RISC-V CPU cores (TCG)
>  M: Palmer Dabbelt <palmer@sifive.com>
>  M: Alistair Francis <Alistair.Francis@wdc.com>
>  M: Sagar Karandikar <sagark@eecs.berkeley.edu>
> @@ -271,7 +271,7 @@ F: include/hw/riscv/
>  F: linux-user/host/riscv32/
>  F: linux-user/host/riscv64/
>  
> -S390
> +S390 CPU cores (TCG)
>  M: Richard Henderson <rth@twiddle.net>
>  M: David Hildenbrand <david@redhat.com>
>  S: Maintained
> @@ -281,7 +281,7 @@ F: disas/s390.c
>  F: tests/tcg/s390x/
>  L: qemu-s390x@nongnu.org
>  
> -SH4
> +SH4 CPU cores (TCG)
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  S: Odd Fixes
>  F: target/sh4/
> @@ -289,7 +289,7 @@ F: hw/sh4/
>  F: disas/sh4.c
>  F: include/hw/sh4/
>  
> -SPARC
> +SPARC CPU cores (TCG)
>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>  M: Artyom Tarasenko <atar4qemu@gmail.com>
>  S: Maintained
> @@ -299,14 +299,14 @@ F: hw/sparc64/
>  F: include/hw/sparc/sparc64.h
>  F: disas/sparc.c
>  
> -UniCore32
> +UniCore32 CPU cores (TCG)
>  M: Guan Xuetao <gxt@mprc.pku.edu.cn>
>  S: Maintained
>  F: target/unicore32/
>  F: hw/unicore32/
>  F: include/hw/unicore32/
>  
> -X86
> +X86 CPU cores (TCG)
>  M: Paolo Bonzini <pbonzini@redhat.com>
>  M: Richard Henderson <rth@twiddle.net>
>  M: Eduardo Habkost <ehabkost@redhat.com>
> @@ -319,7 +319,7 @@ F: disas/i386.c
>  F: docs/qemu-cpu-models.texi
>  T: git https://github.com/ehabkost/qemu.git x86-next
>  
> -Xtensa
> +Xtensa CPU cores (TCG)
>  M: Max Filippov <jcmvbkbc@gmail.com>
>  W: http://wiki.osll.ru/doku.php?id=etc:users:jcmvbkbc:qemu-target-xtensa
>  S: Maintained
> @@ -330,7 +330,7 @@ F: disas/xtensa.c
>  F: include/hw/xtensa/xtensa-isa.h
>  F: default-configs/xtensa*.mak
>  
> -TriCore
> +TriCore CPU cores (TCG)
>  M: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>  S: Maintained
>  F: target/tricore/
> @@ -345,7 +345,7 @@ F: tests/tcg/multiarch/
>  Guest CPU Cores (KVM):
>  ----------------------
>  
> -Overall
> +Overall CPU cores (KVM)

"KVM (Overall)"?

>  M: Paolo Bonzini <pbonzini@redhat.com>
>  L: kvm@vger.kernel.org
>  S: Supported
> @@ -356,24 +356,24 @@ F: include/hw/kvm/
>  F: include/sysemu/kvm*.h
>  F: scripts/kvm/kvm_flightrecorder
>  
> -ARM
> +ARM CPU cores (KVM)

"ARM CPU (KVM)"?

>  M: Peter Maydell <peter.maydell@linaro.org>
>  L: qemu-arm@nongnu.org
>  S: Maintained
>  F: target/arm/kvm.c
>  
> -MIPS
> +MIPS CPU cores (KVM)
>  M: James Hogan <jhogan@kernel.org>
>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
>  S: Maintained
>  F: target/mips/kvm.c
>  
> -PPC
> +PPC CPU cores (KVM)
>  M: David Gibson <david@gibson.dropbear.id.au>
>  S: Maintained
>  F: target/ppc/kvm.c
>  
> -S390
> +S390 CPU cores (KVM)
>  M: Halil Pasic <pasic@linux.ibm.com>
>  M: Cornelia Huck <cohuck@redhat.com>
>  M: Christian Borntraeger <borntraeger@de.ibm.com>
> @@ -392,7 +392,7 @@ T: git https://github.com/cohuck/qemu.git s390-next
>  T: git https://github.com/borntraeger/qemu.git s390-next
>  L: qemu-s390x@nongnu.org
>  
> -X86
> +X86 CPU cores (KVM)
>  M: Paolo Bonzini <pbonzini@redhat.com>
>  M: Marcelo Tosatti <mtosatti@redhat.com>
>  L: kvm@vger.kernel.org
> @@ -403,7 +403,7 @@ F: scripts/kvm/vmxcap
>  Guest CPU Cores (Xen):
>  ----------------------
>  
> -X86
> +X86 CPU cores (Xen)
>  M: Stefano Stabellini <sstabellini@kernel.org>
>  M: Anthony Perard <anthony.perard@citrix.com>
>  M: Paul Durrant <paul.durrant@citrix.com>
> @@ -2256,7 +2256,7 @@ F: tests/uefi-test-tools/
>  
>  Usermode Emulation
>  ------------------
> -Overall
> +Overall usermode emulation

"Usermode Emulation (Overall)"?

>  M: Riku Voipio <riku.voipio@iki.fi>
>  S: Maintained
>  F: thunk.c
> @@ -2282,7 +2282,7 @@ M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: tcg/
>  
> -AArch64 target
> +AArch64 TCG target
>  M: Claudio Fontana <claudio.fontana@huawei.com>
>  M: Claudio Fontana <claudio.fontana@gmail.com>
>  S: Maintained
> @@ -2291,33 +2291,33 @@ F: tcg/aarch64/
>  F: disas/arm-a64.cc
>  F: disas/libvixl/
>  
> -ARM target
> +ARM TCG target
>  M: Andrzej Zaborowski <balrogg@gmail.com>
>  S: Maintained
>  L: qemu-arm@nongnu.org
>  F: tcg/arm/
>  F: disas/arm.c
>  
> -i386 target
> +i386 TCG target
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: tcg/i386/
>  F: disas/i386.c
>  
> -MIPS target
> +MIPS TCG target
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
>  S: Maintained
>  F: tcg/mips/
>  F: disas/mips.c
>  
> -PPC
> +PPC TCG target
>  M: Richard Henderson <rth@twiddle.net>
>  S: Odd Fixes
>  F: tcg/ppc/
>  F: disas/ppc.c
>  
> -RISC-V
> +RISC-V TCG target
>  M: Palmer Dabbelt <palmer@sifive.com>
>  M: Alistair Francis <Alistair.Francis@wdc.com>
>  L: qemu-riscv@nongnu.org
> @@ -2325,19 +2325,19 @@ S: Maintained
>  F: tcg/riscv/
>  F: disas/riscv.c
>  
> -S390 target
> +S390 TCG target
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: tcg/s390/
>  F: disas/s390.c
>  L: qemu-s390x@nongnu.org
>  
> -SPARC target
> +SPARC TCG target
>  S: Odd Fixes
>  F: tcg/sparc/
>  F: disas/sparc.c
>  
> -TCI target
> +TCI TCG target
>  M: Stefan Weil <sw@weilnetz.de>
>  S: Maintained
>  F: tcg/tci/
> 

Re: [Qemu-devel] [PATCH 1/3] MAINTAINERS: Drop redundant L: qemu-devel@nongnu.org

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 5/29/19 5:08 PM, Markus Armbruster wrote:
>> Redundant since commit c9a19d5b95 "MAINTAINERS: add all-match entry
>> for qemu-devel@".
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05019.html
>
> :(

Oh.

I'm happy to take your patch if it applies without too much trouble.

Did more of that series get stuck?

>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks!

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 5/29/19 5:16 PM, Eric Blake wrote:
>> On 5/29/19 10:08 AM, Markus Armbruster wrote:
>>> When scripts/get_maintainer.pl reports something like
>>>
>>>     John Doe <jdoe@example.org> (maintainer:Overall)
>>>
>>> the user is left to wonder *which* of our three "Overall" sections
>>> applies.  We have three, one each under "Guest CPU cores (TCG)",
>>> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>>>
>>> Rename sections under
>>>
>>> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>>>
>>> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>>>
>>> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>>>
>>> * "Architecture support" from "FOO" to "FOO general architecture
>>>   support"
>>>
>>> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>>>
>>> While there,
>>>
>> 
>> Unintentional truncation? Or leftover thought that should be removed
>> after you instead split things?
>
> leftover :)
>
> "While there, polish headline decorations"

You're reading my distracted mind.

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 5/29/19 5:08 PM, Markus Armbruster wrote:
>> When scripts/get_maintainer.pl reports something like
>> 
>>     John Doe <jdoe@example.org> (maintainer:Overall)
>> 
>> the user is left to wonder *which* of our three "Overall" sections
>> applies.  We have three, one each under "Guest CPU cores (TCG)",
>> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>> 
>> Rename sections under
>> 
>> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>> 
>> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>> 
>> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>> 
>> * "Architecture support" from "FOO" to "FOO general architecture
>>   support"
>> 
>> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>
> I find the "cores" pattern more confusing now :S

Then let's find less confusing headlines together.

>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>>  1 file changed, 39 insertions(+), 39 deletions(-)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index edc260e503..196282d165 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -83,7 +83,7 @@ T: git https://github.com/vivier/qemu.git trivial-patches
>>  
>>  Architecture support
>>  --------------------
>> -S390
>> +S390 general architecture support
>
> OK
>
>>  M: Cornelia Huck <cohuck@redhat.com>
>>  S: Supported
>>  F: default-configs/s390x-softmmu.mak
>> @@ -108,7 +108,7 @@ L: qemu-s390x@nongnu.org
>>  
>>  Guest CPU cores (TCG):
>>  ----------------------
>> -Overall
>> +Overall CPU cores (TCG)
>
> What about "TCG (Overall)"?

Could be confused with the stuff under "Tiny Code Generator (TCG)"
below.

"Overall CPUs (TCG)"?

"TCG CPUs (overall)"?

>>  M: Richard Henderson <rth@twiddle.net>
>>  R: Paolo Bonzini <pbonzini@redhat.com>
>>  S: Maintained
>> @@ -133,14 +133,14 @@ F: fpu/
>>  F: include/fpu/
>>  F: tests/fp/
>>  
>> -Alpha
>> +Alpha CPU cores (TCG)
>
> I find "cores" confusing here, why not use "Alpha CPU (TCG)"?

"Alpha CPUs (TCG)"?

"TCG Alpha CPUs"?

Same for KVM and Xen below.

>>  M: Richard Henderson <rth@twiddle.net>
>>  S: Maintained
>>  F: target/alpha/
>>  F: tests/tcg/alpha/
>>  F: disas/alpha.c
>>  
>> -ARM
>> +ARM CPU cores (TCG)
>
> Ditto.
>
>>  M: Peter Maydell <peter.maydell@linaro.org>
>>  L: qemu-arm@nongnu.org
>>  S: Maintained
>> @@ -161,7 +161,7 @@ S: Maintained
>>  F: hw/arm/smmu*
>>  F: include/hw/arm/smmu*
>>  
>> -CRIS
>> +CRIS CPU cores (TCG)
>>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>>  S: Maintained
>>  F: target/cris/
>> @@ -170,14 +170,14 @@ F: include/hw/cris/
>>  F: tests/tcg/cris/
>>  F: disas/cris.c
>>  
>> -HPPA (PA-RISC)
>> +HPPA (PA-RISC) CPU cores (TCG)
>>  M: Richard Henderson <rth@twiddle.net>
>>  S: Maintained
>>  F: target/hppa/
>>  F: hw/hppa/
>>  F: disas/hppa.c
>>  
>> -LM32
>> +LM32 CPU cores (TCG)
>>  M: Michael Walle <michael@walle.cc>
>>  S: Maintained
>>  F: target/lm32/
>> @@ -190,20 +190,20 @@ F: include/hw/char/lm32_juart.h
>>  F: include/hw/lm32/
>>  F: tests/tcg/lm32/
>>  
>> -M68K
>> +M68K CPU cores (TCG)
>>  M: Laurent Vivier <laurent@vivier.eu>
>>  S: Maintained
>>  F: target/m68k/
>>  F: disas/m68k.c
>>  
>> -MicroBlaze
>> +MicroBlaze CPU cores (TCG)
>>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>>  S: Maintained
>>  F: target/microblaze/
>>  F: hw/microblaze/
>>  F: disas/microblaze.c
>>  
>> -MIPS
>> +MIPS CPU cores (TCG)
>>  M: Aurelien Jarno <aurelien@aurel32.net>
>>  M: Aleksandar Markovic <amarkovic@wavecomp.com>
>>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
>> @@ -224,7 +224,7 @@ F: include/hw/timer/mips_gictimer.h
>>  F: tests/tcg/mips/
>>  K: ^Subject:.*(?i)mips
>>  
>> -Moxie
>> +Moxie CPU cores (TCG)
>>  M: Anthony Green <green@moxielogic.com>
>>  S: Maintained
>>  F: target/moxie/
>> @@ -232,7 +232,7 @@ F: disas/moxie.c
>>  F: hw/moxie/
>>  F: default-configs/moxie-softmmu.mak
>>  
>> -NiosII
>> +NiosII CPU cores (TCG)
>>  M: Chris Wulff <crwulff@gmail.com>
>>  M: Marek Vasut <marex@denx.de>
>>  S: Maintained
>> @@ -242,14 +242,14 @@ F: hw/intc/nios2_iic.c
>>  F: disas/nios2.c
>>  F: default-configs/nios2-softmmu.mak
>>  
>> -OpenRISC
>> +OpenRISC CPU cores (TCG)
>>  M: Stafford Horne <shorne@gmail.com>
>>  S: Odd Fixes
>>  F: target/openrisc/
>>  F: hw/openrisc/
>>  F: tests/tcg/openrisc/
>>  
>> -PowerPC
>> +PowerPC CPU cores (TCG)
>>  M: David Gibson <david@gibson.dropbear.id.au>
>>  L: qemu-ppc@nongnu.org
>>  S: Maintained
>> @@ -258,7 +258,7 @@ F: hw/ppc/
>>  F: include/hw/ppc/
>>  F: disas/ppc.c
>>  
>> -RISC-V
>> +RISC-V CPU cores (TCG)
>>  M: Palmer Dabbelt <palmer@sifive.com>
>>  M: Alistair Francis <Alistair.Francis@wdc.com>
>>  M: Sagar Karandikar <sagark@eecs.berkeley.edu>
>> @@ -271,7 +271,7 @@ F: include/hw/riscv/
>>  F: linux-user/host/riscv32/
>>  F: linux-user/host/riscv64/
>>  
>> -S390
>> +S390 CPU cores (TCG)
>>  M: Richard Henderson <rth@twiddle.net>
>>  M: David Hildenbrand <david@redhat.com>
>>  S: Maintained
>> @@ -281,7 +281,7 @@ F: disas/s390.c
>>  F: tests/tcg/s390x/
>>  L: qemu-s390x@nongnu.org
>>  
>> -SH4
>> +SH4 CPU cores (TCG)
>>  M: Aurelien Jarno <aurelien@aurel32.net>
>>  S: Odd Fixes
>>  F: target/sh4/
>> @@ -289,7 +289,7 @@ F: hw/sh4/
>>  F: disas/sh4.c
>>  F: include/hw/sh4/
>>  
>> -SPARC
>> +SPARC CPU cores (TCG)
>>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>  M: Artyom Tarasenko <atar4qemu@gmail.com>
>>  S: Maintained
>> @@ -299,14 +299,14 @@ F: hw/sparc64/
>>  F: include/hw/sparc/sparc64.h
>>  F: disas/sparc.c
>>  
>> -UniCore32
>> +UniCore32 CPU cores (TCG)
>>  M: Guan Xuetao <gxt@mprc.pku.edu.cn>
>>  S: Maintained
>>  F: target/unicore32/
>>  F: hw/unicore32/
>>  F: include/hw/unicore32/
>>  
>> -X86
>> +X86 CPU cores (TCG)
>>  M: Paolo Bonzini <pbonzini@redhat.com>
>>  M: Richard Henderson <rth@twiddle.net>
>>  M: Eduardo Habkost <ehabkost@redhat.com>
>> @@ -319,7 +319,7 @@ F: disas/i386.c
>>  F: docs/qemu-cpu-models.texi
>>  T: git https://github.com/ehabkost/qemu.git x86-next
>>  
>> -Xtensa
>> +Xtensa CPU cores (TCG)
>>  M: Max Filippov <jcmvbkbc@gmail.com>
>>  W: http://wiki.osll.ru/doku.php?id=etc:users:jcmvbkbc:qemu-target-xtensa
>>  S: Maintained
>> @@ -330,7 +330,7 @@ F: disas/xtensa.c
>>  F: include/hw/xtensa/xtensa-isa.h
>>  F: default-configs/xtensa*.mak
>>  
>> -TriCore
>> +TriCore CPU cores (TCG)
>>  M: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>>  S: Maintained
>>  F: target/tricore/
>> @@ -345,7 +345,7 @@ F: tests/tcg/multiarch/
>>  Guest CPU Cores (KVM):
>>  ----------------------
>>  
>> -Overall
>> +Overall CPU cores (KVM)
>
> "KVM (Overall)"?
>
>>  M: Paolo Bonzini <pbonzini@redhat.com>
>>  L: kvm@vger.kernel.org
>>  S: Supported
>> @@ -356,24 +356,24 @@ F: include/hw/kvm/
>>  F: include/sysemu/kvm*.h
>>  F: scripts/kvm/kvm_flightrecorder
>>  
>> -ARM
>> +ARM CPU cores (KVM)
>
> "ARM CPU (KVM)"?
>
>>  M: Peter Maydell <peter.maydell@linaro.org>
>>  L: qemu-arm@nongnu.org
>>  S: Maintained
>>  F: target/arm/kvm.c
>>  
>> -MIPS
>> +MIPS CPU cores (KVM)
>>  M: James Hogan <jhogan@kernel.org>
>>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
>>  S: Maintained
>>  F: target/mips/kvm.c
>>  
>> -PPC
>> +PPC CPU cores (KVM)
>>  M: David Gibson <david@gibson.dropbear.id.au>
>>  S: Maintained
>>  F: target/ppc/kvm.c
>>  
>> -S390
>> +S390 CPU cores (KVM)
>>  M: Halil Pasic <pasic@linux.ibm.com>
>>  M: Cornelia Huck <cohuck@redhat.com>
>>  M: Christian Borntraeger <borntraeger@de.ibm.com>
>> @@ -392,7 +392,7 @@ T: git https://github.com/cohuck/qemu.git s390-next
>>  T: git https://github.com/borntraeger/qemu.git s390-next
>>  L: qemu-s390x@nongnu.org
>>  
>> -X86
>> +X86 CPU cores (KVM)
>>  M: Paolo Bonzini <pbonzini@redhat.com>
>>  M: Marcelo Tosatti <mtosatti@redhat.com>
>>  L: kvm@vger.kernel.org
>> @@ -403,7 +403,7 @@ F: scripts/kvm/vmxcap
>>  Guest CPU Cores (Xen):
>>  ----------------------
>>  
>> -X86
>> +X86 CPU cores (Xen)
>>  M: Stefano Stabellini <sstabellini@kernel.org>
>>  M: Anthony Perard <anthony.perard@citrix.com>
>>  M: Paul Durrant <paul.durrant@citrix.com>
>> @@ -2256,7 +2256,7 @@ F: tests/uefi-test-tools/
>>  
>>  Usermode Emulation
>>  ------------------
>> -Overall
>> +Overall usermode emulation
>
> "Usermode Emulation (Overall)"?

Works for me.

>>  M: Riku Voipio <riku.voipio@iki.fi>
>>  S: Maintained
>>  F: thunk.c
>> @@ -2282,7 +2282,7 @@ M: Richard Henderson <rth@twiddle.net>

Missed one:

    Tiny Code Generator (TCG)
    -------------------------
    Common code

Something like "TCG common code" should do.

    M: Richard Henderson <rth@twiddle.net>
>>  S: Maintained
>>  F: tcg/
>>  
>> -AArch64 target
>> +AArch64 TCG target
>>  M: Claudio Fontana <claudio.fontana@huawei.com>
>>  M: Claudio Fontana <claudio.fontana@gmail.com>
>>  S: Maintained
>> @@ -2291,33 +2291,33 @@ F: tcg/aarch64/
>>  F: disas/arm-a64.cc
>>  F: disas/libvixl/
>>  
>> -ARM target
>> +ARM TCG target
>>  M: Andrzej Zaborowski <balrogg@gmail.com>
>>  S: Maintained
>>  L: qemu-arm@nongnu.org
>>  F: tcg/arm/
>>  F: disas/arm.c
>>  
>> -i386 target
>> +i386 TCG target
>>  M: Richard Henderson <rth@twiddle.net>
>>  S: Maintained
>>  F: tcg/i386/
>>  F: disas/i386.c
>>  
>> -MIPS target
>> +MIPS TCG target
>>  M: Aurelien Jarno <aurelien@aurel32.net>
>>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
>>  S: Maintained
>>  F: tcg/mips/
>>  F: disas/mips.c
>>  
>> -PPC
>> +PPC TCG target
>>  M: Richard Henderson <rth@twiddle.net>
>>  S: Odd Fixes
>>  F: tcg/ppc/
>>  F: disas/ppc.c
>>  
>> -RISC-V
>> +RISC-V TCG target
>>  M: Palmer Dabbelt <palmer@sifive.com>
>>  M: Alistair Francis <Alistair.Francis@wdc.com>
>>  L: qemu-riscv@nongnu.org
>> @@ -2325,19 +2325,19 @@ S: Maintained
>>  F: tcg/riscv/
>>  F: disas/riscv.c
>>  
>> -S390 target
>> +S390 TCG target
>>  M: Richard Henderson <rth@twiddle.net>
>>  S: Maintained
>>  F: tcg/s390/
>>  F: disas/s390.c
>>  L: qemu-s390x@nongnu.org
>>  
>> -SPARC target
>> +SPARC TCG target
>>  S: Odd Fixes
>>  F: tcg/sparc/
>>  F: disas/sparc.c
>>  
>> -TCI target
>> +TCI TCG target
>>  M: Stefan Weil <sw@weilnetz.de>
>>  S: Maintained
>>  F: tcg/tci/
>> 

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Aleksandar Markovic]

On May 29, 2019 5:09 PM, "Markus Armbruster" <armbru@redhat.com> wrote:
>
> When scripts/get_maintainer.pl reports something like
>
>     John Doe <jdoe@example.org> (maintainer:Overall)
>
> the user is left to wonder *which* of our three "Overall" sections
> applies.  We have three, one each under "Guest CPU cores (TCG)",
> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>
> Rename sections under
>
> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>
> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>
> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>

In its essence definitely not a bad idea, but I must admit I tend to agree
with Philippe the new titles sound confusing, odd, artificial. Perhaps the
better alternative could be:

“FOO TCG guest”
“FOO KVM guest”
“FOO Xen guest”

> * "Architecture support" from "FOO" to "FOO general architecture
>   support"
>

Here we have a kind of strange situation with S390 architecture - it is the
only one present in this way in MAINTAINERS. Othrr than that, your new
wording looks fine to me.

> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>

I think this one you got it right.

Yours,
Aleksandar

>
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>  1 file changed, 39 insertions(+), 39 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index edc260e503..196282d165 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -83,7 +83,7 @@ T: git https://github.com/vivier/qemu.git
trivial-patches
>
>  Architecture support
>  --------------------
> -S390
> +S390 general architecture support
>  M: Cornelia Huck <cohuck@redhat.com>
>  S: Supported
>  F: default-configs/s390x-softmmu.mak
> @@ -108,7 +108,7 @@ L: qemu-s390x@nongnu.org
>
>  Guest CPU cores (TCG):
>  ----------------------
> -Overall
> +Overall CPU cores (TCG)
>  M: Richard Henderson <rth@twiddle.net>
>  R: Paolo Bonzini <pbonzini@redhat.com>
>  S: Maintained
> @@ -133,14 +133,14 @@ F: fpu/
>  F: include/fpu/
>  F: tests/fp/
>
> -Alpha
> +Alpha CPU cores (TCG)
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: target/alpha/
>  F: tests/tcg/alpha/
>  F: disas/alpha.c
>
> -ARM
> +ARM CPU cores (TCG)
>  M: Peter Maydell <peter.maydell@linaro.org>
>  L: qemu-arm@nongnu.org
>  S: Maintained
> @@ -161,7 +161,7 @@ S: Maintained
>  F: hw/arm/smmu*
>  F: include/hw/arm/smmu*
>
> -CRIS
> +CRIS CPU cores (TCG)
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  S: Maintained
>  F: target/cris/
> @@ -170,14 +170,14 @@ F: include/hw/cris/
>  F: tests/tcg/cris/
>  F: disas/cris.c
>
> -HPPA (PA-RISC)
> +HPPA (PA-RISC) CPU cores (TCG)
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: target/hppa/
>  F: hw/hppa/
>  F: disas/hppa.c
>
> -LM32
> +LM32 CPU cores (TCG)
>  M: Michael Walle <michael@walle.cc>
>  S: Maintained
>  F: target/lm32/
> @@ -190,20 +190,20 @@ F: include/hw/char/lm32_juart.h
>  F: include/hw/lm32/
>  F: tests/tcg/lm32/
>
> -M68K
> +M68K CPU cores (TCG)
>  M: Laurent Vivier <laurent@vivier.eu>
>  S: Maintained
>  F: target/m68k/
>  F: disas/m68k.c
>
> -MicroBlaze
> +MicroBlaze CPU cores (TCG)
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  S: Maintained
>  F: target/microblaze/
>  F: hw/microblaze/
>  F: disas/microblaze.c
>
> -MIPS
> +MIPS CPU cores (TCG)
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  M: Aleksandar Markovic <amarkovic@wavecomp.com>
>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
> @@ -224,7 +224,7 @@ F: include/hw/timer/mips_gictimer.h
>  F: tests/tcg/mips/
>  K: ^Subject:.*(?i)mips
>
> -Moxie
> +Moxie CPU cores (TCG)
>  M: Anthony Green <green@moxielogic.com>
>  S: Maintained
>  F: target/moxie/
> @@ -232,7 +232,7 @@ F: disas/moxie.c
>  F: hw/moxie/
>  F: default-configs/moxie-softmmu.mak
>
> -NiosII
> +NiosII CPU cores (TCG)
>  M: Chris Wulff <crwulff@gmail.com>
>  M: Marek Vasut <marex@denx.de>
>  S: Maintained
> @@ -242,14 +242,14 @@ F: hw/intc/nios2_iic.c
>  F: disas/nios2.c
>  F: default-configs/nios2-softmmu.mak
>
> -OpenRISC
> +OpenRISC CPU cores (TCG)
>  M: Stafford Horne <shorne@gmail.com>
>  S: Odd Fixes
>  F: target/openrisc/
>  F: hw/openrisc/
>  F: tests/tcg/openrisc/
>
> -PowerPC
> +PowerPC CPU cores (TCG)
>  M: David Gibson <david@gibson.dropbear.id.au>
>  L: qemu-ppc@nongnu.org
>  S: Maintained
> @@ -258,7 +258,7 @@ F: hw/ppc/
>  F: include/hw/ppc/
>  F: disas/ppc.c
>
> -RISC-V
> +RISC-V CPU cores (TCG)
>  M: Palmer Dabbelt <palmer@sifive.com>
>  M: Alistair Francis <Alistair.Francis@wdc.com>
>  M: Sagar Karandikar <sagark@eecs.berkeley.edu>
> @@ -271,7 +271,7 @@ F: include/hw/riscv/
>  F: linux-user/host/riscv32/
>  F: linux-user/host/riscv64/
>
> -S390
> +S390 CPU cores (TCG)
>  M: Richard Henderson <rth@twiddle.net>
>  M: David Hildenbrand <david@redhat.com>
>  S: Maintained
> @@ -281,7 +281,7 @@ F: disas/s390.c
>  F: tests/tcg/s390x/
>  L: qemu-s390x@nongnu.org
>
> -SH4
> +SH4 CPU cores (TCG)
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  S: Odd Fixes
>  F: target/sh4/
> @@ -289,7 +289,7 @@ F: hw/sh4/
>  F: disas/sh4.c
>  F: include/hw/sh4/
>
> -SPARC
> +SPARC CPU cores (TCG)
>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>  M: Artyom Tarasenko <atar4qemu@gmail.com>
>  S: Maintained
> @@ -299,14 +299,14 @@ F: hw/sparc64/
>  F: include/hw/sparc/sparc64.h
>  F: disas/sparc.c
>
> -UniCore32
> +UniCore32 CPU cores (TCG)
>  M: Guan Xuetao <gxt@mprc.pku.edu.cn>
>  S: Maintained
>  F: target/unicore32/
>  F: hw/unicore32/
>  F: include/hw/unicore32/
>
> -X86
> +X86 CPU cores (TCG)
>  M: Paolo Bonzini <pbonzini@redhat.com>
>  M: Richard Henderson <rth@twiddle.net>
>  M: Eduardo Habkost <ehabkost@redhat.com>
> @@ -319,7 +319,7 @@ F: disas/i386.c
>  F: docs/qemu-cpu-models.texi
>  T: git https://github.com/ehabkost/qemu.git x86-next
>
> -Xtensa
> +Xtensa CPU cores (TCG)
>  M: Max Filippov <jcmvbkbc@gmail.com>
>  W: http://wiki.osll.ru/doku.php?id=etc:users:jcmvbkbc:qemu-target-xtensa
>  S: Maintained
> @@ -330,7 +330,7 @@ F: disas/xtensa.c
>  F: include/hw/xtensa/xtensa-isa.h
>  F: default-configs/xtensa*.mak
>
> -TriCore
> +TriCore CPU cores (TCG)
>  M: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>  S: Maintained
>  F: target/tricore/
> @@ -345,7 +345,7 @@ F: tests/tcg/multiarch/
>  Guest CPU Cores (KVM):
>  ----------------------
>
> -Overall
> +Overall CPU cores (KVM)
>  M: Paolo Bonzini <pbonzini@redhat.com>
>  L: kvm@vger.kernel.org
>  S: Supported
> @@ -356,24 +356,24 @@ F: include/hw/kvm/
>  F: include/sysemu/kvm*.h
>  F: scripts/kvm/kvm_flightrecorder
>
> -ARM
> +ARM CPU cores (KVM)
>  M: Peter Maydell <peter.maydell@linaro.org>
>  L: qemu-arm@nongnu.org
>  S: Maintained
>  F: target/arm/kvm.c
>
> -MIPS
> +MIPS CPU cores (KVM)
>  M: James Hogan <jhogan@kernel.org>
>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
>  S: Maintained
>  F: target/mips/kvm.c
>
> -PPC
> +PPC CPU cores (KVM)
>  M: David Gibson <david@gibson.dropbear.id.au>
>  S: Maintained
>  F: target/ppc/kvm.c
>
> -S390
> +S390 CPU cores (KVM)
>  M: Halil Pasic <pasic@linux.ibm.com>
>  M: Cornelia Huck <cohuck@redhat.com>
>  M: Christian Borntraeger <borntraeger@de.ibm.com>
> @@ -392,7 +392,7 @@ T: git https://github.com/cohuck/qemu.git s390-next
>  T: git https://github.com/borntraeger/qemu.git s390-next
>  L: qemu-s390x@nongnu.org
>
> -X86
> +X86 CPU cores (KVM)
>  M: Paolo Bonzini <pbonzini@redhat.com>
>  M: Marcelo Tosatti <mtosatti@redhat.com>
>  L: kvm@vger.kernel.org
> @@ -403,7 +403,7 @@ F: scripts/kvm/vmxcap
>  Guest CPU Cores (Xen):
>  ----------------------
>
> -X86
> +X86 CPU cores (Xen)
>  M: Stefano Stabellini <sstabellini@kernel.org>
>  M: Anthony Perard <anthony.perard@citrix.com>
>  M: Paul Durrant <paul.durrant@citrix.com>
> @@ -2256,7 +2256,7 @@ F: tests/uefi-test-tools/
>
>  Usermode Emulation
>  ------------------
> -Overall
> +Overall usermode emulation
>  M: Riku Voipio <riku.voipio@iki.fi>
>  S: Maintained
>  F: thunk.c
> @@ -2282,7 +2282,7 @@ M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: tcg/
>
> -AArch64 target
> +AArch64 TCG target
>  M: Claudio Fontana <claudio.fontana@huawei.com>
>  M: Claudio Fontana <claudio.fontana@gmail.com>
>  S: Maintained
> @@ -2291,33 +2291,33 @@ F: tcg/aarch64/
>  F: disas/arm-a64.cc
>  F: disas/libvixl/
>
> -ARM target
> +ARM TCG target
>  M: Andrzej Zaborowski <balrogg@gmail.com>
>  S: Maintained
>  L: qemu-arm@nongnu.org
>  F: tcg/arm/
>  F: disas/arm.c
>
> -i386 target
> +i386 TCG target
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: tcg/i386/
>  F: disas/i386.c
>
> -MIPS target
> +MIPS TCG target
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
>  S: Maintained
>  F: tcg/mips/
>  F: disas/mips.c
>
> -PPC
> +PPC TCG target
>  M: Richard Henderson <rth@twiddle.net>
>  S: Odd Fixes
>  F: tcg/ppc/
>  F: disas/ppc.c
>
> -RISC-V
> +RISC-V TCG target
>  M: Palmer Dabbelt <palmer@sifive.com>
>  M: Alistair Francis <Alistair.Francis@wdc.com>
>  L: qemu-riscv@nongnu.org
> @@ -2325,19 +2325,19 @@ S: Maintained
>  F: tcg/riscv/
>  F: disas/riscv.c
>
> -S390 target
> +S390 TCG target
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: tcg/s390/
>  F: disas/s390.c
>  L: qemu-s390x@nongnu.org
>
> -SPARC target
> +SPARC TCG target
>  S: Odd Fixes
>  F: tcg/sparc/
>  F: disas/sparc.c
>
> -TCI target
> +TCI TCG target
>  M: Stefan Weil <sw@weilnetz.de>
>  S: Maintained
>  F: tcg/tci/
> --
> 2.17.2
>
>

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Stafford Horne]

On Wed, May 29, 2019 at 05:08:52PM +0200, Markus Armbruster wrote:
> When scripts/get_maintainer.pl reports something like
> 
>     John Doe <jdoe@example.org> (maintainer:Overall)
> 
> the user is left to wonder *which* of our three "Overall" sections
> applies.  We have three, one each under "Guest CPU cores (TCG)",
> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
> 
> Rename sections under
> 
> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
> 
> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
> 
> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
> 
> * "Architecture support" from "FOO" to "FOO general architecture
>   support"
> 
> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
> 
> While there,
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>  1 file changed, 39 insertions(+), 39 deletions(-)

... 

> -OpenRISC
> +OpenRISC CPU cores (TCG)
>  M: Stafford Horne <shorne@gmail.com>
>  S: Odd Fixes
>  F: target/openrisc/
>  F: hw/openrisc/
>  F: tests/tcg/openrisc/
>  

As directories listed there I look over both target/ (TCG?) and hw/.
Would it be better to be 'OpenRISC general architecture'?

-Stafford

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Markus Armbruster]

Aleksandar Markovic <aleksandar.m.mail@gmail.com> writes:

> On May 29, 2019 5:09 PM, "Markus Armbruster" <armbru@redhat.com> wrote:
>>
>> When scripts/get_maintainer.pl reports something like
>>
>>     John Doe <jdoe@example.org> (maintainer:Overall)
>>
>> the user is left to wonder *which* of our three "Overall" sections
>> applies.  We have three, one each under "Guest CPU cores (TCG)",
>> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>>
>> Rename sections under
>>
>> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>>
>> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>>
>> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>>
>
> In its essence definitely not a bad idea, but I must admit I tend to agree
> with Philippe the new titles sound confusing, odd, artificial. Perhaps the
> better alternative could be:
>
> “FOO TCG guest”
> “FOO KVM guest”
> “FOO Xen guest”

Other suggestions mentioned so far:

  "FOO CPUs (TCG)"
  "TCG FOO CPUs"

and same for KVM and Xen.

I guess mentioning target first, accelerator second, no parenthesis
makes sense.  That leaves "guest" vs. "CPUs".  Which one's closer to the
truth?

>> * "Architecture support" from "FOO" to "FOO general architecture
>>   support"
>>
>
> Here we have a kind of strange situation with S390 architecture - it is the
> only one present in this way in MAINTAINERS. Othrr than that, your new
> wording looks fine to me.

Yes, it's odd.  But it's what works for the S390 maintainers.

>> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>>
>
> I think this one you got it right.

Thanks!

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Markus Armbruster]

Stafford Horne <shorne@gmail.com> writes:

> On Wed, May 29, 2019 at 05:08:52PM +0200, Markus Armbruster wrote:
>> When scripts/get_maintainer.pl reports something like
>> 
>>     John Doe <jdoe@example.org> (maintainer:Overall)
>> 
>> the user is left to wonder *which* of our three "Overall" sections
>> applies.  We have three, one each under "Guest CPU cores (TCG)",
>> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>> 
>> Rename sections under
>> 
>> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>> 
>> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>> 
>> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>> 
>> * "Architecture support" from "FOO" to "FOO general architecture
>>   support"
>> 
>> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>> 
>> While there,
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>>  1 file changed, 39 insertions(+), 39 deletions(-)
>
> ... 
>
>> -OpenRISC
>> +OpenRISC CPU cores (TCG)
>>  M: Stafford Horne <shorne@gmail.com>
>>  S: Odd Fixes
>>  F: target/openrisc/
>>  F: hw/openrisc/
>>  F: tests/tcg/openrisc/
>>  
>
> As directories listed there I look over both target/ (TCG?) and hw/.

Same for ARM, LM32, MicroBlaze, MIPS, Moxie, ...

> Would it be better to be 'OpenRISC general architecture'?

Valid question.  Peter, do you have an opinion?

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Philippe Mathieu-Daudé]

On 5/31/19 5:36 AM, Stafford Horne wrote:
> On Wed, May 29, 2019 at 05:08:52PM +0200, Markus Armbruster wrote:
>> When scripts/get_maintainer.pl reports something like
>>
>>     John Doe <jdoe@example.org> (maintainer:Overall)
>>
>> the user is left to wonder *which* of our three "Overall" sections
>> applies.  We have three, one each under "Guest CPU cores (TCG)",
>> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>>
>> Rename sections under
>>
>> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>>
>> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>>
>> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>>
>> * "Architecture support" from "FOO" to "FOO general architecture
>>   support"
>>
>> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>>
>> While there,
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>>  1 file changed, 39 insertions(+), 39 deletions(-)
> 
> ... 
> 
>> -OpenRISC
>> +OpenRISC CPU cores (TCG)
>>  M: Stafford Horne <shorne@gmail.com>
>>  S: Odd Fixes
>>  F: target/openrisc/
>>  F: hw/openrisc/
>>  F: tests/tcg/openrisc/
>>  
> 
> As directories listed there I look over both target/ (TCG?) and hw/.
> Would it be better to be 'OpenRISC general architecture'?

There is a historical separation between target/ and hw/ because they
cover different concepts, and have different maintainers/reviewers.

- target/$arch/ is for TCG/KVM
- hw/ is for machines and their devices
  (some devices are reused by multiple archs)

Although the separation is not always clear (some devices are tied to an
architecture, some architecture instruction directly access devices) I'd
prefer we keep 2 distincts MAINTAINERS sections (keeping you maintainer
of both). This will ease developper with specific background/interests
to volunteer to a particular section.

Regards,

Phil.

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Cornelia Huck]

On Mon, 03 Jun 2019 10:29:35 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Aleksandar Markovic <aleksandar.m.mail@gmail.com> writes:
> 
> > On May 29, 2019 5:09 PM, "Markus Armbruster" <armbru@redhat.com> wrote:  
> >>
> >> When scripts/get_maintainer.pl reports something like
> >>
> >>     John Doe <jdoe@example.org> (maintainer:Overall)
> >>
> >> the user is left to wonder *which* of our three "Overall" sections
> >> applies.  We have three, one each under "Guest CPU cores (TCG)",
> >> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
> >>
> >> Rename sections under
> >>
> >> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
> >>
> >> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
> >>
> >> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
> >>  
> >
> > In its essence definitely not a bad idea, but I must admit I tend to agree
> > with Philippe the new titles sound confusing, odd, artificial. Perhaps the
> > better alternative could be:
> >
> > “FOO TCG guest”
> > “FOO KVM guest”
> > “FOO Xen guest”  
> 
> Other suggestions mentioned so far:
> 
>   "FOO CPUs (TCG)"
>   "TCG FOO CPUs"
> 
> and same for KVM and Xen.
> 
> I guess mentioning target first, accelerator second, no parenthesis
> makes sense.  That leaves "guest" vs. "CPUs".  Which one's closer to the
> truth?

'CPUs' makes more sense to me; 'guest' would also include
(architecture-specific) emulated devices.

> 
> >> * "Architecture support" from "FOO" to "FOO general architecture
> >>   support"
> >>  
> >
> > Here we have a kind of strange situation with S390 architecture - it is the
> > only one present in this way in MAINTAINERS. Othrr than that, your new
> > wording looks fine to me.  
> 
> Yes, it's odd.  But it's what works for the S390 maintainers.

Yes. I basically integrate all s390 stuff, including pull requests from
others. I'm more wondering why other architectures don't do that as
well :) Different setup, I guess.

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Stafford Horne]

On Mon, Jun 03, 2019 at 10:45:14AM +0200, Philippe Mathieu-Daudé wrote:
> On 5/31/19 5:36 AM, Stafford Horne wrote:
> > On Wed, May 29, 2019 at 05:08:52PM +0200, Markus Armbruster wrote:
> >> When scripts/get_maintainer.pl reports something like
> >>
> >>     John Doe <jdoe@example.org> (maintainer:Overall)
> >>
> >> the user is left to wonder *which* of our three "Overall" sections
> >> applies.  We have three, one each under "Guest CPU cores (TCG)",
> >> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
> >>
> >> Rename sections under
> >>
> >> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
> >>
> >> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
> >>
> >> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
> >>
> >> * "Architecture support" from "FOO" to "FOO general architecture
> >>   support"
> >>
> >> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
> >>
> >> While there,
> >>
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >> ---
> >>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
> >>  1 file changed, 39 insertions(+), 39 deletions(-)
> > 
> > ... 
> > 
> >> -OpenRISC
> >> +OpenRISC CPU cores (TCG)
> >>  M: Stafford Horne <shorne@gmail.com>
> >>  S: Odd Fixes
> >>  F: target/openrisc/
> >>  F: hw/openrisc/
> >>  F: tests/tcg/openrisc/
> >>  
> > 
> > As directories listed there I look over both target/ (TCG?) and hw/.
> > Would it be better to be 'OpenRISC general architecture'?
> 
> There is a historical separation between target/ and hw/ because they
> cover different concepts, and have different maintainers/reviewers.
> 
> - target/$arch/ is for TCG/KVM
> - hw/ is for machines and their devices
>   (some devices are reused by multiple archs)
> 
> Although the separation is not always clear (some devices are tied to an
> architecture, some architecture instruction directly access devices) I'd
> prefer we keep 2 distincts MAINTAINERS sections (keeping you maintainer
> of both). This will ease developper with specific background/interests
> to volunteer to a particular section.

Hello,

Thanks for the explaination.  I think it makes sense to have 2 different
maintainer sections.  In that case should this patch be amended to move the
'F: hw/openrisc/' etc out to a different section with the different header?

-Stafford

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Markus Armbruster]

Stafford Horne <shorne@gmail.com> writes:

> On Mon, Jun 03, 2019 at 10:45:14AM +0200, Philippe Mathieu-Daudé wrote:
>> On 5/31/19 5:36 AM, Stafford Horne wrote:
>> > On Wed, May 29, 2019 at 05:08:52PM +0200, Markus Armbruster wrote:
>> >> When scripts/get_maintainer.pl reports something like
>> >>
>> >>     John Doe <jdoe@example.org> (maintainer:Overall)
>> >>
>> >> the user is left to wonder *which* of our three "Overall" sections
>> >> applies.  We have three, one each under "Guest CPU cores (TCG)",
>> >> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>> >>
>> >> Rename sections under
>> >>
>> >> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>> >>
>> >> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>> >>
>> >> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>> >>
>> >> * "Architecture support" from "FOO" to "FOO general architecture
>> >>   support"
>> >>
>> >> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>> >>
>> >> While there,
>> >>
>> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> >> ---
>> >>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>> >>  1 file changed, 39 insertions(+), 39 deletions(-)
>> > 
>> > ... 
>> > 
>> >> -OpenRISC
>> >> +OpenRISC CPU cores (TCG)
>> >>  M: Stafford Horne <shorne@gmail.com>
>> >>  S: Odd Fixes
>> >>  F: target/openrisc/
>> >>  F: hw/openrisc/
>> >>  F: tests/tcg/openrisc/
>> >>  
>> > 
>> > As directories listed there I look over both target/ (TCG?) and hw/.
>> > Would it be better to be 'OpenRISC general architecture'?
>> 
>> There is a historical separation between target/ and hw/ because they
>> cover different concepts, and have different maintainers/reviewers.
>> 
>> - target/$arch/ is for TCG/KVM
>> - hw/ is for machines and their devices
>>   (some devices are reused by multiple archs)
>> 
>> Although the separation is not always clear (some devices are tied to an
>> architecture, some architecture instruction directly access devices) I'd
>> prefer we keep 2 distincts MAINTAINERS sections (keeping you maintainer
>> of both). This will ease developper with specific background/interests
>> to volunteer to a particular section.
>
> Hello,
>
> Thanks for the explaination.  I think it makes sense to have 2 different
> maintainer sections.  In that case should this patch be amended to move the
> 'F: hw/openrisc/' etc out to a different section with the different header?

This patch merely improves headlines.  Splitting up the OpenRISC section
above should be separate.  Care to send the patch?

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Stafford Horne]

On Thu, Jun 06, 2019 at 07:01:49PM +0200, Markus Armbruster wrote:
>Stafford Horne <shorne@gmail.com> writes:
>
>> On Mon, Jun 03, 2019 at 10:45:14AM +0200, Philippe Mathieu-Daudé wrote:
>>> On 5/31/19 5:36 AM, Stafford Horne wrote:
>>> > On Wed, May 29, 2019 at 05:08:52PM +0200, Markus Armbruster wrote:
>>> >> When scripts/get_maintainer.pl reports something like
>>> >>
>>> >>     John Doe <jdoe@example.org> (maintainer:Overall)
>>> >>
>>> >> the user is left to wonder *which* of our three "Overall" sections
>>> >> applies.  We have three, one each under "Guest CPU cores (TCG)",
>>> >> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>>> >>
>>> >> Rename sections under
>>> >>
>>> >> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>>> >>
>>> >> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>>> >>
>>> >> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>>> >>
>>> >> * "Architecture support" from "FOO" to "FOO general architecture
>>> >>   support"
>>> >>
>>> >> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>>> >>
>>> >> While there,
>>> >>
>>> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>> >> ---
>>> >>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>>> >>  1 file changed, 39 insertions(+), 39 deletions(-)
>>> >
>>> > ...
>>> >
>>> >> -OpenRISC
>>> >> +OpenRISC CPU cores (TCG)
>>> >>  M: Stafford Horne <shorne@gmail.com>
>>> >>  S: Odd Fixes
>>> >>  F: target/openrisc/
>>> >>  F: hw/openrisc/
>>> >>  F: tests/tcg/openrisc/
>>> >>
>>> >
>>> > As directories listed there I look over both target/ (TCG?) and hw/.
>>> > Would it be better to be 'OpenRISC general architecture'?
>>>
>>> There is a historical separation between target/ and hw/ because they
>>> cover different concepts, and have different maintainers/reviewers.
>>>
>>> - target/$arch/ is for TCG/KVM
>>> - hw/ is for machines and their devices
>>>   (some devices are reused by multiple archs)
>>>
>>> Although the separation is not always clear (some devices are tied to an
>>> architecture, some architecture instruction directly access devices) I'd
>>> prefer we keep 2 distincts MAINTAINERS sections (keeping you maintainer
>>> of both). This will ease developper with specific background/interests
>>> to volunteer to a particular section.
>>
>> Hello,
>>
>> Thanks for the explaination.  I think it makes sense to have 2 different
>> maintainer sections.  In that case should this patch be amended to move the
>> 'F: hw/openrisc/' etc out to a different section with the different header?
>
>This patch merely improves headlines.  Splitting up the OpenRISC section
>above should be separate.  Care to send the patch?

Sure, now that I look at it, there is a section for 'OpenRISC Machines' and the
maintainer is out of date.

-Stafford