All of lore.kernel.org
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the rdma tree
@ 2019-07-09  3:30 Stephen Rothwell
  2019-07-09  7:04 ` Mark Zhang
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-09  3:30 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Mark Zhang,
	Majd Dibbiny, asahiro Yamada

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from /home/sfr/next/next/include/rdma/rdma_counter.h:12,
                 from <command-line>:
/home/sfr/next/next/include/rdma/ib_verbs.h:2126:27: error: field 'port_counter' has incomplete type
  struct rdma_port_counter port_counter;
                           ^~~~~~~~~~~~

Caused by commit

  413d3347503b ("RDMA/counter: Add set/clear per-port auto mode support")

rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
from rdma_counter.h, but it is not defined yet :-(

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 9 Jul 2019 13:17:49 +1000
Subject: [PATCH] RDMA: don't try to build rdma_counter.h for now

rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
from rdma_counter.h, but it is not defined yet :-(

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/Kbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/Kbuild b/include/Kbuild
index 78434c59701f..8dab85cdf4f4 100644
--- a/include/Kbuild
+++ b/include/Kbuild
@@ -939,6 +939,7 @@ header-test-			+= rdma/ib.h
 header-test-			+= rdma/iw_portmap.h
 header-test-			+= rdma/opa_port_info.h
 header-test-			+= rdma/rdmavt_cq.h
+header-test-			+= rdma/rdma_counter.h
 header-test-			+= rdma/restrack.h
 header-test-			+= rdma/signature.h
 header-test-			+= rdma/tid_rdma_defs.h
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-09  3:30 linux-next: build failure after merge of the rdma tree Stephen Rothwell
@ 2019-07-09  7:04 ` Mark Zhang
  2019-07-09  7:18   ` Leon Romanovsky
  0 siblings, 1 reply; 68+ messages in thread
From: Mark Zhang @ 2019-07-09  7:04 UTC (permalink / raw)
  To: Stephen Rothwell, Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Majd Dibbiny,
	asahiro Yamada, Leon Romanovsky

Hi Stephen,

Can you please try the patch below, thank you.

net/mlx5: Remove include ib_verbs.h in rdma_counter.h

rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
from rdma_counter.h, but it is not defined yet.

Fixes: 413d3347503b ("RDMA/counter: Add set/clear per-port auto mode 
support")
Signed-off-by: Mark Zhang <markz@mellanox.com>

diff --git a/include/rdma/rdma_counter.h b/include/rdma/rdma_counter.h
index 68827700ba95..eb99856e8b30 100644
--- a/include/rdma/rdma_counter.h
+++ b/include/rdma/rdma_counter.h
@@ -9,10 +9,10 @@
  #include <linux/mutex.h>
  #include <linux/pid_namespace.h>

-#include <rdma/ib_verbs.h>
  #include <rdma/restrack.h>
  #include <rdma/rdma_netlink.h>

+struct ib_device;
  struct ib_qp;

  struct auto_mode_param {

On 7/9/2019 11:30 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from /home/sfr/next/next/include/rdma/rdma_counter.h:12,
>                   from <command-line>:
> /home/sfr/next/next/include/rdma/ib_verbs.h:2126:27: error: field 'port_counter' has incomplete type
>    struct rdma_port_counter port_counter;
>                             ^~~~~~~~~~~~
> 
> Caused by commit
> 
>    413d3347503b ("RDMA/counter: Add set/clear per-port auto mode support")
> 
> rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
> from rdma_counter.h, but it is not defined yet :-(
> 
> I have applied the following patch for today.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 9 Jul 2019 13:17:49 +1000
> Subject: [PATCH] RDMA: don't try to build rdma_counter.h for now
> 
> rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
> from rdma_counter.h, but it is not defined yet :-(
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>   include/Kbuild | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/Kbuild b/include/Kbuild
> index 78434c59701f..8dab85cdf4f4 100644
> --- a/include/Kbuild
> +++ b/include/Kbuild
> @@ -939,6 +939,7 @@ header-test-			+= rdma/ib.h
>   header-test-			+= rdma/iw_portmap.h
>   header-test-			+= rdma/opa_port_info.h
>   header-test-			+= rdma/rdmavt_cq.h
> +header-test-			+= rdma/rdma_counter.h
>   header-test-			+= rdma/restrack.h
>   header-test-			+= rdma/signature.h
>   header-test-			+= rdma/tid_rdma_defs.h
> 


^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-09  7:04 ` Mark Zhang
@ 2019-07-09  7:18   ` Leon Romanovsky
  2019-07-09 12:43     ` Stephen Rothwell
  2019-07-09 12:46     ` Jason Gunthorpe
  0 siblings, 2 replies; 68+ messages in thread
From: Leon Romanovsky @ 2019-07-09  7:18 UTC (permalink / raw)
  To: Stephen Rothwell, Doug Ledford, Jason Gunthorpe
  Cc: Mark Zhang, Linux Next Mailing List, Linux Kernel Mailing List,
	Majd Dibbiny, asahiro Yamada

On Tue, Jul 09, 2019 at 10:04:16AM +0300, Mark Zhang wrote:
> Hi Stephen,

Stephen,

For some reason, I wasn't in initial email report, can you please check why?

I need to be aware of any issues related to patches with my name on it
for tracking and improving internal submission flows/checks.

>
> Can you please try the patch below, thank you.

Jason, Doug,

Can you please take this patch?

Thanks

>
> net/mlx5: Remove include ib_verbs.h in rdma_counter.h
>
> rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
> from rdma_counter.h, but it is not defined yet.
>
> Fixes: 413d3347503b ("RDMA/counter: Add set/clear per-port auto mode
> support")
> Signed-off-by: Mark Zhang <markz@mellanox.com>
>
> diff --git a/include/rdma/rdma_counter.h b/include/rdma/rdma_counter.h
> index 68827700ba95..eb99856e8b30 100644
> --- a/include/rdma/rdma_counter.h
> +++ b/include/rdma/rdma_counter.h
> @@ -9,10 +9,10 @@
>   #include <linux/mutex.h>
>   #include <linux/pid_namespace.h>
>
> -#include <rdma/ib_verbs.h>
>   #include <rdma/restrack.h>
>   #include <rdma/rdma_netlink.h>
>
> +struct ib_device;
>   struct ib_qp;
>
>   struct auto_mode_param {
>
> On 7/9/2019 11:30 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the rdma tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > In file included from /home/sfr/next/next/include/rdma/rdma_counter.h:12,
> >                   from <command-line>:
> > /home/sfr/next/next/include/rdma/ib_verbs.h:2126:27: error: field 'port_counter' has incomplete type
> >    struct rdma_port_counter port_counter;
> >                             ^~~~~~~~~~~~
> >
> > Caused by commit
> >
> >    413d3347503b ("RDMA/counter: Add set/clear per-port auto mode support")
> >
> > rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
> > from rdma_counter.h, but it is not defined yet :-(
> >
> > I have applied the following patch for today.
> >
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Tue, 9 Jul 2019 13:17:49 +1000
> > Subject: [PATCH] RDMA: don't try to build rdma_counter.h for now
> >
> > rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
> > from rdma_counter.h, but it is not defined yet :-(
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >   include/Kbuild | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/include/Kbuild b/include/Kbuild
> > index 78434c59701f..8dab85cdf4f4 100644
> > --- a/include/Kbuild
> > +++ b/include/Kbuild
> > @@ -939,6 +939,7 @@ header-test-			+= rdma/ib.h
> >   header-test-			+= rdma/iw_portmap.h
> >   header-test-			+= rdma/opa_port_info.h
> >   header-test-			+= rdma/rdmavt_cq.h
> > +header-test-			+= rdma/rdma_counter.h
> >   header-test-			+= rdma/restrack.h
> >   header-test-			+= rdma/signature.h
> >   header-test-			+= rdma/tid_rdma_defs.h
> >
>

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-09  7:18   ` Leon Romanovsky
@ 2019-07-09 12:43     ` Stephen Rothwell
  2019-07-09 13:11       ` Leon Romanovsky
  2019-07-09 12:46     ` Jason Gunthorpe
  1 sibling, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-09 12:43 UTC (permalink / raw)
  To: Leon Romanovsky
  Cc: Doug Ledford, Jason Gunthorpe, Mark Zhang,
	Linux Next Mailing List, Linux Kernel Mailing List, Majd Dibbiny,
	asahiro Yamada

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hi Leon,

On Tue, 9 Jul 2019 07:18:00 +0000 Leon Romanovsky <leonro@mellanox.com> wrote:
>
> For some reason, I wasn't in initial email report, can you please check why?

Sorry about that, I manually grab email addresses from SOB lines in
commits I am reporting and managed to miss yours this time.  I might
try to script this up.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-09  7:18   ` Leon Romanovsky
  2019-07-09 12:43     ` Stephen Rothwell
@ 2019-07-09 12:46     ` Jason Gunthorpe
  2019-07-10  1:04       ` Stephen Rothwell
  1 sibling, 1 reply; 68+ messages in thread
From: Jason Gunthorpe @ 2019-07-09 12:46 UTC (permalink / raw)
  To: Leon Romanovsky
  Cc: Stephen Rothwell, Doug Ledford, Mark Zhang,
	Linux Next Mailing List, Linux Kernel Mailing List, Majd Dibbiny,
	asahiro Yamada, linux-rdma

On Tue, Jul 09, 2019 at 04:18:00AM -0300, Leon Romanovsky wrote:
> On Tue, Jul 09, 2019 at 10:04:16AM +0300, Mark Zhang wrote:
> > Hi Stephen,
> 
> Stephen,
> 
> For some reason, I wasn't in initial email report, can you please check why?
> 
> I need to be aware of any issues related to patches with my name on it
> for tracking and improving internal submission flows/checks.
> 
> >
> > Can you please try the patch below, thank you.
> 
> Jason, Doug,
> 
> Can you please take this patch?

It isn't quite enough to make the header compile stand alone, I'm
adding this instead.

From 37c1e072276b03b080eb24ff24c39080aeaf49ef Mon Sep 17 00:00:00 2001
From: Jason Gunthorpe <jgg@mellanox.com>
Date: Tue, 9 Jul 2019 09:44:47 -0300
Subject: [PATCH] RDMA/counters: Make rdma_counter.h compile stand alone

5.4-rc1 will have new compile time debugging to test that headers can be
compiled stand alone. Many rdma headers are already broken and excluded
from the mechanism, however to avoid compile failures during the merge
window fix enough so that the newly added header compiles clean.

Fixes: 413d3347503b ("RDMA/counter: Add set/clear per-port auto mode support")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Mark Zhang <markz@mellanox.com>
---
 include/rdma/rdma_counter.h | 2 +-
 include/rdma/restrack.h     | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/rdma/rdma_counter.h b/include/rdma/rdma_counter.h
index 68827700ba957e..eb99856e8b3078 100644
--- a/include/rdma/rdma_counter.h
+++ b/include/rdma/rdma_counter.h
@@ -9,10 +9,10 @@
 #include <linux/mutex.h>
 #include <linux/pid_namespace.h>
 
-#include <rdma/ib_verbs.h>
 #include <rdma/restrack.h>
 #include <rdma/rdma_netlink.h>
 
+struct ib_device;
 struct ib_qp;
 
 struct auto_mode_param {
diff --git a/include/rdma/restrack.h b/include/rdma/restrack.h
index 4041a4d96524b4..b0fc6b26bdf531 100644
--- a/include/rdma/restrack.h
+++ b/include/rdma/restrack.h
@@ -14,6 +14,9 @@
 #include <uapi/rdma/rdma_netlink.h>
 #include <linux/xarray.h>
 
+struct ib_device;
+struct sk_buff;
+
 /**
  * enum rdma_restrack_type - HW objects to track
  */
@@ -52,8 +55,6 @@ enum rdma_restrack_type {
 	RDMA_RESTRACK_MAX
 };
 
-struct ib_device;
-
 /**
  * struct rdma_restrack_entry - metadata per-entry
  */
-- 
2.21.0


^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-09 12:43     ` Stephen Rothwell
@ 2019-07-09 13:11       ` Leon Romanovsky
  0 siblings, 0 replies; 68+ messages in thread
From: Leon Romanovsky @ 2019-07-09 13:11 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Doug Ledford, Jason Gunthorpe, Mark Zhang,
	Linux Next Mailing List, Linux Kernel Mailing List, Majd Dibbiny,
	asahiro Yamada

On Tue, Jul 09, 2019 at 10:43:56PM +1000, Stephen Rothwell wrote:
> Hi Leon,
>
> On Tue, 9 Jul 2019 07:18:00 +0000 Leon Romanovsky <leonro@mellanox.com> wrote:
> >
> > For some reason, I wasn't in initial email report, can you please check why?
>
> Sorry about that, I manually grab email addresses from SOB lines in
> commits I am reporting and managed to miss yours this time.  I might
> try to script this up.

Maybe it will help,
https://github.com/rleon/x-tools/blob/master/x-fp#L141
This is how I'm generating CC-list for patches.

Thanks

>
> --
> Cheers,
> Stephen Rothwell



^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-09 12:46     ` Jason Gunthorpe
@ 2019-07-10  1:04       ` Stephen Rothwell
  2019-07-10  4:30         ` Stephen Rothwell
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-10  1:04 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: Leon Romanovsky, Doug Ledford, Mark Zhang,
	Linux Next Mailing List, Linux Kernel Mailing List, Majd Dibbiny,
	Masahiro Yamada, linux-rdma

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

Hi Jason,

On Tue, 9 Jul 2019 12:46:34 +0000 Jason Gunthorpe <jgg@mellanox.com> wrote:
>
> It isn't quite enough to make the header compile stand alone, I'm
> adding this instead.
> 
> From 37c1e072276b03b080eb24ff24c39080aeaf49ef Mon Sep 17 00:00:00 2001
> From: Jason Gunthorpe <jgg@mellanox.com>
> Date: Tue, 9 Jul 2019 09:44:47 -0300
> Subject: [PATCH] RDMA/counters: Make rdma_counter.h compile stand alone

I will apply this to linux-next today and reenable the stand alone
building for rdma_counter.h

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-10  1:04       ` Stephen Rothwell
@ 2019-07-10  4:30         ` Stephen Rothwell
  2019-07-16 23:28           ` Stephen Rothwell
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-10  4:30 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: Leon Romanovsky, Doug Ledford, Mark Zhang,
	Linux Next Mailing List, Linux Kernel Mailing List, Majd Dibbiny,
	Masahiro Yamada, linux-rdma

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Hi all,

On Wed, 10 Jul 2019 11:04:43 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 9 Jul 2019 12:46:34 +0000 Jason Gunthorpe <jgg@mellanox.com> wrote:
> >
> > It isn't quite enough to make the header compile stand alone, I'm
> > adding this instead.
> > 
> > From 37c1e072276b03b080eb24ff24c39080aeaf49ef Mon Sep 17 00:00:00 2001
> > From: Jason Gunthorpe <jgg@mellanox.com>
> > Date: Tue, 9 Jul 2019 09:44:47 -0300
> > Subject: [PATCH] RDMA/counters: Make rdma_counter.h compile stand alone  
> 
> I will apply this to linux-next today and reenable the stand alone
> building for rdma_counter.h

That worked for me ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-10  4:30         ` Stephen Rothwell
@ 2019-07-16 23:28           ` Stephen Rothwell
  2019-07-17  6:33             ` Masahiro Yamada
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-16 23:28 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Jason Gunthorpe, Leon Romanovsky, Doug Ledford, Mark Zhang,
	Linux Next Mailing List, Linux Kernel Mailing List, Majd Dibbiny,
	linux-rdma

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

Hi,

On Wed, 10 Jul 2019 14:30:36 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Wed, 10 Jul 2019 11:04:43 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Tue, 9 Jul 2019 12:46:34 +0000 Jason Gunthorpe <jgg@mellanox.com> wrote:  
> > >
> > > It isn't quite enough to make the header compile stand alone, I'm
> > > adding this instead.
> > > 
> > > From 37c1e072276b03b080eb24ff24c39080aeaf49ef Mon Sep 17 00:00:00 2001
> > > From: Jason Gunthorpe <jgg@mellanox.com>
> > > Date: Tue, 9 Jul 2019 09:44:47 -0300
> > > Subject: [PATCH] RDMA/counters: Make rdma_counter.h compile stand alone    
> > 
> > I will apply this to linux-next today and reenable the stand alone
> > building for rdma_counter.h  
> 
> That worked for me ...

rdma_counter.h should be able to be removed from the exceptions list now.

I have been building linux-next with this patch for a while, so maybe
it could be applied to the kbuild tree?

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 10 Jul 2019 13:03:16 +1000
Subject: [PATCH] rdma: attempt to build rdma_counter.h stand alone again

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/Kbuild | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/Kbuild b/include/Kbuild
index 7e9f1acb9dd5..765ff864130d 100644
--- a/include/Kbuild
+++ b/include/Kbuild
@@ -949,7 +949,6 @@ header-test-			+= pcmcia/ds.h
 header-test-			+= rdma/ib.h
 header-test-			+= rdma/iw_portmap.h
 header-test-			+= rdma/opa_port_info.h
-header-test-			+= rdma/rdma_counter.h
 header-test-			+= rdma/rdmavt_cq.h
 header-test-			+= rdma/restrack.h
 header-test-			+= rdma/signature.h
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-16 23:28           ` Stephen Rothwell
@ 2019-07-17  6:33             ` Masahiro Yamada
  2019-07-17  7:45               ` Stephen Rothwell
  0 siblings, 1 reply; 68+ messages in thread
From: Masahiro Yamada @ 2019-07-17  6:33 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jason Gunthorpe, Leon Romanovsky, Doug Ledford, Mark Zhang,
	Linux Next Mailing List, Linux Kernel Mailing List, Majd Dibbiny,
	linux-rdma

Hi Stephen,


On Wed, Jul 17, 2019 at 8:28 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi,
>
> On Wed, 10 Jul 2019 14:30:36 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Wed, 10 Jul 2019 11:04:43 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > On Tue, 9 Jul 2019 12:46:34 +0000 Jason Gunthorpe <jgg@mellanox.com> wrote:
> > > >
> > > > It isn't quite enough to make the header compile stand alone, I'm
> > > > adding this instead.
> > > >
> > > > From 37c1e072276b03b080eb24ff24c39080aeaf49ef Mon Sep 17 00:00:00 2001
> > > > From: Jason Gunthorpe <jgg@mellanox.com>
> > > > Date: Tue, 9 Jul 2019 09:44:47 -0300
> > > > Subject: [PATCH] RDMA/counters: Make rdma_counter.h compile stand alone
> > >
> > > I will apply this to linux-next today and reenable the stand alone
> > > building for rdma_counter.h
> >
> > That worked for me ...
>
> rdma_counter.h should be able to be removed from the exceptions list now.
>
> I have been building linux-next with this patch for a while, so maybe
> it could be applied to the kbuild tree?
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 10 Jul 2019 13:03:16 +1000
> Subject: [PATCH] rdma: attempt to build rdma_counter.h stand alone again
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  include/Kbuild | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/Kbuild b/include/Kbuild
> index 7e9f1acb9dd5..765ff864130d 100644
> --- a/include/Kbuild
> +++ b/include/Kbuild
> @@ -949,7 +949,6 @@ header-test-                        += pcmcia/ds.h
>  header-test-                   += rdma/ib.h
>  header-test-                   += rdma/iw_portmap.h
>  header-test-                   += rdma/opa_port_info.h
> -header-test-                   += rdma/rdma_counter.h
>  header-test-                   += rdma/rdmavt_cq.h
>  header-test-                   += rdma/restrack.h
>  header-test-                   += rdma/signature.h

Yes, this is just a one-liner fix-up,
so I'd like to fold it into this:

https://patchwork.kernel.org/patch/11047283/


-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-17  6:33             ` Masahiro Yamada
@ 2019-07-17  7:45               ` Stephen Rothwell
  0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-17  7:45 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Jason Gunthorpe, Leon Romanovsky, Doug Ledford, Mark Zhang,
	Linux Next Mailing List, Linux Kernel Mailing List, Majd Dibbiny,
	linux-rdma

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

Hi Masahiro,

On Wed, 17 Jul 2019 15:33:28 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> Yes, this is just a one-liner fix-up,
> so I'd like to fold it into this:
> 
> https://patchwork.kernel.org/patch/11047283/

Fine by me.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2020-02-26  2:51 Stephen Rothwell
  2020-02-26  3:04 ` Devesh Sharma
@ 2020-02-26 17:25 ` Jason Gunthorpe
  1 sibling, 0 replies; 68+ messages in thread
From: Jason Gunthorpe @ 2020-02-26 17:25 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List,
	Devesh Sharma, Naresh Kumar PBS, Selvin Xavier

On Wed, Feb 26, 2020 at 01:51:27PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the rdma tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/infiniband/hw/bnxt_re/qplib_res.c: In function '__free_pbl':
> drivers/infiniband/hw/bnxt_re/qplib_res.c:78:2: error: implicit declaration of function 'vfree'; did you mean 'kfree'? [-Werror=implicit-function-declaration]
>    78 |  vfree(pbl->pg_arr);
>       |  ^~~~~
>       |  kfree
> drivers/infiniband/hw/bnxt_re/qplib_res.c: In function '__alloc_pbl':
> drivers/infiniband/hw/bnxt_re/qplib_res.c:117:16: error: implicit declaration of function 'vmalloc'; did you mean 'kmalloc'? [-Werror=implicit-function-declaration]
>   117 |  pbl->pg_arr = vmalloc(pages * sizeof(void *));
>       |                ^~~~~~~
>       |                kmalloc
> drivers/infiniband/hw/bnxt_re/qplib_res.c:117:14: warning: assignment to 'void **' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>   117 |  pbl->pg_arr = vmalloc(pages * sizeof(void *));
>       |              ^
> drivers/infiniband/hw/bnxt_re/qplib_res.c:121:18: warning: assignment to 'dma_addr_t *' {aka 'long long unsigned int *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
>   121 |  pbl->pg_map_arr = vmalloc(pages * sizeof(dma_addr_t));
>       |                  ^
> 
> Caused by commit
> 
>   0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation")
> 
> I added the following fix for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 26 Feb 2020 13:46:02 +1100
> Subject: [PATCH] RDMA/bnxt_re: using vmalloc requires including vmalloc.h
> 
> Fixes: 0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>  drivers/infiniband/hw/bnxt_re/qplib_res.c | 1 +
>  1 file changed, 1 insertion(+)

Okay applied, thanks

Jason

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2020-02-26  2:51 Stephen Rothwell
@ 2020-02-26  3:04 ` Devesh Sharma
  2020-02-26 17:25 ` Jason Gunthorpe
  1 sibling, 0 replies; 68+ messages in thread
From: Devesh Sharma @ 2020-02-26  3:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Doug Ledford, Jason Gunthorpe, Linux Next Mailing List,
	Linux Kernel Mailing List, Naresh Kumar PBS, Selvin Xavier

On Wed, Feb 26, 2020 at 8:21 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the rdma tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/infiniband/hw/bnxt_re/qplib_res.c: In function '__free_pbl':
> drivers/infiniband/hw/bnxt_re/qplib_res.c:78:2: error: implicit declaration of function 'vfree'; did you mean 'kfree'? [-Werror=implicit-function-declaration]
>    78 |  vfree(pbl->pg_arr);
>       |  ^~~~~
>       |  kfree
> drivers/infiniband/hw/bnxt_re/qplib_res.c: In function '__alloc_pbl':
> drivers/infiniband/hw/bnxt_re/qplib_res.c:117:16: error: implicit declaration of function 'vmalloc'; did you mean 'kmalloc'? [-Werror=implicit-function-declaration]
>   117 |  pbl->pg_arr = vmalloc(pages * sizeof(void *));
>       |                ^~~~~~~
>       |                kmalloc
> drivers/infiniband/hw/bnxt_re/qplib_res.c:117:14: warning: assignment to 'void **' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>   117 |  pbl->pg_arr = vmalloc(pages * sizeof(void *));
>       |              ^
> drivers/infiniband/hw/bnxt_re/qplib_res.c:121:18: warning: assignment to 'dma_addr_t *' {aka 'long long unsigned int *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
>   121 |  pbl->pg_map_arr = vmalloc(pages * sizeof(dma_addr_t));
>       |                  ^
>
> Caused by commit
>
>   0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation")
>
> I added the following fix for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 26 Feb 2020 13:46:02 +1100
> Subject: [PATCH] RDMA/bnxt_re: using vmalloc requires including vmalloc.h
>
> Fixes: 0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/infiniband/hw/bnxt_re/qplib_res.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
> index 4346b95963cf..fc5909c7f2e0 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
> @@ -44,6 +44,7 @@
>  #include <linux/inetdevice.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/if_vlan.h>
> +#include <linux/vmalloc.h>
>  #include "roce_hsi.h"
>  #include "qplib_res.h"
>  #include "qplib_sp.h"
> --
> 2.25.0
>
> --
> Cheers,
> Stephen Rothwell

Thanks!
Acked-by: Devesh Sharma <devesh.sharma@broadcom.com>

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2020-02-26  2:51 Stephen Rothwell
  2020-02-26  3:04 ` Devesh Sharma
  2020-02-26 17:25 ` Jason Gunthorpe
  0 siblings, 2 replies; 68+ messages in thread
From: Stephen Rothwell @ 2020-02-26  2:51 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Devesh Sharma, Naresh Kumar PBS, Selvin Xavier

[-- Attachment #1: Type: text/plain, Size: 2315 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/infiniband/hw/bnxt_re/qplib_res.c: In function '__free_pbl':
drivers/infiniband/hw/bnxt_re/qplib_res.c:78:2: error: implicit declaration of function 'vfree'; did you mean 'kfree'? [-Werror=implicit-function-declaration]
   78 |  vfree(pbl->pg_arr);
      |  ^~~~~
      |  kfree
drivers/infiniband/hw/bnxt_re/qplib_res.c: In function '__alloc_pbl':
drivers/infiniband/hw/bnxt_re/qplib_res.c:117:16: error: implicit declaration of function 'vmalloc'; did you mean 'kmalloc'? [-Werror=implicit-function-declaration]
  117 |  pbl->pg_arr = vmalloc(pages * sizeof(void *));
      |                ^~~~~~~
      |                kmalloc
drivers/infiniband/hw/bnxt_re/qplib_res.c:117:14: warning: assignment to 'void **' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  117 |  pbl->pg_arr = vmalloc(pages * sizeof(void *));
      |              ^
drivers/infiniband/hw/bnxt_re/qplib_res.c:121:18: warning: assignment to 'dma_addr_t *' {aka 'long long unsigned int *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
  121 |  pbl->pg_map_arr = vmalloc(pages * sizeof(dma_addr_t));
      |                  ^

Caused by commit

  0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation")

I added the following fix for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 26 Feb 2020 13:46:02 +1100
Subject: [PATCH] RDMA/bnxt_re: using vmalloc requires including vmalloc.h

Fixes: 0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/infiniband/hw/bnxt_re/qplib_res.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
index 4346b95963cf..fc5909c7f2e0 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
@@ -44,6 +44,7 @@
 #include <linux/inetdevice.h>
 #include <linux/dma-mapping.h>
 #include <linux/if_vlan.h>
+#include <linux/vmalloc.h>
 #include "roce_hsi.h"
 #include "qplib_res.h"
 #include "qplib_sp.h"
-- 
2.25.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-08 16:08 ` Jason Gunthorpe
  2019-07-09  3:11   ` Stephen Rothwell
@ 2019-07-25 18:32   ` Dennis Dalessandro
  1 sibling, 0 replies; 68+ messages in thread
From: Dennis Dalessandro @ 2019-07-25 18:32 UTC (permalink / raw)
  To: Jason Gunthorpe, Stephen Rothwell
  Cc: Doug Ledford, Masahiro Yamada, Linux Next Mailing List,
	Linux Kernel Mailing List, Kamenee Arumugam

On 7/8/2019 12:08 PM, Jason Gunthorpe wrote:
> On Mon, Jul 08, 2019 at 12:57:25PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the rdma tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> In file included from <command-line>:32:
>> ./usr/include/rdma/rvt-abi.h:13:10: fatal error: rdma/ib_verbs.h: No such file or directory
>>   #include <rdma/ib_verbs.h>
>>            ^~~~~~~~~~~~~~~~~
>>
>> Caused by commits
>>
>>    dabac6e460ce ("IB/hfi1: Move receive work queue struct into uapi directory")
>>
>> interacting with commit
>>
>>    0c422a3d4e1b ("kbuild: compile-test exported headers to ensure they are self-contained")
>>
>> from the kbuild tree.
>>
>> You can't reference the include/linux headers from uapi headers ...
>>
>> I have used the rmda tree from 20190628 again today (given the previous
>> errors).
> 
> This is a bug that will break our userspace package too, we must fix
> it, very happy to see the functionality in "kbuild: compile-test
> exported headers to ensure they are self-contained"
> 
> Dennis, you must put stuff in rdma-core and run the rdma-core CI if
> you are messing with the uapi headers.

Sorry for the delay, I've been on vacation the past few weeks, just now 
seeing this...

I'm pretty sure Kamenee did when she prepared the patches in the first 
place and sent the PR. Not sure where things went off the rails but 
we'll be more careful in the future. Thanks for fixing.

-Denny

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-08 16:08 ` Jason Gunthorpe
@ 2019-07-09  3:11   ` Stephen Rothwell
  2019-07-25 18:32   ` Dennis Dalessandro
  1 sibling, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-09  3:11 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: Doug Ledford, Masahiro Yamada, Linux Next Mailing List,
	Linux Kernel Mailing List, Kamenee Arumugam, Dennis Dalessandro

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

Hi Jason,

On Mon, 8 Jul 2019 16:08:27 +0000 Jason Gunthorpe <jgg@mellanox.com> wrote:
>
> From f10ff380fd7dfba4a36d40f8dd00fe17da8a1a10 Mon Sep 17 00:00:00 2001
> From: Jason Gunthorpe <jgg@mellanox.com>
> Date: Mon, 8 Jul 2019 12:17:48 -0300
> Subject: [PATCH] RDMA/rvt: Do not use a kernel header in the ABI
> 
> rvt was using ib_sge as part of it's ABI, which is not allowed. Introduce
> a new struct with the same layout and use it instead.
> 
> Fixes: dabac6e460ce ("IB/hfi1: Move receive work queue struct into uapi directory")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

I applied that to linux-next today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-08  2:57 Stephen Rothwell
@ 2019-07-08 16:08 ` Jason Gunthorpe
  2019-07-09  3:11   ` Stephen Rothwell
  2019-07-25 18:32   ` Dennis Dalessandro
  0 siblings, 2 replies; 68+ messages in thread
From: Jason Gunthorpe @ 2019-07-08 16:08 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Doug Ledford, Masahiro Yamada, Linux Next Mailing List,
	Linux Kernel Mailing List, Kamenee Arumugam, Dennis Dalessandro

On Mon, Jul 08, 2019 at 12:57:25PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from <command-line>:32:
> ./usr/include/rdma/rvt-abi.h:13:10: fatal error: rdma/ib_verbs.h: No such file or directory
>  #include <rdma/ib_verbs.h>
>           ^~~~~~~~~~~~~~~~~
> 
> Caused by commits
> 
>   dabac6e460ce ("IB/hfi1: Move receive work queue struct into uapi directory")
> 
> interacting with commit
> 
>   0c422a3d4e1b ("kbuild: compile-test exported headers to ensure they are self-contained")
> 
> from the kbuild tree.
> 
> You can't reference the include/linux headers from uapi headers ...
> 
> I have used the rmda tree from 20190628 again today (given the previous
> errors).

This is a bug that will break our userspace package too, we must fix
it, very happy to see the functionality in "kbuild: compile-test
exported headers to ensure they are self-contained"

Dennis, you must put stuff in rdma-core and run the rdma-core CI if
you are messing with the uapi headers.

I'm adding this fixup so we can progress with the merge window. Please
check it right away.

From f10ff380fd7dfba4a36d40f8dd00fe17da8a1a10 Mon Sep 17 00:00:00 2001
From: Jason Gunthorpe <jgg@mellanox.com>
Date: Mon, 8 Jul 2019 12:17:48 -0300
Subject: [PATCH] RDMA/rvt: Do not use a kernel header in the ABI

rvt was using ib_sge as part of it's ABI, which is not allowed. Introduce
a new struct with the same layout and use it instead.

Fixes: dabac6e460ce ("IB/hfi1: Move receive work queue struct into uapi directory")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---
 drivers/infiniband/sw/rdmavt/qp.c | 32 ++++++++++++++++++++++++++-----
 include/uapi/rdma/rvt-abi.h       |  9 +++++++--
 2 files changed, 34 insertions(+), 7 deletions(-)

diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/rdmavt/qp.c
index 11b4d3c1efd486..0b0a241c57ff37 100644
--- a/drivers/infiniband/sw/rdmavt/qp.c
+++ b/drivers/infiniband/sw/rdmavt/qp.c
@@ -1847,8 +1847,11 @@ int rvt_post_recv(struct ib_qp *ibqp, const struct ib_recv_wr *wr,
 			wqe = rvt_get_rwqe_ptr(&qp->r_rq, wq->head);
 			wqe->wr_id = wr->wr_id;
 			wqe->num_sge = wr->num_sge;
-			for (i = 0; i < wr->num_sge; i++)
-				wqe->sg_list[i] = wr->sg_list[i];
+			for (i = 0; i < wr->num_sge; i++) {
+				wqe->sg_list[i].addr = wr->sg_list[i].addr;
+				wqe->sg_list[i].length = wr->sg_list[i].length;
+				wqe->sg_list[i].lkey = wr->sg_list[i].lkey;
+			}
 			/*
 			 * Make sure queue entry is written
 			 * before the head index.
@@ -2250,8 +2253,11 @@ int rvt_post_srq_recv(struct ib_srq *ibsrq, const struct ib_recv_wr *wr,
 		wqe = rvt_get_rwqe_ptr(&srq->rq, wq->head);
 		wqe->wr_id = wr->wr_id;
 		wqe->num_sge = wr->num_sge;
-		for (i = 0; i < wr->num_sge; i++)
-			wqe->sg_list[i] = wr->sg_list[i];
+		for (i = 0; i < wr->num_sge; i++) {
+			wqe->sg_list[i].addr = wr->sg_list[i].addr;
+			wqe->sg_list[i].length = wr->sg_list[i].length;
+			wqe->sg_list[i].lkey = wr->sg_list[i].lkey;
+		}
 		/* Make sure queue entry is written before the head index. */
 		smp_store_release(&wq->head, next);
 		spin_unlock_irqrestore(&srq->rq.kwq->p_lock, flags);
@@ -2259,6 +2265,22 @@ int rvt_post_srq_recv(struct ib_srq *ibsrq, const struct ib_recv_wr *wr,
 	return 0;
 }
 
+/*
+ * rvt used the internal kernel struct as part of its ABI, for now make sure
+ * the kernel struct does not change layout. FIXME: rvt should never cast the
+ * user struct to a kernel struct.
+ */
+static struct ib_sge *rvt_cast_sge(struct rvt_wqe_sge *sge)
+{
+	BUILD_BUG_ON(offsetof(struct ib_sge, addr) !=
+		     offsetof(struct rvt_wqe_sge, addr));
+	BUILD_BUG_ON(offsetof(struct ib_sge, length) !=
+		     offsetof(struct rvt_wqe_sge, length));
+	BUILD_BUG_ON(offsetof(struct ib_sge, lkey) !=
+		     offsetof(struct rvt_wqe_sge, lkey));
+	return (struct ib_sge *)sge;
+}
+
 /*
  * Validate a RWQE and fill in the SGE state.
  * Return 1 if OK.
@@ -2282,7 +2304,7 @@ static int init_sge(struct rvt_qp *qp, struct rvt_rwqe *wqe)
 			continue;
 		/* Check LKEY */
 		ret = rvt_lkey_ok(rkt, pd, j ? &ss->sg_list[j - 1] : &ss->sge,
-				  NULL, &wqe->sg_list[i],
+				  NULL, rvt_cast_sge(&wqe->sg_list[i]),
 				  IB_ACCESS_LOCAL_WRITE);
 		if (unlikely(ret <= 0))
 			goto bad_lkey;
diff --git a/include/uapi/rdma/rvt-abi.h b/include/uapi/rdma/rvt-abi.h
index d2e35d24f1a9e6..7328293c715cfb 100644
--- a/include/uapi/rdma/rvt-abi.h
+++ b/include/uapi/rdma/rvt-abi.h
@@ -10,11 +10,16 @@
 
 #include <linux/types.h>
 #include <rdma/ib_user_verbs.h>
-#include <rdma/ib_verbs.h>
 #ifndef RDMA_ATOMIC_UAPI
 #define RDMA_ATOMIC_UAPI(_type, _name) struct{ _type val; } _name
 #endif
 
+struct rvt_wqe_sge {
+	__aligned_u64 addr;
+	__u32 length;
+	__u32 lkey;
+};
+
 /*
  * This structure is used to contain the head pointer, tail pointer,
  * and completion queue entries as a single memory allocation so
@@ -39,7 +44,7 @@ struct rvt_rwqe {
 	__u64 wr_id;
 	__u8 num_sge;
 	__u8 padding[7];
-	struct ib_sge sg_list[];
+	struct rvt_wqe_sge sg_list[];
 };
 
 /*
-- 
2.21.0



^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-08  3:03 Stephen Rothwell
@ 2019-07-08 14:09 ` Jason Gunthorpe
  0 siblings, 0 replies; 68+ messages in thread
From: Jason Gunthorpe @ 2019-07-08 14:09 UTC (permalink / raw)
  To: Stephen Rothwell, Bernard Metzler
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List

On Mon, Jul 08, 2019 at 01:03:51PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from include/asm-generic/percpu.h:7,
>                  from arch/x86/include/asm/percpu.h:544,
>                  from arch/x86/include/asm/preempt.h:6,
>                  from include/linux/preempt.h:78,
>                  from include/linux/spinlock.h:51,
>                  from include/linux/seqlock.h:36,
>                  from include/linux/time.h:6,
>                  from include/linux/ktime.h:24,
>                  from include/linux/timer.h:6,
>                  from include/linux/netdevice.h:24,
>                  from drivers/infiniband/sw/siw/siw_main.c:8:
> include/linux/percpu-defs.h:92:33: warning: '__pcpu_unique_use_cnt' initialized and declared 'extern'
>   extern __PCPU_DUMMY_ATTRS char __pcpu_unique_##name;  \
>                                  ^~~~~~~~~~~~~~
> include/linux/percpu-defs.h:115:2: note: in expansion of macro 'DEFINE_PER_CPU_SECTION'
>   DEFINE_PER_CPU_SECTION(type, name, "")
>   ^~~~~~~~~~~~~~~~~~~~~~
> drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
>  static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
>         ^~~~~~~~~~~~~~
> include/linux/percpu-defs.h:93:26: error: redefinition of '__pcpu_unique_use_cnt'
>   __PCPU_DUMMY_ATTRS char __pcpu_unique_##name;   \
>                           ^~~~~~~~~~~~~~
> include/linux/percpu-defs.h:115:2: note: in expansion of macro 'DEFINE_PER_CPU_SECTION'
>   DEFINE_PER_CPU_SECTION(type, name, "")
>   ^~~~~~~~~~~~~~~~~~~~~~
> drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
>  static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));

Bernard, 

This looks like the wrong way to use DEFINE_PER_CPU these days. I'm
not sure why my compiles don't hit it, or why 0-day didn't say
something

Looking at the other atomic_t PER_CPU users they just rely on
automatic zero initialization, so this should just be:

  static DEFINE_PER_CPU(atomic_t, use_cnt);

?

Please confirm ASAP.

Jason

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2019-07-08  3:03 Stephen Rothwell
  2019-07-08 14:09 ` Jason Gunthorpe
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-08  3:03 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Bernard Metzler

[-- Attachment #1: Type: text/plain, Size: 4144 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/asm-generic/percpu.h:7,
                 from arch/x86/include/asm/percpu.h:544,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:78,
                 from include/linux/spinlock.h:51,
                 from include/linux/seqlock.h:36,
                 from include/linux/time.h:6,
                 from include/linux/ktime.h:24,
                 from include/linux/timer.h:6,
                 from include/linux/netdevice.h:24,
                 from drivers/infiniband/sw/siw/siw_main.c:8:
include/linux/percpu-defs.h:92:33: warning: '__pcpu_unique_use_cnt' initialized and declared 'extern'
  extern __PCPU_DUMMY_ATTRS char __pcpu_unique_##name;  \
                                 ^~~~~~~~~~~~~~
include/linux/percpu-defs.h:115:2: note: in expansion of macro 'DEFINE_PER_CPU_SECTION'
  DEFINE_PER_CPU_SECTION(type, name, "")
  ^~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~
include/linux/percpu-defs.h:93:26: error: redefinition of '__pcpu_unique_use_cnt'
  __PCPU_DUMMY_ATTRS char __pcpu_unique_##name;   \
                          ^~~~~~~~~~~~~~
include/linux/percpu-defs.h:115:2: note: in expansion of macro 'DEFINE_PER_CPU_SECTION'
  DEFINE_PER_CPU_SECTION(type, name, "")
  ^~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~
include/linux/percpu-defs.h:92:33: note: previous definition of '__pcpu_unique_use_cnt' was here
  extern __PCPU_DUMMY_ATTRS char __pcpu_unique_##name;  \
                                 ^~~~~~~~~~~~~~
include/linux/percpu-defs.h:115:2: note: in expansion of macro 'DEFINE_PER_CPU_SECTION'
  DEFINE_PER_CPU_SECTION(type, name, "")
  ^~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:33: warning: 'use_cnt' initialized and declared 'extern'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
                                 ^~~~~~~
include/linux/percpu-defs.h:94:44: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
  extern __PCPU_ATTRS(sec) __typeof__(type) name;   \
                                            ^~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:33: error: redefinition of 'use_cnt'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
                                 ^~~~~~~
include/linux/percpu-defs.h:95:44: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
  __PCPU_ATTRS(sec) __weak __typeof__(type) name
                                            ^~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:33: note: previous definition of 'use_cnt' was here
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
                                 ^~~~~~~
include/linux/percpu-defs.h:94:44: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
  extern __PCPU_ATTRS(sec) __typeof__(type) name;   \
                                            ^~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~

Caused by commit

  bdcf26bf9b3a ("rdma/siw: network and RDMA core interface")

I have used the rdma tree from 20190628 again today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2019-07-08  2:57 Stephen Rothwell
  2019-07-08 16:08 ` Jason Gunthorpe
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-08  2:57 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe, Masahiro Yamada
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Kamenee Arumugam, Dennis Dalessandro

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from <command-line>:32:
./usr/include/rdma/rvt-abi.h:13:10: fatal error: rdma/ib_verbs.h: No such file or directory
 #include <rdma/ib_verbs.h>
          ^~~~~~~~~~~~~~~~~

Caused by commits

  dabac6e460ce ("IB/hfi1: Move receive work queue struct into uapi directory")

interacting with commit

  0c422a3d4e1b ("kbuild: compile-test exported headers to ensure they are self-contained")

from the kbuild tree.

You can't reference the include/linux headers from uapi headers ...

I have used the rmda tree from 20190628 again today (given the previous
errors).
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-05 13:15   ` Jason Gunthorpe
@ 2019-07-05 14:59     ` Stephen Rothwell
  0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-05 14:59 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List,
	Xi Wang, Lijun Ou

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

Hi Jason,

On Fri, 5 Jul 2019 13:15:31 +0000 Jason Gunthorpe <jgg@mellanox.com> wrote:
>
> It should be fixed now

Excellent, thanks.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-04  2:02 ` Stephen Rothwell
  2019-07-04  2:04   ` Jason Gunthorpe
@ 2019-07-05 13:15   ` Jason Gunthorpe
  2019-07-05 14:59     ` Stephen Rothwell
  1 sibling, 1 reply; 68+ messages in thread
From: Jason Gunthorpe @ 2019-07-05 13:15 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List,
	Xi Wang, Lijun Ou

On Thu, Jul 04, 2019 at 12:02:35PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 1 Jul 2019 14:14:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> > 
> > After merging the rdma tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
> > see include/linux/module.h for more information
> 	.
> 	.
> 	.
> > ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> 	.
> 	.
> 	.
> > ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> > 
> > Presumably caused by commit
> > 
> >   e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")
> > 
> > I have used the rdma tree from next-20190628 for today.
> 
> I am still getting these errors/warnings.

It should be fixed now

Regards,
Jason

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-04  2:04   ` Jason Gunthorpe
  2019-07-04  2:10     ` oulijun
  2019-07-04  4:07     ` wangxi
@ 2019-07-04  6:31     ` oulijun
  2 siblings, 0 replies; 68+ messages in thread
From: oulijun @ 2019-07-04  6:31 UTC (permalink / raw)
  To: Jason Gunthorpe, Stephen Rothwell
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List,
	Xi Wang

在 2019/7/4 10:04, Jason Gunthorpe 写道:
> On Thu, Jul 04, 2019 at 12:02:35PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> On Mon, 1 Jul 2019 14:14:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>> Hi all,
>>>
>>> After merging the rdma tree, today's linux-next build (x86_64
>>> allmodconfig) failed like this:
>>>
>>> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
>>> see include/linux/module.h for more information
>> 	.
>> 	.
>> 	.
>>> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
>> 	.
>> 	.
>> 	.
>>> ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
>>>
>>> Presumably caused by commit
>>>
>>>   e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")
>>>
>>> I have used the rdma tree from next-20190628 for today.
>> I am still getting these errors/warnings.
> I have not got a fixing patch from HNS team.
>
> At this late date I will revert the problematic HNS patch tomorrow.
>
> Jason
Hi, Jason
   We have sent a fixup patch.  This problem only appears when compiled into ko. Our self-test is build in.

Thanks.
Lijun Ou
> .
>



^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-04  4:07     ` wangxi
@ 2019-07-04  4:10       ` wangxi
  0 siblings, 0 replies; 68+ messages in thread
From: wangxi @ 2019-07-04  4:10 UTC (permalink / raw)
  To: Jason Gunthorpe, Stephen Rothwell
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List,
	Lijun Ou



在 2019/7/4 12:07, wangxi 写道:
> 
> 
> 在 2019/7/4 10:04, Jason Gunthorpe 写道:
>> On Thu, Jul 04, 2019 at 12:02:35PM +1000, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> On Mon, 1 Jul 2019 14:14:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> After merging the rdma tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>>
>>>> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
>>>> see include/linux/module.h for more information
>>> 	.
>>> 	.
>>> 	.
>>>> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
>>> 	.
>>> 	.
>>> 	.
>>>> ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
>>>>
>>>> Presumably caused by commit
>>>>
>>>>   e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")
>>>>
>>>> I have used the rdma tree from next-20190628 for today.
>>>
>>> I am still getting these errors/warnings.
>>
>> I have not got a fixing patch from HNS team.
>>
>> At this late date I will revert the problematic HNS patch tomorrow.
>> There is indeed a mistake, I will append a patch as soon as possible.
> 
> The patch sent before has a problem caused by the merge of the local code. The correct one
> should be as follows :
> 
> diff --git a/drivers/infiniband/hw/hns/Makefile b/drivers/infiniband/hw/hns/Makefile
> index b956cf4..b06125f 100644
> --- a/drivers/infiniband/hw/hns/Makefile
> +++ b/drivers/infiniband/hw/hns/Makefile
> @@ -9,8 +9,8 @@ hns-roce-objs := hns_roce_main.o hns_roce_cmd.o hns_roce_pd.o \
>         hns_roce_cq.o hns_roce_alloc.o hns_roce_db.o hns_roce_srq.o hns_roce_restrack.o
> 
>  ifdef CONFIG_INFINIBAND_HNS_HIP06
> -hns-roce-hw-v1-objs := hns_roce_hw_v1.o
> -obj-$(CONFIG_INFINIBAND_HNS) += hns-roce-hw-v1.o $(hns-roce-objs)
> +hns-roce-hw-v1-objs := hns_roce_hw_v1.o $(hns-roce-objs)
> +obj-$(CONFIG_INFINIBAND_HNS) += hns-roce-hw-v1.o
>  endif
> 

The old patch does have an error and I will append a new patch as soon as possible.

>> Jason
>> .
>>


^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-04  2:04   ` Jason Gunthorpe
  2019-07-04  2:10     ` oulijun
@ 2019-07-04  4:07     ` wangxi
  2019-07-04  4:10       ` wangxi
  2019-07-04  6:31     ` oulijun
  2 siblings, 1 reply; 68+ messages in thread
From: wangxi @ 2019-07-04  4:07 UTC (permalink / raw)
  To: Jason Gunthorpe, Stephen Rothwell
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List,
	Lijun Ou



在 2019/7/4 10:04, Jason Gunthorpe 写道:
> On Thu, Jul 04, 2019 at 12:02:35PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> On Mon, 1 Jul 2019 14:14:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> Hi all,
>>>
>>> After merging the rdma tree, today's linux-next build (x86_64
>>> allmodconfig) failed like this:
>>>
>>> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
>>> see include/linux/module.h for more information
>> 	.
>> 	.
>> 	.
>>> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
>> 	.
>> 	.
>> 	.
>>> ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
>>>
>>> Presumably caused by commit
>>>
>>>   e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")
>>>
>>> I have used the rdma tree from next-20190628 for today.
>>
>> I am still getting these errors/warnings.
> 
> I have not got a fixing patch from HNS team.
> 
> At this late date I will revert the problematic HNS patch tomorrow.
> There is indeed a mistake, I will append a patch as soon as possible.

The patch sent before has a problem caused by the merge of the local code. The correct one
should be as follows :

diff --git a/drivers/infiniband/hw/hns/Makefile b/drivers/infiniband/hw/hns/Makefile
index b956cf4..b06125f 100644
--- a/drivers/infiniband/hw/hns/Makefile
+++ b/drivers/infiniband/hw/hns/Makefile
@@ -9,8 +9,8 @@ hns-roce-objs := hns_roce_main.o hns_roce_cmd.o hns_roce_pd.o \
        hns_roce_cq.o hns_roce_alloc.o hns_roce_db.o hns_roce_srq.o hns_roce_restrack.o

 ifdef CONFIG_INFINIBAND_HNS_HIP06
-hns-roce-hw-v1-objs := hns_roce_hw_v1.o
-obj-$(CONFIG_INFINIBAND_HNS) += hns-roce-hw-v1.o $(hns-roce-objs)
+hns-roce-hw-v1-objs := hns_roce_hw_v1.o $(hns-roce-objs)
+obj-$(CONFIG_INFINIBAND_HNS) += hns-roce-hw-v1.o
 endif

> Jason
> .
> 


^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-04  2:04   ` Jason Gunthorpe
@ 2019-07-04  2:10     ` oulijun
  2019-07-04  4:07     ` wangxi
  2019-07-04  6:31     ` oulijun
  2 siblings, 0 replies; 68+ messages in thread
From: oulijun @ 2019-07-04  2:10 UTC (permalink / raw)
  To: Jason Gunthorpe, Stephen Rothwell
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List,
	Xi Wang

在 2019/7/4 10:04, Jason Gunthorpe 写道:
> On Thu, Jul 04, 2019 at 12:02:35PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> On Mon, 1 Jul 2019 14:14:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>> Hi all,
>>>
>>> After merging the rdma tree, today's linux-next build (x86_64
>>> allmodconfig) failed like this:
>>>
>>> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
>>> see include/linux/module.h for more information
>> 	.
>> 	.
>> 	.
>>> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
>> 	.
>> 	.
>> 	.
>>> ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
>>>
>>> Presumably caused by commit
>>>
>>>   e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")
>>>
>>> I have used the rdma tree from next-20190628 for today.
>> I am still getting these errors/warnings.
> I have not got a fixing patch from HNS team.
>
> At this late date I will revert the problematic HNS patch tomorrow.
>
> Jason
Hi, Jason
  Sorry,  our guys may not see your mail in time. I will fix it and send a email in today.

Thanks
Lijun Ou
> .
>



^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-04  2:02 ` Stephen Rothwell
@ 2019-07-04  2:04   ` Jason Gunthorpe
  2019-07-04  2:10     ` oulijun
                       ` (2 more replies)
  2019-07-05 13:15   ` Jason Gunthorpe
  1 sibling, 3 replies; 68+ messages in thread
From: Jason Gunthorpe @ 2019-07-04  2:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List,
	Xi Wang, Lijun Ou

On Thu, Jul 04, 2019 at 12:02:35PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 1 Jul 2019 14:14:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> > 
> > After merging the rdma tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
> > see include/linux/module.h for more information
> 	.
> 	.
> 	.
> > ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> 	.
> 	.
> 	.
> > ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> > 
> > Presumably caused by commit
> > 
> >   e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")
> > 
> > I have used the rdma tree from next-20190628 for today.
> 
> I am still getting these errors/warnings.

I have not got a fixing patch from HNS team.

At this late date I will revert the problematic HNS patch tomorrow.

Jason

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-01  4:14 Stephen Rothwell
  2019-07-01  7:54 ` wangxi
@ 2019-07-04  2:02 ` Stephen Rothwell
  2019-07-04  2:04   ` Jason Gunthorpe
  2019-07-05 13:15   ` Jason Gunthorpe
  1 sibling, 2 replies; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-04  2:02 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Xi Wang, Lijun Ou

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

Hi all,

On Mon, 1 Jul 2019 14:14:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
> see include/linux/module.h for more information
	.
	.
	.
> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
	.
	.
	.
> ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> 
> Presumably caused by commit
> 
>   e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")
> 
> I have used the rdma tree from next-20190628 for today.

I am still getting these errors/warnings.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-01  7:54 ` wangxi
@ 2019-07-01 22:49   ` Jason Gunthorpe
  0 siblings, 0 replies; 68+ messages in thread
From: Jason Gunthorpe @ 2019-07-01 22:49 UTC (permalink / raw)
  To: wangxi
  Cc: Stephen Rothwell, Doug Ledford, Linux Next Mailing List,
	Linux Kernel Mailing List, Lijun Ou

On Mon, Jul 01, 2019 at 03:54:30PM +0800, wangxi wrote:
> > Presumably caused by commit
> > 
> >   e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")
> 
> I have confirmed the latest code in
> https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git.  I
> found that the changes to Makefile and Kconfig in the original patch
> have been lost.

What does that mean?

Commit e9816ddf2a33f3afdf3dfc35c21aafad389ee482 looks the same as 
https://patchwork.kernel.org/patch/11003547/

To me

Please send a fixup patch.

This looks wrong:

obj-$(CONFIG_INFINIBAND_HNS) += hns-roce-hw-v1.o $(hns-roce-objs)

Jason

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2019-07-01  4:14 Stephen Rothwell
@ 2019-07-01  7:54 ` wangxi
  2019-07-01 22:49   ` Jason Gunthorpe
  2019-07-04  2:02 ` Stephen Rothwell
  1 sibling, 1 reply; 68+ messages in thread
From: wangxi @ 2019-07-01  7:54 UTC (permalink / raw)
  To: Stephen Rothwell, Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Lijun Ou



在 2019/7/1 12:14, Stephen Rothwell 写道:
> Hi all,
> 
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_alloc.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_cmd.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_cq.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_db.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_hem.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_mr.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_pd.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_qp.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_restrack.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_srq.o
> see include/linux/module.h for more information
> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_ib_umem_write_mtt" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_mtt_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_buf_write_mtt" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_buf_alloc" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_mtt_init" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_free_db" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_alloc_db" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_bitmap_free_range" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_bitmap_alloc_range" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_db_unmap_user" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_mtr_cleanup" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_get_kmem_bufs" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_buf_alloc" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_db_map_user" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_free_buf_list" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_mtr_attach" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_mtr_init" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_hem_list_calc_root_ba" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_get_umem_bufs" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_alloc_buf_list" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_init_buf_region" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
> ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
> ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
> ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
> ERROR: "hns_roce_hem_list_find_mtt" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_hem_list_request" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_hem_list_release" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_hem_list_init" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_check_whether_mhop" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_table_put_range" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_table_get_range" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
> ERROR: "hns_roce_fill_res_entry" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_dereg_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_reg_user_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_get_dma_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_ib_create_cq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_modify_qp" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_create_qp" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_destroy_ah" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_query_ah" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_create_ah" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_dealloc_pd" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_alloc_pd" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_rereg_user_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_dealloc_mw" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_alloc_mw" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_map_mr_sg" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_alloc_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_destroy_srq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_create_srq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cleanup_qp_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cleanup_uar_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cleanup_pd_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cleanup_mr_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cleanup_cq_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cleanup_hem_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cmd_use_polling" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_init_srq_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cmd_cleanup" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cleanup_hem" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cleanup_bitmap" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cmd_use_events" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_init_qp_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_init_cq_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_init_mr_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_init_pd_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_init_uar_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_check_whether_mhop" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_init_hem_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_cmd_init" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_uar_alloc" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_uar_free" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_free_db" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_db_unmap_user" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_mtt_cleanup" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_ib_umem_write_mtt" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_db_map_user" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_buf_write_mtt" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_buf_alloc" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_alloc_db" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_mtt_init" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_check_whether_mhop" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
> ERROR: "hns_roce_cleanup_srq_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
> ERROR: "hns_roce_cleanup_uar_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
> ERROR: "hns_roce_cleanup_pd_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
> ERROR: "hns_roce_cleanup_mr_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
> ERROR: "hns_roce_cleanup_cq_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
> ERROR: "hns_roce_cleanup_qp_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
> ERROR: "to_hr_qp_type" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "get_send_wqe" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_release_range_qp" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_mtt_cleanup" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_cmd_event" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_cq_completion" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_create_qp" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_init" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_free_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_hw2sw_mpt" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_get_gid_index" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_dealloc_pd" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_qp_remove" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_alloc_pd" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "get_recv_wqe" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_unlock_cqs" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_exit" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_qp_event" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "to_hns_roce_state" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_ib_create_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_cq_event" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_qp_free" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_lock_cqs" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_wq_overflow" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "key_to_hw_index" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
> 
> Presumably caused by commit
> 
>   e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")
> 
I have confirmed the latest code in https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git.
I found that the changes to Makefile and Kconfig in the original patch have been lost.

> I have used the rdma tree from next-20190628 for today.
> 


^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2019-07-01  4:14 Stephen Rothwell
  2019-07-01  7:54 ` wangxi
  2019-07-04  2:02 ` Stephen Rothwell
  0 siblings, 2 replies; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-01  4:14 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Xi Wang, Lijun Ou

[-- Attachment #1: Type: text/plain, Size: 15626 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_alloc.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_cmd.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_cq.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_db.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_hem.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_mr.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_pd.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_qp.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_restrack.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_srq.o
see include/linux/module.h for more information
ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_ib_umem_write_mtt" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_mtt_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_buf_write_mtt" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_buf_alloc" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_mtt_init" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_free_db" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_alloc_db" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_bitmap_free_range" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_bitmap_alloc_range" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_db_unmap_user" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_mtr_cleanup" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_get_kmem_bufs" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_buf_alloc" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_db_map_user" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_free_buf_list" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_mtr_attach" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_mtr_init" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_hem_list_calc_root_ba" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_get_umem_bufs" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_alloc_buf_list" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_init_buf_region" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
ERROR: "hns_roce_hem_list_find_mtt" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_hem_list_request" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_hem_list_release" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_hem_list_init" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_check_whether_mhop" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_table_put_range" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_table_get_range" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_fill_res_entry" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_dereg_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_reg_user_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_get_dma_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_ib_create_cq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_modify_qp" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_create_qp" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_destroy_ah" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_query_ah" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_create_ah" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_dealloc_pd" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_alloc_pd" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_rereg_user_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_dealloc_mw" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_alloc_mw" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_map_mr_sg" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_alloc_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_destroy_srq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_create_srq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_qp_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_uar_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_pd_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_mr_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_cq_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_hem_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cmd_use_polling" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_srq_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cmd_cleanup" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_hem" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_bitmap" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cmd_use_events" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_qp_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_cq_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_mr_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_pd_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_uar_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_check_whether_mhop" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_hem_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cmd_init" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_uar_alloc" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_uar_free" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_free_db" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_db_unmap_user" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_mtt_cleanup" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_ib_umem_write_mtt" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_db_map_user" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_buf_write_mtt" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_buf_alloc" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_alloc_db" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_mtt_init" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_check_whether_mhop" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_cleanup_srq_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "hns_roce_cleanup_uar_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "hns_roce_cleanup_pd_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "hns_roce_cleanup_mr_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "hns_roce_cleanup_cq_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "hns_roce_cleanup_qp_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "to_hr_qp_type" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "get_send_wqe" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_release_range_qp" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_mtt_cleanup" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_cmd_event" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_cq_completion" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_create_qp" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_init" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_free_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_hw2sw_mpt" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_get_gid_index" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_dealloc_pd" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_qp_remove" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_alloc_pd" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "get_recv_wqe" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_unlock_cqs" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_exit" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_qp_event" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "to_hns_roce_state" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_ib_create_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_cq_event" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_qp_free" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_lock_cqs" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_wq_overflow" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "key_to_hw_index" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!

Presumably caused by commit

  e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")

I have used the rdma tree from next-20190628 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2018-12-05 22:58     ` Stephen Rothwell
  2018-12-10  0:43       ` Changbin Du
@ 2018-12-10 15:52       ` Masahiro Yamada
  1 sibling, 0 replies; 68+ messages in thread
From: Masahiro Yamada @ 2018-12-10 15:52 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: guyle, Jason Gunthorpe, dledford, Linux-Next Mailing List,
	Linux Kernel Mailing List, majd, Leon Romanovsky, Changbin Du

On Thu, Dec 6, 2018 at 7:59 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Guy,
>
> On Wed, 5 Dec 2018 12:25:57 +0000 "Guy Levi(SW)" <guyle@mellanox.com> wrote:
> >
> > >
> > > Huh. So apparently every compiler that tested this patch (0-day, mine,
> > > the submitters) optimized this call away because is_atomic_response()
> > > always returns 0: meaning mlx5_get_atomic_laddr is never callable and
> > > can be deleted entirely, including the call to mlx5_get_send_wqe.
> > >
> > > Not sure what compiler setup will hit this, but it is clearly wrong
> > > code..
> >
> > Flag -o0  ?
>
> No, but the kbuild tree contains a change that allows turning off of
> gcc's autoinlining and the CONFIG option guarding that gets turned on
> for allmodconfig builds among others.
>
> Masahiro, should CONFIG_NO_AUTO_INLINE maybe need to be off unless
> explicitly enabled (like CONFIG_DEBUG_INFO and others)?


No.

If CONFIG_NO_AUTO_INLINE is turned off for compile-testing,
people will not even notice a breakage,
then the code will get broken here and there.

You will not be able to enable it
when you really want to use it.





In this case, the reason is obvious.

If you expect the compiler to optimize the code out,
you must use 'static inline' instead of 'static'.


static int is_atomic_response(struct mlx5_ib_qp *qp, uint16_t idx)
{
       /* TBD: waiting decision
        */
       return 0;
}





-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2018-12-05 22:58     ` Stephen Rothwell
@ 2018-12-10  0:43       ` Changbin Du
  2018-12-10 15:52       ` Masahiro Yamada
  1 sibling, 0 replies; 68+ messages in thread
From: Changbin Du @ 2018-12-10  0:43 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Guy Levi(SW),
	Jason Gunthorpe, Doug Ledford, Linux Next Mailing List,
	Linux Kernel Mailing List, Majd Dibbiny, Leon Romanovsky,
	Changbin Du, Masahiro Yamada

On Thu, Dec 06, 2018 at 09:58:15AM +1100, Stephen Rothwell wrote:
> Hi Guy,
> 
> On Wed, 5 Dec 2018 12:25:57 +0000 "Guy Levi(SW)" <guyle@mellanox.com> wrote:
> >
> > > 
> > > Huh. So apparently every compiler that tested this patch (0-day, mine,
> > > the submitters) optimized this call away because is_atomic_response()
> > > always returns 0: meaning mlx5_get_atomic_laddr is never callable and
> > > can be deleted entirely, including the call to mlx5_get_send_wqe.
> > > 
> > > Not sure what compiler setup will hit this, but it is clearly wrong
> > > code..  
> > 
> > Flag -o0  ?
> 
> No, but the kbuild tree contains a change that allows turning off of
> gcc's autoinlining and the CONFIG option guarding that gets turned on
> for allmodconfig builds among others.
>
Let me turn it off to pass allmodconfig build. it is a pure debug
option.

> Masahiro, should CONFIG_NO_AUTO_INLINE maybe need to be off unless
> explicitly enabled (like CONFIG_DEBUG_INFO and others)?
> 
> -- 
> Cheers,
> Stephen Rothwell



-- 
Thanks,
Changbin Du

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2018-12-04  9:42   ` Leon Romanovsky
@ 2018-12-07  2:41     ` Stephen Rothwell
  0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2018-12-07  2:41 UTC (permalink / raw)
  To: Leon Romanovsky
  Cc: Jason Gunthorpe, Doug Ledford, Linux Next Mailing List,
	Linux Kernel Mailing List, Guy Levi(SW),
	Majd Dibbiny

[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]

Hi all,

On Tue, 4 Dec 2018 09:42:59 +0000 Leon Romanovsky <leonro@mellanox.com> wrote:
>
> On Tue, Dec 04, 2018 at 01:52:54AM +0000, Jason Gunthorpe wrote:
> > On Tue, Dec 04, 2018 at 11:47:31AM +1100, Stephen Rothwell wrote:  
> > >
> > > After merging the rdma tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > ERROR: "mlx5_get_send_wqe" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!
> > >
> > > Caused by commit
> > >
> > >   34f4c9554d8b ("IB/mlx5: Use fragmented QP's buffer for in-kernel users")
> > >
> > > mlx5_get_send_wqe() is still used in drivers/infiniband/hw/mlx5/cq.c
> > > and declared in drivers/infiniband/hw/mlx5/mlx5_ib.h ...
> > >
> > > I have used the version of the rdma tree from next-20181203 for today.  
> >
> > Huh. So apparently every compiler that tested this patch (0-day, mine,
> > the submitters) optimized this call away because is_atomic_response()
> > always returns 0: meaning mlx5_get_atomic_laddr is never callable and
> > can be deleted entirely, including the call to mlx5_get_send_wqe.
> >
> > Not sure what compiler setup will hit this, but it is clearly wrong
> > code..
> >
> > Guy/Leon, please send a fixup.. Maybe just delete all this
> > handle_atomics stuff?  
> 
> I deleted it and will wait for the results of regression prior to send the patch.

I am still getting this error.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2018-12-05 12:25   ` Guy Levi(SW)
@ 2018-12-05 22:58     ` Stephen Rothwell
  2018-12-10  0:43       ` Changbin Du
  2018-12-10 15:52       ` Masahiro Yamada
  0 siblings, 2 replies; 68+ messages in thread
From: Stephen Rothwell @ 2018-12-05 22:58 UTC (permalink / raw)
  To: Guy Levi(SW)
  Cc: Jason Gunthorpe, Doug Ledford, Linux Next Mailing List,
	Linux Kernel Mailing List, Majd Dibbiny, Leon Romanovsky,
	Changbin Du, Masahiro Yamada

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

Hi Guy,

On Wed, 5 Dec 2018 12:25:57 +0000 "Guy Levi(SW)" <guyle@mellanox.com> wrote:
>
> > 
> > Huh. So apparently every compiler that tested this patch (0-day, mine,
> > the submitters) optimized this call away because is_atomic_response()
> > always returns 0: meaning mlx5_get_atomic_laddr is never callable and
> > can be deleted entirely, including the call to mlx5_get_send_wqe.
> > 
> > Not sure what compiler setup will hit this, but it is clearly wrong
> > code..  
> 
> Flag -o0  ?

No, but the kbuild tree contains a change that allows turning off of
gcc's autoinlining and the CONFIG option guarding that gets turned on
for allmodconfig builds among others.

Masahiro, should CONFIG_NO_AUTO_INLINE maybe need to be off unless
explicitly enabled (like CONFIG_DEBUG_INFO and others)?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* RE: linux-next: build failure after merge of the rdma tree
  2018-12-04  1:52 ` Jason Gunthorpe
  2018-12-04  9:42   ` Leon Romanovsky
@ 2018-12-05 12:25   ` Guy Levi(SW)
  2018-12-05 22:58     ` Stephen Rothwell
  1 sibling, 1 reply; 68+ messages in thread
From: Guy Levi(SW) @ 2018-12-05 12:25 UTC (permalink / raw)
  To: Jason Gunthorpe, Stephen Rothwell
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List,
	Majd Dibbiny, Leon Romanovsky

> 
> Huh. So apparently every compiler that tested this patch (0-day, mine,
> the submitters) optimized this call away because is_atomic_response()
> always returns 0: meaning mlx5_get_atomic_laddr is never callable and
> can be deleted entirely, including the call to mlx5_get_send_wqe.
> 
> Not sure what compiler setup will hit this, but it is clearly wrong
> code..

Flag -o0  ?


> 
> Guy/Leon, please send a fixup.. Maybe just delete all this
> handle_atomics stuff?
> 
> Thanks,
> Jason

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2018-12-04  1:52 ` Jason Gunthorpe
@ 2018-12-04  9:42   ` Leon Romanovsky
  2018-12-07  2:41     ` Stephen Rothwell
  2018-12-05 12:25   ` Guy Levi(SW)
  1 sibling, 1 reply; 68+ messages in thread
From: Leon Romanovsky @ 2018-12-04  9:42 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: Stephen Rothwell, Doug Ledford, Linux Next Mailing List,
	Linux Kernel Mailing List, Guy Levi(SW),
	Majd Dibbiny

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

On Tue, Dec 04, 2018 at 01:52:54AM +0000, Jason Gunthorpe wrote:
> On Tue, Dec 04, 2018 at 11:47:31AM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the rdma tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: "mlx5_get_send_wqe" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!
> >
> > Caused by commit
> >
> >   34f4c9554d8b ("IB/mlx5: Use fragmented QP's buffer for in-kernel users")
> >
> > mlx5_get_send_wqe() is still used in drivers/infiniband/hw/mlx5/cq.c
> > and declared in drivers/infiniband/hw/mlx5/mlx5_ib.h ...
> >
> > I have used the version of the rdma tree from next-20181203 for today.
>
> Huh. So apparently every compiler that tested this patch (0-day, mine,
> the submitters) optimized this call away because is_atomic_response()
> always returns 0: meaning mlx5_get_atomic_laddr is never callable and
> can be deleted entirely, including the call to mlx5_get_send_wqe.
>
> Not sure what compiler setup will hit this, but it is clearly wrong
> code..
>
> Guy/Leon, please send a fixup.. Maybe just delete all this
> handle_atomics stuff?

I deleted it and will wait for the results of regression prior to send the patch.

Thanks

>
> Thanks,
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2018-12-04  0:47 Stephen Rothwell
@ 2018-12-04  1:52 ` Jason Gunthorpe
  2018-12-04  9:42   ` Leon Romanovsky
  2018-12-05 12:25   ` Guy Levi(SW)
  0 siblings, 2 replies; 68+ messages in thread
From: Jason Gunthorpe @ 2018-12-04  1:52 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Doug Ledford, Linux Next Mailing List, Linux Kernel Mailing List,
	Guy Levi(SW),
	Majd Dibbiny, Leon Romanovsky

On Tue, Dec 04, 2018 at 11:47:31AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "mlx5_get_send_wqe" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!
> 
> Caused by commit
> 
>   34f4c9554d8b ("IB/mlx5: Use fragmented QP's buffer for in-kernel users")
> 
> mlx5_get_send_wqe() is still used in drivers/infiniband/hw/mlx5/cq.c
> and declared in drivers/infiniband/hw/mlx5/mlx5_ib.h ...
> 
> I have used the version of the rdma tree from next-20181203 for today.

Huh. So apparently every compiler that tested this patch (0-day, mine,
the submitters) optimized this call away because is_atomic_response()
always returns 0: meaning mlx5_get_atomic_laddr is never callable and
can be deleted entirely, including the call to mlx5_get_send_wqe.

Not sure what compiler setup will hit this, but it is clearly wrong
code..

Guy/Leon, please send a fixup.. Maybe just delete all this
handle_atomics stuff?

Thanks,
Jason

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2018-12-04  0:47 Stephen Rothwell
  2018-12-04  1:52 ` Jason Gunthorpe
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2018-12-04  0:47 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Guy Levi,
	Majd Dibbiny, Leon Romanovsky

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "mlx5_get_send_wqe" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!

Caused by commit

  34f4c9554d8b ("IB/mlx5: Use fragmented QP's buffer for in-kernel users")

mlx5_get_send_wqe() is still used in drivers/infiniband/hw/mlx5/cq.c
and declared in drivers/infiniband/hw/mlx5/mlx5_ib.h ...

I have used the version of the rdma tree from next-20181203 for today.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2018-01-25  8:50 ` Leon Romanovsky
@ 2018-01-25 16:08   ` Doug Ledford
  0 siblings, 0 replies; 68+ messages in thread
From: Doug Ledford @ 2018-01-25 16:08 UTC (permalink / raw)
  To: Leon Romanovsky, Stephen Rothwell
  Cc: Jason Gunthorpe, Linux-Next Mailing List,
	Linux Kernel Mailing List, Bart Van Assche

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

On Thu, 2018-01-25 at 10:50 +0200, Leon Romanovsky wrote:
> On Thu, Jan 25, 2018 at 06:22:59PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the rdma tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > ERROR: "init_rcu_head" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!
> > 
> > Caused by commit
> > 
> >   a11253142e6d ("IB/srpt: Rework multi-channel support")
> > 
> > I have used the rdma tree from next-20180119 for today.
> 
> Hi Stephen,
> 
> Please see this patch: https://patchwork.kernel.org/patch/10181845/

This has been pulled into the rdma-next area, you shouldn't have a
problem with this after today.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2018-01-25  7:22 Stephen Rothwell
@ 2018-01-25  8:50 ` Leon Romanovsky
  2018-01-25 16:08   ` Doug Ledford
  0 siblings, 1 reply; 68+ messages in thread
From: Leon Romanovsky @ 2018-01-25  8:50 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Doug Ledford, Jason Gunthorpe, Linux-Next Mailing List,
	Linux Kernel Mailing List, Bart Van Assche

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

On Thu, Jan 25, 2018 at 06:22:59PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "init_rcu_head" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!
>
> Caused by commit
>
>   a11253142e6d ("IB/srpt: Rework multi-channel support")
>
> I have used the rdma tree from next-20180119 for today.

Hi Stephen,

Please see this patch: https://patchwork.kernel.org/patch/10181845/

Thanks

>
> --
> Cheers,
> Stephen Rothwell

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2018-01-25  7:22 Stephen Rothwell
  2018-01-25  8:50 ` Leon Romanovsky
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2018-01-25  7:22 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Bart Van Assche

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "init_rcu_head" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!

Caused by commit

  a11253142e6d ("IB/srpt: Rework multi-channel support")

I have used the rdma tree from next-20180119 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2017-07-31  2:07 Stephen Rothwell
  0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2017-07-31  2:07 UTC (permalink / raw)
  To: Doug Ledford
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Matan Barak

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/infiniband/hw/hns/hns_roce_eq.c: In function 'hns_roce_init_eq_table':
drivers/infiniband/hw/hns/hns_roce_eq.c:711:9: error: implicit declaration of function 'request_irq' [-Werror=implicit-function-declaration]
   ret = request_irq(eq_table->eq[j].irq, hns_roce_msi_x_interrupt,
         ^
drivers/infiniband/hw/hns/hns_roce_eq.c:726:3: error: implicit declaration of function 'free_irq' [-Werror=implicit-function-declaration]
   free_irq(eq_table->eq[j].irq, eq_table->eq + j);
   ^

Probably exposed by commit

  e89bf462b6be ("IB/hns: Support compile test for hns RoCE driver")

But maybe caused by another commit thet modified includes so that
linux/interrupt.h is not longer implictly included ...

I have used the rdma tree from next-20170728 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2017-04-21  2:21   ` Doug Ledford
@ 2017-04-21  2:23     ` Stephen Rothwell
  0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2017-04-21  2:23 UTC (permalink / raw)
  To: Doug Ledford
  Cc: Joe Perches, Linux-Next Mailing List, Linux Kernel Mailing List,
	Steve Wise

Hi Doug,

On Thu, 20 Apr 2017 22:21:15 -0400 Doug Ledford <dledford@redhat.com> wrote:
>
> I created a fix and added it to my tree.

Thanks.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2017-04-21  1:58 ` Joe Perches
  2017-04-21  2:21   ` Doug Ledford
@ 2017-04-21  2:21   ` Stephen Rothwell
  1 sibling, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2017-04-21  2:21 UTC (permalink / raw)
  To: Joe Perches
  Cc: Doug Ledford, Linux-Next Mailing List, Linux Kernel Mailing List,
	Steve Wise

Hi Joe,

On Thu, 20 Apr 2017 18:58:55 -0700 Joe Perches <joe@perches.com> wrote:
>
> Pretty sure there were crossing commits adding PDBG()
> as the original patches were written against next-20170209
> 
> From my tree:
> 
> $ git log --pretty=oneline -5 747edc68212781296de30dd2b4e63711240da7a9
> 747edc68212781296de30dd2b4e63711240da7a9 cxgb4: Convert PDBG to pr_debug
> d054cd530aeef452c7c252504f7d4d6ebba31ae3 cxgb4: Use more common logging style
> 41a74ceecd35cf2f38e2a1a1a394c7718547deb6 cxgb3: Convert PDBG to pr_debug
> 15772862930dfd2f2e10574b86c063d781976a89 cxgb3: Use more common logging style
> 9f7e70ff42dbf3af7ed0699906b699c41930b265 Add linux-next specific files for 20170209
> 
> $ git grep -w PDBG 747edc68212781296de30dd2b4e63711240da7a9
> $

In the rdma tree:

$ git log --pretty=oneline -5 a9a42886d0b3
a9a42886d0b3b989166472b7ea59b1c157d90f9b cxgb4: Convert PDBG to pr_debug
700456bd25946ef531773d1ad2dd511e1cc4515e cxgb4: Use more common logging style
b7b37ee0e137c8384c6cb3a37c4621649d5acdf6 cxgb3: Convert PDBG to pr_debug
46b2d4e8eca752003b903e68c3bec6b15fd7eba0 cxgb3: Use more common logging style
cd565b4b51e5fe258d6ce9ddc167ee51f3044ba5 IB/IPoIB: Support acceleration options callbacks
$ git grep -w PDBG a9a42886d0b3
a9a42886d0b3:drivers/infiniband/hw/cxgb4/cm.c:                          PDBG("%s snd_isn %u\n", __func__, t6req->rsvd);
a9a42886d0b3:drivers/infiniband/hw/cxgb4/cm.c:                          PDBG("%s snd_isn %u\n", __func__, t6req6->rsvd);

So these were added somewhere in Doug's tree and they need to be fixed
up there.  Your patches were rebased/cherrypicked/applied on to Doug's tree.

Ah, the new ones come from commit

  192539f4ce36 "iw_cxgb4: clean up send_connect()"

but that is in v4.11-rc1 and so should would not have been in next-20170209.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2017-04-21  1:58 ` Joe Perches
@ 2017-04-21  2:21   ` Doug Ledford
  2017-04-21  2:23     ` Stephen Rothwell
  2017-04-21  2:21   ` Stephen Rothwell
  1 sibling, 1 reply; 68+ messages in thread
From: Doug Ledford @ 2017-04-21  2:21 UTC (permalink / raw)
  To: Joe Perches, Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Steve Wise

On Thu, 2017-04-20 at 18:58 -0700, Joe Perches wrote:
> On Fri, 2017-04-21 at 11:42 +1000, Stephen Rothwell wrote:
> > 
> > Hi Doug,
> > 
> > After merging the rdma tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > drivers/infiniband/hw/cxgb4/cm.c: In function 'send_connect':
> > drivers/infiniband/hw/cxgb4/cm.c:830:5: error: implicit declaration
> > of function 'PDBG' [-Werror=implicit-function-declaration]
> >      PDBG("%s snd_isn %u\n", __func__, t6req->rsvd);
> >      ^
> > 
> > Caused by commit
> > 
> >   a9a42886d0b3 ("cxgb4: Convert PDBG to pr_debug")
> > 
> > I have used the rdma tree from next-20170420 for today.
> > 
> > There was another PDBG() missed in that file as well.
> 
> Pretty sure there were crossing commits adding PDBG()
> as the original patches were written against next-20170209
> 
> From my tree:
> 
> $ git log --pretty=oneline -5
> 747edc68212781296de30dd2b4e63711240da7a9
> 747edc68212781296de30dd2b4e63711240da7a9 cxgb4: Convert PDBG to
> pr_debug
> d054cd530aeef452c7c252504f7d4d6ebba31ae3 cxgb4: Use more common
> logging style
> 41a74ceecd35cf2f38e2a1a1a394c7718547deb6 cxgb3: Convert PDBG to
> pr_debug
> 15772862930dfd2f2e10574b86c063d781976a89 cxgb3: Use more common
> logging style
> 9f7e70ff42dbf3af7ed0699906b699c41930b265 Add linux-next specific
> files for 20170209
> 
> $ git grep -w PDBG 747edc68212781296de30dd2b4e63711240da7a9
> $

I created a fix and added it to my tree.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2017-04-21  1:42 Stephen Rothwell
@ 2017-04-21  1:58 ` Joe Perches
  2017-04-21  2:21   ` Doug Ledford
  2017-04-21  2:21   ` Stephen Rothwell
  0 siblings, 2 replies; 68+ messages in thread
From: Joe Perches @ 2017-04-21  1:58 UTC (permalink / raw)
  To: Stephen Rothwell, Doug Ledford
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Steve Wise

On Fri, 2017-04-21 at 11:42 +1000, Stephen Rothwell wrote:
> Hi Doug,
> 
> After merging the rdma tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/infiniband/hw/cxgb4/cm.c: In function 'send_connect':
> drivers/infiniband/hw/cxgb4/cm.c:830:5: error: implicit declaration of function 'PDBG' [-Werror=implicit-function-declaration]
>      PDBG("%s snd_isn %u\n", __func__, t6req->rsvd);
>      ^
> 
> Caused by commit
> 
>   a9a42886d0b3 ("cxgb4: Convert PDBG to pr_debug")
> 
> I have used the rdma tree from next-20170420 for today.
> 
> There was another PDBG() missed in that file as well.

Pretty sure there were crossing commits adding PDBG()
as the original patches were written against next-20170209

>From my tree:

$ git log --pretty=oneline -5 747edc68212781296de30dd2b4e63711240da7a9
747edc68212781296de30dd2b4e63711240da7a9 cxgb4: Convert PDBG to pr_debug
d054cd530aeef452c7c252504f7d4d6ebba31ae3 cxgb4: Use more common logging style
41a74ceecd35cf2f38e2a1a1a394c7718547deb6 cxgb3: Convert PDBG to pr_debug
15772862930dfd2f2e10574b86c063d781976a89 cxgb3: Use more common logging style
9f7e70ff42dbf3af7ed0699906b699c41930b265 Add linux-next specific files for 20170209

$ git grep -w PDBG 747edc68212781296de30dd2b4e63711240da7a9
$

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2017-04-21  1:42 Stephen Rothwell
  2017-04-21  1:58 ` Joe Perches
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2017-04-21  1:42 UTC (permalink / raw)
  To: Doug Ledford
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Joe Perches,
	Steve Wise

Hi Doug,

After merging the rdma tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/infiniband/hw/cxgb4/cm.c: In function 'send_connect':
drivers/infiniband/hw/cxgb4/cm.c:830:5: error: implicit declaration of function 'PDBG' [-Werror=implicit-function-declaration]
     PDBG("%s snd_isn %u\n", __func__, t6req->rsvd);
     ^

Caused by commit

  a9a42886d0b3 ("cxgb4: Convert PDBG to pr_debug")

I have used the rdma tree from next-20170420 for today.

There was another PDBG() missed in that file as well.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2017-02-15  1:05 ` Doug Ledford
@ 2017-02-15  5:09   ` Selvin Xavier
  0 siblings, 0 replies; 68+ messages in thread
From: Selvin Xavier @ 2017-02-15  5:09 UTC (permalink / raw)
  To: Doug Ledford
  Cc: Stephen Rothwell, David Miller, Networking, linux-next,
	linux-kernel, Michael Chan, Eddie Wai, Devesh Sharma,
	Somnath Kotur, Sriharsha Basavapatna

On Wed, Feb 15, 2017 at 6:35 AM, Doug Ledford <dledford@redhat.com> wrote:
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Wed, 15 Feb 2017 11:23:25 +1100
>> Subject: [PATCH] RDMA/bnxt_re: fix for "bnxt_en: Update to firmware interface spec 1.7.0."
>>
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Thanks Stephen.  I had been forewarned about this by Selvin and I
> instructed him to send me a fixup patch that would resolve the issue.  I
> would apply it to my tree before merging with Linus.  He just hadn't
> time to send it yet.  Your patch is sufficient as well, so I may just
> pull it in.  Thanks again.

Thanks Stephen and Doug for taking care of this.

Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2017-02-15  0:30 Stephen Rothwell
@ 2017-02-15  1:05 ` Doug Ledford
  2017-02-15  5:09   ` Selvin Xavier
  0 siblings, 1 reply; 68+ messages in thread
From: Doug Ledford @ 2017-02-15  1:05 UTC (permalink / raw)
  To: Stephen Rothwell, David Miller, Networking
  Cc: linux-next, linux-kernel, Michael Chan, Selvin Xavier, Eddie Wai,
	Devesh Sharma, Somnath Kotur, Sriharsha Basavapatna


[-- Attachment #1.1: Type: text/plain, Size: 3198 bytes --]

On 2/14/2017 7:30 PM, Stephen Rothwell wrote:
> Hi Doug,
> 
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_net_ring_free':
> drivers/infiniband/hw/bnxt_re/main.c:231:18: error: 'RING_ALLOC_REQ_RING_TYPE_CMPL' undeclared (first use in this function)
>   req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
>                   ^
> drivers/infiniband/hw/bnxt_re/main.c:231:18: note: each undeclared identifier is reported only once for each function it appears in
> drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_net_ring_alloc':
> drivers/infiniband/hw/bnxt_re/main.c:271:18: error: 'RING_ALLOC_REQ_RING_TYPE_CMPL' undeclared (first use in this function)
>   req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
>                   ^
> 
> Caused by commit
> 
>   1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
> 
> interacting with commit
> 
>   bac9a7e0f5d6 ("bnxt_en: Update to firmware interface spec 1.7.0.")
> 
> from the net-next tree.
> 
> I added this merge fix patch:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 15 Feb 2017 11:23:25 +1100
> Subject: [PATCH] RDMA/bnxt_re: fix for "bnxt_en: Update to firmware interface spec 1.7.0."
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Thanks Stephen.  I had been forewarned about this by Selvin and I
instructed him to send me a fixup patch that would resolve the issue.  I
would apply it to my tree before merging with Linus.  He just hadn't
time to send it yet.  Your patch is sufficient as well, so I may just
pull it in.  Thanks again.

> ---
>  drivers/infiniband/hw/bnxt_re/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
> index 6b9f1178050f..bd452a92b386 100644
> --- a/drivers/infiniband/hw/bnxt_re/main.c
> +++ b/drivers/infiniband/hw/bnxt_re/main.c
> @@ -228,7 +228,7 @@ static int bnxt_re_net_ring_free(struct bnxt_re_dev *rdev, u16 fw_ring_id,
>  	}
>  
>  	bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_RING_FREE, -1, -1);
> -	req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
> +	req.ring_type = RING_ALLOC_REQ_RING_TYPE_L2_CMPL;
>  	req.ring_id = cpu_to_le16(fw_ring_id);
>  	bnxt_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&resp,
>  			    sizeof(resp), DFLT_HWRM_CMD_TIMEOUT);
> @@ -268,7 +268,7 @@ static int bnxt_re_net_ring_alloc(struct bnxt_re_dev *rdev, dma_addr_t *dma_arr,
>  	/* Association of ring index with doorbell index and MSIX number */
>  	req.logical_id = cpu_to_le16(map_index);
>  	req.length = cpu_to_le32(ring_mask + 1);
> -	req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
> +	req.ring_type = RING_ALLOC_REQ_RING_TYPE_L2_CMPL;
>  	req.int_mode = RING_ALLOC_REQ_INT_MODE_MSIX;
>  	bnxt_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&resp,
>  			    sizeof(resp), DFLT_HWRM_CMD_TIMEOUT);
> 


-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2017-02-15  0:30 Stephen Rothwell
  2017-02-15  1:05 ` Doug Ledford
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2017-02-15  0:30 UTC (permalink / raw)
  To: Doug Ledford, David Miller, Networking
  Cc: linux-next, linux-kernel, Michael Chan, Selvin Xavier, Eddie Wai,
	Devesh Sharma, Somnath Kotur, Sriharsha Basavapatna

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_net_ring_free':
drivers/infiniband/hw/bnxt_re/main.c:231:18: error: 'RING_ALLOC_REQ_RING_TYPE_CMPL' undeclared (first use in this function)
  req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
                  ^
drivers/infiniband/hw/bnxt_re/main.c:231:18: note: each undeclared identifier is reported only once for each function it appears in
drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_net_ring_alloc':
drivers/infiniband/hw/bnxt_re/main.c:271:18: error: 'RING_ALLOC_REQ_RING_TYPE_CMPL' undeclared (first use in this function)
  req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
                  ^

Caused by commit

  1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")

interacting with commit

  bac9a7e0f5d6 ("bnxt_en: Update to firmware interface spec 1.7.0.")

from the net-next tree.

I added this merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 15 Feb 2017 11:23:25 +1100
Subject: [PATCH] RDMA/bnxt_re: fix for "bnxt_en: Update to firmware interface spec 1.7.0."

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/infiniband/hw/bnxt_re/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index 6b9f1178050f..bd452a92b386 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -228,7 +228,7 @@ static int bnxt_re_net_ring_free(struct bnxt_re_dev *rdev, u16 fw_ring_id,
 	}
 
 	bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_RING_FREE, -1, -1);
-	req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
+	req.ring_type = RING_ALLOC_REQ_RING_TYPE_L2_CMPL;
 	req.ring_id = cpu_to_le16(fw_ring_id);
 	bnxt_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&resp,
 			    sizeof(resp), DFLT_HWRM_CMD_TIMEOUT);
@@ -268,7 +268,7 @@ static int bnxt_re_net_ring_alloc(struct bnxt_re_dev *rdev, dma_addr_t *dma_arr,
 	/* Association of ring index with doorbell index and MSIX number */
 	req.logical_id = cpu_to_le16(map_index);
 	req.length = cpu_to_le32(ring_mask + 1);
-	req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
+	req.ring_type = RING_ALLOC_REQ_RING_TYPE_L2_CMPL;
 	req.int_mode = RING_ALLOC_REQ_INT_MODE_MSIX;
 	bnxt_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&resp,
 			    sizeof(resp), DFLT_HWRM_CMD_TIMEOUT);
-- 
2.10.2

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-09-28 15:00   ` Doug Ledford
  2016-09-28 15:23     ` Greg KH
@ 2016-09-28 21:45     ` Stephen Rothwell
  1 sibling, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2016-09-28 21:45 UTC (permalink / raw)
  To: Doug Ledford
  Cc: linux-next, linux-kernel, Christoph Hellwig, Greg KH,
	Oleg Drokin, Andreas Dilger

Hi Doug,

On Wed, 28 Sep 2016 11:00:11 -0400 Doug Ledford <dledford@redhat.com> wrote:
>
> That doesn't seem like a particularly good thing to put in.  Wouldn't
> you end up just reverting it later when they fix lustre?  And are you
> going to revert the revert when it breaks again and revert the revert of
> the revert when it's fixed again?  That just seems a lot of churn.  I
> thought it was generally accepted that things in staging might or might
> not work and if they don't, we don't care?  Am I wrong on that?

The allmodconfig build needs to work.  Linus does an allmodconfig build
as part of his testing ...

Part of the fix patch should reenable building of the currently broken code.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-09-28 15:23     ` Greg KH
@ 2016-09-28 15:26       ` Doug Ledford
  0 siblings, 0 replies; 68+ messages in thread
From: Doug Ledford @ 2016-09-28 15:26 UTC (permalink / raw)
  To: Greg KH
  Cc: Stephen Rothwell, linux-next, linux-kernel, Christoph Hellwig,
	Oleg Drokin, Andreas Dilger


[-- Attachment #1.1: Type: text/plain, Size: 3281 bytes --]

On 9/28/16 11:23 AM, Greg KH wrote:
> On Wed, Sep 28, 2016 at 11:00:11AM -0400, Doug Ledford wrote:
>> On 9/27/16 9:43 PM, Stephen Rothwell wrote:
>>> Hi Stephen,
>>>
>>> On Tue, 27 Sep 2016 11:23:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>>
>>>> Hi Doug,
>>>>
>>>> After merging the rdma tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>>
>>>> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_hdev_setup_mrs':
>>>> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:7: error: implicit declaration of function 'ib_get_dma_mr' [-Werror=implicit-function-declaration]
>>>>   mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
>>>>        ^
>>>> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>>   mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
>>>>      ^
>>>>
>>>> Caused by commit
>>>>
>>>>   5ef990f06bd7 ("IB/core: remove ib_get_dma_mr")
>>>>
>>>> I have used the rdma tree from next-20160923 for today.
>>>
>>> As pointed out by Christoph, I should have just disabled the driver in
>>> staging, so today I just applied the patch below.  Doug, that should
>>> probably be applied to the rdma tree so that you don't break Linus'
>>> tree when it gets merged.
>>>
>>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>>> Date: Wed, 28 Sep 2016 11:35:28 +1000
>>> Subject: [PATCH] starging/lustre: disable LNET infiniband support
>>>
>>> Commit 5ef990f06bd7 ("IB/core: remove ib_get_dma_mr") broke the
>>> lustre LNET infiniband support.  Since this is in drivers/staging,
>>> lets just disable it for now until ti can be fixed properly.
>>>
>>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>>> ---
>>>  drivers/staging/lustre/lnet/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/staging/lustre/lnet/Kconfig b/drivers/staging/lustre/lnet/Kconfig
>>> index 2b5930150cda..13b43278a38d 100644
>>> --- a/drivers/staging/lustre/lnet/Kconfig
>>> +++ b/drivers/staging/lustre/lnet/Kconfig
>>> @@ -35,6 +35,7 @@ config LNET_SELFTEST
>>>  config LNET_XPRT_IB
>>>  	tristate "LNET infiniband support"
>>>  	depends on LNET && INFINIBAND && INFINIBAND_ADDR_TRANS
>>> +	depends on BROKEN
>>>  	default LNET && INFINIBAND
>>>  	help
>>>  	  This option allows the LNET users to use infiniband as an
>>>
>>
>> That doesn't seem like a particularly good thing to put in.  Wouldn't
>> you end up just reverting it later when they fix lustre?  And are you
>> going to revert the revert when it breaks again and revert the revert of
>> the revert when it's fixed again?
> 
> Yup :)
> 
> Well, in reality just keep adding and removing the line without dealing
> with reverts, much simpler...
> 
>> That just seems a lot of churn.  I
>> thought it was generally accepted that things in staging might or might
>> not work and if they don't, we don't care?  Am I wrong on that?
> 
> Nope, you are not wrong, but it is nice to not break some people's
> builds if it's possible.

Okie dokie, got it.


-- 
Doug Ledford <dledford@redhat.com>    GPG Key ID: 0E572FDD
  Red Hat, Inc.
  100 E. Davie St
  Raleigh, NC 27601 USA


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 907 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-09-28 15:00   ` Doug Ledford
@ 2016-09-28 15:23     ` Greg KH
  2016-09-28 15:26       ` Doug Ledford
  2016-09-28 21:45     ` Stephen Rothwell
  1 sibling, 1 reply; 68+ messages in thread
From: Greg KH @ 2016-09-28 15:23 UTC (permalink / raw)
  To: Doug Ledford
  Cc: Stephen Rothwell, linux-next, linux-kernel, Christoph Hellwig,
	Oleg Drokin, Andreas Dilger

On Wed, Sep 28, 2016 at 11:00:11AM -0400, Doug Ledford wrote:
> On 9/27/16 9:43 PM, Stephen Rothwell wrote:
> > Hi Stephen,
> > 
> > On Tue, 27 Sep 2016 11:23:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>
> >> Hi Doug,
> >>
> >> After merging the rdma tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_hdev_setup_mrs':
> >> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:7: error: implicit declaration of function 'ib_get_dma_mr' [-Werror=implicit-function-declaration]
> >>   mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
> >>        ^
> >> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >>   mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
> >>      ^
> >>
> >> Caused by commit
> >>
> >>   5ef990f06bd7 ("IB/core: remove ib_get_dma_mr")
> >>
> >> I have used the rdma tree from next-20160923 for today.
> > 
> > As pointed out by Christoph, I should have just disabled the driver in
> > staging, so today I just applied the patch below.  Doug, that should
> > probably be applied to the rdma tree so that you don't break Linus'
> > tree when it gets merged.
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 28 Sep 2016 11:35:28 +1000
> > Subject: [PATCH] starging/lustre: disable LNET infiniband support
> > 
> > Commit 5ef990f06bd7 ("IB/core: remove ib_get_dma_mr") broke the
> > lustre LNET infiniband support.  Since this is in drivers/staging,
> > lets just disable it for now until ti can be fixed properly.
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/staging/lustre/lnet/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/lustre/lnet/Kconfig b/drivers/staging/lustre/lnet/Kconfig
> > index 2b5930150cda..13b43278a38d 100644
> > --- a/drivers/staging/lustre/lnet/Kconfig
> > +++ b/drivers/staging/lustre/lnet/Kconfig
> > @@ -35,6 +35,7 @@ config LNET_SELFTEST
> >  config LNET_XPRT_IB
> >  	tristate "LNET infiniband support"
> >  	depends on LNET && INFINIBAND && INFINIBAND_ADDR_TRANS
> > +	depends on BROKEN
> >  	default LNET && INFINIBAND
> >  	help
> >  	  This option allows the LNET users to use infiniband as an
> > 
> 
> That doesn't seem like a particularly good thing to put in.  Wouldn't
> you end up just reverting it later when they fix lustre?  And are you
> going to revert the revert when it breaks again and revert the revert of
> the revert when it's fixed again?

Yup :)

Well, in reality just keep adding and removing the line without dealing
with reverts, much simpler...

> That just seems a lot of churn.  I
> thought it was generally accepted that things in staging might or might
> not work and if they don't, we don't care?  Am I wrong on that?

Nope, you are not wrong, but it is nice to not break some people's
builds if it's possible.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-09-28  1:43 ` Stephen Rothwell
@ 2016-09-28 15:00   ` Doug Ledford
  2016-09-28 15:23     ` Greg KH
  2016-09-28 21:45     ` Stephen Rothwell
  0 siblings, 2 replies; 68+ messages in thread
From: Doug Ledford @ 2016-09-28 15:00 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Christoph Hellwig, Greg KH,
	Oleg Drokin, Andreas Dilger


[-- Attachment #1.1: Type: text/plain, Size: 2795 bytes --]

On 9/27/16 9:43 PM, Stephen Rothwell wrote:
> Hi Stephen,
> 
> On Tue, 27 Sep 2016 11:23:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi Doug,
>>
>> After merging the rdma tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_hdev_setup_mrs':
>> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:7: error: implicit declaration of function 'ib_get_dma_mr' [-Werror=implicit-function-declaration]
>>   mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
>>        ^
>> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>   mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
>>      ^
>>
>> Caused by commit
>>
>>   5ef990f06bd7 ("IB/core: remove ib_get_dma_mr")
>>
>> I have used the rdma tree from next-20160923 for today.
> 
> As pointed out by Christoph, I should have just disabled the driver in
> staging, so today I just applied the patch below.  Doug, that should
> probably be applied to the rdma tree so that you don't break Linus'
> tree when it gets merged.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 28 Sep 2016 11:35:28 +1000
> Subject: [PATCH] starging/lustre: disable LNET infiniband support
> 
> Commit 5ef990f06bd7 ("IB/core: remove ib_get_dma_mr") broke the
> lustre LNET infiniband support.  Since this is in drivers/staging,
> lets just disable it for now until ti can be fixed properly.
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/lustre/lnet/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lnet/Kconfig b/drivers/staging/lustre/lnet/Kconfig
> index 2b5930150cda..13b43278a38d 100644
> --- a/drivers/staging/lustre/lnet/Kconfig
> +++ b/drivers/staging/lustre/lnet/Kconfig
> @@ -35,6 +35,7 @@ config LNET_SELFTEST
>  config LNET_XPRT_IB
>  	tristate "LNET infiniband support"
>  	depends on LNET && INFINIBAND && INFINIBAND_ADDR_TRANS
> +	depends on BROKEN
>  	default LNET && INFINIBAND
>  	help
>  	  This option allows the LNET users to use infiniband as an
> 

That doesn't seem like a particularly good thing to put in.  Wouldn't
you end up just reverting it later when they fix lustre?  And are you
going to revert the revert when it breaks again and revert the revert of
the revert when it's fixed again?  That just seems a lot of churn.  I
thought it was generally accepted that things in staging might or might
not work and if they don't, we don't care?  Am I wrong on that?

-- 
Doug Ledford <dledford@redhat.com>    GPG Key ID: 0E572FDD
  Red Hat, Inc.
  100 E. Davie St
  Raleigh, NC 27601 USA


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 907 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-09-27  1:23 Stephen Rothwell
  2016-09-27  5:04 ` Christoph Hellwig
@ 2016-09-28  1:43 ` Stephen Rothwell
  2016-09-28 15:00   ` Doug Ledford
  1 sibling, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2016-09-28  1:43 UTC (permalink / raw)
  To: Doug Ledford
  Cc: linux-next, linux-kernel, Christoph Hellwig, Greg KH,
	Oleg Drokin, Andreas Dilger

Hi Stephen,

On Tue, 27 Sep 2016 11:23:34 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Doug,
> 
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_hdev_setup_mrs':
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:7: error: implicit declaration of function 'ib_get_dma_mr' [-Werror=implicit-function-declaration]
>   mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
>        ^
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>   mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
>      ^
> 
> Caused by commit
> 
>   5ef990f06bd7 ("IB/core: remove ib_get_dma_mr")
> 
> I have used the rdma tree from next-20160923 for today.

As pointed out by Christoph, I should have just disabled the driver in
staging, so today I just applied the patch below.  Doug, that should
probably be applied to the rdma tree so that you don't break Linus'
tree when it gets merged.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 28 Sep 2016 11:35:28 +1000
Subject: [PATCH] starging/lustre: disable LNET infiniband support

Commit 5ef990f06bd7 ("IB/core: remove ib_get_dma_mr") broke the
lustre LNET infiniband support.  Since this is in drivers/staging,
lets just disable it for now until ti can be fixed properly.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/lustre/lnet/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lnet/Kconfig b/drivers/staging/lustre/lnet/Kconfig
index 2b5930150cda..13b43278a38d 100644
--- a/drivers/staging/lustre/lnet/Kconfig
+++ b/drivers/staging/lustre/lnet/Kconfig
@@ -35,6 +35,7 @@ config LNET_SELFTEST
 config LNET_XPRT_IB
 	tristate "LNET infiniband support"
 	depends on LNET && INFINIBAND && INFINIBAND_ADDR_TRANS
+	depends on BROKEN
 	default LNET && INFINIBAND
 	help
 	  This option allows the LNET users to use infiniband as an
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-09-27 13:39     ` Christoph Hellwig
@ 2016-09-27 17:15       ` Doug Ledford
  0 siblings, 0 replies; 68+ messages in thread
From: Doug Ledford @ 2016-09-27 17:15 UTC (permalink / raw)
  To: Christoph Hellwig, Stephen Rothwell; +Cc: linux-next, linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 926 bytes --]

On 9/27/16 9:39 AM, Christoph Hellwig wrote:
> On Tue, Sep 27, 2016 at 03:48:20PM +1000, Stephen Rothwell wrote:
>> Yeah, sorry.  Note, however, that you bothered to fix up this same
>> staging file in another of your patches ...
> 
> It's generally not that I don't fix them up because I hate them, it's
> just because they are doing something so incredibly stupid that it would
> take forever to fix up (and something that would have been could if it
> ever had been through review).   For this particular case I think everyone
> would be served much better if this module was simply dropped from the
> tree, as there will be lots of future patches that will break it.
> 

I don't know that I would drop them, but certainly turn them off.  They
can keep their driver up to date.

-- 
Doug Ledford <dledford@redhat.com>    GPG Key ID: 0E572FDD
  Red Hat, Inc.
  100 E. Davie St
  Raleigh, NC 27601 USA


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 907 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-09-27  5:48   ` Stephen Rothwell
@ 2016-09-27 13:39     ` Christoph Hellwig
  2016-09-27 17:15       ` Doug Ledford
  0 siblings, 1 reply; 68+ messages in thread
From: Christoph Hellwig @ 2016-09-27 13:39 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Christoph Hellwig, Doug Ledford, linux-next, linux-kernel

On Tue, Sep 27, 2016 at 03:48:20PM +1000, Stephen Rothwell wrote:
> Yeah, sorry.  Note, however, that you bothered to fix up this same
> staging file in another of your patches ...

It's generally not that I don't fix them up because I hate them, it's
just because they are doing something so incredibly stupid that it would
take forever to fix up (and something that would have been could if it
ever had been through review).   For this particular case I think everyone
would be served much better if this module was simply dropped from the
tree, as there will be lots of future patches that will break it.

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-09-27  5:04 ` Christoph Hellwig
@ 2016-09-27  5:48   ` Stephen Rothwell
  2016-09-27 13:39     ` Christoph Hellwig
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2016-09-27  5:48 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Doug Ledford, linux-next, linux-kernel

Hi Christoph,

On Tue, 27 Sep 2016 07:04:15 +0200 Christoph Hellwig <hch@lst.de> wrote:
>
> On Tue, Sep 27, 2016 at 11:23:34AM +1000, Stephen Rothwell wrote:
> > Hi Doug,
> > 
> > After merging the rdma tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:  
> 
> Please just disable broken staging code like lustre for the linux-next
> builds. We had that discussion before, didn't we?

Yeah, sorry.  Note, however, that you bothered to fix up this same
staging file in another of your patches ...

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-09-27  1:23 Stephen Rothwell
@ 2016-09-27  5:04 ` Christoph Hellwig
  2016-09-27  5:48   ` Stephen Rothwell
  2016-09-28  1:43 ` Stephen Rothwell
  1 sibling, 1 reply; 68+ messages in thread
From: Christoph Hellwig @ 2016-09-27  5:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Doug Ledford, linux-next, linux-kernel, Christoph Hellwig

On Tue, Sep 27, 2016 at 11:23:34AM +1000, Stephen Rothwell wrote:
> Hi Doug,
> 
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Please just disable broken staging code like lustre for the linux-next
builds. We had that discussion before, didn't we?

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2016-09-27  1:23 Stephen Rothwell
  2016-09-27  5:04 ` Christoph Hellwig
  2016-09-28  1:43 ` Stephen Rothwell
  0 siblings, 2 replies; 68+ messages in thread
From: Stephen Rothwell @ 2016-09-27  1:23 UTC (permalink / raw)
  To: Doug Ledford; +Cc: linux-next, linux-kernel, Christoph Hellwig

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_hdev_setup_mrs':
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:7: error: implicit declaration of function 'ib_get_dma_mr' [-Werror=implicit-function-declaration]
  mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
       ^
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
     ^

Caused by commit

  5ef990f06bd7 ("IB/core: remove ib_get_dma_mr")

I have used the rdma tree from next-20160923 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* RE: linux-next: build failure after merge of the rdma tree
  2016-03-16 19:02   ` Doug Ledford
  2016-03-16 20:41     ` Stephen Rothwell
@ 2016-03-16 22:14     ` Ismail, Mustafa
  1 sibling, 0 replies; 68+ messages in thread
From: Ismail, Mustafa @ 2016-03-16 22:14 UTC (permalink / raw)
  To: Doug Ledford, Herbert Xu, Stephen Rothwell
  Cc: linux-next, linux-kernel, Latif, Faisal

Faisal is out until 3/18. We will make the changes and send a patch shortly.
Thanks Herbert for the pointers. Regards.

-----Original Message-----
From: linux-next-owner@vger.kernel.org [mailto:linux-next-owner@vger.kernel.org] On Behalf Of Doug Ledford
Sent: Wednesday, March 16, 2016 2:03 PM
To: Herbert Xu <herbert@gondor.apana.org.au>; Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Latif, Faisal <faisal.latif@intel.com>
Subject: Re: linux-next: build failure after merge of the rdma tree

On 3/16/2016 2:49 AM, Herbert Xu wrote:
> On Wed, Mar 16, 2016 at 12:15:38PM +1100, Stephen Rothwell wrote:
>> Hi Doug,
>>
>> After merging the rdma tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> In file included from drivers/infiniband/hw/i40iw/i40iw.h:57:0,
>>                  from drivers/infiniband/hw/i40iw/i40iw_cm.c:63:
>> drivers/infiniband/hw/i40iw/i40iw_osdep.h:175:12: warning: 'struct hash_desc' declared inside parameter list
>>             u32 length, u32 value);
>>             ^
>>
>> And it went downhill badly after that.
>>
>> Caused by commit
>>
>>   896545098777 ("crypto: hash - Remove crypto_hash interface")
>>
>> from the crypto tree interacting with commits
>>
>>   786c6adb3a94 ("i40iw: add puda code")
>>   4e9042e647ff ("i40iw: add hw and utils files")
>>
>> (at least) from the rdma tree.
>>
>> Its a bit of a pain finding these conflicts now - it would have been 
>> better a few weeks ago.
>>
>> For now, all I can do is to use the rdma tree from next-20160315 for 
>> today.
>>
>> Herbert, any hints for Doug, Faisal?
> 
> crypto_hash is obsolete.  You should be using shash if your input is 
> completely linear or ahash if you need SG lists.  For an example of 
> how you can do the conversion, have a look at
> 
> commit 69110e3cedbb8aad1c70d91ed58a9f4f0ed9eec6
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> Date:   Sun Jan 24 21:19:52 2016 +0800
> 
>     iscsi-target: Use shash and ahash
> 
> Cheers,
> 

Pending an update from Intel on the i40iw driver, I have pulled it from my for-next area.  This should not be a problem with tonight's merge.

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-03-16 19:02   ` Doug Ledford
@ 2016-03-16 20:41     ` Stephen Rothwell
  2016-03-16 22:14     ` Ismail, Mustafa
  1 sibling, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2016-03-16 20:41 UTC (permalink / raw)
  To: Doug Ledford; +Cc: Herbert Xu, linux-next, linux-kernel, Faisal Latif

Hi Doug,

On Wed, 16 Mar 2016 15:02:42 -0400 Doug Ledford <dledford@redhat.com> wrote:
>
> Pending an update from Intel on the i40iw driver, I have pulled it from
> my for-next area.  This should not be a problem with tonight's merge.

Thanks.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-03-16  6:49 ` Herbert Xu
@ 2016-03-16 19:02   ` Doug Ledford
  2016-03-16 20:41     ` Stephen Rothwell
  2016-03-16 22:14     ` Ismail, Mustafa
  0 siblings, 2 replies; 68+ messages in thread
From: Doug Ledford @ 2016-03-16 19:02 UTC (permalink / raw)
  To: Herbert Xu, Stephen Rothwell; +Cc: linux-next, linux-kernel, Faisal Latif


[-- Attachment #1.1: Type: text/plain, Size: 1675 bytes --]

On 3/16/2016 2:49 AM, Herbert Xu wrote:
> On Wed, Mar 16, 2016 at 12:15:38PM +1100, Stephen Rothwell wrote:
>> Hi Doug,
>>
>> After merging the rdma tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> In file included from drivers/infiniband/hw/i40iw/i40iw.h:57:0,
>>                  from drivers/infiniband/hw/i40iw/i40iw_cm.c:63:
>> drivers/infiniband/hw/i40iw/i40iw_osdep.h:175:12: warning: 'struct hash_desc' declared inside parameter list
>>             u32 length, u32 value);
>>             ^
>>
>> And it went downhill badly after that.
>>
>> Caused by commit
>>
>>   896545098777 ("crypto: hash - Remove crypto_hash interface")
>>
>> from the crypto tree interacting with commits
>>
>>   786c6adb3a94 ("i40iw: add puda code")
>>   4e9042e647ff ("i40iw: add hw and utils files")
>>
>> (at least) from the rdma tree.
>>
>> Its a bit of a pain finding these conflicts now - it would have been
>> better a few weeks ago.
>>
>> For now, all I can do is to use the rdma tree from next-20160315 for
>> today.
>>
>> Herbert, any hints for Doug, Faisal?
> 
> crypto_hash is obsolete.  You should be using shash if your input
> is completely linear or ahash if you need SG lists.  For an example
> of how you can do the conversion, have a look at
> 
> commit 69110e3cedbb8aad1c70d91ed58a9f4f0ed9eec6
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> Date:   Sun Jan 24 21:19:52 2016 +0800
> 
>     iscsi-target: Use shash and ahash
> 
> Cheers,
> 

Pending an update from Intel on the i40iw driver, I have pulled it from
my for-next area.  This should not be a problem with tonight's merge.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread

* Re: linux-next: build failure after merge of the rdma tree
  2016-03-16  1:15 Stephen Rothwell
@ 2016-03-16  6:49 ` Herbert Xu
  2016-03-16 19:02   ` Doug Ledford
  0 siblings, 1 reply; 68+ messages in thread
From: Herbert Xu @ 2016-03-16  6:49 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Doug Ledford, linux-next, linux-kernel, Faisal Latif

On Wed, Mar 16, 2016 at 12:15:38PM +1100, Stephen Rothwell wrote:
> Hi Doug,
> 
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from drivers/infiniband/hw/i40iw/i40iw.h:57:0,
>                  from drivers/infiniband/hw/i40iw/i40iw_cm.c:63:
> drivers/infiniband/hw/i40iw/i40iw_osdep.h:175:12: warning: 'struct hash_desc' declared inside parameter list
>             u32 length, u32 value);
>             ^
> 
> And it went downhill badly after that.
> 
> Caused by commit
> 
>   896545098777 ("crypto: hash - Remove crypto_hash interface")
> 
> from the crypto tree interacting with commits
> 
>   786c6adb3a94 ("i40iw: add puda code")
>   4e9042e647ff ("i40iw: add hw and utils files")
> 
> (at least) from the rdma tree.
> 
> Its a bit of a pain finding these conflicts now - it would have been
> better a few weeks ago.
> 
> For now, all I can do is to use the rdma tree from next-20160315 for
> today.
> 
> Herbert, any hints for Doug, Faisal?

crypto_hash is obsolete.  You should be using shash if your input
is completely linear or ahash if you need SG lists.  For an example
of how you can do the conversion, have a look at

commit 69110e3cedbb8aad1c70d91ed58a9f4f0ed9eec6
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Sun Jan 24 21:19:52 2016 +0800

    iscsi-target: Use shash and ahash

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2016-03-16  1:15 Stephen Rothwell
  2016-03-16  6:49 ` Herbert Xu
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2016-03-16  1:15 UTC (permalink / raw)
  To: Doug Ledford, Herbert Xu; +Cc: linux-next, linux-kernel, Faisal Latif

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/infiniband/hw/i40iw/i40iw.h:57:0,
                 from drivers/infiniband/hw/i40iw/i40iw_cm.c:63:
drivers/infiniband/hw/i40iw/i40iw_osdep.h:175:12: warning: 'struct hash_desc' declared inside parameter list
            u32 length, u32 value);
            ^

And it went downhill badly after that.

Caused by commit

  896545098777 ("crypto: hash - Remove crypto_hash interface")

from the crypto tree interacting with commits

  786c6adb3a94 ("i40iw: add puda code")
  4e9042e647ff ("i40iw: add hw and utils files")

(at least) from the rdma tree.

Its a bit of a pain finding these conflicts now - it would have been
better a few weeks ago.

For now, all I can do is to use the rdma tree from next-20160315 for
today.

Herbert, any hints for Doug, Faisal?

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2016-01-13  1:35 ` Stephen Rothwell
  0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2016-01-13  1:35 UTC (permalink / raw)
  To: Doug Ledford, David Miller, netdev
  Cc: linux-next, linux-kernel, Maor Gottlieb, Achiad Shochat

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_add':
drivers/infiniband/hw/mlx5/main.c:2255:6: error: too few arguments to function 'mlx5_ib_port_link_layer'
  if (mlx5_ib_port_link_layer(&dev->ib_dev) ==
      ^
drivers/infiniband/hw/mlx5/main.c:89:1: note: declared here
 mlx5_ib_port_link_layer(struct ib_device *device, u8 port_num)
 ^

Caused by commit

  ebd61f68e1c7 ("IB/mlx5: Support IB device's callback for getting the link layer")

interacting with commit

  038d2ef87572 ("IB/mlx5: Add flow steering support")

from the net-next tree.

I have added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 13 Jan 2016 12:30:50 +1100
Subject: [PATCH] IB/mlx5: merge fix for mlx5_ib_port_link_layer API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/infiniband/hw/mlx5/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 307a8c040a11..a2613d828578 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -2252,7 +2252,7 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev)
 			(1ull << IB_USER_VERBS_CMD_CLOSE_XRCD);
 	}
 
-	if (mlx5_ib_port_link_layer(&dev->ib_dev) ==
+	if (mlx5_ib_port_link_layer(&dev->ib_dev, 1) ==
 	    IB_LINK_LAYER_ETHERNET) {
 		dev->ib_dev.create_flow	= mlx5_ib_create_flow;
 		dev->ib_dev.destroy_flow = mlx5_ib_destroy_flow;
-- 
2.6.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 68+ messages in thread

* linux-next: build failure after merge of the rdma tree
@ 2016-01-13  1:35 ` Stephen Rothwell
  0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2016-01-13  1:35 UTC (permalink / raw)
  To: Doug Ledford, David Miller, netdev
  Cc: linux-next, linux-kernel, Maor Gottlieb, Achiad Shochat

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_add':
drivers/infiniband/hw/mlx5/main.c:2255:6: error: too few arguments to function 'mlx5_ib_port_link_layer'
  if (mlx5_ib_port_link_layer(&dev->ib_dev) ==
      ^
drivers/infiniband/hw/mlx5/main.c:89:1: note: declared here
 mlx5_ib_port_link_layer(struct ib_device *device, u8 port_num)
 ^

Caused by commit

  ebd61f68e1c7 ("IB/mlx5: Support IB device's callback for getting the link layer")

interacting with commit

  038d2ef87572 ("IB/mlx5: Add flow steering support")

from the net-next tree.

I have added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 13 Jan 2016 12:30:50 +1100
Subject: [PATCH] IB/mlx5: merge fix for mlx5_ib_port_link_layer API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/infiniband/hw/mlx5/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 307a8c040a11..a2613d828578 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -2252,7 +2252,7 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev)
 			(1ull << IB_USER_VERBS_CMD_CLOSE_XRCD);
 	}
 
-	if (mlx5_ib_port_link_layer(&dev->ib_dev) ==
+	if (mlx5_ib_port_link_layer(&dev->ib_dev, 1) ==
 	    IB_LINK_LAYER_ETHERNET) {
 		dev->ib_dev.create_flow	= mlx5_ib_create_flow;
 		dev->ib_dev.destroy_flow = mlx5_ib_destroy_flow;
-- 
2.6.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 68+ messages in thread

end of thread, other threads:[~2020-02-26 17:25 UTC | newest]

Thread overview: 68+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09  3:30 linux-next: build failure after merge of the rdma tree Stephen Rothwell
2019-07-09  7:04 ` Mark Zhang
2019-07-09  7:18   ` Leon Romanovsky
2019-07-09 12:43     ` Stephen Rothwell
2019-07-09 13:11       ` Leon Romanovsky
2019-07-09 12:46     ` Jason Gunthorpe
2019-07-10  1:04       ` Stephen Rothwell
2019-07-10  4:30         ` Stephen Rothwell
2019-07-16 23:28           ` Stephen Rothwell
2019-07-17  6:33             ` Masahiro Yamada
2019-07-17  7:45               ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2020-02-26  2:51 Stephen Rothwell
2020-02-26  3:04 ` Devesh Sharma
2020-02-26 17:25 ` Jason Gunthorpe
2019-07-08  3:03 Stephen Rothwell
2019-07-08 14:09 ` Jason Gunthorpe
2019-07-08  2:57 Stephen Rothwell
2019-07-08 16:08 ` Jason Gunthorpe
2019-07-09  3:11   ` Stephen Rothwell
2019-07-25 18:32   ` Dennis Dalessandro
2019-07-01  4:14 Stephen Rothwell
2019-07-01  7:54 ` wangxi
2019-07-01 22:49   ` Jason Gunthorpe
2019-07-04  2:02 ` Stephen Rothwell
2019-07-04  2:04   ` Jason Gunthorpe
2019-07-04  2:10     ` oulijun
2019-07-04  4:07     ` wangxi
2019-07-04  4:10       ` wangxi
2019-07-04  6:31     ` oulijun
2019-07-05 13:15   ` Jason Gunthorpe
2019-07-05 14:59     ` Stephen Rothwell
2018-12-04  0:47 Stephen Rothwell
2018-12-04  1:52 ` Jason Gunthorpe
2018-12-04  9:42   ` Leon Romanovsky
2018-12-07  2:41     ` Stephen Rothwell
2018-12-05 12:25   ` Guy Levi(SW)
2018-12-05 22:58     ` Stephen Rothwell
2018-12-10  0:43       ` Changbin Du
2018-12-10 15:52       ` Masahiro Yamada
2018-01-25  7:22 Stephen Rothwell
2018-01-25  8:50 ` Leon Romanovsky
2018-01-25 16:08   ` Doug Ledford
2017-07-31  2:07 Stephen Rothwell
2017-04-21  1:42 Stephen Rothwell
2017-04-21  1:58 ` Joe Perches
2017-04-21  2:21   ` Doug Ledford
2017-04-21  2:23     ` Stephen Rothwell
2017-04-21  2:21   ` Stephen Rothwell
2017-02-15  0:30 Stephen Rothwell
2017-02-15  1:05 ` Doug Ledford
2017-02-15  5:09   ` Selvin Xavier
2016-09-27  1:23 Stephen Rothwell
2016-09-27  5:04 ` Christoph Hellwig
2016-09-27  5:48   ` Stephen Rothwell
2016-09-27 13:39     ` Christoph Hellwig
2016-09-27 17:15       ` Doug Ledford
2016-09-28  1:43 ` Stephen Rothwell
2016-09-28 15:00   ` Doug Ledford
2016-09-28 15:23     ` Greg KH
2016-09-28 15:26       ` Doug Ledford
2016-09-28 21:45     ` Stephen Rothwell
2016-03-16  1:15 Stephen Rothwell
2016-03-16  6:49 ` Herbert Xu
2016-03-16 19:02   ` Doug Ledford
2016-03-16 20:41     ` Stephen Rothwell
2016-03-16 22:14     ` Ismail, Mustafa
2016-01-13  1:35 Stephen Rothwell
2016-01-13  1:35 ` Stephen Rothwell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.