All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: "Ramuthevar,
	Vadivel MuruganX"  <vadivel.muruganx.ramuthevar@linux.intel.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	anders.roxell@linaro.org, arnd@arndb.de,
	brendanhiggins@google.com, cheol.yong.kim@intel.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, masonccyang@mxic.com.tw,
	miquel.raynal@bootlin.com, piotrs@cadence.com,
	qi-ming.wu@intel.com, richard@nod.at, robh+dt@kernel.org,
	tglx@linutronix.de, vigneshr@ti.com
Subject: Re: [PATCH v1 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
Date: Thu, 16 Apr 2020 14:32:50 +0300	[thread overview]
Message-ID: <20200416113250.GA185537@smile.fi.intel.com> (raw)
In-Reply-To: <20200416131725.51259573@collabora.com>

On Thu, Apr 16, 2020 at 01:17:25PM +0200, Boris Brezillon wrote:
> On Thu, 16 Apr 2020 18:40:53 +0800
> "Ramuthevar, Vadivel MuruganX"
> <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
> 
> > >>> we'll be happy to have one more of the existing driver converted to  
> > >>> ->exec_op() ;-).  
> > >> I have completely adapted to ->exec_op() hook up to replace the legacy
> > >> call-back.  
> > > I suspect porting what you've done to the xway driver shouldn't be too
> > > complicated.  
> > Not ported from xway_nand.c driver , we have developed from the scratch 
> > to make it work on
> > Intel LGM SoC , it's new x86 ATOM based SoC, IP itself completely 
> > different and most of the registers won't match.
> > if we port then it would be ugly and also what are the problem may occur 
> > we do not know.
> 
> Sorry but IMO they look similar enough to try to merge them.

I agree. I tried to convince them internally... but here we are.

-- 
With Best Regards,
Andy Shevchenko



WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: cheol.yong.kim@intel.com, devicetree@vger.kernel.org,
	qi-ming.wu@intel.com, anders.roxell@linaro.org, vigneshr@ti.com,
	arnd@arndb.de,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	richard@nod.at, brendanhiggins@google.com,
	linux-kernel@vger.kernel.org, "Ramuthevar,
	Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>,
	robh+dt@kernel.org, linux-mtd@lists.infradead.org,
	miquel.raynal@bootlin.com, tglx@linutronix.de,
	masonccyang@mxic.com.tw, piotrs@cadence.com
Subject: Re: [PATCH v1 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
Date: Thu, 16 Apr 2020 14:32:50 +0300	[thread overview]
Message-ID: <20200416113250.GA185537@smile.fi.intel.com> (raw)
In-Reply-To: <20200416131725.51259573@collabora.com>

On Thu, Apr 16, 2020 at 01:17:25PM +0200, Boris Brezillon wrote:
> On Thu, 16 Apr 2020 18:40:53 +0800
> "Ramuthevar, Vadivel MuruganX"
> <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
> 
> > >>> we'll be happy to have one more of the existing driver converted to  
> > >>> ->exec_op() ;-).  
> > >> I have completely adapted to ->exec_op() hook up to replace the legacy
> > >> call-back.  
> > > I suspect porting what you've done to the xway driver shouldn't be too
> > > complicated.  
> > Not ported from xway_nand.c driver , we have developed from the scratch 
> > to make it work on
> > Intel LGM SoC , it's new x86 ATOM based SoC, IP itself completely 
> > different and most of the registers won't match.
> > if we port then it would be ugly and also what are the problem may occur 
> > we do not know.
> 
> Sorry but IMO they look similar enough to try to merge them.

I agree. I tried to convince them internally... but here we are.

-- 
With Best Regards,
Andy Shevchenko



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-04-16 11:33 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  2:24 [PATCH v1 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-04-14  2:24 ` Ramuthevar, Vadivel MuruganX
2020-04-14  2:24 ` [PATCH v1 1/2] dt-bindings: mtd: Add YAML for Nand Flash Controller support Ramuthevar,Vadivel MuruganX
2020-04-14  2:24   ` Ramuthevar, Vadivel MuruganX
2020-04-14  7:04   ` Boris Brezillon
2020-04-14  7:04     ` Boris Brezillon
2020-04-15  1:51     ` Ramuthevar, Vadivel MuruganX
2020-04-15  1:51       ` Ramuthevar, Vadivel MuruganX
2020-04-14  2:24 ` [PATCH v1 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-04-14  2:24   ` Ramuthevar, Vadivel MuruganX
2020-04-14  7:21   ` Boris Brezillon
2020-04-14  7:21     ` Boris Brezillon
2020-04-15  6:01     ` Ramuthevar, Vadivel MuruganX
2020-04-15  6:01       ` Ramuthevar, Vadivel MuruganX
2020-04-15 22:05   ` Martin Blumenstingl
2020-04-15 22:05     ` Martin Blumenstingl
2020-04-16  9:35     ` Ramuthevar, Vadivel MuruganX
2020-04-16  9:35       ` Ramuthevar, Vadivel MuruganX
2020-04-16  9:38       ` Boris Brezillon
2020-04-16  9:38         ` Boris Brezillon
2020-04-16  9:45         ` Ramuthevar, Vadivel MuruganX
2020-04-16  9:45           ` Ramuthevar, Vadivel MuruganX
2020-04-16 10:26           ` Boris Brezillon
2020-04-16 10:26             ` Boris Brezillon
2020-04-16 10:40             ` Ramuthevar, Vadivel MuruganX
2020-04-16 10:40               ` Ramuthevar, Vadivel MuruganX
2020-04-16 11:17               ` Boris Brezillon
2020-04-16 11:17                 ` Boris Brezillon
2020-04-16 11:32                 ` Andy Shevchenko [this message]
2020-04-16 11:32                   ` Andy Shevchenko
2020-04-17  5:10                   ` Ramuthevar, Vadivel MuruganX
2020-04-17  5:10                     ` Ramuthevar, Vadivel MuruganX
     [not found]                 ` <de9f50b8-9215-d294-9914-e49701552185@linux.intel.com>
2020-04-16 11:57                   ` Boris Brezillon
2020-04-16 11:57                     ` Boris Brezillon
2020-04-16 12:26                     ` Andy Shevchenko
2020-04-16 12:26                       ` Andy Shevchenko
2020-04-16 12:40                       ` Boris Brezillon
2020-04-16 12:40                         ` Boris Brezillon
2020-04-16 13:20                         ` Arnd Bergmann
2020-04-16 13:20                           ` Arnd Bergmann
2020-04-16 13:51                           ` John Crispin
2020-04-16 13:51                             ` John Crispin
2020-04-20  1:09                           ` Ramuthevar, Vadivel MuruganX
2020-04-20  1:09                             ` Ramuthevar, Vadivel MuruganX
2020-04-16 18:08                     ` Martin Blumenstingl
2020-04-16 18:08                       ` Martin Blumenstingl
2020-04-17  5:21                     ` Ramuthevar, Vadivel MuruganX
2020-04-17  5:21                       ` Ramuthevar, Vadivel MuruganX
2020-04-17  7:02                       ` Boris Brezillon
2020-04-17  7:02                         ` Boris Brezillon
2020-04-17  7:53                         ` Ramuthevar, Vadivel MuruganX
2020-04-17  7:53                           ` Ramuthevar, Vadivel MuruganX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416113250.GA185537@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=anders.roxell@linaro.org \
    --cc=arnd@arndb.de \
    --cc=boris.brezillon@collabora.com \
    --cc=brendanhiggins@google.com \
    --cc=cheol.yong.kim@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=miquel.raynal@bootlin.com \
    --cc=piotrs@cadence.com \
    --cc=qi-ming.wu@intel.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vadivel.muruganx.ramuthevar@linux.intel.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.