All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c.
@ 2020-05-24 11:36 ` Gaurav Pathak
  0 siblings, 0 replies; 26+ messages in thread
From: Gaurav Pathak @ 2020-05-24 11:36 UTC (permalink / raw)
  To: abbotti, gregkh, hsweeten; +Cc: linux-kernel, devel

Silence following sparse warning:
drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_interrupt’:
drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable]
  int data;
      ^~~~
drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_attach’:
drivers/staging/comedi/drivers/dt2814.c:232:6: warning: variable ‘i’ set but not used [-Wunused-but-set-variable]
  int i;
      ^

Signed-off-by: Gaurav Pathak <gauravpathak129@gmail.com>
---
 drivers/staging/comedi/drivers/dt2814.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/staging/comedi/drivers/dt2814.c b/drivers/staging/comedi/drivers/dt2814.c
index d2c715737361..eea587d63e18 100644
--- a/drivers/staging/comedi/drivers/dt2814.c
+++ b/drivers/staging/comedi/drivers/dt2814.c
@@ -186,22 +186,15 @@ static int dt2814_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
 
 static irqreturn_t dt2814_interrupt(int irq, void *d)
 {
-	int lo, hi;
 	struct comedi_device *dev = d;
 	struct dt2814_private *devpriv = dev->private;
 	struct comedi_subdevice *s = dev->read_subdev;
-	int data;
 
 	if (!dev->attached) {
 		dev_err(dev->class_dev, "spurious interrupt\n");
 		return IRQ_HANDLED;
 	}
 
-	hi = inb(dev->iobase + DT2814_DATA);
-	lo = inb(dev->iobase + DT2814_DATA);
-
-	data = (hi << 4) | (lo >> 4);
-
 	if (!(--devpriv->ntrig)) {
 		int i;
 
@@ -229,7 +222,6 @@ static int dt2814_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	struct dt2814_private *devpriv;
 	struct comedi_subdevice *s;
 	int ret;
-	int i;
 
 	ret = comedi_request_region(dev, it->options[0], 0x2);
 	if (ret)
@@ -241,8 +233,6 @@ static int dt2814_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 		dev_err(dev->class_dev, "reset error (fatal)\n");
 		return -EIO;
 	}
-	i = inb(dev->iobase + DT2814_DATA);
-	i = inb(dev->iobase + DT2814_DATA);
 
 	if (it->options[1]) {
 		ret = request_irq(it->options[1], dt2814_interrupt, 0,
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2020-05-26 20:26 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-24 11:36 [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c Gaurav Pathak
2020-05-24 11:36 ` Gaurav Pathak
2020-05-24 12:10 ` Luc Van Oostenryck
2020-05-24 12:10   ` Luc Van Oostenryck
2020-05-24 12:49   ` GAURAV PATHAK
2020-05-24 12:49     ` GAURAV PATHAK
2020-05-24 13:58     ` Luc Van Oostenryck
2020-05-24 13:58       ` Luc Van Oostenryck
2020-05-24 13:32   ` GAURAV PATHAK
2020-05-24 13:32     ` GAURAV PATHAK
2020-05-24 14:08     ` Luc Van Oostenryck
2020-05-24 14:08       ` Luc Van Oostenryck
2020-05-26 14:13 ` Dan Carpenter
2020-05-26 14:13   ` Dan Carpenter
2020-05-26 14:54   ` GAURAV PATHAK
2020-05-26 14:54     ` GAURAV PATHAK
2020-05-26 15:09     ` Dan Carpenter
2020-05-26 15:09       ` Dan Carpenter
2020-05-26 15:50       ` [PATCH v2] Staging: comedi: dt2814: remove unused assignments gaurav
2020-05-26 15:50         ` gaurav
2020-05-26 18:21         ` Dan Carpenter
2020-05-26 18:21           ` Dan Carpenter
2020-05-26 18:51           ` [PATCH v3] " Gaurav Pathak
2020-05-26 18:51             ` Gaurav Pathak
2020-05-26 20:24             ` Dan Carpenter
2020-05-26 20:24               ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.