All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Suman Anna <s-anna@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Tero Kristo <t-kristo@ti.com>,
	"J, KEERTHY" <j-keerthy@ti.com>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Vignesh Raghavendra <vigneshr@ti.com>, <lokeshvutla@ti.com>,
	<grygorii.strashko@ti.com>, <nsekhar@ti.com>
Subject: Re: [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name
Date: Wed, 2 Sep 2020 13:14:39 -0500	[thread overview]
Message-ID: <20200902181439.ywzxknv3vb7fcfeo@akan> (raw)
In-Reply-To: <1cdb8cb1-3a08-423d-ba34-299ac1a4b9b4@ti.com>

On 11:55-20200902, Suman Anna wrote:
> On 9/1/20 5:30 PM, Nishanth Menon wrote:
> > Use temperature-sensor@ naming for nodes following standard conventions of device
> > tree (section 2.2.2 Generic Names recommendation in [1]).
> > 
> > [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
> > 
> > Suggested-by: Suman Anna <s-anna@ti.com>
> > Suggested-by: Vignesh Raghavendra <vigneshr@ti.com>
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> > index bb498be2f0a4..ed42f13e7663 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> > @@ -95,7 +95,7 @@
> >  		clock-names = "gpio";
> >  	};
> >  
> > -	wkup_vtm0: thermal@42050000 {
> > +	wkup_vtm0: temperature-sensor@42050000 {
> 
> There has been a suggestion to use something like thermal-sensor during the
> bindings review, but it is better to use this standard node name.

Yes - I did notice it as well, and then picked up the recommendation
straight from 0.3 spec itself.
> 
> Reviewed-by: Suman Anna <s-anna@ti.com>
> 
> regards
> Suman
> 
> >  		compatible = "ti,am654-vtm";
> >  		reg = <0x42050000 0x25c>;
> >  		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
> > 
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Suman Anna <s-anna@ti.com>
Cc: devicetree@vger.kernel.org, grygorii.strashko@ti.com,
	Vignesh Raghavendra <vigneshr@ti.com>,
	lokeshvutla@ti.com, "J,  KEERTHY" <j-keerthy@ti.com>,
	nsekhar@ti.com, linux-kernel@vger.kernel.org,
	Tero Kristo <t-kristo@ti.com>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name
Date: Wed, 2 Sep 2020 13:14:39 -0500	[thread overview]
Message-ID: <20200902181439.ywzxknv3vb7fcfeo@akan> (raw)
In-Reply-To: <1cdb8cb1-3a08-423d-ba34-299ac1a4b9b4@ti.com>

On 11:55-20200902, Suman Anna wrote:
> On 9/1/20 5:30 PM, Nishanth Menon wrote:
> > Use temperature-sensor@ naming for nodes following standard conventions of device
> > tree (section 2.2.2 Generic Names recommendation in [1]).
> > 
> > [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
> > 
> > Suggested-by: Suman Anna <s-anna@ti.com>
> > Suggested-by: Vignesh Raghavendra <vigneshr@ti.com>
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> > index bb498be2f0a4..ed42f13e7663 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> > @@ -95,7 +95,7 @@
> >  		clock-names = "gpio";
> >  	};
> >  
> > -	wkup_vtm0: thermal@42050000 {
> > +	wkup_vtm0: temperature-sensor@42050000 {
> 
> There has been a suggestion to use something like thermal-sensor during the
> bindings review, but it is better to use this standard node name.

Yes - I did notice it as well, and then picked up the recommendation
straight from 0.3 spec itself.
> 
> Reviewed-by: Suman Anna <s-anna@ti.com>
> 
> regards
> Suman
> 
> >  		compatible = "ti,am654-vtm";
> >  		reg = <0x42050000 0x25c>;
> >  		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
> > 
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-02 18:14 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 22:30 [PATCH 0/7] arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings Nishanth Menon
2020-09-01 22:30 ` Nishanth Menon
2020-09-01 22:30 ` [PATCH 1/7] arm64: dts: ti: k3-am65*: Use generic gpio for node names Nishanth Menon
2020-09-01 22:30   ` Nishanth Menon
2020-09-02  4:13   ` Suman Anna
2020-09-02  4:13     ` Suman Anna
2020-09-01 22:30 ` [PATCH 2/7] arm64: dts: ti: k3-am65*: Use generic clock for serdes clock name Nishanth Menon
2020-09-01 22:30   ` Nishanth Menon
2020-09-02 17:45   ` Suman Anna
2020-09-02 17:45     ` Suman Anna
2020-09-02 18:21     ` Nishanth Menon
2020-09-02 18:21       ` Nishanth Menon
2020-09-01 22:30 ` [PATCH 3/7] arm64: dts: ti: k3-*: Use generic pinctrl for node names Nishanth Menon
2020-09-01 22:30   ` Nishanth Menon
2020-09-02  4:14   ` Suman Anna
2020-09-02  4:14     ` Suman Anna
2020-09-01 22:30 ` [PATCH 4/7] arm64: dts: ti: k3-am65-base-board Use generic camera for node name instead of ov5640 Nishanth Menon
2020-09-01 22:30   ` Nishanth Menon
2020-09-02  4:14   ` Suman Anna
2020-09-02  4:14     ` Suman Anna
2020-09-01 22:30 ` [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name Nishanth Menon
2020-09-01 22:30   ` Nishanth Menon
2020-09-02 16:55   ` Suman Anna
2020-09-02 16:55     ` Suman Anna
2020-09-02 18:14     ` Nishanth Menon [this message]
2020-09-02 18:14       ` Nishanth Menon
2020-09-01 22:30 ` [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names Nishanth Menon
2020-09-01 22:30   ` Nishanth Menon
2020-09-02 16:51   ` Suman Anna
2020-09-02 16:51     ` Suman Anna
2020-09-02 18:18     ` Nishanth Menon
2020-09-02 18:18       ` Nishanth Menon
2020-09-03  5:25       ` Vignesh Raghavendra
2020-09-03  5:25         ` Vignesh Raghavendra
2020-09-03 11:23         ` Nishanth Menon
2020-09-03 11:23           ` Nishanth Menon
2020-09-01 22:30 ` [PATCH 7/7] arm64: dts: ti: k3-*: Fix up node_name_chars_strict errors Nishanth Menon
2020-09-01 22:30   ` Nishanth Menon
2020-09-02 16:54   ` Suman Anna
2020-09-02 16:54     ` Suman Anna
2020-09-02 18:16     ` Nishanth Menon
2020-09-02 18:16       ` Nishanth Menon
2020-09-02  3:36 ` [PATCH 0/7] arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings Lokesh Vutla
2020-09-02  3:36   ` Lokesh Vutla
2020-09-03 13:00 ` [PATCH V2 0/8] arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings + hex usage Nishanth Menon
2020-09-03 13:00   ` Nishanth Menon
2020-09-07 11:54   ` Nishanth Menon
2020-09-07 11:54     ` Nishanth Menon
2020-09-03 13:00 ` [PATCH V2 1/8] arm64: dts: ti: k3-j721e: Use lower case hexadecimal Nishanth Menon
2020-09-03 13:00   ` Nishanth Menon
2020-09-03 13:23   ` Suman Anna
2020-09-03 13:23     ` Suman Anna
2020-09-03 13:23     ` Suman Anna
2020-09-03 14:01   ` Lokesh Vutla
2020-09-03 14:01     ` Lokesh Vutla
2020-09-03 13:00 ` [PATCH V2 2/8] arm64: dts: ti: k3-am65-main: " Nishanth Menon
2020-09-03 13:00   ` Nishanth Menon
2020-09-03 13:24   ` Suman Anna
2020-09-03 13:24     ` Suman Anna
2020-09-03 14:02   ` Lokesh Vutla
2020-09-03 14:02     ` Lokesh Vutla
2020-09-03 13:00 ` [PATCH V2 3/8] arm64: dts: ti: k3-am65*: Use generic gpio for node names Nishanth Menon
2020-09-03 13:00   ` Nishanth Menon
2020-09-03 13:00 ` [PATCH V2 4/8] arm64: dts: ti: k3-am65*: Use generic clock for syscon clock names Nishanth Menon
2020-09-03 13:00   ` Nishanth Menon
2020-09-03 13:21   ` Vignesh Raghavendra
2020-09-03 13:21     ` Vignesh Raghavendra
2020-09-03 13:00 ` [PATCH V2 5/8] arm64: dts: ti: k3-*: Use generic pinctrl for node names Nishanth Menon
2020-09-03 13:00   ` Nishanth Menon
2020-09-03 13:00 ` [PATCH V2 6/8] arm64: dts: ti: k3-am65-base-board Use generic camera for node name instead of ov5640 Nishanth Menon
2020-09-03 13:00   ` Nishanth Menon
2020-09-03 13:00 ` [PATCH V2 7/8] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name Nishanth Menon
2020-09-03 13:00   ` Nishanth Menon
2020-09-03 13:20   ` Vignesh Raghavendra
2020-09-03 13:20     ` Vignesh Raghavendra
2020-09-03 13:00 ` [PATCH V2 8/8] arm64: dts: ti: k3-*: Fix up node_name_chars_strict warnings Nishanth Menon
2020-09-03 13:00   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200902181439.ywzxknv3vb7fcfeo@akan \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=nsekhar@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=s-anna@ti.com \
    --cc=t-kristo@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.