From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Dan Scally <djrscally@gmail.com>, yong.zhi@intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, gregkh@linuxfoundation.org, davem@davemloft.net, robh@kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, jorhand@linux.microsoft.com, kitakar@gmail.com, kieran.bingham@ideasonboard.com Subject: Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms Date: Fri, 18 Sep 2020 16:07:39 +0300 [thread overview] Message-ID: <20200918130739.GA3956970@smile.fi.intel.com> (raw) In-Reply-To: <20200918075157.GF26842@paasikivi.fi.intel.com> On Fri, Sep 18, 2020 at 10:51:57AM +0300, Sakari Ailus wrote: > On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote: > > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote: > > > On 17/09/2020 11:33, Sakari Ailus wrote: > > > > a module and not enlarge everyone's kernel, and the initialisation would at > > > > the same time take place before the rest of what the CIO2 driver does in > > > > probe. > > > I thought of that as well, but wasn't sure which was preferable. I can > > > compress it into the CIO2 driver though sure. > > > > Sakari, I tend to agree with Dan and have the board file separated from the > > driver and even framework. > > And it'll be linked to the kernel binary then I suppose? Solely depends to your Kconfig dependencies and declaration. From code perspective you may do it before enumeration of the certain device or after with reprobe. > I don't have a strong opinion either way, just thought that this will > affect anyone using x86 machines, whether or not they have IPU3. I guess it > could be compiled in if the ipu3-cio2 driver is enabled? Of course! -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: devel@driverdev.osuosl.org, robh@kernel.org, jorhand@linux.microsoft.com, linux-media@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com, Dan Scally <djrscally@gmail.com>, kitakar@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, davem@davemloft.net, tian.shu.qiu@intel.com, yong.zhi@intel.com Subject: Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms Date: Fri, 18 Sep 2020 16:07:39 +0300 [thread overview] Message-ID: <20200918130739.GA3956970@smile.fi.intel.com> (raw) In-Reply-To: <20200918075157.GF26842@paasikivi.fi.intel.com> On Fri, Sep 18, 2020 at 10:51:57AM +0300, Sakari Ailus wrote: > On Thu, Sep 17, 2020 at 03:45:14PM +0300, Andy Shevchenko wrote: > > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote: > > > On 17/09/2020 11:33, Sakari Ailus wrote: > > > > a module and not enlarge everyone's kernel, and the initialisation would at > > > > the same time take place before the rest of what the CIO2 driver does in > > > > probe. > > > I thought of that as well, but wasn't sure which was preferable. I can > > > compress it into the CIO2 driver though sure. > > > > Sakari, I tend to agree with Dan and have the board file separated from the > > driver and even framework. > > And it'll be linked to the kernel binary then I suppose? Solely depends to your Kconfig dependencies and declaration. From code perspective you may do it before enumeration of the certain device or after with reprobe. > I don't have a strong opinion either way, just thought that this will > affect anyone using x86 machines, whether or not they have IPU3. I guess it > could be compiled in if the ipu3-cio2 driver is enabled? Of course! -- With Best Regards, Andy Shevchenko _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-09-18 13:07 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-16 21:36 [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms Daniel Scally 2020-09-16 21:36 ` Daniel Scally 2020-09-17 0:17 ` kernel test robot 2020-09-17 3:02 ` kernel test robot 2020-09-17 7:53 ` Greg KH 2020-09-17 7:53 ` Greg KH 2020-09-17 9:47 ` Dan Scally 2020-09-17 9:47 ` Dan Scally 2020-09-17 10:15 ` Dan Carpenter 2020-09-17 10:15 ` Dan Carpenter 2020-09-17 10:24 ` Dan Scally 2020-09-17 10:24 ` Dan Scally 2020-09-17 13:28 ` Kieran Bingham 2020-09-17 13:28 ` Kieran Bingham 2020-09-17 14:08 ` Andy Shevchenko 2020-09-17 14:08 ` Andy Shevchenko 2020-09-17 14:19 ` Kieran Bingham 2020-09-17 14:19 ` Kieran Bingham 2020-09-17 14:36 ` Andy Shevchenko 2020-09-17 14:36 ` Andy Shevchenko 2020-09-17 9:34 ` Dan Carpenter 2020-09-17 9:34 ` Dan Carpenter 2020-09-17 10:19 ` Joe Perches 2020-09-17 10:19 ` Joe Perches 2020-09-18 22:50 ` Dan Scally 2020-09-18 22:50 ` Dan Scally 2020-09-17 10:33 ` Sakari Ailus 2020-09-17 10:33 ` Sakari Ailus 2020-09-17 10:49 ` Dan Carpenter 2020-09-17 10:49 ` Dan Carpenter 2020-09-17 12:25 ` Andy Shevchenko 2020-09-17 12:25 ` Andy Shevchenko 2020-09-17 13:15 ` Dan Carpenter 2020-09-17 13:15 ` Dan Carpenter 2020-09-18 6:40 ` Sakari Ailus 2020-09-18 6:40 ` Sakari Ailus 2020-09-18 8:16 ` Dan Carpenter 2020-09-18 8:16 ` Dan Carpenter 2020-09-17 10:52 ` Dan Scally 2020-09-17 10:52 ` Dan Scally 2020-09-17 12:45 ` Andy Shevchenko 2020-09-17 12:45 ` Andy Shevchenko 2020-09-17 13:36 ` Dan Scally 2020-09-17 13:36 ` Dan Scally 2020-09-17 14:14 ` Andy Shevchenko 2020-09-17 14:14 ` Andy Shevchenko 2020-09-17 21:25 ` Daniel Scally 2020-09-17 21:25 ` Daniel Scally 2020-09-17 14:44 ` Andy Shevchenko 2020-09-17 14:44 ` Andy Shevchenko 2020-09-18 7:51 ` Sakari Ailus 2020-09-18 7:51 ` Sakari Ailus 2020-09-18 13:07 ` Andy Shevchenko [this message] 2020-09-18 13:07 ` Andy Shevchenko 2020-09-21 13:33 ` Dan Scally 2020-09-21 13:33 ` Dan Scally 2020-09-21 14:33 ` Andy Shevchenko 2020-09-21 14:33 ` Andy Shevchenko 2020-09-23 9:39 ` Dan Scally 2020-09-23 9:39 ` Dan Scally 2020-09-28 11:37 ` Dan Scally 2020-09-28 11:37 ` Dan Scally 2020-09-18 8:03 ` Dan Carpenter 2020-09-18 8:03 ` Dan Carpenter 2020-09-18 8:09 ` Dan Scally 2020-09-18 8:09 ` Dan Scally 2020-09-20 21:34 ` kernel test robot 2020-09-20 21:34 ` [RFC PATCH] cio2_sync_state() can be static kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200918130739.GA3956970@smile.fi.intel.com \ --to=andriy.shevchenko@linux.intel.com \ --cc=bingbu.cao@intel.com \ --cc=davem@davemloft.net \ --cc=devel@driverdev.osuosl.org \ --cc=djrscally@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=jorhand@linux.microsoft.com \ --cc=kieran.bingham@ideasonboard.com \ --cc=kitakar@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=robh@kernel.org \ --cc=sakari.ailus@linux.intel.com \ --cc=tian.shu.qiu@intel.com \ --cc=yong.zhi@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.